174469 2017-07-13 11:22:21 -0700 -Wimplicit-fallthrough warning in ComputedStyleExtractor::propertyValue 2017-08-07 15:01:31 -0700 1 1 1 Unclassified WebKit CSS Other PC All RESOLVED FIXED InRadar P2 Normal --- 174463 1 mcatanzaro mcatanzaro achristensen cdumez commit-queue koivisto mcatanzaro simon.fraser webkit-bug-importer zalan oldest_to_newest 1328515 0 mcatanzaro 2017-07-13 11:22:21 -0700 This new warning from GCC 7 has found a problem in ComputedStyleExtractor::propertyValue: [2701/5861] Building CXX object Source.../css/CSSComputedStyleDeclaration.cpp.o ../../Source/WebCore/css/CSSComputedStyleDeclaration.cpp: In member function ‘WTF::RefPtr<WebCore::CSSValue> WebCore::ComputedStyleExtractor::propertyValue(WebCore::CSSPropertyID, WebCore::EUpdateLayout)’: ../../Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3344:13: warning: this statement may fall through [-Wimplicit-fallthrough=] } ^ ../../Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3345:9: note: here case CSSPropertyTextIndent: { ^~~~ Looking at the code, the fallthrough there appears to almost surely be undesired. But I have no clue how to fix it. 1328710 1 webkit-bug-importer 2017-07-14 01:19:19 -0700 <rdar://problem/33311638> 1336009 2 mcatanzaro 2017-08-07 10:15:45 -0700 Anyone know how to fix this one? 1336028 3 simon.fraser 2017-08-07 10:44:59 -0700 I don't think this is harmful. The switch in the previous block returns under every condition. 1336083 4 mcatanzaro 2017-08-07 12:25:52 -0700 Um, so it does. I'm surprised I missed that. Let's just silence the warning, then. 1336084 5 317452 mcatanzaro 2017-08-07 12:28:14 -0700 Created attachment 317452 Patch 1336102 6 317452 simon.fraser 2017-08-07 13:20:32 -0700 Comment on attachment 317452 Patch Or maybe just return nullptr? 1336130 7 mcatanzaro 2017-08-07 14:26:21 -0700 (In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 317452 [details] > Patch > > Or maybe just return nullptr? I assume that if we don't want that code to ever be hit, an assert is most appropriate? 1336139 8 317452 simon.fraser 2017-08-07 14:31:56 -0700 Comment on attachment 317452 Patch Sure, i guess. 1336157 9 317452 commit-queue 2017-08-07 15:01:29 -0700 Comment on attachment 317452 Patch Clearing flags on attachment: 317452 Committed r220354: <http://trac.webkit.org/changeset/220354> 1336159 10 commit-queue 2017-08-07 15:01:31 -0700 All reviewed patches have been landed. Closing bug. 317452 2017-08-07 12:28:14 -0700 2017-08-07 15:01:29 -0700 Patch bug-174469-20170807142813.patch text/plain 1641 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGVkMmIzMjQ3MTA0MjAy ZTM4ZDM2YWIyY2ZjZmExZmMyMDJjYTk2Ni4uZWQyNmE2ZTQxMTllNTM1MWIxMDZhMDJkNWUwZjUz OTRmZDgyMWJkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA4LTA3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV2ltcGxp Y2l0LWZhbGx0aHJvdWdoIHdhcm5pbmcgaW4gQ29tcHV0ZWRTdHlsZUV4dHJhY3Rvcjo6cHJvcGVy dHlWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc0NDY5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMzMxMTYzOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBSRUxFQVNFX0FTU0VSVF9O T1RfUkVBQ0hFRCB0byBzaWxlbmNlIHRoaXMgd2FybmluZy4KKworICAgICAgICAqIGNzcy9DU1ND b21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29tcHV0ZWRT dHlsZUV4dHJhY3Rvcjo6cHJvcGVydHlWYWx1ZSk6CisKIDIwMTctMDgtMDcgIEJyYWR5IEVpZHNv biAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBtb3N0IG9mIFNlcnZp Y2VXb3JrZXJDb250YWluZXI6OmFkZFJlZ2lzdHJhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKaW5kZXggZmEyMjI0ODQ5OTIy YmFhYjJlN2I5ZTkyYTU3Yzg2NTZjYTg4OWZkOC4uN2VjOGViODYyNDEwYzI2OWI5N2YyMDNmMTM0 YjM3N2Y0MWRjMWE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVk U3R5bGVEZWNsYXJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVk U3R5bGVEZWNsYXJhdGlvbi5jcHAKQEAgLTMzNDEsNiArMzM0MSw3IEBAIFJlZlB0cjxDU1NWYWx1 ZT4gQ29tcHV0ZWRTdHlsZUV4dHJhY3Rvcjo6cHJvcGVydHlWYWx1ZShDU1NQcm9wZXJ0eUlEIHBy b3BlcnR5SUQsCiAgICAgICAgICAgICAgICAgbGlzdC0+YXBwZW5kKGNzc1ZhbHVlUG9vbC5jcmVh dGVWYWx1ZShzdHlsZS0+dGV4dEVtcGhhc2lzTWFyaygpKSk7CiAgICAgICAgICAgICAgICAgcmV0 dXJuIFdURk1vdmUobGlzdCk7CiAgICAgICAgICAgICB9CisgICAgICAgICAgICBSRUxFQVNFX0FT U0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICBjYXNlIENTU1Byb3BlcnR5VGV4dEluZGVudDog ewogICAgICAgICAgICAgLy8gSWYgQ1NTM19URVhUIGlzIGRpc2FibGVkIG9yIHRleHQtaW5kZW50 IGhhcyBvbmx5IG9uZSB2YWx1ZSg8bGVuZ3RoPiB8IDxwZXJjZW50YWdlPiksCiAgICAgICAgICAg ICAvLyBnZXRQcm9wZXJ0eUNTU1ZhbHVlKCkgcmV0dXJucyBDU1NWYWx1ZS4K