174467 2017-07-13 11:02:10 -0700 Incorrect assertion in JSC::CallLinkInfo::callTypeFor 2017-07-13 13:39:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other PC Linux RESOLVED FIXED P2 Normal --- 174463 1 mcatanzaro mcatanzaro bugs-noreply buildbot commit-queue fpizlo keith_miller mark.lam mcatanzaro msaboff saam oldest_to_newest 1328496 0 mcatanzaro 2017-07-13 11:02:10 -0700 In CallLinkInfo::callTypeFor, the assertion ASSERT(opcodeID == op_tail_call_varargs || op_tail_call_forward_arguments) should surely be ASSERT(opcodeID == op_tail_call_varargs || opcodeID == op_tail_call_forward_arguments). Currently it always passes because op_tail_call_forward_arguments is nonzero. This was introduced in r205462. It's found by a new GCC warning: [522/5861] Building CXX object Source/...ptCore.dir/bytecode/CallLinkInfo.cpp.o In file included from ../../Source/WTF/wtf/StdLibExtras.h:33:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/JavaScriptCore/config.h:31, from ../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:26: ../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp: In static member function ‘static JSC::CallLinkInfo::CallType JSC::CallLinkInfo::callTypeFor(JSC::OpcodeID)’: ../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:54:48: warning: enum constant in boolean context [-Wint-in-bool-context] ASSERT(opcodeID == op_tail_call_varargs || op_tail_call_forward_arguments); ^ ../../Source/WTF/wtf/Assertions.h:296:11: note: in definition of macro ‘ASSERT’ if (!(assertion)) { \ ^~~~~~~~~ 1328499 1 315358 mcatanzaro 2017-07-13 11:03:42 -0700 Created attachment 315358 Patch 1328500 2 mcatanzaro 2017-07-13 11:04:08 -0700 Let's hope the assertion does not get hit now that it will be active! 1328546 3 315358 commit-queue 2017-07-13 13:39:36 -0700 Comment on attachment 315358 Patch Clearing flags on attachment: 315358 Committed r219462: <http://trac.webkit.org/changeset/219462> 1328547 4 commit-queue 2017-07-13 13:39:38 -0700 All reviewed patches have been landed. Closing bug. 315358 2017-07-13 11:03:42 -0700 2017-07-13 13:39:36 -0700 Patch bug-174467-20170713130341.patch text/plain 1392 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 ZjY3MDkxMjE2Y2IxYjQ5NWJkOTQ0OTAxNzE0MGE4ZWQ5NGVkYWM5Li5kMThmNGZiOTEzMTNjMzU4 YjQwMjVlNzFkNWRlNDA1MjJmMWI0ODgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNy0wNy0xMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgSW5jb3JyZWN0IGFzc2VydGlvbiBpbiBKU0M6OkNhbGxMaW5r SW5mbzo6Y2FsbFR5cGVGb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NDQ2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYnl0ZWNvZGUvQ2FsbExpbmtJbmZvLmNwcDoKKyAgICAgICAgKEpTQzo6Q2Fs bExpbmtJbmZvOjpjYWxsVHlwZUZvcik6CisKIDIwMTctMDctMTMgIENhaW8gTGltYSAgPHRpY2Fp b2xpbWFAZ21haWwuY29tPgogCiAgICAgICAgIFtFU25leHRdIEltcGxlbWVudCBPYmplY3QgU3By ZWFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ2FsbExpbmtJ bmZvLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9DYWxsTGlua0luZm8uY3Bw CmluZGV4IDdmZmRhMDVmNGNhY2UyZDFkMzljYjI4NGRhNTg2MmJiZjczMjlhMWMuLjNhY2M1ZmJl M2ZlZWM1MDFjN2VkYzU0ZGVjODk2Njg2YzNjN2E5YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9DYWxsTGlua0luZm8uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9DYWxsTGlua0luZm8uY3BwCkBAIC01MSw3ICs1MSw3IEBAIENhbGxM aW5rSW5mbzo6Q2FsbFR5cGUgQ2FsbExpbmtJbmZvOjpjYWxsVHlwZUZvcihPcGNvZGVJRCBvcGNv ZGVJRCkKICAgICAgICAgcmV0dXJuIENvbnN0cnVjdFZhcmFyZ3M7CiAgICAgaWYgKG9wY29kZUlE ID09IG9wX3RhaWxfY2FsbCkKICAgICAgICAgcmV0dXJuIFRhaWxDYWxsOwotICAgIEFTU0VSVChv cGNvZGVJRCA9PSBvcF90YWlsX2NhbGxfdmFyYXJncyB8fCBvcF90YWlsX2NhbGxfZm9yd2FyZF9h cmd1bWVudHMpOworICAgIEFTU0VSVChvcGNvZGVJRCA9PSBvcF90YWlsX2NhbGxfdmFyYXJncyB8 fCBvcGNvZGVJRCA9PSBvcF90YWlsX2NhbGxfZm9yd2FyZF9hcmd1bWVudHMpOwogICAgIHJldHVy biBUYWlsQ2FsbFZhcmFyZ3M7CiB9CiAK