174463 2017-07-13 10:10:08 -0700 Fix compiler warnings when building with GCC 7 2017-07-14 09:26:20 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 174467 174469 174470 174506 155047 1 mcatanzaro mcatanzaro bugs-noreply clopez darin loic.yhuel mcatanzaro oldest_to_newest 1328462 0 mcatanzaro 2017-07-13 10:10:08 -0700 [50/5861] Building C object Source/Thi...i/CMakeFiles/brotli.dir/dec/decode.c.o ../../Source/ThirdParty/brotli/dec/decode.c: In function ‘DecodeVarLenUint8’: ../../Source/ThirdParty/brotli/dec/decode.c:143:10: warning: this statement may fall through [-Wimplicit-fallthrough=] if (bits == 0) { ^ ../../Source/ThirdParty/brotli/dec/decode.c:149:5: note: here case BROTLI_STATE_DECODE_UINT8_SHORT: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:160:14: warning: this statement may fall through [-Wimplicit-fallthrough=] *value = bits; ~~~~~~~^~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:163:5: note: here case BROTLI_STATE_DECODE_UINT8_LONG: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c: In function ‘DecodeMetaBlockLength’: ../../Source/ThirdParty/brotli/dec/decode.c:196:38: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_metablock_header = BROTLI_STATE_METABLOCK_HEADER_EMPTY; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:199:7: note: here case BROTLI_STATE_METABLOCK_HEADER_EMPTY: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:207:38: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_metablock_header = BROTLI_STATE_METABLOCK_HEADER_NIBBLES; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:210:7: note: here case BROTLI_STATE_METABLOCK_HEADER_NIBBLES: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:221:38: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_metablock_header = BROTLI_STATE_METABLOCK_HEADER_SIZE; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:224:7: note: here case BROTLI_STATE_METABLOCK_HEADER_SIZE: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:236:38: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_metablock_header = ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ BROTLI_STATE_METABLOCK_HEADER_UNCOMPRESSED; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:240:7: note: here case BROTLI_STATE_METABLOCK_HEADER_UNCOMPRESSED: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:258:38: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_metablock_header = BROTLI_STATE_METABLOCK_HEADER_BYTES; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:261:7: note: here case BROTLI_STATE_METABLOCK_HEADER_BYTES: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:270:38: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_metablock_header = BROTLI_STATE_METABLOCK_HEADER_METADATA; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:273:7: note: here case BROTLI_STATE_METABLOCK_HEADER_METADATA: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c: In function ‘ReadHuffmanCode’: ../../Source/ThirdParty/brotli/dec/decode.c:694:10: warning: this statement may fall through [-Wimplicit-fallthrough=] if (s->sub_loop_counter != 1) { ^ ../../Source/ThirdParty/brotli/dec/decode.c:706:5: note: here case BROTLI_STATE_HUFFMAN_SIMPLE_SIZE: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:712:27: warning: this statement may fall through [-Wimplicit-fallthrough=] s->sub_loop_counter = 0; ~~~~~~~~~~~~~~~~~~~~^~~ ../../Source/ThirdParty/brotli/dec/decode.c:714:5: note: here case BROTLI_STATE_HUFFMAN_SIMPLE_READ: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:714:44: warning: this statement may fall through [-Wimplicit-fallthrough=] case BROTLI_STATE_HUFFMAN_SIMPLE_READ: { ^ ../../Source/ThirdParty/brotli/dec/decode.c:721:5: note: here case BROTLI_STATE_HUFFMAN_SIMPLE_BUILD: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:762:27: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_huffman = BROTLI_STATE_HUFFMAN_LENGTH_SYMBOLS; ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:765:5: note: here case BROTLI_STATE_HUFFMAN_LENGTH_SYMBOLS: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c: In function ‘DecodeContextMap’: ../../Source/ThirdParty/brotli/dec/decode.c:937:31: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_context_map = BROTLI_STATE_CONTEXT_MAP_READ_PREFIX; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:939:5: note: here case BROTLI_STATE_CONTEXT_MAP_READ_PREFIX: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:939:48: warning: this statement may fall through [-Wimplicit-fallthrough=] case BROTLI_STATE_CONTEXT_MAP_READ_PREFIX: { ^ ../../Source/ThirdParty/brotli/dec/decode.c:957:5: note: here case BROTLI_STATE_CONTEXT_MAP_HUFFMAN: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:962:31: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_context_map = BROTLI_STATE_CONTEXT_MAP_DECODE; ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:964:5: note: here case BROTLI_STATE_CONTEXT_MAP_DECODE: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:964:43: warning: this statement may fall through [-Wimplicit-fallthrough=] case BROTLI_STATE_CONTEXT_MAP_DECODE: { ^ ../../Source/ThirdParty/brotli/dec/decode.c:1009:5: note: here case BROTLI_STATE_CONTEXT_MAP_TRANSFORM: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c: In function ‘CopyUncompressedBlockToOutput’: ../../Source/ThirdParty/brotli/dec/decode.c:1254:34: warning: this statement may fall through [-Wimplicit-fallthrough=] s->substate_uncompressed = BROTLI_STATE_UNCOMPRESSED_WRITE; ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:1257:7: note: here case BROTLI_STATE_UNCOMPRESSED_WRITE: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c: In function ‘BrotliDecompressStream’: ../../Source/ThirdParty/brotli/dec/decode.c:1952:18: warning: this statement may fall through [-Wimplicit-fallthrough=] s->state = BROTLI_STATE_METABLOCK_BEGIN; ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:1954:7: note: here case BROTLI_STATE_METABLOCK_BEGIN: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:1957:18: warning: this statement may fall through [-Wimplicit-fallthrough=] s->state = BROTLI_STATE_METABLOCK_HEADER; ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:1959:7: note: here case BROTLI_STATE_METABLOCK_HEADER: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2032:18: warning: this statement may fall through [-Wimplicit-fallthrough=] s->state = BROTLI_STATE_HUFFMAN_CODE_1; ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2034:7: note: here case BROTLI_STATE_HUFFMAN_CODE_1: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2039:18: warning: this statement may fall through [-Wimplicit-fallthrough=] s->state = BROTLI_STATE_HUFFMAN_CODE_2; ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2042:7: note: here case BROTLI_STATE_HUFFMAN_CODE_2: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2047:18: warning: this statement may fall through [-Wimplicit-fallthrough=] s->state = BROTLI_STATE_HUFFMAN_CODE_3; ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2050:7: note: here case BROTLI_STATE_HUFFMAN_CODE_3: { ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2062:45: warning: this statement may fall through [-Wimplicit-fallthrough=] case BROTLI_STATE_METABLOCK_HEADER_2: { ^ ../../Source/ThirdParty/brotli/dec/decode.c:2085:7: note: here case BROTLI_STATE_CONTEXT_MODES: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2090:18: warning: this statement may fall through [-Wimplicit-fallthrough=] s->state = BROTLI_STATE_CONTEXT_MAP_1; ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2092:7: note: here case BROTLI_STATE_CONTEXT_MAP_1: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2100:18: warning: this statement may fall through [-Wimplicit-fallthrough=] s->state = BROTLI_STATE_CONTEXT_MAP_2; ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2102:7: note: here case BROTLI_STATE_CONTEXT_MAP_2: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2127:18: warning: this statement may fall through [-Wimplicit-fallthrough=] s->state = BROTLI_STATE_TREE_GROUP; ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2129:7: note: here case BROTLI_STATE_TREE_GROUP: ^~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2220:18: warning: this statement may fall through [-Wimplicit-fallthrough=] s->state = BROTLI_STATE_DONE; ~~~~~~~~~^~~~~~~~~~~~~~~~~~~ ../../Source/ThirdParty/brotli/dec/decode.c:2222:7: note: here case BROTLI_STATE_DONE: ^~~~ [466/5861] Building CXX object Source/.../B3LowerMacrosAfterOptimizations.cpp.o In file included from ../../Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp:36:0: ../../Source/JavaScriptCore/b3/B3ConstPtrValue.h: In instantiation of ‘JSC::B3::ConstPtrValue::ConstPtrValue(JSC::B3::Origin, T*) [with T = float(float) throw ()]’: ../../Source/JavaScriptCore/b3/B3ProcedureInlines.h:38:49: required from ‘ValueType* JSC::B3::Procedure::add(Arguments ...) [with ValueType = JSC::B3::ConstPtrValue; Arguments = {JSC::B3::Origin, float (*)(float) throw ()}]’ ../../Source/JavaScriptCore/b3/B3InsertionSetInlines.h:38:12: required from ‘ValueType* JSC::B3::InsertionSet::insert(size_t, Arguments ...) [with ValueType = JSC::B3::ConstPtrValue; Arguments = {JSC::B3::Origin, float (*)(float) throw ()}; size_t = long unsigned int]’ ../../Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp:99:100: required from here ../../Source/JavaScriptCore/b3/B3ConstPtrValue.h:56:5: warning: mangled name for ‘JSC::B3::ConstPtrValue::ConstPtrValue(JSC::B3::Origin, T*) [with T = float(float) throw ()]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type] ConstPtrValue(Origin origin, T* pointer) ^~~~~~~~~~~~~ ../../Source/JavaScriptCore/b3/B3ConstPtrValue.h:56:5: warning: mangled name for ‘JSC::B3::ConstPtrValue::ConstPtrValue(JSC::B3::Origin, T*) [with T = float(float) throw ()]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type] In file included from ../../Source/WTF/wtf/FastMalloc.h:26:0, from ../../Source/JavaScriptCore/config.h:31, from ../../Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp:26: ../../Source/WTF/wtf/StdLibExtras.h:143:15: warning: mangled name for ‘ToType WTF::bitwise_cast(FromType) [with ToType = long int; FromType = float (*)(float) throw ()]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type] inline ToType bitwise_cast(FromType from) ^~~~~~~~~~~~ In file included from ../../Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp:36:0: ../../Source/JavaScriptCore/b3/B3ConstPtrValue.h:56:5: warning: mangled name for ‘JSC::B3::ConstPtrValue::ConstPtrValue(JSC::B3::Origin, T*) [with T = float(float) throw ()]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type] ConstPtrValue(Origin origin, T* pointer) ^~~~~~~~~~~~~ In file included from ../../Source/JavaScriptCore/b3/B3BasicBlockInlines.h:31:0, from ../../Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp:31: ../../Source/JavaScriptCore/b3/B3ProcedureInlines.h:36:12: warning: mangled name for ‘ValueType* JSC::B3::Procedure::add(Arguments ...) [with ValueType = JSC::B3::ConstPtrValue; Arguments = {JSC::B3::Origin, float (*)(float) throw ()}]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type] ValueType* Procedure::add(Arguments... arguments) ^~~~~~~~~ In file included from ../../Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp:37:0: ../../Source/JavaScriptCore/b3/B3InsertionSetInlines.h:36:12: warning: mangled name for ‘ValueType* JSC::B3::InsertionSet::insert(size_t, Arguments ...) [with ValueType = JSC::B3::ConstPtrValue; Arguments = {JSC::B3::Origin, float (*)(float) throw ()}]’ will change in C++17 because the exception specification is part of a function type [-Wnoexcept-type] ValueType* InsertionSet::insert(size_t index, Arguments... arguments) ^~~~~~~~~~~~ [522/5861] Building CXX object Source/...ptCore.dir/bytecode/CallLinkInfo.cpp.o In file included from ../../Source/WTF/wtf/StdLibExtras.h:33:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/JavaScriptCore/config.h:31, from ../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:26: ../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp: In static member function ‘static JSC::CallLinkInfo::CallType JSC::CallLinkInfo::callTypeFor(JSC::OpcodeID)’: ../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:54:48: warning: enum constant in boolean context [-Wint-in-bool-context] ASSERT(opcodeID == op_tail_call_varargs || op_tail_call_forward_arguments); ^ ../../Source/WTF/wtf/Assertions.h:296:11: note: in definition of macro ‘ASSERT’ if (!(assertion)) { \ ^~~~~~~~~ [735/5861] Building C object Source/Ja.../disassembler/udis86/udis86_decode.c.o ../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.c: In function ‘decode_operand’: ../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:751:18: warning: this statement may fall through [-Wimplicit-fallthrough=] u->br_far = 1; ~~~~~~~~~~~^~~ ../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:753:5: note: here case OP_M: ^~~~ ../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:754:10: warning: this statement may fall through [-Wimplicit-fallthrough=] if (MODRM_MOD(modrm(u)) == 3) { ^ ../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:758:5: note: here case OP_E: ^~~~ ../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:773:10: warning: this statement may fall through [-Wimplicit-fallthrough=] if (MODRM_MOD(modrm(u)) != 3) { ^ ../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:777:5: note: here case OP_Q: ^~~~ ../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:784:10: warning: this statement may fall through [-Wimplicit-fallthrough=] if (MODRM_MOD(modrm(u)) != 3) { ^ ../../Source/JavaScriptCore/disassembler/udis86/udis86_decode.c:788:5: note: here case OP_W: ^~~~ [978/5861] Building CXX object Source/...criptCore.dir/runtime/ConfigFile.cpp.o ../../Source/JavaScriptCore/runtime/ConfigFile.cpp: In lambda function: ../../Source/JavaScriptCore/runtime/ConfigFile.cpp:281:62: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] auto parseLogFile = [&](StatementNesting statementNesting) { ^ ../../Source/JavaScriptCore/runtime/ConfigFile.cpp:286:29: note: ‘snprintf’ output 2 or more bytes (assuming 4098) into a destination of size 4097 snprintf(logPathname, s_maxPathLength + 1, "%s/%s", m_configDirectory, filename); ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [2701/5861] Building CXX object Source.../css/CSSComputedStyleDeclaration.cpp.o ../../Source/WebCore/css/CSSComputedStyleDeclaration.cpp: In member function ‘WTF::RefPtr<WebCore::CSSValue> WebCore::ComputedStyleExtractor::propertyValue(WebCore::CSSPropertyID, WebCore::EUpdateLayout)’: ../../Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3344:13: warning: this statement may fall through [-Wimplicit-fallthrough=] } ^ ../../Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3345:9: note: here case CSSPropertyTextIndent: { ^~~~ [3172/5861] Building CXX object Source...s/WebCore.dir/html/ImageDocument.cpp.o ../../Source/WebCore/html/ImageDocument.cpp: In member function ‘void WebCore::ImageDocument::createDocumentStructure()’: ../../Source/WebCore/html/ImageDocument.cpp:226:103: warning: enum constant in boolean context [-Wint-in-bool-context] body->setInlineStyleProperty(CSSPropertyBackgroundColor, "white", CSSPrimitiveValue::CSS_IDENT); ^ [4595/5861] Building CXX object Source...ort.dir/testing/InternalSettings.cpp.o ../../Source/WebCore/testing/InternalSettings.cpp: In member function ‘WebCore::ExceptionOr<void> WebCore::InternalSettings::setShouldManageAudioSessionCategory(bool)’: ../../Source/WebCore/testing/InternalSettings.cpp:839:78: warning: unused parameter ‘should’ [-Wunused-parameter] ExceptionOr<void> InternalSettings::setShouldManageAudioSessionCategory(bool should) ^~~~~~ [5146/5861] Building CXX object Source...Platform/IPC/unix/ConnectionUnix.cpp.o ../../Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp: In member function ‘bool IPC::Connection::sendOutputMessage(IPC::UnixMessage&)’: ../../Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:454:42: warning: this statement may fall through [-Wimplicit-fallthrough=] attachmentInfo[i].setSize(attachments[i].size()); ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:456:13: note: here case Attachment::SocketType: ^~~~ 1328465 1 clopez 2017-07-13 10:24:40 -0700 This would fail to build on the Mac port as they pass both -Werror,-Wimplicit-fallthrough 1328467 2 mcatanzaro 2017-07-13 10:29:04 -0700 (In reply to Carlos Alberto Lopez Perez from comment #1) > This would fail to build on the Mac port as they pass both > -Werror,-Wimplicit-fallthrough I don't understand your comment. We need to build brotli with -Wno-implicit-fallthrough. Mac port does not build brotli at all. 1328468 3 mcatanzaro 2017-07-13 10:31:46 -0700 Ah, I see we do have some -Wimplicit-fallthrough warnings elsewhere. But clearly Mac port is not failing to build, so either their compiler somehow implements the warning differently, or maybe they don't use it for all files. 1328525 4 315364 mcatanzaro 2017-07-13 11:41:40 -0700 Created attachment 315364 Patch 1328531 5 315366 mcatanzaro 2017-07-13 11:54:25 -0700 Created attachment 315366 Patch 1328551 6 315366 darin 2017-07-13 13:46:23 -0700 Comment on attachment 315366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315366&action=review This patch probably should not have [GTK] on it, since it’s not in platform-specific code even if it’s for the benefit of ports that can use gcc. > Source/cmake/OptionsCommon.cmake:78 > + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-noexcept-type") Is this working around a bug, or what? 1328625 7 mcatanzaro 2017-07-13 18:35:28 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 315366 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315366&action=review > > This patch probably should not have [GTK] on it, since it’s not in > platform-specific code even if it’s for the benefit of ports that can use > gcc. Good point. > > Source/cmake/OptionsCommon.cmake:78 > > + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-noexcept-type") > > Is this working around a bug, or what? No, it's just a bad warning. Apparently noexcept is part of the function signature in C++17, so the mangled names of a bunch of functions will change between C++14 and C++17. That's a major ABI change. But these are not public API functions, so it doesn't matter. The only place that -Wnoexcept-type *might* be a useful warning is in the public C++ API headers, but those are slated for removal anyway. On the other hand, I see now that those functions use throw() rather than noexcept. I should probably modernize that in a follow-up patch. 1328634 8 mcatanzaro 2017-07-13 18:43:53 -0700 (In reply to Michael Catanzaro from comment #7) > > > Source/cmake/OptionsCommon.cmake:78 > > > + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-noexcept-type") > > > > Is this working around a bug, or what? > > No, it's just a bad warning. Er, actually those functions do not have noexcept specifiers at all. You're right, it is a GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80985 I'll add a comment about that to the patch. 1328636 9 mcatanzaro 2017-07-13 18:45:49 -0700 (In reply to Michael Catanzaro from comment #8) > Er, actually those functions do not have noexcept specifiers at all. You're > right, it is a GCC bug: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80985 Well, I guess the warning is working as designed, it's just assuming that we compile some of our C++ files with C++14 and some with C++17. Then the code would break. Fortunately, we don't do that. 1328638 10 mcatanzaro 2017-07-13 18:48:54 -0700 Committed r219480: <http://trac.webkit.org/changeset/219480> 1328700 11 315366 loic.yhuel 2017-07-14 00:17:27 -0700 Comment on attachment 315366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315366&action=review > Source/ThirdParty/brotli/CMakeLists.txt:21 > + ADD_TARGET_PROPERTIES(brotli COMPILE_FLAGS "-Wno-cast-align -Wno-implicit-fallthrough") This flag is only supported in gcc >= 7, so with older versions, as soon as there is another warning in the file, it would output : cc1plus: warning: unrecognized command line option ‘-Wno-implicit-fallthrough’ 1328761 12 mcatanzaro 2017-07-14 08:30:49 -0700 (In reply to Loïc Yhuel from comment #11) > This flag is only supported in gcc >= 7, so with older versions, as soon as > there is another warning in the file, it would output : > cc1plus: warning: unrecognized command line option > ‘-Wno-implicit-fallthrough’ Oops, sorry. Will fix. 315364 2017-07-13 11:41:40 -0700 2017-07-13 11:54:23 -0700 Patch bug-174463-20170713134139.patch text/plain 7790 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 ZjY3MDkxMjE2Y2IxYjQ5NWJkOTQ0OTAxNzE0MGE4ZWQ5NGVkYWM5Li4yZjZiYmU0NTZjZWMwODg1 MTBlYzgyOTkyZGMyZTFlYTg2MjRhMDZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNy0wNy0xMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IGNvbXBpbGVyIHdhcm5pbmdzIHdoZW4gYnVp bGRpbmcgd2l0aCBHQ0MgNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc0NDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9kZWNvZGUuYzoKKyAgICAgICAg KGRlY29kZV9vcGVyYW5kKToKKwogMjAxNy0wNy0xMyAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBn bWFpbC5jb20+CiAKICAgICAgICAgW0VTbmV4dF0gSW1wbGVtZW50IE9iamVjdCBTcHJlYWQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZyBiL1NvdXJjZS9UaGlyZFBhcnR5 L0NoYW5nZUxvZwppbmRleCBkMTdlMmExYWFiMzlkOTk1OTA3ZDk0YTAzZTU0ODFlZmMyYzQ5ODgy Li5iN2Y5ZjQzZDIwMjU2OTdlNzIxMWFlZjQzOWEwY2U0MzMxMDI4MTViIDEwMDY0NAotLS0gYS9T b3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMDctMTMgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNh dGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBjb21waWxlciB3YXJuaW5n cyB3aGVuIGJ1aWxkaW5nIHdpdGggR0NDIDcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NDQ2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogYnJvdGxpL0NNYWtlTGlzdHMudHh0OgorCiAyMDE3LTA1LTEx ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAYW0uc29ueS5jb20+CiAKICAgICAgICAgW0NN YWtlXSBBZGQgSEFWRSBjaGVjayBmb3IgcmVnZXguaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdlNmFkYjJhY2Fi MTJiYjEwMWUzMDg4N2RkZGEwNmNmZjRlZTExMWEuLmFmNjU1ODIwNDEzNjVjNDNkOWU2ZTkwMWNi YWQ1N2Y2OGNjYjI2MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wNy0xMyAg TWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dU S10gRml4IGNvbXBpbGVyIHdhcm5pbmdzIHdoZW4gYnVpbGRpbmcgd2l0aCBHQ0MgNworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0NDYzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVy bmFsU2V0dGluZ3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW50ZXJuYWxTZXR0aW5nczo6c2V0 U2hvdWxkTWFuYWdlQXVkaW9TZXNzaW9uQ2F0ZWdvcnkpOgorCiAyMDE3LTA3LTEzICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR0NyeXB0XSBJbXBsZW1l bnQgQ3J5cHRvS2V5UlNBIFNQS0kgZXhwb3J0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGFlYzM3ZDMwMzcyYWEz YzBjYzA2MGRjZTZlMzBmYTVjZTgxNWJkNWMuLjNiMGJlNGVhNmJjZDA3ZDdhNWZhNDc3YzVlYTU2 NzE4ZDBmYTdkNTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wNy0xMyAgTWlj aGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g Rml4IGNvbXBpbGVyIHdhcm5pbmdzIHdoZW4gYnVpbGRpbmcgd2l0aCBHQ0MgNworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0NDYzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvdW5p eC9Db25uZWN0aW9uVW5peC5jcHA6CisgICAgICAgIChJUEM6OkNvbm5lY3Rpb246OnNlbmRPdXRw dXRNZXNzYWdlKToKKwogMjAxNy0wNy0xMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViIEF1dG9tYXRpb246IGV2YWx1YXRlSmF2YVNjcmlw dEZ1bmN0aW9uIHNob3VsZCBzdGFydCB0aGUgY2FsbGJhY2sgdGltZW91dCBhZnRlciB0aGUgZnVu Y3Rpb24gaXMgYXBwbGllZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fz c2VtYmxlci91ZGlzODYvdWRpczg2X2RlY29kZS5jIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rp c2Fzc2VtYmxlci91ZGlzODYvdWRpczg2X2RlY29kZS5jCmluZGV4IGMwZWEyODM2MjgzMTQ1NDhj NTlkZmZiNDg5ZDgxZGQxMTAyYjJlZGQuLjI1MzMwMTI2ODE0N2MyYzMyZjY4OTIzY2Q3ZjNmYzhj OGJkZGU2M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIv dWRpczg2L3VkaXM4Nl9kZWNvZGUuYworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNz ZW1ibGVyL3VkaXM4Ni91ZGlzODZfZGVjb2RlLmMKQEAgLTc0OSwxMiArNzQ5LDEyIEBAIGRlY29k ZV9vcGVyYW5kKHN0cnVjdCB1ZCAgICAgICAgICAgKnUsCiAgICAgICBicmVhazsKICAgICBjYXNl IE9QX0Y6CiAgICAgICB1LT5icl9mYXIgID0gMTsKLSAgICAgIC8qIGludGVuZGVkIGZhbGwgdGhy b3VnaCAqLworICAgICAgRkFMTFRIUk9VR0g7CiAgICAgY2FzZSBPUF9NOgogICAgICAgaWYgKE1P RFJNX01PRChtb2RybSh1KSkgPT0gMykgewogICAgICAgICBVREVSUih1LCAiZXhwZWN0ZWQgbW9k cm0ubW9kICE9IDNcbiIpOwogICAgICAgfQotICAgICAgLyogaW50ZW5kZWQgZmFsbCB0aHJvdWdo ICovCisgICAgICBGQUxMVEhST1VHSDsKICAgICBjYXNlIE9QX0U6CiAgICAgICBkZWNvZGVfbW9k cm1fcm0odSwgb3BlcmFuZCwgUkVHQ0xBU1NfR1BSLCBzaXplKTsKICAgICAgIGJyZWFrOwpAQCAt NzczLDcgKzc3Myw3IEBAIGRlY29kZV9vcGVyYW5kKHN0cnVjdCB1ZCAgICAgICAgICAgKnUsCiAg ICAgICBpZiAoTU9EUk1fTU9EKG1vZHJtKHUpKSAhPSAzKSB7CiAgICAgICAgIFVERVJSKHUsICJl eHBlY3RlZCBtb2RybS5tb2QgPT0gM1xuIik7CiAgICAgICB9Ci0gICAgICAvKiBpbnRlbmRlZCBm YWxsIHRocm91Z2ggKi8KKyAgICAgIEZBTExUSFJPVUdIOwogICAgIGNhc2UgT1BfUToKICAgICAg IGRlY29kZV9tb2RybV9ybSh1LCBvcGVyYW5kLCBSRUdDTEFTU19NTVgsIHNpemUpOwogICAgICAg YnJlYWs7CkBAIC03ODQsNyArNzg0LDcgQEAgZGVjb2RlX29wZXJhbmQoc3RydWN0IHVkICAgICAg ICAgICAqdSwKICAgICAgIGlmIChNT0RSTV9NT0QobW9kcm0odSkpICE9IDMpIHsKICAgICAgICAg VURFUlIodSwgImV4cGVjdGVkIG1vZHJtLm1vZCA9PSAzXG4iKTsKICAgICAgIH0KLSAgICAgIC8q IGludGVuZGVkIGZhbGwgdGhyb3VnaCAqLworICAgICAgRkFMTFRIUk9VR0g7CiAgICAgY2FzZSBP UF9XOgogICAgICAgZGVjb2RlX21vZHJtX3JtKHUsIG9wZXJhbmQsIFJFR0NMQVNTX1hNTSwgc2l6 ZSk7CiAgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2Jyb3RsaS9D TWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBhcnR5L2Jyb3RsaS9DTWFrZUxpc3RzLnR4dApp bmRleCAyYzQwNmRhOGM4YjMxNzk3NDFkNGFmNzk3NGU0ZTY2NzZhNjJmOGZhLi4xNjYyMGUxNTc3 NTlkOTMwYjQ2ZDMwMDhjNTU1NzBmNjE3YmRiOTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9icm90bGkvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1RoaXJkUGFydHkvYnJvdGxp L0NNYWtlTGlzdHMudHh0CkBAIC0xNyw2ICsxNyw2IEBAIGFkZF9kZWZpbml0aW9ucygtREJST1RM SV9CVUlMRF9QT1JUQUJMRSkKIGFkZF9saWJyYXJ5KGJyb3RsaSBTVEFUSUMgJHtCUk9UTElfU09V UkNFU30pCiBXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTKGJyb3RsaSkKIAotaWYgKENP TVBJTEVSX0lTX0NMQU5HKQotICAgIEFERF9UQVJHRVRfUFJPUEVSVElFUyhicm90bGkgQ09NUElM RV9GTEFHUyAiLVduby1jYXN0LWFsaWduIikKK2lmIChDT01QSUxFUl9JU19HQ0NfT1JfQ0xBTkcp CisgICAgQUREX1RBUkdFVF9QUk9QRVJUSUVTKGJyb3RsaSBDT01QSUxFX0ZMQUdTICItV25vLWNh c3QtYWxpZ24gLVduby1pbXBsaWNpdC1mYWxsdGhyb3VnaCIpCiBlbmRpZiAoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAKaW5kZXggZjA0ZmUyNzkzNmQ4NzFi MTJkM2RkNmRkYTEyMzY0Njg0M2RiY2M1Mi4uM2Y1ZWY5YTRmYTEwOTc3ZjExYmMxYWU3NDljODA3 NDliY2FkNTc1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNl dHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGluZ3Mu Y3BwCkBAIC04NDIsNiArODQyLDcgQEAgRXhjZXB0aW9uT3I8dm9pZD4gSW50ZXJuYWxTZXR0aW5n czo6c2V0U2hvdWxkTWFuYWdlQXVkaW9TZXNzaW9uQ2F0ZWdvcnkoYm9vbCBzaG8KICAgICBTZXR0 aW5nczo6c2V0U2hvdWxkTWFuYWdlQXVkaW9TZXNzaW9uQ2F0ZWdvcnkoc2hvdWxkKTsKICAgICBy ZXR1cm4geyB9OwogI2Vsc2UKKyAgICBVTlVTRURfUEFSQU1FVEVSKHNob3VsZCk7CiAgICAgcmV0 dXJuIEV4Y2VwdGlvbiB7IElOVkFMSURfQUNDRVNTX0VSUiB9OwogI2VuZGlmCiB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAKaW5k ZXggZjcxZDJmNzJlNmZkZWMyODc1NWQ2ZmQ3MjlhNGUyZDdiMDA1OGJlOS4uMjAzYzU2YWRiNjI2 OTllMzA2ZDkzODRjYzg2MzdkNDYxYzg3NDY0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlvblVuaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1BsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcApAQCAtNDUyLDcgKzQ1Miw3IEBA IGJvb2wgQ29ubmVjdGlvbjo6c2VuZE91dHB1dE1lc3NhZ2UoVW5peE1lc3NhZ2UmIG91dHB1dE1l c3NhZ2UpCiAgICAgICAgICAgICBzd2l0Y2ggKGF0dGFjaG1lbnRzW2ldLnR5cGUoKSkgewogICAg ICAgICAgICAgY2FzZSBBdHRhY2htZW50OjpNYXBwZWRNZW1vcnlUeXBlOgogICAgICAgICAgICAg ICAgIGF0dGFjaG1lbnRJbmZvW2ldLnNldFNpemUoYXR0YWNobWVudHNbaV0uc2l6ZSgpKTsKLSAg ICAgICAgICAgICAgICAvLyBGYWxsIHRyaG91Z2gsIHNldCBmaWxlIGRlc2NyaXB0b3Igb3IgbnVs bC4KKyAgICAgICAgICAgICAgICBGQUxMVEhST1VHSDsKICAgICAgICAgICAgIGNhc2UgQXR0YWNo bWVudDo6U29ja2V0VHlwZToKICAgICAgICAgICAgICAgICBpZiAoYXR0YWNobWVudHNbaV0uZmls ZURlc2NyaXB0b3IoKSAhPSAtMSkgewogICAgICAgICAgICAgICAgICAgICBBU1NFUlQoZmRQdHIp OwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UgYi9Tb3VyY2Uv Y21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQppbmRleCA2MWEwYWU3NWY4OWFhYzM5ZGU5NGYwMTRm YzEwOTkzNTVjMmQ2OGE4Li4yNmZjMGFmNjQ5YWU2YjZlZDU0NzRjMWRiZTZjOTg3YTBlM2RiMmQ5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQorKysgYi9Tb3Vy Y2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAtNDQsNiArNDQsOCBAQCBpZiAoQ01BS0Vf R0VORVJBVE9SIFNUUkVRVUFMICJOaW5qYSIpCiAgICAgZW5kaWYgKCkKIGVuZGlmICgpCiAKKyMg RklYTUU6IFNvbWUgd2FybmluZyBmbGFncyBzaG91bGQgcHJvYmFibHkgYmUgc2V0IGluIFdlYktp dEhlbHBlcnMuY21ha2UgaW5zdGVhZC4KKyMgQnV0IGxhbmd1YWdlLXNwZWNpZmljIHdhcm5pbmdz IHByb2JhYmx5IGNhbm5vdCBiZSBtb3ZlZCB0aGVyZS4KIGlmIChDT01QSUxFUl9JU19HQ0NfT1Jf Q0xBTkcpCiAgICAgc2V0KENNQUtFX0NfRkxBR1MgIiR7Q01BS0VfQ19GTEFHU30gLWZuby1zdHJp Y3QtYWxpYXNpbmciKQogICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdT fSAtZm5vLXN0cmljdC1hbGlhc2luZyIpCkBAIC03MSw2ICs3MywxMCBAQCBpZiAoQ09NUElMRVJf SVNfR0NDX09SX0NMQU5HKQogICAgICAgICBzZXQoQ01BS0VfQ19GTEFHUyAiJHtDTUFLRV9DX0ZM QUdTfSAtV25vLWV4cGFuc2lvbi10by1kZWZpbmVkIikKICAgICAgICAgc2V0KENNQUtFX0NYWF9G TEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC1Xbm8tZXhwYW5zaW9uLXRvLWRlZmluZWQiKQogICAg IGVuZGlmICgpCisKKyAgICBpZiAoQ01BS0VfQ09NUElMRVJfSVNfR05VQ1hYIEFORCAke0NNQUtF X0NYWF9DT01QSUxFUl9WRVJTSU9OfSBWRVJTSU9OX0dSRUFURVIgIjcuMCIpCisgICAgICAgIHNl dChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtV25vLW5vZXhjZXB0LXR5cGUi KQorICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCiAjIEVuc3VyZSB0aGF0IHRoZSBkZWZhdWx0IGlu Y2x1ZGUgc3lzdGVtIGRpcmVjdG9yaWVzIGFyZSBhZGRlZCB0byB0aGUgbGlzdCBvZiBDTWFrZSBp bXBsaWNpdCBpbmNsdWRlcy4KZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRl eCAwZTU2MGYxYzA2NmMwZTE2OTY0Mjc0MzU2ZWZhZjM0MmQ5MTdlOWU3Li40N2VjYmRjZmNhMmVl YjA0NjcxN2U1ZGMyNjNlNzI4MjFkOGZhOWQwIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMDctMTMgIE1pY2hhZWwgQ2F0YW56YXJv ICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBjb21waWxlciB3 YXJuaW5ncyB3aGVuIGJ1aWxkaW5nIHdpdGggR0NDIDcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDQ2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21h a2U6CisKIDIwMTctMDctMTIgIE1hdHQgTGV3aXMgIDxqbGV3aXMzQGFwcGxlLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjE5NDAxLgo= 315366 2017-07-13 11:54:25 -0700 2017-07-13 13:46:23 -0700 Patch bug-174463-20170713135424.patch text/plain 7808 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5NDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 M2YxOTE1OTVmMzUzYWNlYmU1Njc4MDI4ZTFjY2NmY2IzNmFlODU5Li4wZTEzYzNiYmI0ZWFiNWYz MTEzNjdkMzdmNTI1M2ZhYzVhZmE0OWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNy0wNy0xMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IGNvbXBpbGVyIHdhcm5pbmdzIHdoZW4gYnVp bGRpbmcgd2l0aCBHQ0MgNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc0NDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9kZWNvZGUuYzoKKyAgICAgICAg KGRlY29kZV9vcGVyYW5kKToKKwogMjAxNy0wNy0xMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92ZSB1bnVzZWQgYW5k IHVudGVzdGVkIFBhZ2UgZG9tYWluIGNvbW1hbmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggZDE3ZTJh MWFhYjM5ZDk5NTkwN2Q5NGEwM2U1NDgxZWZjMmM0OTg4Mi4uYjdmOWY0M2QyMDI1Njk3ZTcyMTFh ZWY0MzlhMGNlNDMzMTAyODE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDE3LTA3LTEzICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR1RLXSBGaXggY29tcGlsZXIgd2FybmluZ3Mgd2hlbiBidWlsZGluZyB3aXRoIEdD QyA3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ0 NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJy b3RsaS9DTWFrZUxpc3RzLnR4dDoKKwogMjAxNy0wNS0xMSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9s bXN0ZWFkQGFtLnNvbnkuY29tPgogCiAgICAgICAgIFtDTWFrZV0gQWRkIEhBVkUgY2hlY2sgZm9y IHJlZ2V4LmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MTMzZGYyMTNkZWUxM2Q5MTkxMWNhZTFhNDAzNTM3NGEy OWI4N2U4Li5hMzlmNzdiMWI3NjZlODM1YzQyNjIxNWUxN2ZkYWQ3NzRhMTc3MTQ0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDctMTMgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNh dGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBjb21waWxlciB3YXJuaW5n cyB3aGVuIGJ1aWxkaW5nIHdpdGggR0NDIDcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NDQ2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkludGVybmFsU2V0dGluZ3M6OnNldFNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lv bkNhdGVnb3J5KToKKwogMjAxNy0wNy0xMyAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBsZS5j b20+CiAKICAgICAgICAgRml4IHN0eWxlLiBVc2UgI3ByYWdtYSBvbmNlIGluIFZpZGVvRnVsbHNj cmVlbiBhbmQgUGxheWJhY2tTZXNzaW9uIGhlYWRlcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjAzZTUxNWEy ZmE2NDdiODFhODczNDc5Nzg1MTBiZTYxMjRhNGZiYi4uMWE4NjkxNzk4YzY5NDRmNmFkNTA5ODgw YjM4Y2NlNTQ0OGU1NTM5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA3LTEz ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBb R1RLXSBGaXggY29tcGlsZXIgd2FybmluZ3Mgd2hlbiBidWlsZGluZyB3aXRoIEdDQyA3CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ0NjMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL0lQ Qy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcDoKKyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6c2Vu ZE91dHB1dE1lc3NhZ2UpOgorCiAyMDE3LTA3LTEzICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFw cGxlLmNvbT4KIAogICAgICAgICBGaXggc3R5bGUuIFVzZSAjcHJhZ21hIG9uY2UgaW4gVmlkZW9G dWxsc2NyZWVuIGFuZCBQbGF5YmFja1Nlc3Npb24gaGVhZGVycy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9kZWNvZGUuYyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9kZWNvZGUuYwpp bmRleCBjMGVhMjgzNjI4MzE0NTQ4YzU5ZGZmYjQ4OWQ4MWRkMTEwMmIyZWRkLi4yNTMzMDEyNjgx NDdjMmMzMmY2ODkyM2NkN2YzZmM4YzhiZGRlNjNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91ZGlzODZfZGVjb2RlLmMKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvdWRpczg2X2RlY29kZS5jCkBAIC03 NDksMTIgKzc0OSwxMiBAQCBkZWNvZGVfb3BlcmFuZChzdHJ1Y3QgdWQgICAgICAgICAgICp1LAog ICAgICAgYnJlYWs7CiAgICAgY2FzZSBPUF9GOgogICAgICAgdS0+YnJfZmFyICA9IDE7Ci0gICAg ICAvKiBpbnRlbmRlZCBmYWxsIHRocm91Z2ggKi8KKyAgICAgIEZBTExUSFJPVUdIOwogICAgIGNh c2UgT1BfTToKICAgICAgIGlmIChNT0RSTV9NT0QobW9kcm0odSkpID09IDMpIHsKICAgICAgICAg VURFUlIodSwgImV4cGVjdGVkIG1vZHJtLm1vZCAhPSAzXG4iKTsKICAgICAgIH0KLSAgICAgIC8q IGludGVuZGVkIGZhbGwgdGhyb3VnaCAqLworICAgICAgRkFMTFRIUk9VR0g7CiAgICAgY2FzZSBP UF9FOgogICAgICAgZGVjb2RlX21vZHJtX3JtKHUsIG9wZXJhbmQsIFJFR0NMQVNTX0dQUiwgc2l6 ZSk7CiAgICAgICBicmVhazsKQEAgLTc3Myw3ICs3NzMsNyBAQCBkZWNvZGVfb3BlcmFuZChzdHJ1 Y3QgdWQgICAgICAgICAgICp1LAogICAgICAgaWYgKE1PRFJNX01PRChtb2RybSh1KSkgIT0gMykg ewogICAgICAgICBVREVSUih1LCAiZXhwZWN0ZWQgbW9kcm0ubW9kID09IDNcbiIpOwogICAgICAg fQotICAgICAgLyogaW50ZW5kZWQgZmFsbCB0aHJvdWdoICovCisgICAgICBGQUxMVEhST1VHSDsK ICAgICBjYXNlIE9QX1E6CiAgICAgICBkZWNvZGVfbW9kcm1fcm0odSwgb3BlcmFuZCwgUkVHQ0xB U1NfTU1YLCBzaXplKTsKICAgICAgIGJyZWFrOwpAQCAtNzg0LDcgKzc4NCw3IEBAIGRlY29kZV9v cGVyYW5kKHN0cnVjdCB1ZCAgICAgICAgICAgKnUsCiAgICAgICBpZiAoTU9EUk1fTU9EKG1vZHJt KHUpKSAhPSAzKSB7CiAgICAgICAgIFVERVJSKHUsICJleHBlY3RlZCBtb2RybS5tb2QgPT0gM1xu Iik7CiAgICAgICB9Ci0gICAgICAvKiBpbnRlbmRlZCBmYWxsIHRocm91Z2ggKi8KKyAgICAgIEZB TExUSFJPVUdIOwogICAgIGNhc2UgT1BfVzoKICAgICAgIGRlY29kZV9tb2RybV9ybSh1LCBvcGVy YW5kLCBSRUdDTEFTU19YTU0sIHNpemUpOwogICAgICAgYnJlYWs7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvVGhpcmRQYXJ0eS9icm90bGkvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9i cm90bGkvQ01ha2VMaXN0cy50eHQKaW5kZXggMmM0MDZkYThjOGIzMTc5NzQxZDRhZjc5NzRlNGU2 Njc2YTYyZjhmYS4uMTY2MjBlMTU3NzU5ZDkzMGI0NmQzMDA4YzU1NTcwZjYxN2JkYjkxZSAxMDA2 NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvYnJvdGxpL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv dXJjZS9UaGlyZFBhcnR5L2Jyb3RsaS9DTWFrZUxpc3RzLnR4dApAQCAtMTcsNiArMTcsNiBAQCBh ZGRfZGVmaW5pdGlvbnMoLURCUk9UTElfQlVJTERfUE9SVEFCTEUpCiBhZGRfbGlicmFyeShicm90 bGkgU1RBVElDICR7QlJPVExJX1NPVVJDRVN9KQogV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9G TEFHUyhicm90bGkpCiAKLWlmIChDT01QSUxFUl9JU19DTEFORykKLSAgICBBRERfVEFSR0VUX1BS T1BFUlRJRVMoYnJvdGxpIENPTVBJTEVfRkxBR1MgIi1Xbm8tY2FzdC1hbGlnbiIpCitpZiAoQ09N UElMRVJfSVNfR0NDX09SX0NMQU5HKQorICAgIEFERF9UQVJHRVRfUFJPUEVSVElFUyhicm90bGkg Q09NUElMRV9GTEFHUyAiLVduby1jYXN0LWFsaWduIC1Xbm8taW1wbGljaXQtZmFsbHRocm91Z2gi KQogZW5kaWYgKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxT ZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuY3Bw CmluZGV4IGYwNGZlMjc5MzZkODcxYjEyZDNkZDZkZGExMjM2NDY4NDNkYmNjNTIuLjEyZDE5ZDAw MzU5ZmUzNzhmZTRlYWU3MDRjMmM1MTczNDQ1M2MwMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvdGVz dGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcApAQCAtODQyLDYgKzg0Miw3IEBAIEV4Y2VwdGlvbk9y PHZvaWQ+IEludGVybmFsU2V0dGluZ3M6OnNldFNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lvbkNhdGVn b3J5KGJvb2wgc2hvCiAgICAgU2V0dGluZ3M6OnNldFNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lvbkNh dGVnb3J5KHNob3VsZCk7CiAgICAgcmV0dXJuIHsgfTsKICNlbHNlCisgICAgVU5VU0VEX1BBUkFN KHNob3VsZCk7CiAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IElOVkFMSURfQUNDRVNTX0VSUiB9Owog I2VuZGlmCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9D b25uZWN0aW9uVW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9Db25u ZWN0aW9uVW5peC5jcHAKaW5kZXggZjcxZDJmNzJlNmZkZWMyODc1NWQ2ZmQ3MjlhNGUyZDdiMDA1 OGJlOS4uMjAzYzU2YWRiNjI2OTllMzA2ZDkzODRjYzg2MzdkNDYxYzg3NDY0NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlvblVuaXguY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcApA QCAtNDUyLDcgKzQ1Miw3IEBAIGJvb2wgQ29ubmVjdGlvbjo6c2VuZE91dHB1dE1lc3NhZ2UoVW5p eE1lc3NhZ2UmIG91dHB1dE1lc3NhZ2UpCiAgICAgICAgICAgICBzd2l0Y2ggKGF0dGFjaG1lbnRz W2ldLnR5cGUoKSkgewogICAgICAgICAgICAgY2FzZSBBdHRhY2htZW50OjpNYXBwZWRNZW1vcnlU eXBlOgogICAgICAgICAgICAgICAgIGF0dGFjaG1lbnRJbmZvW2ldLnNldFNpemUoYXR0YWNobWVu dHNbaV0uc2l6ZSgpKTsKLSAgICAgICAgICAgICAgICAvLyBGYWxsIHRyaG91Z2gsIHNldCBmaWxl IGRlc2NyaXB0b3Igb3IgbnVsbC4KKyAgICAgICAgICAgICAgICBGQUxMVEhST1VHSDsKICAgICAg ICAgICAgIGNhc2UgQXR0YWNobWVudDo6U29ja2V0VHlwZToKICAgICAgICAgICAgICAgICBpZiAo YXR0YWNobWVudHNbaV0uZmlsZURlc2NyaXB0b3IoKSAhPSAtMSkgewogICAgICAgICAgICAgICAg ICAgICBBU1NFUlQoZmRQdHIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNDb21t b24uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQppbmRleCA2MWEwYWU3 NWY4OWFhYzM5ZGU5NGYwMTRmYzEwOTkzNTVjMmQ2OGE4Li4yNmZjMGFmNjQ5YWU2YjZlZDU0NzRj MWRiZTZjOTg3YTBlM2RiMmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1v bi5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAtNDQsNiAr NDQsOCBAQCBpZiAoQ01BS0VfR0VORVJBVE9SIFNUUkVRVUFMICJOaW5qYSIpCiAgICAgZW5kaWYg KCkKIGVuZGlmICgpCiAKKyMgRklYTUU6IFNvbWUgd2FybmluZyBmbGFncyBzaG91bGQgcHJvYmFi bHkgYmUgc2V0IGluIFdlYktpdEhlbHBlcnMuY21ha2UgaW5zdGVhZC4KKyMgQnV0IGxhbmd1YWdl LXNwZWNpZmljIHdhcm5pbmdzIHByb2JhYmx5IGNhbm5vdCBiZSBtb3ZlZCB0aGVyZS4KIGlmIChD T01QSUxFUl9JU19HQ0NfT1JfQ0xBTkcpCiAgICAgc2V0KENNQUtFX0NfRkxBR1MgIiR7Q01BS0Vf Q19GTEFHU30gLWZuby1zdHJpY3QtYWxpYXNpbmciKQogICAgIHNldChDTUFLRV9DWFhfRkxBR1Mg IiR7Q01BS0VfQ1hYX0ZMQUdTfSAtZm5vLXN0cmljdC1hbGlhc2luZyIpCkBAIC03MSw2ICs3Mywx MCBAQCBpZiAoQ09NUElMRVJfSVNfR0NDX09SX0NMQU5HKQogICAgICAgICBzZXQoQ01BS0VfQ19G TEFHUyAiJHtDTUFLRV9DX0ZMQUdTfSAtV25vLWV4cGFuc2lvbi10by1kZWZpbmVkIikKICAgICAg ICAgc2V0KENNQUtFX0NYWF9GTEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC1Xbm8tZXhwYW5zaW9u LXRvLWRlZmluZWQiKQogICAgIGVuZGlmICgpCisKKyAgICBpZiAoQ01BS0VfQ09NUElMRVJfSVNf R05VQ1hYIEFORCAke0NNQUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OfSBWRVJTSU9OX0dSRUFURVIg IjcuMCIpCisgICAgICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAt V25vLW5vZXhjZXB0LXR5cGUiKQorICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCiAjIEVuc3VyZSB0 aGF0IHRoZSBkZWZhdWx0IGluY2x1ZGUgc3lzdGVtIGRpcmVjdG9yaWVzIGFyZSBhZGRlZCB0byB0 aGUgbGlzdCBvZiBDTWFrZSBpbXBsaWNpdCBpbmNsdWRlcy4KZGlmZiAtLWdpdCBhL0NoYW5nZUxv ZyBiL0NoYW5nZUxvZwppbmRleCAwZTU2MGYxYzA2NmMwZTE2OTY0Mjc0MzU2ZWZhZjM0MmQ5MTdl OWU3Li40N2VjYmRjZmNhMmVlYjA0NjcxN2U1ZGMyNjNlNzI4MjFkOGZhOWQwIDEwMDY0NAotLS0g YS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMDctMTMg IE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEtdIEZpeCBjb21waWxlciB3YXJuaW5ncyB3aGVuIGJ1aWxkaW5nIHdpdGggR0NDIDcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDQ2MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtl L09wdGlvbnNDb21tb24uY21ha2U6CisKIDIwMTctMDctMTIgIE1hdHQgTGV3aXMgIDxqbGV3aXMz QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjE5NDAxLgo=