174221 2017-07-06 15:27:21 -0700 [Win] Build precompiled header successfully with clang-cl 2017-07-06 18:11:05 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 173889 1 stephan.szabo webkit-unassigned achristensen commit-queue lforschler oldest_to_newest 1326215 0 stephan.szabo 2017-07-06 15:27:21 -0700 Clang-cl doesn't support using /Yc without /FI and gives a warning. Without ninja we don't seem to get any pch built, with it, we seem to get one built by CL that clang-cl cannot read. 1326216 1 314764 stephan.szabo 2017-07-06 15:34:20 -0700 Created attachment 314764 Patch to pass /FI for clang-cl builds when making precompiled headers 1326244 2 314774 stephan.szabo 2017-07-06 16:24:56 -0700 Created attachment 314774 Patch to pass /FI for clang-cl builds when making precompiled headers 1326277 3 314774 commit-queue 2017-07-06 18:11:04 -0700 Comment on attachment 314774 Patch to pass /FI for clang-cl builds when making precompiled headers Clearing flags on attachment: 314774 Committed r219228: <http://trac.webkit.org/changeset/219228> 1326278 4 commit-queue 2017-07-06 18:11:05 -0700 All reviewed patches have been landed. Closing bug. 314764 2017-07-06 15:34:20 -0700 2017-07-06 16:24:56 -0700 Patch to pass /FI for clang-cl builds when making precompiled headers 174221-1.diff text/plain 1760 stephan.szabo ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2YmZkMjMwYzEyMy4uYzdi N2E5OTViNzEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0wNy0wNiAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5j b20+CisKKyAgICAgICAgW1dpbl0gQnVpbGQgcHJlY29tcGlsZWQgaGVhZGVyIHN1Y2Nlc3NmdWxs eSB3aXRoIGNsYW5nLWNsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzQyMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2U6CisKIDIwMTctMDYtMjgg IFN0ZXBoYW4gU3phYm8gIDxzdGVwaGFuLnN6YWJvQGFtLnNvbnkuY29tPgogCiAgICAgICAgIFtX aW5dIEJ1aWxkIEpTQ09ubHkgb24gV2luZG93cyB3aXRoIGNsYW5nLWNsCmRpZmYgLS1naXQgYS9T b3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jv cy5jbWFrZQppbmRleCA3MTM5MjdlN2I1NS4uZGEzZjAwZTViZTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jv cy5jbWFrZQpAQCAtMzQsOSArMzQsMTYgQEAgbWFjcm8oQUREX1BSRUNPTVBJTEVEX0hFQURFUiBf aGVhZGVyIF9jcHAgX3NvdXJjZSkKICAgICAgICAgc2V0KFByZWNvbXBpbGVkQmluYXJ5ICIke0NN QUtFX0NVUlJFTlRfQklOQVJZX0RJUn0vJHtfc291cmNlfS8ke1ByZWNvbXBpbGVkQmFzZW5hbWV9 LnBjaCIpCiAgICAgICAgIHNldChfc291cmNlcyAkeyR7X3NvdXJjZX19KQogCi0gICAgICAgIHNl dF9zb3VyY2VfZmlsZXNfcHJvcGVydGllcygke19jcHB9Ci0gICAgICAgICAgICBQUk9QRVJUSUVT IENPTVBJTEVfRkxBR1MgIi9ZY1wiJHtfaGVhZGVyfVwiIC9GcFwiJHtQcmVjb21waWxlZEJpbmFy eX1cIiIKLSAgICAgICAgICAgIE9CSkVDVF9PVVRQVVRTICIke1ByZWNvbXBpbGVkQmluYXJ5fSIp CisgICAgICAgICMgY2xhbmctY2wgcmVxdWlyZXMgL0ZJIHdpdGggL1ljCisgICAgICAgIGlmIChD T01QSUxFUl9JU19DTEFOR19DTCkKKyAgICAgICAgICAgIHNldF9zb3VyY2VfZmlsZXNfcHJvcGVy dGllcygke19jcHB9CisgICAgICAgICAgICAgICAgUFJPUEVSVElFUyBDT01QSUxFX0ZMQUdTICIv WWNcIiR7X2hlYWRlcn1cIiAvRnBcIiR7UHJlY29tcGlsZWRCaW5hcnl9XCIgL0ZJXCIke19oZWFk ZXJ9XCIiCisgICAgICAgICAgICAgICAgT0JKRUNUX09VVFBVVFMgIiR7UHJlY29tcGlsZWRCaW5h cnl9IikKKyAgICAgICAgZWxzZSAoKQorICAgICAgICAgICAgc2V0X3NvdXJjZV9maWxlc19wcm9w ZXJ0aWVzKCR7X2NwcH0KK1wgICAgICAgICAgICAgICBQUk9QRVJUSUVTIENPTVBJTEVfRkxBR1Mg Ii9ZY1wiJHtfaGVhZGVyfVwiIC9GcFwiJHtQcmVjb21waWxlZEJpbmFyeX1cIiIKKyAgICAgICAg ICAgICAgICBPQkpFQ1RfT1VUUFVUUyAiJHtQcmVjb21waWxlZEJpbmFyeX0iKQorICAgICAgICBl bmRpZiAoKQogICAgICAgICBzZXRfc291cmNlX2ZpbGVzX3Byb3BlcnRpZXMoJHtfc291cmNlc30K ICAgICAgICAgICAgIFBST1BFUlRJRVMgQ09NUElMRV9GTEFHUyAiL1l1XCIke19oZWFkZXJ9XCIg L0ZJXCIke19oZWFkZXJ9XCIgL0ZwXCIke1ByZWNvbXBpbGVkQmluYXJ5fVwiIikKIAo= 314774 2017-07-06 16:24:56 -0700 2017-07-06 18:11:04 -0700 Patch to pass /FI for clang-cl builds when making precompiled headers 174221-2.diff text/plain 1760 stephan.szabo ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2YmZkMjMwYzEyMy4uYzdi N2E5OTViNzEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0wNy0wNiAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5j b20+CisKKyAgICAgICAgW1dpbl0gQnVpbGQgcHJlY29tcGlsZWQgaGVhZGVyIHN1Y2Nlc3NmdWxs eSB3aXRoIGNsYW5nLWNsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzQyMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2U6CisKIDIwMTctMDYtMjgg IFN0ZXBoYW4gU3phYm8gIDxzdGVwaGFuLnN6YWJvQGFtLnNvbnkuY29tPgogCiAgICAgICAgIFtX aW5dIEJ1aWxkIEpTQ09ubHkgb24gV2luZG93cyB3aXRoIGNsYW5nLWNsCmRpZmYgLS1naXQgYS9T b3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jv cy5jbWFrZQppbmRleCA3MTM5MjdlN2I1NS4uZDhlZWZmYWRkMTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jv cy5jbWFrZQpAQCAtMzQsOSArMzQsMTYgQEAgbWFjcm8oQUREX1BSRUNPTVBJTEVEX0hFQURFUiBf aGVhZGVyIF9jcHAgX3NvdXJjZSkKICAgICAgICAgc2V0KFByZWNvbXBpbGVkQmluYXJ5ICIke0NN QUtFX0NVUlJFTlRfQklOQVJZX0RJUn0vJHtfc291cmNlfS8ke1ByZWNvbXBpbGVkQmFzZW5hbWV9 LnBjaCIpCiAgICAgICAgIHNldChfc291cmNlcyAkeyR7X3NvdXJjZX19KQogCi0gICAgICAgIHNl dF9zb3VyY2VfZmlsZXNfcHJvcGVydGllcygke19jcHB9Ci0gICAgICAgICAgICBQUk9QRVJUSUVT IENPTVBJTEVfRkxBR1MgIi9ZY1wiJHtfaGVhZGVyfVwiIC9GcFwiJHtQcmVjb21waWxlZEJpbmFy eX1cIiIKLSAgICAgICAgICAgIE9CSkVDVF9PVVRQVVRTICIke1ByZWNvbXBpbGVkQmluYXJ5fSIp CisgICAgICAgICMgY2xhbmctY2wgcmVxdWlyZXMgL0ZJIHdpdGggL1ljCisgICAgICAgIGlmIChD T01QSUxFUl9JU19DTEFOR19DTCkKKyAgICAgICAgICAgIHNldF9zb3VyY2VfZmlsZXNfcHJvcGVy dGllcygke19jcHB9CisgICAgICAgICAgICAgICAgUFJPUEVSVElFUyBDT01QSUxFX0ZMQUdTICIv WWNcIiR7X2hlYWRlcn1cIiAvRnBcIiR7UHJlY29tcGlsZWRCaW5hcnl9XCIgL0ZJXCIke19oZWFk ZXJ9XCIiCisgICAgICAgICAgICAgICAgT0JKRUNUX09VVFBVVFMgIiR7UHJlY29tcGlsZWRCaW5h cnl9IikKKyAgICAgICAgZWxzZSAoKQorICAgICAgICAgICAgc2V0X3NvdXJjZV9maWxlc19wcm9w ZXJ0aWVzKCR7X2NwcH0KKyAgICAgICAgICAgICAgICBQUk9QRVJUSUVTIENPTVBJTEVfRkxBR1Mg Ii9ZY1wiJHtfaGVhZGVyfVwiIC9GcFwiJHtQcmVjb21waWxlZEJpbmFyeX1cIiIKKyAgICAgICAg ICAgICAgICBPQkpFQ1RfT1VUUFVUUyAiJHtQcmVjb21waWxlZEJpbmFyeX0iKQorICAgICAgICBl bmRpZiAoKQogICAgICAgICBzZXRfc291cmNlX2ZpbGVzX3Byb3BlcnRpZXMoJHtfc291cmNlc30K ICAgICAgICAgICAgIFBST1BFUlRJRVMgQ09NUElMRV9GTEFHUyAiL1l1XCIke19oZWFkZXJ9XCIg L0ZJXCIke19oZWFkZXJ9XCIgL0ZwXCIke1ByZWNvbXBpbGVkQmluYXJ5fVwiIikKIAo=