173888 2017-06-27 14:25:39 -0700 [JSC] Do not touch VM after notifying Ready in DFG::Worklist 2017-06-27 17:46:54 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki buildbot fpizlo keith_miller mark.lam msaboff ryanhaddad saam oldest_to_newest 1323251 0 ysuzuki 2017-06-27 14:25:39 -0700 [JSC] Do not touch VM after notifying Ready in DFG::Worklist 1323253 1 313944 ysuzuki 2017-06-27 14:28:36 -0700 Created attachment 313944 Patch 1323256 2 buildbot 2017-06-27 14:31:48 -0700 Attachment 313944 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:9: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: dangling pointer [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1323261 3 313947 ysuzuki 2017-06-27 14:33:42 -0700 Created attachment 313947 Patch 1323266 4 saam 2017-06-27 14:41:57 -0700 Can you unmark the test as flaky too? 1323348 5 ysuzuki 2017-06-27 17:43:05 -0700 (In reply to Saam Barati from comment #4) > Can you unmark the test as flaky too? Sure! 1323349 6 ysuzuki 2017-06-27 17:45:26 -0700 (In reply to Yusuke Suzuki from comment #5) > (In reply to Saam Barati from comment #4) > > Can you unmark the test as flaky too? > > Sure! It seems that existing test marking is just Slow due to its slowness. 1323351 7 ysuzuki 2017-06-27 17:46:54 -0700 Committed r218856: <http://trac.webkit.org/changeset/218856> 313944 2017-06-27 14:28:36 -0700 2017-06-27 14:33:40 -0700 Patch bug-173888-20170628062835.patch text/plain 1638 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 Y2UzMWRmZDQ2YjAwODc0M2EyNGJiYWUzMmY2NmMzZTNjZmJiMTIzLi4wODdkZDgxZjRjYjY5MDFk MGVlZGVjZGEzMjNhZTc1MDc0MWM2Mjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wNi0yNyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBEbyBub3QgdG91Y2ggVk0gYWZ0ZXIgbm90aWZ5aW5nIFJl YWR5IGluIERGRzo6V29ya2xpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3Mzg4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFmdGVyIG5vdGlmeWluZyBQbGFuOjpSZWFkeSwgVk0gY2FuIGJlIGRlc3Ry b3llZC4KKyAgICAgICAgVGh1cywgUGxhbjo6dm0oKSBjYW4gcmV0dXJuIGEgZGFuZ2xpbmcgcG9p bnRlci4gRG8gbm90IHRvdWNoIGl0LgorICAgICAgICBUaGlzIGNhdXNlcyBvY2Nhc2lvbmFsIFNF R1YgLyBhc3NlcnRpb24gZmFpbHVyZXMgaW4gd29ya2Vycy9ib21iIHRlc3QuCisKKyAgICAgICAg KiBkZmcvREZHV29ya2xpc3QuY3BwOgorCiAyMDE3LTA2LTI2ICBZdXN1a2UgU3V6dWtpICA8dXRh dGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtXVEZdIERyb3AgVGhyZWFkOjpjcmVhdGUo b2Jzb2xldGUgdGhpbmdzKSBBUEkgc2luY2Ugd2UgY2FuIHVzZSBsYW1iZGEKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHV29ya2xpc3QuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAKaW5kZXggZDcxYmE1NzNjMWM5MDg4MWMyNWMz NzhmNDJjYzk0N2NkZmVmZDgyNy4uNGJiY2M1ZDQ3ZDFkZWU1N2IwN2EwMDM2Nzc5OTc4YmYzNzE3 ODcwZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAKQEAgLTEz MCw5ICsxMzAsOSBAQCBjbGFzcyBXb3JrbGlzdDo6VGhyZWFkQm9keSA6IHB1YmxpYyBBdXRvbWF0 aWNUaHJlYWQgewogICAgICAgICAgICAgCiAgICAgICAgICAgICBtX3dvcmtsaXN0Lm1fcmVhZHlQ bGFucy5hcHBlbmQobV9wbGFuKTsKICAgICAgICAgICAgIAorICAgICAgICAgICAgUkVMRUFTRV9B U1NFUlQoIW1fcGxhbi0+dm0tPmhlYXAuY29sbGVjdG9yQmVsaWV2ZXNUaGF0VGhlV29ybGRJc1N0 b3BwZWQoKSk7CiAgICAgICAgICAgICBtX3dvcmtsaXN0Lm1fcGxhbkNvbXBpbGVkLm5vdGlmeUFs bCgpOwogICAgICAgICB9Ci0gICAgICAgIFJFTEVBU0VfQVNTRVJUKCFtX3BsYW4tPnZtLT5oZWFw LmNvbGxlY3RvckJlbGlldmVzVGhhdFRoZVdvcmxkSXNTdG9wcGVkKCkpOwogICAgICAgICAKICAg ICAgICAgcmV0dXJuIFdvcmtSZXN1bHQ6OkNvbnRpbnVlOwogICAgIH0K 313947 2017-06-27 14:33:42 -0700 2017-06-27 14:40:55 -0700 Patch bug-173888-20170628063341.patch text/plain 1662 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4ODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 Y2UzMWRmZDQ2YjAwODc0M2EyNGJiYWUzMmY2NmMzZTNjZmJiMTIzLi4yMjkyYzllYzE0NjI4MGFi NTcxODEzZjk5ZmM5NDdkZjc5NmY1MzY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wNi0yNyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBEbyBub3QgdG91Y2ggVk0gYWZ0ZXIgbm90aWZ5aW5nIFJl YWR5IGluIERGRzo6V29ya2xpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3Mzg4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFmdGVyIG5vdGlmeWluZyBQbGFuOjpSZWFkeSBhbmQgcmVsZWFzaW5nIFdv cmtsaXN0IGxvY2ssIFZNIGNhbiBiZSBkZXN0cm95ZWQuCisgICAgICAgIFRodXMsIFBsYW46OnZt KCkgY2FuIHJldHVybiBhIGRlc3Ryb3llZCBWTS4gRG8gbm90IHRvdWNoIGl0LgorICAgICAgICBU aGlzIGNhdXNlcyBvY2Nhc2lvbmFsIFNFR1YgLyBhc3NlcnRpb24gZmFpbHVyZXMgaW4gd29ya2Vy cy9ib21iIHRlc3QuCisKKyAgICAgICAgKiBkZmcvREZHV29ya2xpc3QuY3BwOgorCiAyMDE3LTA2 LTI2ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtX VEZdIERyb3AgVGhyZWFkOjpjcmVhdGUob2Jzb2xldGUgdGhpbmdzKSBBUEkgc2luY2Ugd2UgY2Fu IHVzZSBsYW1iZGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHV29y a2xpc3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAKaW5k ZXggZDcxYmE1NzNjMWM5MDg4MWMyNWMzNzhmNDJjYzk0N2NkZmVmZDgyNy4uNGJiY2M1ZDQ3ZDFk ZWU1N2IwN2EwMDM2Nzc5OTc4YmYzNzE3ODcwZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdXb3JrbGlzdC5jcHAKQEAgLTEzMCw5ICsxMzAsOSBAQCBjbGFzcyBXb3JrbGlzdDo6VGhy ZWFkQm9keSA6IHB1YmxpYyBBdXRvbWF0aWNUaHJlYWQgewogICAgICAgICAgICAgCiAgICAgICAg ICAgICBtX3dvcmtsaXN0Lm1fcmVhZHlQbGFucy5hcHBlbmQobV9wbGFuKTsKICAgICAgICAgICAg IAorICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoIW1fcGxhbi0+dm0tPmhlYXAuY29sbGVjdG9y QmVsaWV2ZXNUaGF0VGhlV29ybGRJc1N0b3BwZWQoKSk7CiAgICAgICAgICAgICBtX3dvcmtsaXN0 Lm1fcGxhbkNvbXBpbGVkLm5vdGlmeUFsbCgpOwogICAgICAgICB9Ci0gICAgICAgIFJFTEVBU0Vf QVNTRVJUKCFtX3BsYW4tPnZtLT5oZWFwLmNvbGxlY3RvckJlbGlldmVzVGhhdFRoZVdvcmxkSXNT dG9wcGVkKCkpOwogICAgICAgICAKICAgICAgICAgcmV0dXJuIFdvcmtSZXN1bHQ6OkNvbnRpbnVl OwogICAgIH0K