<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>173801</bug_id>
          
          <creation_ts>2017-06-23 18:29:10 -0700</creation_ts>
          <short_desc>[GTK+] Homebrew is not allowed to run any script under sudo.</short_desc>
          <delta_ts>2019-08-12 17:53:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>https://github.com/WebKit/webkit/blob/master/Tools/gtk/install-dependencies#L3</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="YuHang">yhorg</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>agomez</cc>
    
    <cc>ashvayka</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dhaval</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>lforschler</cc>
    
    <cc>ltilve</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1322532</commentid>
    <comment_count>0</comment_count>
    <who name="YuHang">yhorg</who>
    <bug_when>2017-06-23 18:29:10 -0700</bug_when>
    <thetext>/Tools/gtk/install-dependencies

... line 3
# This script needs to be run with root rights.
if [ $UID -ne 0 ]; then
    sudo $0
    exit 0
fi


These code snippet will cause error while installing dependencies.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1501508</commentid>
    <comment_count>1</comment_count>
    <who name="overclockedllama">dhaval</who>
    <bug_when>2019-02-02 11:20:28 -0800</bug_when>
    <thetext>fix proposed at https://github.com/WebKit/webkit/pull/30</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1543574</commentid>
    <comment_count>2</comment_count>
      <attachid>371812</attachid>
    <who name="Alexey Shvayka">ashvayka</who>
    <bug_when>2019-06-10 19:48:24 -0700</bug_when>
    <thetext>Created attachment 371812
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1543575</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Shvayka">ashvayka</who>
    <bug_when>2019-06-10 19:52:52 -0700</bug_when>
    <thetext>Tools/gtk/install-dependencies works fine for me w/o root privileges.
Homebrew 2.1.4
macOS 10.14.4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1543784</commentid>
    <comment_count>4</comment_count>
    <who name="overclockedllama">dhaval</who>
    <bug_when>2019-06-11 12:00:41 -0700</bug_when>
    <thetext>Yeah that patch makes more sense. Brew should not run as root.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560633</commentid>
    <comment_count>5</comment_count>
      <attachid>371812</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-12 17:52:55 -0700</bug_when>
    <thetext>Comment on attachment 371812
Patch

Clearing flags on attachment: 371812

Committed r248584: &lt;https://trac.webkit.org/changeset/248584&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560634</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-12 17:52:57 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560635</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-08-12 17:53:20 -0700</bug_when>
    <thetext>&lt;rdar://problem/54235619&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>371812</attachid>
            <date>2019-06-10 19:48:24 -0700</date>
            <delta_ts>2019-08-12 17:52:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-173801-20190611054823.patch</filename>
            <type>text/plain</type>
            <size>1143</size>
            <attacher name="Alexey Shvayka">ashvayka</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI0NjMwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE1IEBACisyMDE5LTA2LTEwICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWls
LmNvbT4KKworICAgICAgICBBWDogSG9tZWJyZXcgaXMgbm90IGFsbG93ZWQgdG8gcnVuIGFueSBz
Y3JpcHQgdW5kZXIgc3Vkby4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE3MzgwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIExhdGVzdCB2ZXJzaW9ucyBvZiBIb21lYnJldyB0aHJvdyBhbiBlcnJvciB3aGVu
IHJ1biBhcyByb290LgorICAgICAgICBEZXBlbmRlbmNpZXMgYXJlIHN1Y2Nlc3NmdWxseSBpbnN0
YWxsZWQgdy9vIGBzdWRvYCBvbiBtYWNPUywgc28gc2tpcCBpdC4KKworICAgICAgICAqIGd0ay9p
bnN0YWxsLWRlcGVuZGVuY2llczoKKwogMjAxOS0wNi0xMCAgU2FtIFdlaW5pZyAgPHdlaW5pZ0Bh
cHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIERhc2hib2FyZCBzdXBwb3J0CkluZGV4OiBUb29s
cy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvZ3RrL2luc3Rh
bGwtZGVwZW5kZW5jaWVzCShyZXZpc2lvbiAyNDYwNjcpCisrKyBUb29scy9ndGsvaW5zdGFsbC1k
ZXBlbmRlbmNpZXMJKHdvcmtpbmcgY29weSkKQEAgLTEsNyArMSw3IEBACiAjIS91c3IvYmluL2Vu
diBiYXNoCiAKLSMgVGhpcyBzY3JpcHQgbmVlZHMgdG8gYmUgcnVuIHdpdGggcm9vdCByaWdodHMu
Ci1pZiBbICRVSUQgLW5lIDAgXTsgdGhlbgorIyBPbiBMaW51eCBzeXN0ZW1zLCB0aGlzIHNjcmlw
dCBuZWVkcyB0byBiZSBydW4gd2l0aCByb290IHJpZ2h0cy4KK2lmIFsgYHVuYW1lYCAhPSAiRGFy
d2luIiBdICYmIFsgJFVJRCAtbmUgMCBdOyB0aGVuCiAgICAgc3VkbyAkMAogICAgIGV4aXQgMAog
ZmkK
</data>

          </attachment>
      

    </bug>

</bugzilla>