173693 2017-06-21 22:35:51 -0700 Add some thread safety guards to GenericCallback 2017-06-22 10:42:10 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 beidson beidson cdumez commit-queue ggaren mitz rniwa sam oldest_to_newest 1321761 0 beidson 2017-06-21 22:35:51 -0700 Add some thread safety guards to GenericCallback A callback should be created, performed, invalidated, and/or destroyed all on the same thread. Let's write code to notify us if that doesn't happen. 1321763 1 313585 beidson 2017-06-21 22:38:46 -0700 Created attachment 313585 Patch 1321764 2 beidson 2017-06-21 22:39:22 -0700 (I haven't even compiled yet, justing throwing this at EWS for now) 1321951 3 313585 commit-queue 2017-06-22 10:34:39 -0700 Comment on attachment 313585 Patch Clearing flags on attachment: 313585 Committed r218705: <http://trac.webkit.org/changeset/218705> 1321952 4 commit-queue 2017-06-22 10:34:40 -0700 All reviewed patches have been landed. Closing bug. 1321960 5 313585 mitz 2017-06-22 10:42:10 -0700 Comment on attachment 313585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313585&action=review > Source/WebKit2/UIProcess/GenericCallback.h:153 > +#ifndef NDEBUG This should be #if !ASSERT_DISABLED instead. 313585 2017-06-21 22:38:46 -0700 2017-06-22 10:34:39 -0700 Patch bug-173693-20170621223845.patch text/plain 2304 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjE4Njc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDBmNTMwMWFlNDRkNjM3 NGM0ZmYyNmQzODZhOGM2OGZhODRlMGI3Mi4uOThiYTYwOGZmMWRjNTFiNTEwYjUyMThlYmNjNDIy NjczYzhlMTJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTIxICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc29tZSB0aHJlYWQg c2FmZXR5IGd1YXJkcyB0byBHZW5lcmljQ2FsbGJhY2suCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzM2OTMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGNhbGxiYWNrIHNob3VsZCBiZSBjcmVhdGVkLCBw ZXJmb3JtZWQsIGludmFsaWRhdGVkLCBhbmQvb3IgZGVzdHJveWVkIGFsbCBvbiB0aGUgc2FtZSB0 aHJlYWQuCisgICAgICAgIExldCdzIHdyaXRlIGNvZGUgdG8gbm90aWZ5IHVzIGlmIHRoYXQgZG9l c24ndCBoYXBwZW4uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvR2VuZXJpY0NhbGxiYWNrLmg6Cisg ICAgICAgIChXZWJLaXQ6OkdlbmVyaWNDYWxsYmFjazo6fkdlbmVyaWNDYWxsYmFjayk6CisgICAg ICAgIChXZWJLaXQ6OkdlbmVyaWNDYWxsYmFjazo6cGVyZm9ybUNhbGxiYWNrV2l0aFJldHVyblZh bHVlKToKKyAgICAgICAgKFdlYktpdDo6R2VuZXJpY0NhbGxiYWNrOjppbnZhbGlkYXRlKToKKwog MjAxNy0wNi0yMSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFJFR1JFU1NJT04gKHIyMTg0MTkpOiAzIE5TTXV0YWJsZURpY2lvbnRhcnkgbGVha3MgY2FsbGlu ZyAtW1dLUHJvY2Vzc1Bvb2wgX3BsdWdpbkxvYWRDbGllbnRQb2xpY2llc10KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9HZW5lcmljQ2FsbGJhY2suaCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9HZW5lcmljQ2FsbGJhY2suaAppbmRleCA0NGJiYzkxZDQyYTg2ZTQxMzMx YWU3YzM2ZDgwOTc2MmY2N2VkZGJiLi4wMzViNzU0YzY1NzM3NjYzYjNkMzUwOTJlYjI1NGMzYWQy ODYxZmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvR2VuZXJpY0NhbGxi YWNrLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oCkBA IC0zNSw2ICszNSw3IEBACiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KICNpbmNsdWRlIDx3 dGYvUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9SdW5Mb29wLmg+CisjaW5jbHVkZSA8d3Rm L1RocmVhZGluZy5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApAQCAtMTAwLDExICsxMDEsMTQg QEAgcHVibGljOgogCiAgICAgdmlydHVhbCB+R2VuZXJpY0NhbGxiYWNrKCkKICAgICB7CisgICAg ICAgIEFTU0VSVChjdXJyZW50VGhyZWFkKCkgPT0gbV9vcmlnaW5UaHJlYWRJRCk7CiAgICAgICAg IEFTU0VSVCghbV9jYWxsYmFjayk7CiAgICAgfQogCiAgICAgdm9pZCBwZXJmb3JtQ2FsbGJhY2tX aXRoUmV0dXJuVmFsdWUoVC4uLiByZXR1cm5WYWx1ZSkKICAgICB7CisgICAgICAgIEFTU0VSVChj dXJyZW50VGhyZWFkKCkgPT0gbV9vcmlnaW5UaHJlYWRJRCk7CisKICAgICAgICAgaWYgKCFtX2Nh bGxiYWNrKQogICAgICAgICAgICAgcmV0dXJuOwogCkBAIC0xMjAsNiArMTI0LDggQEAgcHVibGlj OgogCiAgICAgdm9pZCBpbnZhbGlkYXRlKEVycm9yIGVycm9yID0gRXJyb3I6OlVua25vd24pIGZp bmFsCiAgICAgeworICAgICAgICBBU1NFUlQoY3VycmVudFRocmVhZCgpID09IG1fb3JpZ2luVGhy ZWFkSUQpOworCiAgICAgICAgIGlmICghbV9jYWxsYmFjaykKICAgICAgICAgICAgIHJldHVybjsK IApAQCAtMTQzLDYgKzE0OSwxMCBAQCBwcml2YXRlOgogICAgIH0KIAogICAgIHN0ZDo6b3B0aW9u YWw8Q2FsbGJhY2tGdW5jdGlvbj4gbV9jYWxsYmFjazsKKworI2lmbmRlZiBOREVCVUcKKyAgICBU aHJlYWRJZGVudGlmaWVyIG1fb3JpZ2luVGhyZWFkSUQgeyBjdXJyZW50VGhyZWFkKCkgfTsKKyNl bmRpZgogfTsKIAogdGVtcGxhdGU8dHlwZW5hbWUgQVBJUmV0dXJuVmFsdWVUeXBlLCB0eXBlbmFt ZSBJbnRlcm5hbFJldHVyblZhbHVlVHlwZSA9IHR5cGVuYW1lIEFQSVR5cGVJbmZvPEFQSVJldHVy blZhbHVlVHlwZT46OkltcGxUeXBlKj4K