173375 2017-06-14 11:09:33 -0700 REGRESSION (r218228): Layout Test editing/execCommand/strikethrough-uses-strike-tag.html is failing 2017-06-15 13:39:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=173330 https://bugs.webkit.org/show_bug.cgi?id=173380 P2 Normal --- 1 jlewis3 webkit-unassigned ap ryanhaddad zalan oldest_to_newest 1319238 0 jlewis3 2017-06-14 11:09:33 -0700 editing/execCommand/strikethrough-uses-strike-tag.html started failing after revision r218228 https://trac.webkit.org/changeset/218228/webkit I spoke with Zalan about the revision and failure. Test just needed re-baselining. 1319244 1 jlewis3 2017-06-14 11:12:58 -0700 Re-baselined test: https://trac.webkit.org/changeset/218273/webkit 1319272 2 jlewis3 2017-06-14 12:20:55 -0700 Fixed typo: https://trac.webkit.org/changeset/218279/webkit 1319406 3 jlewis3 2017-06-14 18:20:29 -0700 After the Re-baseline, the test began to pass on release, but the Debug builds began to fail. Debug diff --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/editing/execCommand/strikethrough-uses-strike-tag-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/editing/execCommand/strikethrough-uses-strike-tag-actual.txt @@ -1,4 +1,3 @@ -Blocked access to external URL https://www.webkit.org/ Ensuring we continue to use strike tags for legacy strikethrough execCommands, not s tags. See https://bugs.webkit.org/show_bug.cgi?id=53475 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". 1319465 4 ap 2017-06-14 23:13:44 -0700 > -Blocked access to external URL https://www.webkit.org/ This output is coming from the preceding test editing/execCommand/show-modal-dialog-during-execCommand.html, which is now unskipped, but only in release. Zalan, could you please take a look? Clearly, we shouldn't leak output from the preceding test. 1319578 5 zalan 2017-06-15 08:28:13 -0700 (In reply to Alexey Proskuryakov from comment #4) > > -Blocked access to external URL https://www.webkit.org/ > > This output is coming from the preceding test > editing/execCommand/show-modal-dialog-during-execCommand.html, which is now > unskipped, but only in release. > > Zalan, could you please take a look? Clearly, we shouldn't leak output from > the preceding test. Oh, I was under the impression that the unskipped test(show-modal-dialog-during-execCommand.html) needed rebaselining. I agree, it's not okay to leak output from any test. I will surely look at it though I am not the best person to deal with such failures. 1319648 6 jlewis3 2017-06-15 12:02:07 -0700 Spoke with zalan, reverted re-baseline and re-implemented skip. https://trac.webkit.org/changeset/218346/webkit