173330 2017-06-13 14:30:15 -0700 Synchronous media query callbacks on nested frames could produced a detached FrameView. 2017-06-14 18:23:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173375 InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue jlewis3 simon.fraser zalan oldest_to_newest 1318821 0 zalan 2017-06-13 14:30:15 -0700 rdar://problem/32487541 1318828 1 312812 zalan 2017-06-13 14:45:12 -0700 Created attachment 312812 Patch 1318829 2 zalan 2017-06-13 14:45:51 -0700 see bug 173329 too. 1318832 3 312812 simon.fraser 2017-06-13 14:49:09 -0700 Comment on attachment 312812 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312812&action=review > Source/WebCore/page/FrameView.cpp:1522 > + // FIXME: Firing media query callbacks synchronously on nested frames could produced a detached FrameView here (webkit.org/b/173329). I would mention that a media query listener could trigger a navigation. 1318881 4 312824 zalan 2017-06-13 16:08:50 -0700 Created attachment 312824 Patch 1318915 5 commit-queue 2017-06-13 17:18:52 -0700 The commit-queue encountered the following flaky tests while processing attachment 312824: media/media-source/media-source-unnecessary-seek-seeked.html bug 173344 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch. 1318916 6 312824 commit-queue 2017-06-13 17:19:25 -0700 Comment on attachment 312824 Patch Clearing flags on attachment: 312824 Committed r218228: <http://trac.webkit.org/changeset/218228> 1318917 7 commit-queue 2017-06-13 17:19:26 -0700 All reviewed patches have been landed. Closing bug. 1319407 8 jlewis3 2017-06-14 18:23:57 -0700 After this patch was added, the test editing/execCommand/strikethrough-uses-strike-tag.html started failing on release builds Per Zalan, I Re-baselined the test. See bug: https://bugs.webkit.org/show_bug.cgi?id=173375 After the re-baseline, the test began to pass on release, but started to fail on Mac WK1 Debug. 312812 2017-06-13 14:45:12 -0700 2017-06-13 16:08:49 -0700 Patch bug-173330-20170613144511.patch text/plain 3211 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3Nzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMxY2EwYWM0NzJiMTU0 NTI4YzY2YjYyYTE3MWNmZTZjMDhjZDBlYS4uNzNjNGU3MjE3NjhmNjkzOTg4YTRhNGU2N2JiYzBk MTkwY2I5Y2Q2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTEzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3luY2hyb25vdXMgbWVkaWEg cXVlcnkgY2FsbGJhY2tzIG9uIG5lc3RlZCBmcmFtZXMgY291bGQgcHJvZHVjZWQgYSBkZXRhY2hl ZCBGcmFtZVZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzMzMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBjcmFzaCB3aGVuIHRoZSBuZXN0ZWQgZnJhbWUncyBt ZWRpYSBxdWVyeSBjYWxsYmFjayB0cmlnZ2VycyBuYXZpZ2F0aW9uIG9uIHRoZSBtYWluZnJhbWUu CisgICAgICAgIHdlYmtpdC5vcmcvYi8xNzMzMjkgaXMgdG8gdHJhY2sgd2hldGhlciB3ZSBzaG91 bGQgYWxsb3cgc3luY2hyb25vdXMgY2FsbGJhY2sgZmlyaW5nIGZyb20gRnJhbWVWaWV3OjpsYXlv dXQoKS4gCisKKyAgICAgICAgQ292ZXJlZCBieSBzaG93LW1vZGFsLWRpYWxvZy1kdXJpbmctZXhl Y0NvbW1hbmQuaHRtbC4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZyYW1lVmlldzo6bGF5b3V0KToKKwogMjAxNy0wNi0wNSAgWmFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIERlc3Ryb3kgdGhlIGFzc29jaWF0ZWQgcmVu ZGVyZXIgc3VidHJlZSB3aGVuIGRpc3BsYXk6IGNvbnRlbnRzIG5vZGUgaXMgZGVsZXRlZC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCBjNDFmYzhkM2RkM2VjNjk0MjJhODIzMTJkZDEx NTYwNjBkMzBkYWI4Li44MDY4ZWVmNTQ5NWY2MWMxYmEwYTc1NTJkZjQ2MzVhYmNiNzMwMmRkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0xNTE3LDggKzE1MTcsMTIgQEAgdm9pZCBG cmFtZVZpZXc6OmxheW91dChib29sIGFsbG93U3VidHJlZSkKIAogICAgIGJvb2wgbmVlZGVkRnVs bFJlcGFpbnQgPSBtX25lZWRzRnVsbFJlcGFpbnQ7CiAKLSAgICBpZiAoIXN1YnRyZWUgJiYgIWRv d25jYXN0PFJlbmRlclZpZXc+KCpyb290KS5wcmludGluZygpKQorICAgIGlmICghc3VidHJlZSAm JiAhZG93bmNhc3Q8UmVuZGVyVmlldz4oKnJvb3QpLnByaW50aW5nKCkpIHsKICAgICAgICAgYWRq dXN0Vmlld1NpemUoKTsKKyAgICAgICAgLy8gRklYTUU6IEZpcmluZyBtZWRpYSBxdWVyeSBjYWxs YmFja3Mgc3luY2hyb25vdXNseSBvbiBuZXN0ZWQgZnJhbWVzIGNvdWxkIHByb2R1Y2VkIGEgZGV0 YWNoZWQgRnJhbWVWaWV3IGhlcmUgKHdlYmtpdC5vcmcvYi8xNzMzMjkpLgorICAgICAgICBpZiAo aGFzT25lUmVmKCkpCisgICAgICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgbV9sYXlvdXRQ aGFzZSA9IEluUG9zdExheW91dDsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGRlNzQ2NWY4YWFlYmMwMzI0M2Q4MmVlZWY0 MGUyODAxNDliZTJhZjMuLjAzNTVjN2M2M2YyMDMyMDAyZTUxNzk2MWE1YTQwYzIwOTFjMzU0MGQg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wNi0xMyAgWmFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPgorCisgICAgICAgIFN5bmNocm9ub3VzIG1lZGlhIHF1ZXJ5IGNhbGxiYWNrcyBv biBuZXN0ZWQgZnJhbWVzIGNvdWxkIHByb2R1Y2VkIGEgZGV0YWNoZWQgRnJhbWVWaWV3LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMzMwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0 YXRpb25zOiBBU1NFUlQoZnJhbWUoKS0+dmlldygpID09IHRoaXMpIHN0aWxsIGZpcmVzIGR1ZSB0 byB0aGUgdW5leHBlY3RlZCBuYXZpZ2F0aW9uLCBidXQgd2UgY2xlYXJseQorICAgICAgICBtYW5h Z2UgdG8gcmVjb3ZlciBmcm9tIGl0LiBVbnNraXAgaXQgKGRlYnVnKSB3aGVuIHdlYmtpdC5vcmcv Yi8xNzMzMjkgaXMgcmVzb2x2ZWQuCisKIDIwMTctMDYtMDUgIFJ5YW4gSGFkZGFkICA8cnlhbmhh ZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgUmViYXNlbGluZSB0ZXN0cyBmb3IgV2luZG93cyBh ZnRlciByMjE3NzcyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBi L0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYmRmNDg5NGFlNjRmZWEzNmEyYWFi N2M0NDdmNWZmYTU5ZTZhZWJhMS4uMjNiY2FlNzUyMGIxMmFhZWQ4OGVhNmJjNTJlN2EwMWQyNjY4 OGVkZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlv dXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0zOCw3ICszOCw3IEBAIGZhc3QvY3NzL3Zhcmlh Ymxlcy9jb25zdGFudHMvaW9zIFsgU2tpcCBdCiBodHRwL3Rlc3RzL3ByZWxvYWQvdmlld3BvcnQg WyBTa2lwIF0KIAogIyB3aW5kb3cuc2hvd01vZGFsRGlhbG9nIGlzIG9ubHkgdGVzdGVkIGluIER1 bXBSZW5kZXJUcmVlIG9uIE1hYy4KLWVkaXRpbmcvZXhlY0NvbW1hbmQvc2hvdy1tb2RhbC1kaWFs b2ctZHVyaW5nLWV4ZWNDb21tYW5kLmh0bWwgWyBTa2lwIF0KK1sgRGVidWcgXSBlZGl0aW5nL2V4 ZWNDb21tYW5kL3Nob3ctbW9kYWwtZGlhbG9nLWR1cmluZy1leGVjQ29tbWFuZC5odG1sIFsgU2tp cCBdCiAKIGZhc3Qvc2hhZG93LWRvbS90b3VjaC1ldmVudC1vbi10ZXh0LWFzc2lnbmVkLXRvLXNs b3QuaHRtbCBbIFNraXAgXQogCg== 312824 2017-06-13 16:08:50 -0700 2017-06-13 17:19:25 -0700 Patch bug-173330-20170613160850.patch text/plain 3268 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3Nzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMxY2EwYWM0NzJiMTU0 NTI4YzY2YjYyYTE3MWNmZTZjMDhjZDBlYS4uNTgxYzM0OWYwNDM1MzY0M2Y0OGFhNDQxYzZjZTRj MDEzNjc0NjQ1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA2LTEzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3luY2hyb25vdXMgbWVkaWEg cXVlcnkgY2FsbGJhY2tzIG9uIG5lc3RlZCBmcmFtZXMgY291bGQgcHJvZHVjZWQgYSBkZXRhY2hl ZCBGcmFtZVZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzMzMzAKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAg ICAgVGhpcyBwYXRjaCBmaXhlcyB0aGUgY3Jhc2ggd2hlbiB0aGUgbmVzdGVkIGZyYW1lJ3MgbWVk aWEgcXVlcnkgY2FsbGJhY2sgdHJpZ2dlcnMgbmF2aWdhdGlvbiBvbiB0aGUgbWFpbmZyYW1lLgor ICAgICAgICB3ZWJraXQub3JnL2IvMTczMzI5IGlzIHRvIHRyYWNrIHdoZXRoZXIgd2Ugc2hvdWxk IGFsbG93IHN5bmNocm9ub3VzIGNhbGxiYWNrIGZpcmluZyBmcm9tIEZyYW1lVmlldzo6bGF5b3V0 KCkuIAorCisgICAgICAgIENvdmVyZWQgYnkgc2hvdy1tb2RhbC1kaWFsb2ctZHVyaW5nLWV4ZWND b21tYW5kLmh0bWwuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZVZpZXc6OmxheW91dCk6CisKIDIwMTctMDYtMDUgIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBEZXN0cm95IHRoZSBhc3NvY2lhdGVkIHJlbmRl cmVyIHN1YnRyZWUgd2hlbiBkaXNwbGF5OiBjb250ZW50cyBub2RlIGlzIGRlbGV0ZWQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggYzQxZmM4ZDNkZDNlYzY5NDIyYTgyMzEyZGQxMTU2 MDYwZDMwZGFiOC4uNDRlYjQ0ZTQ0MWQ5ZDZkYzg2NWZhNmI0ZmI3NTU4ZjJkZTcyM2UwZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMTUxNyw4ICsxNTE3LDEzIEBAIHZvaWQgRnJh bWVWaWV3OjpsYXlvdXQoYm9vbCBhbGxvd1N1YnRyZWUpCiAKICAgICBib29sIG5lZWRlZEZ1bGxS ZXBhaW50ID0gbV9uZWVkc0Z1bGxSZXBhaW50OwogCi0gICAgaWYgKCFzdWJ0cmVlICYmICFkb3du Y2FzdDxSZW5kZXJWaWV3Pigqcm9vdCkucHJpbnRpbmcoKSkKKyAgICBpZiAoIXN1YnRyZWUgJiYg IWRvd25jYXN0PFJlbmRlclZpZXc+KCpyb290KS5wcmludGluZygpKSB7CiAgICAgICAgIGFkanVz dFZpZXdTaXplKCk7CisgICAgICAgIC8vIEZJWE1FOiBGaXJpbmcgbWVkaWEgcXVlcnkgY2FsbGJh Y2tzIHN5bmNocm9ub3VzbHkgb24gbmVzdGVkIGZyYW1lcyBjb3VsZCBwcm9kdWNlZCBhIGRldGFj aGVkIEZyYW1lVmlldyBoZXJlIGJ5CisgICAgICAgIC8vIG5hdmlnYXRpbmcgYXdheSBmcm9tIHRo ZSBjdXJyZW50IGRvY3VtZW50IChzZWUgd2Via2l0Lm9yZy9iLzE3MzMyOSkuCisgICAgICAgIGlm IChoYXNPbmVSZWYoKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICBtX2xheW91 dFBoYXNlID0gSW5Qb3N0TGF5b3V0OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGU3NDY1ZjhhYWViYzAzMjQzZDgyZWVl ZjQwZTI4MDE0OWJlMmFmMy4uZmVjZjU1ZGI4Yzc2YWY5YzVmODljNWQ0ZmI0M2I1MjljZjAyNDk0 YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA2LTEzICBaYWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CisKKyAgICAgICAgU3luY2hyb25vdXMgbWVkaWEgcXVlcnkgY2FsbGJhY2tz IG9uIG5lc3RlZCBmcmFtZXMgY291bGQgcHJvZHVjZWQgYSBkZXRhY2hlZCBGcmFtZVZpZXcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzMzMzAKKwor ICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0 YXRpb25zOiBBU1NFUlQoZnJhbWUoKS0+dmlldygpID09IHRoaXMpIHN0aWxsIGZpcmVzIGR1ZSB0 byB0aGUgdW5leHBlY3RlZCBuYXZpZ2F0aW9uLCBidXQgd2UgY2xlYXJseQorICAgICAgICBtYW5h Z2UgdG8gcmVjb3ZlciBmcm9tIGl0LiBVbnNraXAgaXQgKGRlYnVnKSB3aGVuIHdlYmtpdC5vcmcv Yi8xNzMzMjkgaXMgcmVzb2x2ZWQuCisKIDIwMTctMDYtMDUgIFJ5YW4gSGFkZGFkICA8cnlhbmhh ZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgUmViYXNlbGluZSB0ZXN0cyBmb3IgV2luZG93cyBh ZnRlciByMjE3NzcyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBi L0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYmRmNDg5NGFlNjRmZWEzNmEyYWFi N2M0NDdmNWZmYTU5ZTZhZWJhMS4uMjNiY2FlNzUyMGIxMmFhZWQ4OGVhNmJjNTJlN2EwMWQyNjY4 OGVkZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlv dXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0zOCw3ICszOCw3IEBAIGZhc3QvY3NzL3Zhcmlh Ymxlcy9jb25zdGFudHMvaW9zIFsgU2tpcCBdCiBodHRwL3Rlc3RzL3ByZWxvYWQvdmlld3BvcnQg WyBTa2lwIF0KIAogIyB3aW5kb3cuc2hvd01vZGFsRGlhbG9nIGlzIG9ubHkgdGVzdGVkIGluIER1 bXBSZW5kZXJUcmVlIG9uIE1hYy4KLWVkaXRpbmcvZXhlY0NvbW1hbmQvc2hvdy1tb2RhbC1kaWFs b2ctZHVyaW5nLWV4ZWNDb21tYW5kLmh0bWwgWyBTa2lwIF0KK1sgRGVidWcgXSBlZGl0aW5nL2V4 ZWNDb21tYW5kL3Nob3ctbW9kYWwtZGlhbG9nLWR1cmluZy1leGVjQ29tbWFuZC5odG1sIFsgU2tp cCBdCiAKIGZhc3Qvc2hhZG93LWRvbS90b3VjaC1ldmVudC1vbi10ZXh0LWFzc2lnbmVkLXRvLXNs b3QuaHRtbCBbIFNraXAgXQogCg==