173185 2017-06-09 15:01:31 -0700 Web Inspector: REGRESSION(r217749): Event listeners are removed even if they haven't been added 2017-06-10 00:13:27 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=172381 P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes joepeck oldest_to_newest 1317649 0 hi 2017-06-09 15:01:31 -0700 The event listeners are only applied in the ResourceDetailsSidebarPanel after it has initialLayout(). If the panel is created without ever being shown, each time it is hidden() it will attempt to remove the event listeners. Since it has not been initialLayout(), these event listeners would not have already been added. 1317653 1 312496 hi 2017-06-09 15:04:59 -0700 Created attachment 312496 Patch 1317752 2 joepeck 2017-06-09 18:28:47 -0700 Does this trigger benign assertions or something? 1317753 3 312496 joepeck 2017-06-09 18:29:25 -0700 Comment on attachment 312496 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312496&action=review > Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:94 > + this._needsToRemoveResourceEventListeners = false; Can you also put something up in the constructor that initializes this member variable. 1317754 4 312496 joepeck 2017-06-09 18:30:11 -0700 Comment on attachment 312496 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312496&action=review >> Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:94 >> + this._needsToRemoveResourceEventListeners = false; > > Can you also put something up in the constructor that initializes this member variable. Oh this is in the constructor (implicitly). 1317837 5 312558 hi 2017-06-09 21:33:27 -0700 Created attachment 312558 Patch (In reply to Joseph Pecoraro from comment #2) > Does this trigger benign assertions or something? Yes, it causes assertions in `removeEventListener` ``` console.assert(didDelete, "removeEventListener cannot remove " + eventType.toString() + " because it doesn't exist."); ``` 1317853 6 commit-queue 2017-06-09 21:56:59 -0700 The commit-queue encountered the following flaky tests while processing attachment 312558: transforms/hittest-translated-content-off-to-infinity-and-back.html bug 173222 (author: zalan@apple.com) imported/w3c/web-platform-tests/html/browsers/windows/browsing-context.html bug 172934 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1317875 7 312558 commit-queue 2017-06-10 00:13:25 -0700 Comment on attachment 312558 Patch Clearing flags on attachment: 312558 Committed r218049: <http://trac.webkit.org/changeset/218049> 1317876 8 commit-queue 2017-06-10 00:13:27 -0700 All reviewed patches have been landed. Closing bug. 312496 2017-06-09 15:04:59 -0700 2017-06-09 21:33:27 -0700 Patch bug-173185-20170609150459.patch text/plain 3279 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDczNmQxMTFmODYyYTA2YjlkYmRkOTliNjQ1MmIx MTllZGJmNzJmYzIuLjE2ZGVkNWVhZTkxOTBjNmIyOGM1OTFlNGNlMjIzMDFmZWExMDg2YTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA2LTA5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyMTc3NDkpOiBFdmVudCBsaXN0ZW5lcnMgYXJlIHJlbW92ZWQgZXZlbiBpZiB0 aGV5IGhhdmVuJ3QgYmVlbiBhZGRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTczMTg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGVi YXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZURldGFpbHNTaWRlYmFy UGFuZWwucHJvdG90eXBlLnNldCByZXNvdXJjZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVz b3VyY2VEZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fYXBwbHlSZXNvdXJjZUV2ZW50TGlz dGVuZXJzKToKKyAgICAgICAgTWFpbnRhaW4gYSBtZW1iZXIgdmFyaWFibGUgZmxhZyBzdWNoIHRo YXQgZXZlbnQgbGlzdGVuZXJzIGFyZSBvbmx5IHJlbW92ZWQgaWYgaXQgaXMgdHJ1ZS4KKyAgICAg ICAgSXQgaXMgb25seSBzZXQgdG8gdHJ1ZSBvbmNlIHRoZSBldmVudCBsaXN0ZW5lcnMgYXJlIGFk ZGVkLgorCiAyMDE3LTA2LTA3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgQ29udGV4dE1lbnUgaXRlbSB0byBsb2cgV2ViU29j a2V0IG9iamVjdCB0byBjb25zb2xlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZURldGFpbHNTaWRlYmFyUGFuZWwuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZURldGFpbHNTaWRl YmFyUGFuZWwuanMKaW5kZXggYWYwMzRjZTZmMjIzYzJiZDU3Yzg4MTlkN2VlOTkzYWM4NDljMWEw YS4uZTExM2NjZjFlN2Y2NTk3NGQ0MjQyZGMwM2ZmZjNlNGRjMTc1NjcxOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VEZXRhaWxz U2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbC5qcwpAQCAtNzksNyArNzksNyBAQCBX ZWJJbnNwZWN0b3IuUmVzb3VyY2VEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgUmVzb3VyY2VE ZXRhaWxzU2lkZWJhclBhbmVsIGV4dAogICAgICAgICBpZiAocmVzb3VyY2UgPT09IHRoaXMuX3Jl c291cmNlKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGlmICh0aGlzLl9yZXNvdXJj ZSkgeworICAgICAgICBpZiAodGhpcy5fcmVzb3VyY2UgJiYgdGhpcy5fbmVlZHNUb1JlbW92ZVJl c291cmNlRXZlbnRMaXN0ZW5lcnMpIHsKICAgICAgICAgICAgIHRoaXMuX3Jlc291cmNlLnJlbW92 ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlJlc291cmNlLkV2ZW50LlVSTERpZENoYW5nZSwg dGhpcy5fcmVmcmVzaFVSTCwgdGhpcyk7CiAgICAgICAgICAgICB0aGlzLl9yZXNvdXJjZS5yZW1v dmVFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5SZXNvdXJjZS5FdmVudC5NSU1FVHlwZURpZENo YW5nZSwgdGhpcy5fcmVmcmVzaE1JTUVUeXBlLCB0aGlzKTsKICAgICAgICAgICAgIHRoaXMuX3Jl c291cmNlLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlJlc291cmNlLkV2ZW50LlR5 cGVEaWRDaGFuZ2UsIHRoaXMuX3JlZnJlc2hSZXNvdXJjZVR5cGUsIHRoaXMpOwpAQCAtOTAsNiAr OTAsOCBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3Mg UmVzb3VyY2VEZXRhaWxzU2lkZWJhclBhbmVsIGV4dAogICAgICAgICAgICAgdGhpcy5fcmVzb3Vy Y2UucmVtb3ZlRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuUmVzb3VyY2UuRXZlbnQuU2l6ZURp ZENoYW5nZSwgdGhpcy5fcmVmcmVzaERlY29kZWRTaXplLCB0aGlzKTsKICAgICAgICAgICAgIHRo aXMuX3Jlc291cmNlLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlJlc291cmNlLkV2 ZW50LlRyYW5zZmVyU2l6ZURpZENoYW5nZSwgdGhpcy5fcmVmcmVzaFRyYW5zZmVyU2l6ZSwgdGhp cyk7CiAgICAgICAgICAgICB0aGlzLl9yZXNvdXJjZS5yZW1vdmVFdmVudExpc3RlbmVyKFdlYklu c3BlY3Rvci5SZXNvdXJjZS5FdmVudC5Jbml0aWF0ZWRSZXNvdXJjZXNEaWRDaGFuZ2UsIHRoaXMu X3JlZnJlc2hSZWxhdGVkUmVzb3VyY2VzU2VjdGlvbiwgdGhpcyk7CisKKyAgICAgICAgICAgIHRo aXMuX25lZWRzVG9SZW1vdmVSZXNvdXJjZUV2ZW50TGlzdGVuZXJzID0gZmFsc2U7CiAgICAgICAg IH0KIAogICAgICAgICB0aGlzLl9yZXNvdXJjZSA9IHJlc291cmNlOwpAQCAtNjIwLDUgKzYyMiw3 IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZURldGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBSZXNv dXJjZURldGFpbHNTaWRlYmFyUGFuZWwgZXh0CiAgICAgICAgIHRoaXMuX3Jlc291cmNlLmFkZEV2 ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlJlc291cmNlLkV2ZW50LlNpemVEaWRDaGFuZ2UsIHRo aXMuX3JlZnJlc2hEZWNvZGVkU2l6ZSwgdGhpcyk7CiAgICAgICAgIHRoaXMuX3Jlc291cmNlLmFk ZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlJlc291cmNlLkV2ZW50LlRyYW5zZmVyU2l6ZURp ZENoYW5nZSwgdGhpcy5fcmVmcmVzaFRyYW5zZmVyU2l6ZSwgdGhpcyk7CiAgICAgICAgIHRoaXMu X3Jlc291cmNlLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlJlc291cmNlLkV2ZW50Lklu aXRpYXRlZFJlc291cmNlc0RpZENoYW5nZSwgdGhpcy5fcmVmcmVzaFJlbGF0ZWRSZXNvdXJjZXNT ZWN0aW9uLCB0aGlzKTsKKworICAgICAgICB0aGlzLl9uZWVkc1RvUmVtb3ZlUmVzb3VyY2VFdmVu dExpc3RlbmVycyA9IHRydWU7CiAgICAgfQogfTsK 312558 2017-06-09 21:33:27 -0700 2017-06-10 00:13:25 -0700 Patch 173185.diff text/plain 3542 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDczNmQxMTFmODYyLi45ZGEwNDY4MTQ4OSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMDYtMDkgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJF R1JFU1NJT04ocjIxNzc0OSk6IEV2ZW50IGxpc3RlbmVycyBhcmUgcmVtb3ZlZCBldmVuIGlmIHRo ZXkgaGF2ZW4ndCBiZWVuIGFkZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzMxODUKKworICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jh cm8uCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGVi YXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZURldGFpbHNTaWRlYmFy UGFuZWwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlRGV0YWlsc1NpZGViYXJQYW5l bC5wcm90b3R5cGUuc2V0IHJlc291cmNlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJj ZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9hcHBseVJlc291cmNlRXZlbnRMaXN0ZW5l cnMpOgorICAgICAgICBNYWludGFpbiBhIG1lbWJlciB2YXJpYWJsZSBmbGFnIHN1Y2ggdGhhdCBl dmVudCBsaXN0ZW5lcnMgYXJlIG9ubHkgcmVtb3ZlZCBpZiBpdCBpcyB0cnVlLgorICAgICAgICBJ dCBpcyBvbmx5IHNldCB0byB0cnVlIG9uY2UgdGhlIGV2ZW50IGxpc3RlbmVycyBhcmUgYWRkZWQu CisKIDIwMTctMDYtMDcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBDb250ZXh0TWVudSBpdGVtIHRvIGxvZyBXZWJTb2NrZXQg b2JqZWN0IHRvIGNvbnNvbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGViYXJQ YW5lbC5qcwppbmRleCBhZjAzNGNlNmYyMi4uOWQyNWU2MmU1ZDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGVi YXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9SZXNvdXJjZURldGFpbHNTaWRlYmFyUGFuZWwuanMKQEAgLTMyLDYgKzMyLDggQEAgV2ViSW5z cGVjdG9yLlJlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIFJlc291cmNlRGV0YWls c1NpZGViYXJQYW5lbCBleHQKICAgICAgICAgdGhpcy5lbGVtZW50LmNsYXNzTGlzdC5hZGQoInJl c291cmNlIik7CiAKICAgICAgICAgdGhpcy5fcmVzb3VyY2UgPSBudWxsOworICAgICAgICB0aGlz Ll9uZWVkc1RvQXBwbHlSZXNvdXJjZUV2ZW50TGlzdGVuZXJzID0gZmFsc2U7CisgICAgICAgIHRo aXMuX25lZWRzVG9SZW1vdmVSZXNvdXJjZUV2ZW50TGlzdGVuZXJzID0gZmFsc2U7CiAgICAgfQog CiAgICAgLy8gUHVibGljCkBAIC03OSw3ICs4MSw3IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZURl dGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBSZXNvdXJjZURldGFpbHNTaWRlYmFyUGFuZWwgZXh0 CiAgICAgICAgIGlmIChyZXNvdXJjZSA9PT0gdGhpcy5fcmVzb3VyY2UpCiAgICAgICAgICAgICBy ZXR1cm47CiAKLSAgICAgICAgaWYgKHRoaXMuX3Jlc291cmNlKSB7CisgICAgICAgIGlmICh0aGlz Ll9yZXNvdXJjZSAmJiB0aGlzLl9uZWVkc1RvUmVtb3ZlUmVzb3VyY2VFdmVudExpc3RlbmVycykg ewogICAgICAgICAgICAgdGhpcy5fcmVzb3VyY2UucmVtb3ZlRXZlbnRMaXN0ZW5lcihXZWJJbnNw ZWN0b3IuUmVzb3VyY2UuRXZlbnQuVVJMRGlkQ2hhbmdlLCB0aGlzLl9yZWZyZXNoVVJMLCB0aGlz KTsKICAgICAgICAgICAgIHRoaXMuX3Jlc291cmNlLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5z cGVjdG9yLlJlc291cmNlLkV2ZW50Lk1JTUVUeXBlRGlkQ2hhbmdlLCB0aGlzLl9yZWZyZXNoTUlN RVR5cGUsIHRoaXMpOwogICAgICAgICAgICAgdGhpcy5fcmVzb3VyY2UucmVtb3ZlRXZlbnRMaXN0 ZW5lcihXZWJJbnNwZWN0b3IuUmVzb3VyY2UuRXZlbnQuVHlwZURpZENoYW5nZSwgdGhpcy5fcmVm cmVzaFJlc291cmNlVHlwZSwgdGhpcyk7CkBAIC05MCw2ICs5Miw4IEBAIFdlYkluc3BlY3Rvci5S ZXNvdXJjZURldGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBSZXNvdXJjZURldGFpbHNTaWRlYmFy UGFuZWwgZXh0CiAgICAgICAgICAgICB0aGlzLl9yZXNvdXJjZS5yZW1vdmVFdmVudExpc3RlbmVy KFdlYkluc3BlY3Rvci5SZXNvdXJjZS5FdmVudC5TaXplRGlkQ2hhbmdlLCB0aGlzLl9yZWZyZXNo RGVjb2RlZFNpemUsIHRoaXMpOwogICAgICAgICAgICAgdGhpcy5fcmVzb3VyY2UucmVtb3ZlRXZl bnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuUmVzb3VyY2UuRXZlbnQuVHJhbnNmZXJTaXplRGlkQ2hh bmdlLCB0aGlzLl9yZWZyZXNoVHJhbnNmZXJTaXplLCB0aGlzKTsKICAgICAgICAgICAgIHRoaXMu X3Jlc291cmNlLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlJlc291cmNlLkV2ZW50 LkluaXRpYXRlZFJlc291cmNlc0RpZENoYW5nZSwgdGhpcy5fcmVmcmVzaFJlbGF0ZWRSZXNvdXJj ZXNTZWN0aW9uLCB0aGlzKTsKKworICAgICAgICAgICAgdGhpcy5fbmVlZHNUb1JlbW92ZVJlc291 cmNlRXZlbnRMaXN0ZW5lcnMgPSBmYWxzZTsKICAgICAgICAgfQogCiAgICAgICAgIHRoaXMuX3Jl c291cmNlID0gcmVzb3VyY2U7CkBAIC02MjAsNSArNjI0LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291 cmNlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIFJlc291cmNlRGV0YWlsc1NpZGViYXJQYW5l bCBleHQKICAgICAgICAgdGhpcy5fcmVzb3VyY2UuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0 b3IuUmVzb3VyY2UuRXZlbnQuU2l6ZURpZENoYW5nZSwgdGhpcy5fcmVmcmVzaERlY29kZWRTaXpl LCB0aGlzKTsKICAgICAgICAgdGhpcy5fcmVzb3VyY2UuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNw ZWN0b3IuUmVzb3VyY2UuRXZlbnQuVHJhbnNmZXJTaXplRGlkQ2hhbmdlLCB0aGlzLl9yZWZyZXNo VHJhbnNmZXJTaXplLCB0aGlzKTsKICAgICAgICAgdGhpcy5fcmVzb3VyY2UuYWRkRXZlbnRMaXN0 ZW5lcihXZWJJbnNwZWN0b3IuUmVzb3VyY2UuRXZlbnQuSW5pdGlhdGVkUmVzb3VyY2VzRGlkQ2hh bmdlLCB0aGlzLl9yZWZyZXNoUmVsYXRlZFJlc291cmNlc1NlY3Rpb24sIHRoaXMpOworCisgICAg ICAgIHRoaXMuX25lZWRzVG9SZW1vdmVSZXNvdXJjZUV2ZW50TGlzdGVuZXJzID0gdHJ1ZTsKICAg ICB9CiB9Owo=