172940 2017-06-05 16:00:40 -0700 webkitpy: Return correct process names from SimulatorProcess 2017-06-06 14:03:00 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=171976 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain buildbot commit-queue dbates glenn lforschler webkit-bug-importer oldest_to_newest 1315805 0 jbedard 2017-06-05 16:00:40 -0700 Currently, SimulatorProcess will return a process name of '<bundle>.app'. This is incorrect, it should return the name of the executable inside the bundle. Additionally, server_process provides both a name() function and a process_name(). Clarify which is meant and always use process_name(). 1315812 1 312037 jbedard 2017-06-05 16:13:24 -0700 Created attachment 312037 Patch 1315813 2 webkit-bug-importer 2017-06-05 16:13:49 -0700 <rdar://problem/32575766> 1316224 3 312037 commit-queue 2017-06-06 14:02:59 -0700 Comment on attachment 312037 Patch Clearing flags on attachment: 312037 Committed r217856: <http://trac.webkit.org/changeset/217856> 1316225 4 commit-queue 2017-06-06 14:03:00 -0700 All reviewed patches have been landed. Closing bug. 312037 2017-06-05 16:13:24 -0700 2017-06-06 14:02:59 -0700 Patch bug-172940-20170605161324.patch text/plain 7020 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNzgwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI5IEBACisyMDE3LTA2LTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUmV0dXJuIGNvcnJlY3QgcHJvY2VzcyBuYW1lcyBmcm9t IFNpbXVsYXRvclByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3Mjk0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2Rhcndpbi5weToKKyAgICAgICAgKERh cndpblBvcnQucGxpc3RfZGF0YV9mcm9tX2J1bmRsZSk6IFNoYXJlIHBsaXN0IGFjY2VzcyBjb2Rl IGZvciBhY2Nlc3NpbmcgZGlmZmVyZW50IHBsaXN0IGVudHJpZXMuCisgICAgICAgIChEYXJ3aW5Q b3J0LmFwcF9pZGVudGlmaWVyX2Zyb21fYnVuZGxlKTogVXNlIHBsaXN0X2RhdGFfZnJvbV9idW5k bGUuCisgICAgICAgIChEYXJ3aW5Qb3J0LmFwcF9leGVjdXRhYmxlX2Zyb21fYnVuZGxlKTogQWNj ZXNzIG5hbWUgb2YgYXBwIGV4ZWN1dGFibGUgZnJvbSBwcm92aWRlZCBhcHAgYnVuZGxlLgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHk6CisgICAgICAgIChEcml2ZXIu aGFzX2NyYXNoZWQpOiBVc2UgX3NlcnZlcl9wcm9jZXNzLnByb2Nlc3NfbmFtZSgpIGluc3RlYWQg b2YgX3NlcnZlcl9wcm9jZXNzLm5hbWUoKSBzaW5jZQorICAgICAgICBfc2VydmVyX3Byb2Nlc3Mu bmFtZSgpIHdpbGwgbm90IHJldHVybiB0aGUgY29ycmVjdCBwcm9jZXNzIG5hbWUgZm9yIGlPUy4K KyAgICAgICAgKERyaXZlci5fY2hlY2tfZm9yX2RyaXZlcl9jcmFzaF9vcl91bnJlc3BvbnNpdmVu ZXNzKTogRGl0dG8uCisgICAgICAgIChEcml2ZXIuX3JlYWRfYmxvY2spOiBEaXR0by4KKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyX3VuaXR0ZXN0LnB5OgorICAgICAgICAo RHJpdmVyVGVzdC50ZXN0X2NoZWNrX2Zvcl9kcml2ZXJfY3Jhc2guRmFrZVNlcnZlclByb2Nlc3Mu cHJvY2Vzc19uYW1lKTogVXBkYXRlIHNpbmNlIERyaXZlciB1c2VzCisgICAgICAgIHByb2Nlc3Nf bmFtZSgpIGluc3RlYWQgb2YgbmFtZSgpLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9y dC9zZXJ2ZXJfcHJvY2Vzcy5weToKKyAgICAgICAgKFNlcnZlclByb2Nlc3MuX3N0YXJ0KTogVXNl IHByb2Nlc3NfbmFtZSgpIGluc3RlYWQgb2YgbmFtZSgpLgorICAgICAgICAoU2VydmVyUHJvY2Vz cy5zdG9wKTogRGl0dG8uCisgICAgICAgIChTZXJ2ZXJQcm9jZXNzLm5hbWUpOiBEZWxldGVkLgor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJvY2Vzcy5weToKKyAg ICAgICAgKFNpbXVsYXRvclByb2Nlc3MucHJvY2Vzc19uYW1lKTogQ2hlY2sgdGhlIHByb3ZpZGVk IGJ1bmRsZSBmb3IgdGhlIHByb2Nlc3MgbmFtZS4KKwogMjAxNy0wNi0wNSAgSm9uYXRoYW4gQmVk YXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgd2Via2l0cHk6IEFkZCBpT1MgdG8g cGxhdGZvcm0KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kYXJ3aW4ucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Rhcndpbi5weQkocmV2aXNp b24gMjE3Nzg5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Rhcndpbi5weQkod29y a2luZyBjb3B5KQpAQCAtMjM4LDEwICsyMzgsMTYgQEAgY2xhc3MgRGFyd2luUG9ydChBcHBsZVBv cnQpOgogICAgICAgICAgICAgcmV0dXJuIGZhbGxiYWNrCiAKICAgICBAbWVtb2l6ZWQKLSAgICBk ZWYgYXBwX2lkZW50aWZpZXJfZnJvbV9idW5kbGUoc2VsZiwgYXBwX2J1bmRsZSk6CisgICAgZGVm IF9wbGlzdF9kYXRhX2Zyb21fYnVuZGxlKHNlbGYsIGFwcF9idW5kbGUsIGVudHJ5KToKICAgICAg ICAgcGxpc3RfcGF0aCA9IHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihhcHBfYnVuZGxlLCAnSW5mby5w bGlzdCcpCiAgICAgICAgIGlmIG5vdCBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhwbGlzdF9wYXRo KToKICAgICAgICAgICAgIHBsaXN0X3BhdGggPSBzZWxmLl9maWxlc3lzdGVtLmpvaW4oYXBwX2J1 bmRsZSwgJ0NvbnRlbnRzJywgJ0luZm8ucGxpc3QnKQogICAgICAgICBpZiBub3Qgc2VsZi5fZmls ZXN5c3RlbS5leGlzdHMocGxpc3RfcGF0aCk6CiAgICAgICAgICAgICByZXR1cm4gTm9uZQotICAg ICAgICByZXR1cm4gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsnL3Vzci9saWJleGVjL1Bs aXN0QnVkZHknLCAnLWMnLCAnUHJpbnQgQ0ZCdW5kbGVJZGVudGlmaWVyJywgcGxpc3RfcGF0aF0p LnJzdHJpcCgpCisgICAgICAgIHJldHVybiBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQoWycv dXNyL2xpYmV4ZWMvUGxpc3RCdWRkeScsICctYycsICdQcmludCB7fScuZm9ybWF0KGVudHJ5KSwg cGxpc3RfcGF0aF0pLnJzdHJpcCgpCisKKyAgICBkZWYgYXBwX2lkZW50aWZpZXJfZnJvbV9idW5k bGUoc2VsZiwgYXBwX2J1bmRsZSk6CisgICAgICAgIHJldHVybiBzZWxmLl9wbGlzdF9kYXRhX2Zy b21fYnVuZGxlKGFwcF9idW5kbGUsICdDRkJ1bmRsZUlkZW50aWZpZXInKQorCisgICAgZGVmIGFw cF9leGVjdXRhYmxlX2Zyb21fYnVuZGxlKHNlbGYsIGFwcF9idW5kbGUpOgorICAgICAgICByZXR1 cm4gc2VsZi5fcGxpc3RfZGF0YV9mcm9tX2J1bmRsZShhcHBfYnVuZGxlLCAnQ0ZCdW5kbGVFeGVj dXRhYmxlJykKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkocmV2aXNp b24gMjE3Nzg5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkod29y a2luZyBjb3B5KQpAQCAtMzEyLDcgKzMxMiw3IEBAIGNsYXNzIERyaXZlcihvYmplY3QpOgogICAg ICAgICBpZiBzZWxmLl9jcmFzaGVkX3Byb2Nlc3NfbmFtZToKICAgICAgICAgICAgIHJldHVybiBU cnVlCiAgICAgICAgIGlmIHNlbGYuX3NlcnZlcl9wcm9jZXNzLmhhc19jcmFzaGVkKCk6Ci0gICAg ICAgICAgICBzZWxmLl9jcmFzaGVkX3Byb2Nlc3NfbmFtZSA9IHNlbGYuX3NlcnZlcl9wcm9jZXNz Lm5hbWUoKQorICAgICAgICAgICAgc2VsZi5fY3Jhc2hlZF9wcm9jZXNzX25hbWUgPSBzZWxmLl9z ZXJ2ZXJfcHJvY2Vzcy5wcm9jZXNzX25hbWUoKQogICAgICAgICAgICAgc2VsZi5fY3Jhc2hlZF9w aWQgPSBzZWxmLl9zZXJ2ZXJfcHJvY2Vzcy5waWQoKQogICAgICAgICAgICAgcmV0dXJuIFRydWUK ICAgICAgICAgcmV0dXJuIEZhbHNlCkBAIC00NTMsNyArNDUzLDcgQEAgY2xhc3MgRHJpdmVyKG9i amVjdCk6CiAgICAgZGVmIF9jaGVja19mb3JfZHJpdmVyX2NyYXNoX29yX3VucmVzcG9uc2l2ZW5l c3Moc2VsZiwgZXJyb3JfbGluZSk6CiAgICAgICAgIGNyYXNoZWRfY2hlY2sgPSBlcnJvcl9saW5l LnJzdHJpcCgnXHJcbicpCiAgICAgICAgIGlmIGNyYXNoZWRfY2hlY2sgPT0gIiNDUkFTSEVEIjoK LSAgICAgICAgICAgIHNlbGYuX2NyYXNoZWRfcHJvY2Vzc19uYW1lID0gc2VsZi5fc2VydmVyX3By b2Nlc3MubmFtZSgpCisgICAgICAgICAgICBzZWxmLl9jcmFzaGVkX3Byb2Nlc3NfbmFtZSA9IHNl bGYuX3NlcnZlcl9wcm9jZXNzLnByb2Nlc3NfbmFtZSgpCiAgICAgICAgICAgICBzZWxmLl9jcmFz aGVkX3BpZCA9IHNlbGYuX3NlcnZlcl9wcm9jZXNzLnBpZCgpCiAgICAgICAgICAgICByZXR1cm4g VHJ1ZQogICAgICAgICBlbGlmIGVycm9yX2xpbmUuc3RhcnRzd2l0aCgiI0NSQVNIRUQgLSAiKToK QEAgLTYwNyw3ICs2MDcsNyBAQCBjbGFzcyBEcml2ZXIob2JqZWN0KToKICAgICAgICAgICAgICAg ICAgICAgc2VsZi5lcnJvcl9mcm9tX3Rlc3QgKz0gZXJyX2xpbmUKIAogICAgICAgICBpZiBhc2Fu X3Zpb2xhdGlvbl9kZXRlY3RlZCBhbmQgbm90IHNlbGYuX2NyYXNoZWRfcHJvY2Vzc19uYW1lOgot ICAgICAgICAgICAgc2VsZi5fY3Jhc2hlZF9wcm9jZXNzX25hbWUgPSBzZWxmLl9zZXJ2ZXJfcHJv Y2Vzcy5uYW1lKCkKKyAgICAgICAgICAgIHNlbGYuX2NyYXNoZWRfcHJvY2Vzc19uYW1lID0gc2Vs Zi5fc2VydmVyX3Byb2Nlc3MucHJvY2Vzc19uYW1lKCkKICAgICAgICAgICAgIHNlbGYuX2NyYXNo ZWRfcGlkID0gc2VsZi5fc2VydmVyX3Byb2Nlc3MucGlkKCkKIAogICAgICAgICBibG9jay5kZWNv ZGVfY29udGVudCgpCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyX3Vu aXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2 ZXJfdW5pdHRlc3QucHkJKHJldmlzaW9uIDIxNzc4OSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC9kcml2ZXJfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTIwMCw3ICsyMDAs NyBAQCBjbGFzcyBEcml2ZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgIGRl ZiBwaWQoc2VsZik6CiAgICAgICAgICAgICAgICAgcmV0dXJuIDEyMzQKIAotICAgICAgICAgICAg ZGVmIG5hbWUoc2VsZik6CisgICAgICAgICAgICBkZWYgcHJvY2Vzc19uYW1lKHNlbGYpOgogICAg ICAgICAgICAgICAgIHJldHVybiAnRmFrZVNlcnZlclByb2Nlc3MnCiAKICAgICAgICAgICAgIGRl ZiBoYXNfY3Jhc2hlZChzZWxmKToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9z ZXJ2ZXJfcHJvY2Vzcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvc2VydmVyX3Byb2Nlc3MucHkJKHJldmlzaW9uIDIxNzc4OSkKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQkod29ya2luZyBjb3B5KQpAQCAtNzcsOSAr NzcsNiBAQCBjbGFzcyBTZXJ2ZXJQcm9jZXNzKG9iamVjdCk6CiAgICAgICAgICMgRklYTUU6IHRo ZXJlIHNob3VsZCBiZSBhIHdheSB0byBnZXQgd2luMzIgdnMuIGN5Z3dpbiBmcm9tIHBsYXRmb3Jt aW5mby4KICAgICAgICAgc2VsZi5fdXNlX3dpbjMyX2FwaXMgPSBzeXMucGxhdGZvcm0uc3RhcnRz d2l0aCgnd2luJykKIAotICAgIGRlZiBuYW1lKHNlbGYpOgotICAgICAgICByZXR1cm4gc2VsZi5f bmFtZQotCiAgICAgZGVmIHBpZChzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYuX3BpZAogCkBA IC0xMjMsNyArMTIwLDcgQEAgY2xhc3MgU2VydmVyUHJvY2VzcyhvYmplY3QpOgogICAgICAgICAg ICAgZW52PXNlbGYuX2VudiwKICAgICAgICAgICAgIHVuaXZlcnNhbF9uZXdsaW5lcz1zZWxmLl91 bml2ZXJzYWxfbmV3bGluZXMpCiAgICAgICAgIHNlbGYuX3BpZCA9IHNlbGYuX3Byb2MucGlkCi0g ICAgICAgIHNlbGYuX3BvcnQuZmluZF9zeXN0ZW1fcGlkKHNlbGYubmFtZSgpLCBzZWxmLl9waWQp CisgICAgICAgIHNlbGYuX3BvcnQuZmluZF9zeXN0ZW1fcGlkKHNlbGYucHJvY2Vzc19uYW1lKCks IHNlbGYuX3BpZCkKICAgICAgICAgaWYgbm90IHNlbGYuX3VzZV93aW4zMl9hcGlzOgogICAgICAg ICAgICAgc2VsZi5fc2V0X2ZpbGVfbm9uYmxvY2tpbmcoc2VsZi5fcHJvYy5zdGRvdXQpCiAgICAg ICAgICAgICBzZWxmLl9zZXRfZmlsZV9ub25ibG9ja2luZyhzZWxmLl9wcm9jLnN0ZGVycikKQEAg LTM0NSw3ICszNDIsNyBAQCBjbGFzcyBTZXJ2ZXJQcm9jZXNzKG9iamVjdCk6CiAKICAgICAgICAg IyBPbmx5IGJvdGhlciB0byBjaGVjayBmb3IgbGVha3Mgb3Igc3RkZXJyIGlmIHRoZSBwcm9jZXNz IGlzIHN0aWxsIHJ1bm5pbmcuCiAgICAgICAgIGlmIHNlbGYucG9sbCgpIGlzIE5vbmU6Ci0gICAg ICAgICAgICBzZWxmLl9wb3J0LmNoZWNrX2Zvcl9sZWFrcyhzZWxmLm5hbWUoKSwgc2VsZi5waWQo KSkKKyAgICAgICAgICAgIHNlbGYuX3BvcnQuY2hlY2tfZm9yX2xlYWtzKHNlbGYucHJvY2Vzc19u YW1lKCksIHNlbGYucGlkKCkpCiAKICAgICAgICAgbm93ID0gdGltZS50aW1lKCkKICAgICAgICAg aWYgc2VsZi5fcHJvYy5zdGRpbjoKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9z aW11bGF0b3JfcHJvY2Vzcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHkJKHJldmlzaW9uIDIxNzc4OSkKKysrIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJvY2Vzcy5weQkod29ya2luZyBjb3B5KQpA QCAtNzYsNiArNzYsOSBAQCBjbGFzcyBTaW11bGF0b3JQcm9jZXNzKFNlcnZlclByb2Nlc3MpOgog CiAgICAgICAgIHNlbGYuX2J1bmRsZV9pZCA9IHBvcnRfb2JqLmFwcF9pZGVudGlmaWVyX2Zyb21f YnVuZGxlKGNtZFswXSkKIAorICAgIGRlZiBwcm9jZXNzX25hbWUoc2VsZik6CisgICAgICAgIHJl dHVybiBzZWxmLl9wb3J0LmFwcF9leGVjdXRhYmxlX2Zyb21fYnVuZGxlKHNlbGYuX2NtZFswXSkK KwogICAgIEBzdGF0aWNtZXRob2QKICAgICBkZWYgX2FjY2VwdF9jb25uZWN0aW9uX2NyZWF0ZV9m aWxlKHNlcnZlciwgdHlwZSk6CiAgICAgICAgIGNvbm5lY3Rpb24sIGFkZHJlc3MgPSBzZXJ2ZXIu YWNjZXB0KCkK