172348 2017-05-19 00:39:43 -0700 Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed 2017-05-19 02:19:07 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 172339 1 rniwa rniwa addyo cdumez commit-queue fpizlo ggaren koivisto lforschler saam oldest_to_newest 1310505 0 rniwa 2017-05-19 00:39:43 -0700 The problem is that the memory storage class uses ms precision wall clock as a storage ID. Because we're adding 50 items at all once, some items would inevitably end up having the same ID. This results in multiple todo items sharing a single ID and cause havoc. Use a monotonically increasing number as an ID instead. 1310506 1 310629 rniwa 2017-05-19 00:42:48 -0700 Created attachment 310629 Fixes the bug 1310518 2 310629 koivisto 2017-05-19 01:51:12 -0700 Comment on attachment 310629 Fixes the bug r=me 1310529 3 310629 commit-queue 2017-05-19 02:19:05 -0700 Comment on attachment 310629 Fixes the bug Clearing flags on attachment: 310629 Committed r217107: <http://trac.webkit.org/changeset/217107> 1310530 4 commit-queue 2017-05-19 02:19:07 -0700 All reviewed patches have been landed. Closing bug. 310629 2017-05-19 00:42:48 -0700 2017-05-19 02:19:05 -0700 Fixes the bug bug-172348-20170519004251.patch text/plain 1881 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTcxMDIpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA1LTE5ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogVmFuaWxsYSBKUyB0ZXN0IGRvZXNuJ3QgbWFyayBhbGwgdG9kbyBpdGVtcyBhcyBjb21wbGV0 ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjM0 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBi dWcgd2FzIGNhdXNlZCBieSB0aGUgaW4tbWVtb3J5IHN0b3JlIGNsYXNzIHVzaW5nIHRoZSBtaWxp c2Vjb25kIHByZWNpc2lvbiB0aW1lc3RhbXAgYXMgYW4gSUQuCisgICAgICAgIEJlY2F1c2Ugd2Ug aW5zZXJ0cyA1MCBpdGVtcyBhbGwgYXQgb25jZSwgdGhpcyBjYW4gcmVzdWx0IGluIG11bHRpcGxl IGRhdGEgaXRlbXMgc2hhcmluZyBhIHNpbmdsZSBJRC4KKworICAgICAgICBGaXhlZCB0aGUgYnVn IGJ5IHVzaW5nIGEgbW9ub25vdGljYWxseSBpbmNyZWFzaW5nIElEIGluc3RlYWQuCisKKyAgICAg ICAgKiBTcGVlZG9tZXRlci9yZXNvdXJjZXMvdG9kb212Yy92YW5pbGxhLWV4YW1wbGVzL3Zhbmls bGFqcy9qcy9zdG9yZS5qczoKKyAgICAgICAgKFN0b3JlLnByb3RvdHlwZS5zYXZlKToKKwogMjAx Ny0wNS0xOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdS RVNTSU9OIChyMjE2Njk0IC0gMjE2NzEyKTogUGVyZm9ybWFuY2UgdGVzdCBTcGVlZG9tZXRlci9G dWxsLmh0bWwgaXMgZmFpbGluZwpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci9y ZXNvdXJjZXMvdG9kb212Yy92YW5pbGxhLWV4YW1wbGVzL3ZhbmlsbGFqcy9qcy9zdG9yZS5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy90b2Rv bXZjL3ZhbmlsbGEtZXhhbXBsZXMvdmFuaWxsYWpzL2pzL3N0b3JlLmpzCShyZXZpc2lvbiAyMTcw ODcpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy90b2RvbXZjL3Zh bmlsbGEtZXhhbXBsZXMvdmFuaWxsYWpzL2pzL3N0b3JlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0z LDYgKzMsOCBAQAogICAgICd1c2Ugc3RyaWN0JzsKIAogICAgIHZhciBNZW1vcnlTdG9yYWdlID0g e307CisgICAgdmFyIGlkID0gMTsKKwogICAgIC8qKgogICAgICAqIENyZWF0ZXMgYSBuZXcgY2xp ZW50IHNpZGUgc3RvcmFnZSBvYmplY3QgYW5kIHdpbGwgY3JlYXRlIGFuIGVtcHR5CiAgICAgICog Y29sbGVjdGlvbiBpZiBubyBjb2xsZWN0aW9uIGFscmVhZHkgZXhpc3RzLgpAQCAtOTYsNyArOTgs NyBAQAogICAgICAgICAgICAgY2FsbGJhY2suY2FsbCh0aGlzLCB0b2Rvcyk7CiAgICAgICAgIH0g ZWxzZSB7CiAgICAgICAgICAgICAvLyBHZW5lcmF0ZSBhbiBJRAotICAgICAgICAgICAgdXBkYXRl RGF0YS5pZCA9IG5ldyBEYXRlKCkuZ2V0VGltZSgpOworICAgICAgICAgICAgdXBkYXRlRGF0YS5p ZCA9IGlkKys7CiAKICAgICAgICAgICAgIHRvZG9zLnB1c2godXBkYXRlRGF0YSk7CiAgICAgICAg ICAgICBNZW1vcnlTdG9yYWdlW3RoaXMuX2RiTmFtZV0gPSBKU09OLnN0cmluZ2lmeShkYXRhKTsK