<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>17217</bug_id>
          
          <creation_ts>2008-02-08 12:56:46 -0800</creation_ts>
          <short_desc>add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we&apos;re trying to keep small</short_desc>
          <delta_ts>2019-08-07 12:13:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>EasyFix</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>55088</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aroben</cc>
    
    <cc>cwhong893</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>hyatt</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>ysuzuki</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>69784</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-02-08 12:56:46 -0800</bug_when>
    <thetext>add COMPILE_ASSERT(sizeof(Foo) == 32) for classes we&apos;re trying to keep small

Now that we have these magical COMPILE_ASSERTs we should use them to make sure we don&apos;t accidentally inflate core classes with changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559211</commentid>
    <comment_count>1</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2019-08-07 11:28:27 -0700</bug_when>
    <thetext>Simon or Alan:  Is there anything actionable here?  Eric didn&apos;t list specific classes when he filed this, so I&apos;m not sure which ones he was thinking of.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559219</commentid>
    <comment_count>2</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2019-08-07 11:38:11 -0700</bug_when>
    <thetext>Nah.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559237</commentid>
    <comment_count>3</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-08-07 12:13:16 -0700</bug_when>
    <thetext>I don&apos;t think this bug itself is actionable.
But, note that we are already doing this thing for some of super important classes (in particular in JSC).
e.g. https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp#L47</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>