<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>172108</bug_id>
          
          <creation_ts>2017-05-15 01:46:14 -0700</creation_ts>
          <short_desc>[css-grid] Fix static position of positioned grid items</short_desc>
          <delta_ts>2017-05-16 00:50:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BlinkMergeCandidate</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>60731</blocked>
    
    <blocked>172117</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Manuel Rego Casasnovas">rego</reporter>
          <assigned_to name="Manuel Rego Casasnovas">rego</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jfernandez</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>svillar</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1308606</commentid>
    <comment_count>0</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2017-05-15 01:46:14 -0700</bug_when>
    <thetext>Text on the spec (https://drafts.csswg.org/css-grid/#static-position):
  &quot;The static position of an absolutely-positioned child
   of a grid container is determined as if it were the sole grid item
   in a grid area whose edges coincide with the padding edges
   of the grid container.&quot;

This has been already fixed in Blink:
https://codereview.chromium.org/2665983004</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308607</commentid>
    <comment_count>1</comment_count>
      <attachid>310118</attachid>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2017-05-15 01:52:08 -0700</bug_when>
    <thetext>Created attachment 310118
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308621</commentid>
    <comment_count>2</comment_count>
      <attachid>310118</attachid>
    <who name="Javier Fernandez">jfernandez</who>
    <bug_when>2017-05-15 02:36:14 -0700</bug_when>
    <thetext>Comment on attachment 310118
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310118&amp;action=review

&gt; Source/WebCore/rendering/RenderGrid.cpp:938
&gt; +    childLayer-&gt;setStaticBlockPosition(LayoutUnit(borderBefore()));

boderStart() and boderBefore() already return a LayoutUnit, why do we need to create a new one ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308626</commentid>
    <comment_count>3</comment_count>
      <attachid>310126</attachid>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2017-05-15 03:07:47 -0700</bug_when>
    <thetext>Created attachment 310126
Patch

New version applying suggested changes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308627</commentid>
    <comment_count>4</comment_count>
      <attachid>310118</attachid>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2017-05-15 03:08:16 -0700</bug_when>
    <thetext>Comment on attachment 310118
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310118&amp;action=review

&gt;&gt; Source/WebCore/rendering/RenderGrid.cpp:938
&gt;&gt; +    childLayer-&gt;setStaticBlockPosition(LayoutUnit(borderBefore()));
&gt; 
&gt; boderStart() and boderBefore() already return a LayoutUnit, why do we need to create a new one ?

Indeed we don&apos;t need that. Fixed in the new version of the patch. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1309050</commentid>
    <comment_count>5</comment_count>
      <attachid>310126</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-16 00:50:35 -0700</bug_when>
    <thetext>Comment on attachment 310126
Patch

Clearing flags on attachment: 310126

Committed r216916: &lt;http://trac.webkit.org/changeset/216916&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1309051</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-16 00:50:37 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>310118</attachid>
            <date>2017-05-15 01:52:08 -0700</date>
            <delta_ts>2017-05-15 03:07:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-172108-20170515105207.patch</filename>
            <type>text/plain</type>
            <size>5914</size>
            <attacher name="Manuel Rego Casasnovas">rego</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM4MDkxNDQwM2JlMTJm
ZTUwZDllOTM0NTBiZmZjN2JkMjJmNmY3MS4uNmRmOGNkNTcxNDlhY2FmNDZjZGM4YmE2OTc5OWMx
MmRlZDMyMTMxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA1LTE1ICBNYW51
ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp
ZF0gRml4IHN0YXRpYyBwb3NpdGlvbiBvZiBwb3NpdGlvbmVkIGdyaWQgaXRlbXMKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjEwOAorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMg
dXMgZm9sbG93IHRoZSB0ZXh0IG9uIHRoZSBzcGVjCisgICAgICAgIChodHRwczovL2RyYWZ0cy5j
c3N3Zy5vcmcvY3NzLWdyaWQvI3N0YXRpYy1wb3NpdGlvbik6CisgICAgICAgICJUaGUgc3RhdGlj
IHBvc2l0aW9uIG9mIGFuIGFic29sdXRlbHktcG9zaXRpb25lZCBjaGlsZAorICAgICAgICAgb2Yg
YSBncmlkIGNvbnRhaW5lciBpcyBkZXRlcm1pbmVkIGFzIGlmIGl0IHdlcmUgdGhlIHNvbGUgZ3Jp
ZCBpdGVtCisgICAgICAgICBpbiBhIGdyaWQgYXJlYSB3aG9zZSBlZGdlcyBjb2luY2lkZSB3aXRo
IHRoZSBwYWRkaW5nIGVkZ2VzCisgICAgICAgICBvZiB0aGUgZ3JpZCBjb250YWluZXIuIgorCisg
ICAgICAgIFRlc3Q6IGZhc3QvY3NzLWdyaWQtbGF5b3V0L2Fic29sdXRlLXBvc2l0aW9uaW5nLWdy
aWQtY29udGFpbmVyLXBhcmVudC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyR3Jp
ZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjpwcmVwYXJlQ2hpbGRGb3JQb3Np
dGlvbmVkTGF5b3V0KTogTW9kaWZpZWQgdG8gYXZvaWQKKyAgICAgICAgaW5jbHVkaW5nIHBhZGRp
bmcgdG8gbWF0Y2ggdGhlIHNwZWMgYmVoYXZpb3IuCisKIDIwMTctMDUtMTQgIFphbiBEb2JlcnNl
ayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4
IHdpdGggbmV3ZXIgUGVybCB2ZXJzaW9ucy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl
bmRlcmluZy9SZW5kZXJHcmlkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJH
cmlkLmNwcAppbmRleCBlMzVkYzQ2NTBmYjE1OGE1ZmVjZTAwMjdiMzgyNjk1OWFkZTRiMTAyLi5i
YmExNjIzOGQyNWEwN2VmOGFjNTIyMTE0YmI2Y2NiNTJmNmUzNDk3IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
cmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCkBAIC05MzQsOCArOTM0LDggQEAgdm9pZCBSZW5kZXJH
cmlkOjpwcmVwYXJlQ2hpbGRGb3JQb3NpdGlvbmVkTGF5b3V0KFJlbmRlckJveCYgY2hpbGQpCiAg
ICAgY2hpbGQuY29udGFpbmluZ0Jsb2NrKCktPmluc2VydFBvc2l0aW9uZWRPYmplY3QoY2hpbGQp
OwogCiAgICAgUmVuZGVyTGF5ZXIqIGNoaWxkTGF5ZXIgPSBjaGlsZC5sYXllcigpOwotICAgIGNo
aWxkTGF5ZXItPnNldFN0YXRpY0lubGluZVBvc2l0aW9uKGJvcmRlckFuZFBhZGRpbmdTdGFydCgp
KTsKLSAgICBjaGlsZExheWVyLT5zZXRTdGF0aWNCbG9ja1Bvc2l0aW9uKGJvcmRlckFuZFBhZGRp
bmdCZWZvcmUoKSk7CisgICAgY2hpbGRMYXllci0+c2V0U3RhdGljSW5saW5lUG9zaXRpb24oTGF5
b3V0VW5pdChib3JkZXJTdGFydCgpKSk7CisgICAgY2hpbGRMYXllci0+c2V0U3RhdGljQmxvY2tQ
b3NpdGlvbihMYXlvdXRVbml0KGJvcmRlckJlZm9yZSgpKSk7CiB9CiAKIHZvaWQgUmVuZGVyR3Jp
ZDo6bGF5b3V0UG9zaXRpb25lZE9iamVjdChSZW5kZXJCb3gmIGNoaWxkLCBib29sIHJlbGF5b3V0
Q2hpbGRyZW4sIGJvb2wgZml4ZWRQb3NpdGlvbk9iamVjdHNPbmx5KQpkaWZmIC0tZ2l0IGEvTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQxNjRhNTll
M2Q3N2ExNDQ0MjM0ZGI1NTMyNTkxYTMyNDQ2MDBmMGQuLjUzY2Q3MDI0YzYyYWMzNDUzNjJkNWU5
MzM2YjBmZTk2ZDY2YzUxMjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg
Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wNS0xNSAgTWFu
dWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KKworICAgICAgICBbY3NzLWdy
aWRdIEZpeCBzdGF0aWMgcG9zaXRpb24gb2YgcG9zaXRpb25lZCBncmlkIGl0ZW1zCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzIxMDgKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCBpcyB1cGRh
dGVkIGFzIHRoZSBleHBlY3RlZCByZXN1bHRzIHdlcmUgd3JvbmcuCisgICAgICAgIE5vdGUgdGhh
dCBhZnRlciB0aGlzIHBhdGNoIHdlIG1hdGNoIENocm9tZSBhbmQgRmlyZWZveCBiZWhhdmlvciBv
biB0aGlzIHRlc3QuCisKKyAgICAgICAgKiBmYXN0L2Nzcy1ncmlkLWxheW91dC9hYnNvbHV0ZS1w
b3NpdGlvbmluZy1ncmlkLWNvbnRhaW5lci1wYXJlbnQuaHRtbDoKKwogMjAxNy0wNS0xNCAgU2Ft
IFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtXZWJJREwvRE9NXSBSZW1vdmUg
bmVlZCBmb3IgY3VzdG9tIGJpbmRpbmdzIGZvciBIVE1MQWxsQ29sbGVjdGlvbiBhbmQgYnJpbmcg
dXAgdG8gc3BlYwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQv
YWJzb2x1dGUtcG9zaXRpb25pbmctZ3JpZC1jb250YWluZXItcGFyZW50Lmh0bWwgYi9MYXlvdXRU
ZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9hYnNvbHV0ZS1wb3NpdGlvbmluZy1ncmlkLWNvbnRh
aW5lci1wYXJlbnQuaHRtbAppbmRleCAwOGNjYzYzNzdiYjcxZjE3ZTNhOGNlY2FmN2FkNGIwN2Jk
ZDdlNjRiLi5iM2FhYmFlNDNhZmU3ZGY2MGUwN2M5NDU0ZDhhMTA3ZTQ3NWRhOTRiIDEwMDY0NAot
LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9hYnNvbHV0ZS1wb3NpdGlvbmlu
Zy1ncmlkLWNvbnRhaW5lci1wYXJlbnQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1n
cmlkLWxheW91dC9hYnNvbHV0ZS1wb3NpdGlvbmluZy1ncmlkLWNvbnRhaW5lci1wYXJlbnQuaHRt
bApAQCAtMzUsMTkgKzM1LDE5IEBACiAKIDxkaXYgY2xhc3M9ImNvbnRhaW5lciByZWxhdGl2ZSI+
CiAgICAgPGRpdiBjbGFzcz0iZ3JpZCI+Ci0gICAgICAgIDxkaXYgY2xhc3M9InNpemVkVG9Hcmlk
QXJlYSBhYnNvbHV0ZSBhdXRvUm93QXV0b0NvbHVtbiIgZGF0YS1vZmZzZXQteD0iNTAiIGRhdGEt
b2Zmc2V0LXk9IjEwIiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI1MDAiIGRhdGEtZXhwZWN0ZWQtaGVp
Z2h0PSI0MDAiPjwvZGl2PgorICAgICAgICA8ZGl2IGNsYXNzPSJzaXplZFRvR3JpZEFyZWEgYWJz
b2x1dGUgYXV0b1Jvd0F1dG9Db2x1bW4iIGRhdGEtb2Zmc2V0LXg9IjM1IiBkYXRhLW9mZnNldC15
PSI1IiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI1MDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSI0MDAi
PjwvZGl2PgogICAgIDwvZGl2PgogPC9kaXY+CiAKIDxkaXYgY2xhc3M9ImNvbnRhaW5lciByZWxh
dGl2ZSI+CiAgICAgPGRpdiBjbGFzcz0iZ3JpZCI+Ci0gICAgICAgIDxkaXYgY2xhc3M9InNpemVk
VG9HcmlkQXJlYSBhYnNvbHV0ZSBmaXJzdFJvd0ZpcnN0Q29sdW1uIiBkYXRhLW9mZnNldC14PSI1
MCIgZGF0YS1vZmZzZXQteT0iMTAiIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjUwMCIgZGF0YS1leHBl
Y3RlZC1oZWlnaHQ9IjQwMCI+PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9InNpemVkVG9Hcmlk
QXJlYSBhYnNvbHV0ZSBmaXJzdFJvd0ZpcnN0Q29sdW1uIiBkYXRhLW9mZnNldC14PSIzNSIgZGF0
YS1vZmZzZXQteT0iNSIgZGF0YS1leHBlY3RlZC13aWR0aD0iNTAwIiBkYXRhLWV4cGVjdGVkLWhl
aWdodD0iNDAwIj48L2Rpdj4KICAgICA8L2Rpdj4KIDwvZGl2PgogCiA8ZGl2IGNsYXNzPSJjb250
YWluZXIgcmVsYXRpdmUiPgogICAgIDxkaXYgY2xhc3M9ImdyaWQiPgotICAgICAgICA8ZGl2IGNs
YXNzPSJzaXplZFRvR3JpZEFyZWEgYWJzb2x1dGUgc2Vjb25kUm93U2Vjb25kQ29sdW1uIiBkYXRh
LW9mZnNldC14PSI1MCIgZGF0YS1vZmZzZXQteT0iMTAiIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjUw
MCIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjQwMCI+PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9
InNpemVkVG9HcmlkQXJlYSBhYnNvbHV0ZSBzZWNvbmRSb3dTZWNvbmRDb2x1bW4iIGRhdGEtb2Zm
c2V0LXg9IjM1IiBkYXRhLW9mZnNldC15PSI1IiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI1MDAiIGRh
dGEtZXhwZWN0ZWQtaGVpZ2h0PSI0MDAiPjwvZGl2PgogICAgIDwvZGl2PgogPC9kaXY+CiAKQEAg
LTcxLDE5ICs3MSwxOSBAQAogCiA8ZGl2IGNsYXNzPSJjb250YWluZXIgcmVsYXRpdmUiPgogICAg
IDxkaXYgY2xhc3M9ImdyaWQgZGlyZWN0aW9uUlRMIj4KLSAgICAgICAgPGRpdiBjbGFzcz0ic2l6
ZWRUb0dyaWRBcmVhIGFic29sdXRlIGF1dG9Sb3dBdXRvQ29sdW1uIiBkYXRhLW9mZnNldC14PSIt
MTUwIiBkYXRhLW9mZnNldC15PSIxMCIgZGF0YS1leHBlY3RlZC13aWR0aD0iNTAwIiBkYXRhLWV4
cGVjdGVkLWhlaWdodD0iNDAwIj48L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0ic2l6ZWRUb0dy
aWRBcmVhIGFic29sdXRlIGF1dG9Sb3dBdXRvQ29sdW1uIiBkYXRhLW9mZnNldC14PSItMTM1IiBk
YXRhLW9mZnNldC15PSI1IiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI1MDAiIGRhdGEtZXhwZWN0ZWQt
aGVpZ2h0PSI0MDAiPjwvZGl2PgogICAgIDwvZGl2PgogPC9kaXY+CiAKIDxkaXYgY2xhc3M9ImNv
bnRhaW5lciByZWxhdGl2ZSI+CiAgICAgPGRpdiBjbGFzcz0iZ3JpZCBkaXJlY3Rpb25SVEwiPgot
ICAgICAgICA8ZGl2IGNsYXNzPSJzaXplZFRvR3JpZEFyZWEgYWJzb2x1dGUgZmlyc3RSb3dGaXJz
dENvbHVtbiIgZGF0YS1vZmZzZXQteD0iLTE1MCIgZGF0YS1vZmZzZXQteT0iMTAiIGRhdGEtZXhw
ZWN0ZWQtd2lkdGg9IjUwMCIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjQwMCI+PC9kaXY+CisgICAg
ICAgIDxkaXYgY2xhc3M9InNpemVkVG9HcmlkQXJlYSBhYnNvbHV0ZSBmaXJzdFJvd0ZpcnN0Q29s
dW1uIiBkYXRhLW9mZnNldC14PSItMTM1IiBkYXRhLW9mZnNldC15PSI1IiBkYXRhLWV4cGVjdGVk
LXdpZHRoPSI1MDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSI0MDAiPjwvZGl2PgogICAgIDwvZGl2
PgogPC9kaXY+CiAKIDxkaXYgY2xhc3M9ImNvbnRhaW5lciByZWxhdGl2ZSI+CiAgICAgPGRpdiBj
bGFzcz0iZ3JpZCBkaXJlY3Rpb25SVEwiPgotICAgICAgICA8ZGl2IGNsYXNzPSJzaXplZFRvR3Jp
ZEFyZWEgYWJzb2x1dGUgc2Vjb25kUm93U2Vjb25kQ29sdW1uIiBkYXRhLW9mZnNldC14PSItMTUw
IiBkYXRhLW9mZnNldC15PSIxMCIgZGF0YS1leHBlY3RlZC13aWR0aD0iNTAwIiBkYXRhLWV4cGVj
dGVkLWhlaWdodD0iNDAwIj48L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0ic2l6ZWRUb0dyaWRB
cmVhIGFic29sdXRlIHNlY29uZFJvd1NlY29uZENvbHVtbiIgZGF0YS1vZmZzZXQteD0iLTEzNSIg
ZGF0YS1vZmZzZXQteT0iNSIgZGF0YS1leHBlY3RlZC13aWR0aD0iNTAwIiBkYXRhLWV4cGVjdGVk
LWhlaWdodD0iNDAwIj48L2Rpdj4KICAgICA8L2Rpdj4KIDwvZGl2PgogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>310126</attachid>
            <date>2017-05-15 03:07:47 -0700</date>
            <delta_ts>2017-05-16 00:50:35 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-172108-20170515120745.patch</filename>
            <type>text/plain</type>
            <size>5890</size>
            <attacher name="Manuel Rego Casasnovas">rego</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM4MDkxNDQwM2JlMTJm
ZTUwZDllOTM0NTBiZmZjN2JkMjJmNmY3MS4uNmRmOGNkNTcxNDlhY2FmNDZjZGM4YmE2OTc5OWMx
MmRlZDMyMTMxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA1LTE1ICBNYW51
ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp
ZF0gRml4IHN0YXRpYyBwb3NpdGlvbiBvZiBwb3NpdGlvbmVkIGdyaWQgaXRlbXMKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjEwOAorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMg
dXMgZm9sbG93IHRoZSB0ZXh0IG9uIHRoZSBzcGVjCisgICAgICAgIChodHRwczovL2RyYWZ0cy5j
c3N3Zy5vcmcvY3NzLWdyaWQvI3N0YXRpYy1wb3NpdGlvbik6CisgICAgICAgICJUaGUgc3RhdGlj
IHBvc2l0aW9uIG9mIGFuIGFic29sdXRlbHktcG9zaXRpb25lZCBjaGlsZAorICAgICAgICAgb2Yg
YSBncmlkIGNvbnRhaW5lciBpcyBkZXRlcm1pbmVkIGFzIGlmIGl0IHdlcmUgdGhlIHNvbGUgZ3Jp
ZCBpdGVtCisgICAgICAgICBpbiBhIGdyaWQgYXJlYSB3aG9zZSBlZGdlcyBjb2luY2lkZSB3aXRo
IHRoZSBwYWRkaW5nIGVkZ2VzCisgICAgICAgICBvZiB0aGUgZ3JpZCBjb250YWluZXIuIgorCisg
ICAgICAgIFRlc3Q6IGZhc3QvY3NzLWdyaWQtbGF5b3V0L2Fic29sdXRlLXBvc2l0aW9uaW5nLWdy
aWQtY29udGFpbmVyLXBhcmVudC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyR3Jp
ZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjpwcmVwYXJlQ2hpbGRGb3JQb3Np
dGlvbmVkTGF5b3V0KTogTW9kaWZpZWQgdG8gYXZvaWQKKyAgICAgICAgaW5jbHVkaW5nIHBhZGRp
bmcgdG8gbWF0Y2ggdGhlIHNwZWMgYmVoYXZpb3IuCisKIDIwMTctMDUtMTQgIFphbiBEb2JlcnNl
ayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4
IHdpdGggbmV3ZXIgUGVybCB2ZXJzaW9ucy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl
bmRlcmluZy9SZW5kZXJHcmlkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJH
cmlkLmNwcAppbmRleCBlMzVkYzQ2NTBmYjE1OGE1ZmVjZTAwMjdiMzgyNjk1OWFkZTRiMTAyLi41
YjhmYWVlNjVmYWE0MDE2NjJjNDk4ZWIyNWUwZjM0YmQ2ODYzNDJkIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
cmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCkBAIC05MzQsOCArOTM0LDggQEAgdm9pZCBSZW5kZXJH
cmlkOjpwcmVwYXJlQ2hpbGRGb3JQb3NpdGlvbmVkTGF5b3V0KFJlbmRlckJveCYgY2hpbGQpCiAg
ICAgY2hpbGQuY29udGFpbmluZ0Jsb2NrKCktPmluc2VydFBvc2l0aW9uZWRPYmplY3QoY2hpbGQp
OwogCiAgICAgUmVuZGVyTGF5ZXIqIGNoaWxkTGF5ZXIgPSBjaGlsZC5sYXllcigpOwotICAgIGNo
aWxkTGF5ZXItPnNldFN0YXRpY0lubGluZVBvc2l0aW9uKGJvcmRlckFuZFBhZGRpbmdTdGFydCgp
KTsKLSAgICBjaGlsZExheWVyLT5zZXRTdGF0aWNCbG9ja1Bvc2l0aW9uKGJvcmRlckFuZFBhZGRp
bmdCZWZvcmUoKSk7CisgICAgY2hpbGRMYXllci0+c2V0U3RhdGljSW5saW5lUG9zaXRpb24oYm9y
ZGVyU3RhcnQoKSk7CisgICAgY2hpbGRMYXllci0+c2V0U3RhdGljQmxvY2tQb3NpdGlvbihib3Jk
ZXJCZWZvcmUoKSk7CiB9CiAKIHZvaWQgUmVuZGVyR3JpZDo6bGF5b3V0UG9zaXRpb25lZE9iamVj
dChSZW5kZXJCb3gmIGNoaWxkLCBib29sIHJlbGF5b3V0Q2hpbGRyZW4sIGJvb2wgZml4ZWRQb3Np
dGlvbk9iamVjdHNPbmx5KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQxNjRhNTllM2Q3N2ExNDQ0MjM0ZGI1NTMyNTkxYTMy
NDQ2MDBmMGQuLjUzY2Q3MDI0YzYyYWMzNDUzNjJkNWU5MzM2YjBmZTk2ZDY2YzUxMjAgMTAwNjQ0
Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK
QEAgLTEsMyArMSwxNSBAQAorMjAxNy0wNS0xNSAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJl
Z29AaWdhbGlhLmNvbT4KKworICAgICAgICBbY3NzLWdyaWRdIEZpeCBzdGF0aWMgcG9zaXRpb24g
b2YgcG9zaXRpb25lZCBncmlkIGl0ZW1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xNzIxMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBUaGUgdGVzdCBpcyB1cGRhdGVkIGFzIHRoZSBleHBlY3RlZCByZXN1
bHRzIHdlcmUgd3JvbmcuCisgICAgICAgIE5vdGUgdGhhdCBhZnRlciB0aGlzIHBhdGNoIHdlIG1h
dGNoIENocm9tZSBhbmQgRmlyZWZveCBiZWhhdmlvciBvbiB0aGlzIHRlc3QuCisKKyAgICAgICAg
KiBmYXN0L2Nzcy1ncmlkLWxheW91dC9hYnNvbHV0ZS1wb3NpdGlvbmluZy1ncmlkLWNvbnRhaW5l
ci1wYXJlbnQuaHRtbDoKKwogMjAxNy0wNS0xNCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3Jn
PgogCiAgICAgICAgIFtXZWJJREwvRE9NXSBSZW1vdmUgbmVlZCBmb3IgY3VzdG9tIGJpbmRpbmdz
IGZvciBIVE1MQWxsQ29sbGVjdGlvbiBhbmQgYnJpbmcgdXAgdG8gc3BlYwpkaWZmIC0tZ2l0IGEv
TGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvYWJzb2x1dGUtcG9zaXRpb25pbmctZ3Jp
ZC1jb250YWluZXItcGFyZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91
dC9hYnNvbHV0ZS1wb3NpdGlvbmluZy1ncmlkLWNvbnRhaW5lci1wYXJlbnQuaHRtbAppbmRleCAw
OGNjYzYzNzdiYjcxZjE3ZTNhOGNlY2FmN2FkNGIwN2JkZDdlNjRiLi5iM2FhYmFlNDNhZmU3ZGY2
MGUwN2M5NDU0ZDhhMTA3ZTQ3NWRhOTRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nz
cy1ncmlkLWxheW91dC9hYnNvbHV0ZS1wb3NpdGlvbmluZy1ncmlkLWNvbnRhaW5lci1wYXJlbnQu
aHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9hYnNvbHV0ZS1wb3Np
dGlvbmluZy1ncmlkLWNvbnRhaW5lci1wYXJlbnQuaHRtbApAQCAtMzUsMTkgKzM1LDE5IEBACiAK
IDxkaXYgY2xhc3M9ImNvbnRhaW5lciByZWxhdGl2ZSI+CiAgICAgPGRpdiBjbGFzcz0iZ3JpZCI+
Ci0gICAgICAgIDxkaXYgY2xhc3M9InNpemVkVG9HcmlkQXJlYSBhYnNvbHV0ZSBhdXRvUm93QXV0
b0NvbHVtbiIgZGF0YS1vZmZzZXQteD0iNTAiIGRhdGEtb2Zmc2V0LXk9IjEwIiBkYXRhLWV4cGVj
dGVkLXdpZHRoPSI1MDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSI0MDAiPjwvZGl2PgorICAgICAg
ICA8ZGl2IGNsYXNzPSJzaXplZFRvR3JpZEFyZWEgYWJzb2x1dGUgYXV0b1Jvd0F1dG9Db2x1bW4i
IGRhdGEtb2Zmc2V0LXg9IjM1IiBkYXRhLW9mZnNldC15PSI1IiBkYXRhLWV4cGVjdGVkLXdpZHRo
PSI1MDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSI0MDAiPjwvZGl2PgogICAgIDwvZGl2PgogPC9k
aXY+CiAKIDxkaXYgY2xhc3M9ImNvbnRhaW5lciByZWxhdGl2ZSI+CiAgICAgPGRpdiBjbGFzcz0i
Z3JpZCI+Ci0gICAgICAgIDxkaXYgY2xhc3M9InNpemVkVG9HcmlkQXJlYSBhYnNvbHV0ZSBmaXJz
dFJvd0ZpcnN0Q29sdW1uIiBkYXRhLW9mZnNldC14PSI1MCIgZGF0YS1vZmZzZXQteT0iMTAiIGRh
dGEtZXhwZWN0ZWQtd2lkdGg9IjUwMCIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjQwMCI+PC9kaXY+
CisgICAgICAgIDxkaXYgY2xhc3M9InNpemVkVG9HcmlkQXJlYSBhYnNvbHV0ZSBmaXJzdFJvd0Zp
cnN0Q29sdW1uIiBkYXRhLW9mZnNldC14PSIzNSIgZGF0YS1vZmZzZXQteT0iNSIgZGF0YS1leHBl
Y3RlZC13aWR0aD0iNTAwIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iNDAwIj48L2Rpdj4KICAgICA8
L2Rpdj4KIDwvZGl2PgogCiA8ZGl2IGNsYXNzPSJjb250YWluZXIgcmVsYXRpdmUiPgogICAgIDxk
aXYgY2xhc3M9ImdyaWQiPgotICAgICAgICA8ZGl2IGNsYXNzPSJzaXplZFRvR3JpZEFyZWEgYWJz
b2x1dGUgc2Vjb25kUm93U2Vjb25kQ29sdW1uIiBkYXRhLW9mZnNldC14PSI1MCIgZGF0YS1vZmZz
ZXQteT0iMTAiIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjUwMCIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9
IjQwMCI+PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9InNpemVkVG9HcmlkQXJlYSBhYnNvbHV0
ZSBzZWNvbmRSb3dTZWNvbmRDb2x1bW4iIGRhdGEtb2Zmc2V0LXg9IjM1IiBkYXRhLW9mZnNldC15
PSI1IiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI1MDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSI0MDAi
PjwvZGl2PgogICAgIDwvZGl2PgogPC9kaXY+CiAKQEAgLTcxLDE5ICs3MSwxOSBAQAogCiA8ZGl2
IGNsYXNzPSJjb250YWluZXIgcmVsYXRpdmUiPgogICAgIDxkaXYgY2xhc3M9ImdyaWQgZGlyZWN0
aW9uUlRMIj4KLSAgICAgICAgPGRpdiBjbGFzcz0ic2l6ZWRUb0dyaWRBcmVhIGFic29sdXRlIGF1
dG9Sb3dBdXRvQ29sdW1uIiBkYXRhLW9mZnNldC14PSItMTUwIiBkYXRhLW9mZnNldC15PSIxMCIg
ZGF0YS1leHBlY3RlZC13aWR0aD0iNTAwIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iNDAwIj48L2Rp
dj4KKyAgICAgICAgPGRpdiBjbGFzcz0ic2l6ZWRUb0dyaWRBcmVhIGFic29sdXRlIGF1dG9Sb3dB
dXRvQ29sdW1uIiBkYXRhLW9mZnNldC14PSItMTM1IiBkYXRhLW9mZnNldC15PSI1IiBkYXRhLWV4
cGVjdGVkLXdpZHRoPSI1MDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSI0MDAiPjwvZGl2PgogICAg
IDwvZGl2PgogPC9kaXY+CiAKIDxkaXYgY2xhc3M9ImNvbnRhaW5lciByZWxhdGl2ZSI+CiAgICAg
PGRpdiBjbGFzcz0iZ3JpZCBkaXJlY3Rpb25SVEwiPgotICAgICAgICA8ZGl2IGNsYXNzPSJzaXpl
ZFRvR3JpZEFyZWEgYWJzb2x1dGUgZmlyc3RSb3dGaXJzdENvbHVtbiIgZGF0YS1vZmZzZXQteD0i
LTE1MCIgZGF0YS1vZmZzZXQteT0iMTAiIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjUwMCIgZGF0YS1l
eHBlY3RlZC1oZWlnaHQ9IjQwMCI+PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9InNpemVkVG9H
cmlkQXJlYSBhYnNvbHV0ZSBmaXJzdFJvd0ZpcnN0Q29sdW1uIiBkYXRhLW9mZnNldC14PSItMTM1
IiBkYXRhLW9mZnNldC15PSI1IiBkYXRhLWV4cGVjdGVkLXdpZHRoPSI1MDAiIGRhdGEtZXhwZWN0
ZWQtaGVpZ2h0PSI0MDAiPjwvZGl2PgogICAgIDwvZGl2PgogPC9kaXY+CiAKIDxkaXYgY2xhc3M9
ImNvbnRhaW5lciByZWxhdGl2ZSI+CiAgICAgPGRpdiBjbGFzcz0iZ3JpZCBkaXJlY3Rpb25SVEwi
PgotICAgICAgICA8ZGl2IGNsYXNzPSJzaXplZFRvR3JpZEFyZWEgYWJzb2x1dGUgc2Vjb25kUm93
U2Vjb25kQ29sdW1uIiBkYXRhLW9mZnNldC14PSItMTUwIiBkYXRhLW9mZnNldC15PSIxMCIgZGF0
YS1leHBlY3RlZC13aWR0aD0iNTAwIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iNDAwIj48L2Rpdj4K
KyAgICAgICAgPGRpdiBjbGFzcz0ic2l6ZWRUb0dyaWRBcmVhIGFic29sdXRlIHNlY29uZFJvd1Nl
Y29uZENvbHVtbiIgZGF0YS1vZmZzZXQteD0iLTEzNSIgZGF0YS1vZmZzZXQteT0iNSIgZGF0YS1l
eHBlY3RlZC13aWR0aD0iNTAwIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iNDAwIj48L2Rpdj4KICAg
ICA8L2Rpdj4KIDwvZGl2PgogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>