17199 2008-02-06 13:34:58 -0800 ElementRareDataMap should use OwnPtr to avoid any possible leaks 2014-01-13 21:56:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED INVALID P2 Normal --- 1 eric webkit-unassigned andersca aroben mjs oldest_to_newest 69603 0 eric 2008-02-06 13:34:58 -0800 ElementRareDataMap should use OwnPtr to avoid any possible leaks Assuming this is safe, typedef HashMap<const Element*, ElementRareData*> ElementRareDataMap; Should be changed to: typedef HashMap<const Element*, OwnPtr<ElementRareData>> ElementRareDataMap; To avoid any possible leaks. Holding new'd objects in raw pointers is dangerous. 69604 1 aroben 2008-02-06 13:42:58 -0800 (In reply to comment #0) > ElementRareDataMap should use OwnPtr to avoid any possible leaks > > Assuming this is safe, > typedef HashMap<const Element*, ElementRareData*> ElementRareDataMap; > > Should be changed to: > typedef HashMap<const Element*, OwnPtr<ElementRareData>> ElementRareDataMap; I'm not sure this is possible, since OwnPtr isn't copyable. 69608 2 eric 2008-02-06 14:07:38 -0800 Yeah, I tried. OwnPtr isn't copyable, thus this didn't work. There has to be a solution here though. Maybe auto_ptr? There should be construct we can use to do this safely, and make it *very obvious* when reading the code that the memory management is correct. 967662 3 andersca 2014-01-13 21:56:59 -0800 We no longer store rare data in a side table.