171864 2017-05-09 10:37:53 -0700 [Win] Specify source file type when preprocessing IDL files 2017-05-10 07:31:34 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 171618 1 don.olmstead don.olmstead achristensen bfulgham commit-queue lforschler pvollan oldest_to_newest 1306446 0 don.olmstead 2017-05-09 10:37:53 -0700 The source file type, https://msdn.microsoft.com/en-us/library/032xwy55.aspx, should be specified to the preprocessor when running IDL generation. 1306663 1 309559 don.olmstead 2017-05-09 16:27:25 -0700 Created attachment 309559 Patch Adds /FP to the list of CODE_GENERATOR_PREPROCESSOR_ARGUMENTS. This is equivalent to the -x cpp used in GCC/Clang. 1306671 2 achristensen 2017-05-09 16:55:29 -0700 I have a bot building with VS2017 now and it's fine without this. What does this improve or fix? 1306675 3 don.olmstead 2017-05-09 17:01:41 -0700 (In reply to Alex Christensen from comment #2) > I have a bot building with VS2017 now and it's fine without this. What does > this improve or fix? I'm trying to get things building with clang-cl. With cl the flag isn't explicitly needed for it to function. With clang-cl if the flag isn't there then it returns nothing to STDOUT and the build fails. 1306838 4 309559 commit-queue 2017-05-10 07:31:33 -0700 Comment on attachment 309559 Patch Clearing flags on attachment: 309559 Committed r216583: <http://trac.webkit.org/changeset/216583> 1306839 5 commit-queue 2017-05-10 07:31:34 -0700 All reviewed patches have been landed. Closing bug. 309559 2017-05-09 16:27:25 -0700 2017-05-10 07:31:33 -0700 Patch bug-171864.diff text/plain 1241 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkYTA4ODJjYzhjNi4uMTMz MTBiMDI3YTUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0wNS0wOSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNvbnku Y29tPgorCisgICAgICAgIFtXaW5dIFNwZWNpZnkgc291cmNlIGZpbGUgdHlwZSB3aGVuIHByZXBy b2Nlc3NpbmcgSURMIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzE4NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorCiAyMDE3LTA1 LTA5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBVcHN0 cmVhbSB0aGUgV1BFIHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9u LmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UKaW5kZXggYWZjZWI0ZWZh NDIuLmZiZjk1NzVmM2VjIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5j bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAtOSw3ICs5LDcg QEAgaWYgKE1TVkMpCiAgICAgIyBGSVhNRTogU29tZSBjb2RlZ2VuZXJhdG9ycyBkb24ndCBzdXBw b3J0IHBhdGhzIHdpdGggc3BhY2VzLiBTbyB1c2UgdGhlIGV4ZWN1dGFibGUgbmFtZSBvbmx5Lgog ICAgIGdldF9maWxlbmFtZV9jb21wb25lbnQoQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SX0VY RUNVVEFCTEUgJHtDTUFLRV9DWFhfQ09NUElMRVJ9IEFCU09MVVRFKQogCi0gICAgc2V0KENPREVf R0VORVJBVE9SX1BSRVBST0NFU1NPUl9BUkdVTUVOVFMgIi9ub2xvZ28gL0VQIikKKyAgICBzZXQo Q09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SX0FSR1VNRU5UUyAiL25vbG9nbyAvRVAgL1RQIikK ICAgICBzZXQoQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SICJcIiR7Q09ERV9HRU5FUkFUT1Jf UFJFUFJPQ0VTU09SX0VYRUNVVEFCTEV9XCIgJHtDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNTT1Jf QVJHVU1FTlRTfSIpCiAKICAgICBzZXQoQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SX1dJVEhf TElORU1BUktFUlMgJHtDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNTT1J9KQo=