171799 2017-05-07 22:41:15 -0700 WebAssembly: don't just emit extended offset adds for patch 2017-05-08 10:06:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 170215 159775 1 jfbastien jfbastien commit-queue fpizlo jfbastien keith_miller mark.lam msaboff saam oldest_to_newest 1305806 0 jfbastien 2017-05-07 22:41:15 -0700 As recommended by pizlo in bug #170215. 1305807 1 309346 jfbastien 2017-05-07 22:43:38 -0700 Created attachment 309346 patch pizlo had said: (In reply to Filip Pizlo from comment #30) > Comment on attachment 309022 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309022&action=review > > > Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:80 > > + if (isPatch && inst.admitsExtendedOffsetAddr(arg)) { > > I would drop the isPatch check 1305881 2 309346 mark.lam 2017-05-08 09:31:58 -0700 Comment on attachment 309346 patch r=me 1305904 3 309346 commit-queue 2017-05-08 10:06:32 -0700 Comment on attachment 309346 patch Clearing flags on attachment: 309346 Committed r216430: <http://trac.webkit.org/changeset/216430> 1305905 4 commit-queue 2017-05-08 10:06:35 -0700 All reviewed patches have been landed. Closing bug. 309346 2017-05-07 22:43:38 -0700 2017-05-08 10:06:32 -0700 patch 0001-drop-is-patch.patch text/plain 2246 jfbastien RnJvbSA4OTY5MjcwNDVhNjUyYjg5Yjc2ODk2ZGQ4YTc5OTdkOGY3YjQxYjlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBTdW4sIDcgTWF5IDIwMTcgMjI6NDI6NDIgLTA3MDAKU3ViamVjdDogW1BBVENIXSBkcm9wLWlz LXBhdGNoCgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgIHwgMTIgKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fp ckxvd2VyU3RhY2tBcmdzLmNwcCB8ICAzICstLQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDU0Nzg3 MWEuLjRlNWRiMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisy MDE3LTA1LTA3ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KKworICAgICAgICBX ZWJBc3NlbWJseTogZG9uJ3QganVzdCBlbWl0IGV4dGVuZGVkIG9mZnNldCBhZGRzIGZvciBwYXRj aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNzk5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgaXNu J3QgbmVjZXNzYXJ5IHRvIHJlc3RyaWN0LgorCisgICAgICAgICogYjMvYWlyL0Fpckxvd2VyU3Rh Y2tBcmdzLmNwcDoKKyAgICAgICAgKEpTQzo6QjM6OkFpcjo6bG93ZXJTdGFja0FyZ3MpOgorCiAy MDE3LTA1LTA2ICBCaWxsIE1pbmcgIDxtYmJpbGxAZ21haWwuY29tPgogCiAgICAgICAgIEZpeCAz MmJpdCBXaW5kb3dzIGJ1aWxkIGJ5IGdpdmluZyBjb3JyZWN0IHBhcmFtZXRlcnMgdG8gTUFTTQpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJMb3dlclN0YWNrQXJn cy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckxvd2VyU3RhY2tBcmdzLmNw cAppbmRleCAwN2QwZDc4Li5mNjNiZDQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvYWlyL0Fpckxvd2VyU3RhY2tBcmdzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvYWlyL0Fpckxvd2VyU3RhY2tBcmdzLmNwcApAQCAtNzAsMTQgKzcwLDEzIEBAIHZvaWQg bG93ZXJTdGFja0FyZ3MoQ29kZSYgY29kZSkKIAogICAgICAgICBmb3IgKHVuc2lnbmVkIGluc3RJ bmRleCA9IDA7IGluc3RJbmRleCA8IGJsb2NrLT5zaXplKCk7ICsraW5zdEluZGV4KSB7CiAgICAg ICAgICAgICBJbnN0JiBpbnN0ID0gYmxvY2stPmF0KGluc3RJbmRleCk7Ci0gICAgICAgICAgICBi b29sIGlzUGF0Y2ggPSBpbnN0LmtpbmQub3Bjb2RlID09IFBhdGNoOwogCiAgICAgICAgICAgICBp bnN0LmZvckVhY2hBcmcoCiAgICAgICAgICAgICAgICAgWyZdIChBcmcmIGFyZywgQXJnOjpSb2xl IHJvbGUsIEJhbmssIFdpZHRoIHdpZHRoKSB7CiAgICAgICAgICAgICAgICAgICAgIGF1dG8gc3Rh Y2tBZGRyID0gWyZdIChWYWx1ZTo6T2Zmc2V0VHlwZSBvZmZzZXRGcm9tRlApIC0+IEFyZyB7CiAg ICAgICAgICAgICAgICAgICAgICAgICBpbnQzMl90IG9mZnNldEZyb21TUCA9IG9mZnNldEZyb21G UCArIGNvZGUuZnJhbWVTaXplKCk7CiAKLSAgICAgICAgICAgICAgICAgICAgICAgIGlmIChpc1Bh dGNoICYmIGluc3QuYWRtaXRzRXh0ZW5kZWRPZmZzZXRBZGRyKGFyZykpIHsKKyAgICAgICAgICAg ICAgICAgICAgICAgIGlmIChpbnN0LmFkbWl0c0V4dGVuZGVkT2Zmc2V0QWRkcihhcmcpKSB7CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gU3RhY2ttYXBzIGFuZCBwYXRjaHBvaW50cyBl eHBlY3QgYWRkciBpbnB1dHMgcmVsYXRpdmUgdG8gU1Agb3IgRlAgb25seS4gV2UgbWlnaHQgYXMg d2VsbAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vIG5vdCBldmVuIGJvdGhlciBnZW5l cmF0aW5nIGFuIGFkZHIgd2l0aCB2YWxpZCBmb3JtIGZvciB0aGVzZSBvcGNvZGVzIHNpbmNlIGV4 dGVuZGVkIG9mZnNldAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vIGFkZHIgaXMgYWx3 YXlzIHZhbGlkLgotLSAKMi4xMC4xCgo=