17167 2008-02-03 15:54:56 -0800 Failures in fast/dom/Node/initial-values.html 2019-02-06 09:04:00 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric ap cdumez emacemac7 ian jchaffraix oldest_to_newest 69281 0 eric 2008-02-03 15:54:56 -0800 Failures in fast/dom/Node/initial-values.html As previously mentioned in bug 17060, this test case tests for the exact behavior as spec'd in DOM Level 3. There are a few failures remaining for WebKit. Failures unique to WebKit: FAIL element.namespaceURI should be null (of type object). Was http://www.w3.org/1999/xhtml (of type string). FAIL element.nodeName should be html:pre. Was PRE. FAIL element.namespaceURI should be null (of type object). Was http://www.w3.org/1999/xhtml (of type string) Failures shared by FF3b2: FAIL attr.localName should be null (of type object). Was foo (of type string). FAIL attr.localName should be null (of type object). Was foo (of type string). FAIL doc.namespaceURI should be http://www.w3.org/1999/xhtml (of type string). Was null (of type object). FAIL element.localName should be null (of type object). Was pre (of type string). (FF3b2 fails with "PRE" instead of "pre") FAIL element.localName should be null (of type object). Was pre (of type string). (FF3b2 fails with "pre" instead of "PRE" however.) 71631 1 ddkilzer 2008-02-23 13:30:17 -0800 See also Bug 17048. 109656 2 27655 jchaffraix 2009-02-13 04:45:17 -0800 Created attachment 27655 Fix behaviour of nodeName for prefixed QualifiedName This fixes "FAIL element.nodeName should be html:pre. Was PRE." 109691 3 27655 eric 2009-02-13 09:29:53 -0800 Comment on attachment 27655 Fix behaviour of nodeName for prefixed QualifiedName Seems fine to me. 109776 4 ap 2009-02-14 02:47:21 -0800 HTML5 section about APIs in HTML documents does not have a special case for elements with prefixes - should it? The patch looks right to me, as well. 109779 5 ian 2009-02-14 12:46:11 -0800 I don't understand the question. 109780 6 ap 2009-02-14 13:07:18 -0800 > I don't understand the question. From HTML5: ---------- For HTML documents, and for HTML elements in HTML documents, certain APIs defined in DOM3 Core become case-insensitive or case-changing, as sometimes defined in DOM3 Core, and as summarized or required below. [DOM3CORE]. This does not apply to XML documents or to elements that are not in the HTML namespace despite being in HTML documents. Element.tagName and Node.nodeName These attributes must return element names converted to uppercase, regardless of the case with which they were created. ---------- In this bug, we discuss a case where nodeName doesn't convert the result to uppercase, even though the element is an HTML element in an HTML document. 109781 7 ian 2009-02-14 13:35:26 -0800 Why should it not become uppercase? 109782 8 ap 2009-02-14 13:59:55 -0800 As far as I'm concerned, the main reason is that this is what Firefox and Opera do. Also, returning "HTML:PRE" instead of "html:pre" seems to serve no purpose at all - it would create an inconsistency for no practical compatibility reason, as clients that are only aware of HTML semantics would look for "PRE", not "HTML:PRE". I'm deferring to Eric to explain why this is also what DOM 3 Core requires - I couldn't find anything in the spec that directly supported this claim. 109784 9 27655 eric 2009-02-14 16:54:08 -0800 Comment on attachment 27655 Fix behaviour of nodeName for prefixed QualifiedName Removing the review flag so this doesn't get landed before we resolve this discussion. 109785 10 eric 2009-02-14 17:20:59 -0800 (In reply to comment #8) > I'm deferring to Eric to explain why this is also what DOM 3 Core requires - I > couldn't find anything in the spec that directly supported this claim. I wrote this test *forever* ago (assuming it was even me)... But I find this in the spec: tagName has the value "elementExample". Note that this is case-preserving in XML, as are all of the operations of the DOM. The HTML DOM returns the tagName of an HTML element in the canonical uppercase form, regardless of the case in the source HTML document. That's the discussion of tagName, but it suggests that for xhtml (which is what's under discussion), that case is preserved for all attributes, including prefix, since it's XML. 109796 11 ap 2009-02-15 01:29:41 -0800 Actually, the case that is fixed here is in "Element creation using createElementNS on an HTML doc" section of the test, see <http://trac.webkit.org/export/41017/trunk/LayoutTests/fast/dom/Node/initial-values.html>. But I think that compatibility and consistency are sufficient reasons for us to change the behavior. 109798 12 27655 eric 2009-02-15 02:29:19 -0800 Comment on attachment 27655 Fix behaviour of nodeName for prefixed QualifiedName Marking r+ again. At least ap and I agree. :) 110067 13 27655 jchaffraix 2009-02-18 04:19:30 -0800 Comment on attachment 27655 Fix behaviour of nodeName for prefixed QualifiedName Sorry to reply to the discussion this late. I had the same thoughts as Eric about the specification. Document.createElementNS will create an XHTML element per DOM spec (as it splits the localName to fill the prefix which is not done in HTML). To be consistent with the DOM then we also need to have Element.nodeName match the XHTML behaviour. This is also what the other browser are doing. As we do not have a way to know whether an HTMLElement represents internally an XHTML element, the prefix check will correct at least part of the issue (non-prefixed element will continue to fail). Clearing the review flag as I would like to update the test and the code to account for this. 110139 14 27769 jchaffraix 2009-02-18 17:04:10 -0800 Created attachment 27769 Updated version with better comments and more tests 110180 15 27769 ap 2009-02-19 01:24:44 -0800 Comment on attachment 27769 Updated version with better comments and more tests +As we cannot test if an HTMLElement is an XHTML +element, our fix is to check whether it has a prefix and then default +to XML behaviour for nodeName. I don't understand this comment (or a FIXME in HTMLElement.cpp) Where is "XHTML element" defined? In Firefox, HTML elements created by parsing HTML documents (or via createElement) have a null namespace, which is not the case in WebKit and in HTML5. See also <http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/nsGenericHTMLElement.cpp#327>. Changing the behavior for names with prefixes seemed logical and safe, but saying that XHTML elements should be different from HTML elements is an entirely different thing. 110305 16 jchaffraix 2009-02-19 14:51:57 -0800 (In reply to comment #15) > (From update of attachment 27769 [review]) > +As we cannot test if an HTMLElement is an XHTML > +element, our fix is to check whether it has a prefix and then default > +to XML behaviour for nodeName. > > I don't understand this comment (or a FIXME in HTMLElement.cpp) Where is "XHTML > element" defined? Maybe it is my interpretation of the DOM & HTML5 specification but an HTMLElement in WebKit can behave in 2 ways as stated in HTML5 and the DOM spec: it either uses the HTML-specific behaviour or the other one (nodeName is an exemple but other methods have the same dual behaviour). As a result, it defines 2 different elements (HTML and XHTML elements). Other browsers can discriminate on the namespace to choose which algorithm to use (as you are pointing out). We cannot because all HTMLElement are in the same namespace. > Changing the behavior for names with prefixes seemed logical and safe, but > saying that XHTML elements should be different from HTML elements is an > entirely different thing. I am not saying that they should be different (internally we would use the same representation). However I am saying that they have a different behaviour with regard to the DOM and it is what is important here. One of the added tests shows that we are choosing the wrong nodeName algorithm for a non-prefixed element created by createElementNS in an HTML document. 110307 17 ian 2009-02-19 15:02:31 -0800 In HTML5, it's the document that has the HTML vs XML flag and an element acts as per its document's flag. It isn't done on a per-element basis. 110308 18 eric 2009-02-19 15:05:45 -0800 (In reply to comment #17) > In HTML5, it's the document that has the HTML vs XML flag and an element acts > as per its document's flag. It isn't done on a per-element basis. WebKit has an equivalent distinction. document->isHTMLDocument() will tell you if your Document* is really an HTMLDocument* and thus you should be in "html" mode not XHTML mode. 110371 19 jchaffraix 2009-02-20 01:15:11 -0800 (In reply to comment #18) > (In reply to comment #17) > > In HTML5, it's the document that has the HTML vs XML flag and an element acts > > as per its document's flag. It isn't done on a per-element basis. > > WebKit has an equivalent distinction. document->isHTMLDocument() will tell you > if your Document* is really an HTMLDocument* and thus you should be in "html" > mode not XHTML mode. > Exactly. This is the core of my comments: other browsers do such a distinction on an element level (using the namespace). HTML5 removes the namespace distinction as HTML and XHTML elements uses the same namespace and places the distinction at the document level. However the second change will lead to compatibility bugs (this bug is an example). I am just stating that my change only solves part of our current compatibility issue and that we may prefer to solve it entirely, which means a per-element policy that goes against HTML5. We may also decide that this is just a corner case and just side with HTML5. 110385 20 ap 2009-02-20 05:09:13 -0800 FWIW, it seems that Mozilla didn't have a bug about fixing Gecko to use XHTML namespace for HTML elements. I've filed <https://bugzilla.mozilla.org/show_bug.cgi?id=479417>. 120635 21 eric 2009-05-11 05:42:27 -0700 It seems that this change still agrees with Opera and Mozilla, but disagrees with HTML5. It's unclear as to if it agrees or disagrees with DOM Core 3. In either case, it's a corner case. I assume this does not break the document.createElement("foo:bar") case? since the real web does that. :) I'm sure we have test cases to cover that though. 122499 22 27769 eric 2009-05-21 19:07:04 -0700 Comment on attachment 27769 Updated version with better comments and more tests I'm OK with this. The test should say: +Element creation using createElementNS on an HTML doc: Non-Prefixed Element creation, or HTML Element creation (whichever is more correct). 122528 23 ap 2009-05-21 20:47:57 -0700 I'm not sure if we should do this, now that Mozilla actively is being actively updated to match HTML5. 122530 24 eric 2009-05-21 20:54:24 -0700 Please cite the mozilla bug numbers, emails, or whatever information you have. :) And feel free to r- the patch. I'm leaving this r+ with intent to have Julien land it until someone else takes decisive action. 122531 25 ap 2009-05-21 21:00:37 -0700 See comment 20, <https://bugzilla.mozilla.org/show_bug.cgi?id=479417>. 123956 26 abarth 2009-06-02 00:57:57 -0700 Assigning to Eric for resolution. 124048 27 eric 2009-06-02 13:52:30 -0700 (In reply to comment #25) > See comment 20, <https://bugzilla.mozilla.org/show_bug.cgi?id=479417>. This patch does not change the namespaceURI behavior. IT only changes the nodeName behavior. Going to land this and close the bug (even though there are still other "failures" in this test). 124054 28 eric 2009-06-02 14:33:54 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/dom/Node/initial-values-expected.txt M LayoutTests/fast/dom/Node/resources/initial-values.js M WebCore/ChangeLog M WebCore/html/HTMLElement.cpp Committed r44369 1503082 29 lforschler 2019-02-06 09:04:00 -0800 Mass moving XML DOM bugs to the "DOM" Component. 27655 2009-02-13 04:45:17 -0800 2009-02-18 17:04:10 -0800 Fix behaviour of nodeName for prefixed QualifiedName bug17167-initialValueNodeName.diff text/plain 3435 jchaffraix SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDk2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDItMTIgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4 QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQnVnIDE3MTY3OiBGYWlsdXJlcyBpbiBmYXN0L2RvbS9Ob2RlL2luaXRpYWwtdmFsdWVz Lmh0bWwKKworICAgICAgICBUbyBhY2hpdmUgY29tcGF0aWJpbGl0eSB3aXRoIEZGIGFuZCB0aGUg RE9NIHNwZWMsIGlmIHdlIGhhdmUgYSBwcmVmaXgsCisgICAgICAgIHdlIHVzZSB0aGUgbm9kZU5h bWUgWE1MIGFsZ29yaXRobS4KKworICAgICAgICAqIGh0bWwvSFRNTEVsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTEVsZW1lbnQ6Om5vZGVOYW1lKTogQWRkIGEgcHJlZml4IGNoZWNr IGJlZm9yZQorICAgICAgICByZXR1cm5pbmcgdGhlIHVwcGVyY2FzZSB0YWdOYW1lIChIVE1MIGJl aGF2aW91cikuCisKIDIwMDktMDItMTIgIG1pZ2dpbGluICA8bXIuZGlnZ2lsaW5AZ21haWwuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtldmluIE9sbGl2aWVyLgpJbmRleDogV2ViQ29yZS9o dG1sL0hUTUxFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEVsZW1l bnQuY3BwCShyZXZpc2lvbiA0MDk0MykKKysrIFdlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTY1LDcgKzY1LDcgQEAgU3RyaW5nIEhUTUxFbGVtZW50Ojpub2Rl TmFtZSgpIGNvbnN0CiB7CiAgICAgLy8gRklYTUU6IFdvdWxkIGJlIG5pY2UgdG8gaGF2ZSBhbiBh dG9taWNzdHJpbmcgbG9va3VwIGJhc2VkIG9mZiB1cHBlcmNhc2UgY2hhcnMgdGhhdCBkb2VzIG5v dCBoYXZlIHRvIGNvcHkKICAgICAvLyB0aGUgc3RyaW5nIG9uIGEgaGl0IGluIHRoZSBoYXNoLgot ICAgIGlmIChkb2N1bWVudCgpLT5pc0hUTUxEb2N1bWVudCgpKQorICAgIGlmIChkb2N1bWVudCgp LT5pc0hUTUxEb2N1bWVudCgpICYmICF0YWdRTmFtZSgpLmhhc1ByZWZpeCgpKQogICAgICAgICBy ZXR1cm4gdGFnUU5hbWUoKS5sb2NhbE5hbWUoKS5zdHJpbmcoKS51cHBlcigpOwogICAgIHJldHVy biBFbGVtZW50Ojpub2RlTmFtZSgpOwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDA5NjUpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAw OS0wMi0xMiAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMTcxNjc6IEZh aWx1cmVzIGluIGZhc3QvZG9tL05vZGUvaW5pdGlhbC12YWx1ZXMuaHRtbAorCisgICAgICAgIFVw ZGF0ZWQgdGhlIHJlc3VsdHMgYW5kIHJlbW92ZWQgY29tbWVudCBhYm91dCB0aGUgZmFpbHVyZS4K KworICAgICAgICAqIGZhc3QvZG9tL05vZGUvaW5pdGlhbC12YWx1ZXMtZXhwZWN0ZWQudHh0Ogor ICAgICAgICAqIGZhc3QvZG9tL05vZGUvcmVzb3VyY2VzL2luaXRpYWwtdmFsdWVzLmpzOgorCiAy MDA5LTAyLTEyICBIb3JpYSBPbGFydSAgPG9sYXJ1QGFkb2JlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvaW5p dGlhbC12YWx1ZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv ZG9tL05vZGUvaW5pdGlhbC12YWx1ZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA0MDk0MykKKysr IExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvaW5pdGlhbC12YWx1ZXMtZXhwZWN0ZWQudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC04MSw3ICs4MSw3IEBAIFBBU1MgZWxlbWVudC5wcmVmaXggaXMgbnVs bAogUEFTUyBlbGVtZW50Lm5vZGVWYWx1ZSBpcyBudWxsCiBQQVNTIGVsZW1lbnQuYXR0cmlidXRl cy50b1N0cmluZygpIGlzICdbb2JqZWN0IE5hbWVkTm9kZU1hcF0nCiBFbGVtZW50IGNyZWF0aW9u IHVzaW5nIGNyZWF0ZUVsZW1lbnROUyBvbiBhbiBIVE1MIGRvYzoKLUZBSUwgZWxlbWVudC5ub2Rl TmFtZSBzaG91bGQgYmUgaHRtbDpwcmUuIFdhcyBQUkUuCitQQVNTIGVsZW1lbnQubm9kZU5hbWUg aXMgJ2h0bWw6cHJlJwogUEFTUyBlbGVtZW50LmxvY2FsTmFtZSBpcyAncHJlJwogUEFTUyBlbGVt ZW50Lm5hbWVzcGFjZVVSSSBpcyAnaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCcKIFBBU1Mg ZWxlbWVudC5wcmVmaXggaXMgJ2h0bWwnCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2Rl L3Jlc291cmNlcy9pbml0aWFsLXZhbHVlcy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2RvbS9Ob2RlL3Jlc291cmNlcy9pbml0aWFsLXZhbHVlcy5qcwkocmV2aXNpb24gNDA5NDMp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL3Jlc291cmNlcy9pbml0aWFsLXZhbHVlcy5q cwkod29ya2luZyBjb3B5KQpAQCAtMTI5LDggKzEyOSw2IEBAIHNob3VsZEJlKCJlbGVtZW50LmF0 dHJpYnV0ZXMudG9TdHJpbmcoKSIKIAogZGVidWcoIkVsZW1lbnQgY3JlYXRpb24gdXNpbmcgY3Jl YXRlRWxlbWVudE5TIG9uIGFuIFhIVE1MIGRvYzoiKQogZWxlbWVudCA9IHhtbERvYy5jcmVhdGVF bGVtZW50TlMoImh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiLCAiaHRtbDpwcmUiKTsKLS8v IFNwZWM6IGh0dHA6Ly93d3cudzMub3JnL1RSL0RPTS1MZXZlbC0yLUNvcmUvY29yZS5odG1sI0xl dmVsLTItQ29yZS1ET00tY3JlYXRlRWxlbWVudE5TCi0vLyBXZWJLaXQgY3VycmVudGx5IHJldHVy bnMgIlBSRSIgaW5zdGVhZCBvZiAiaHRtbDpwcmUiCiBzaG91bGRCZSgiZWxlbWVudC5ub2RlTmFt ZSIsICInaHRtbDpwcmUnIik7CiBzaG91bGRCZSgiZWxlbWVudC5sb2NhbE5hbWUiLCAiJ3ByZSci KTsKIHNob3VsZEJlKCJlbGVtZW50Lm5hbWVzcGFjZVVSSSIsICInaHR0cDovL3d3dy53My5vcmcv MTk5OS94aHRtbCciKTsK 27769 2009-02-18 17:04:10 -0800 2009-05-21 19:07:04 -0700 Updated version with better comments and more tests bug17167-initialValueNodeName-updated.diff text/plain 7713 jchaffraix SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTA2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMDktMDItMTggIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4 QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQnVnIDE3MTY3OiBGYWlsdXJlcyBpbiBmYXN0L2RvbS9Ob2RlL2luaXRpYWwtdmFsdWVz Lmh0bWwKKworICAgICAgICBUaGlzIHBhcnRseSBzb2x2ZSBhIGNvbXBhdGliaWxpdHkgaXNzdWUg d2l0aCBvdGhlciBicm93c2Vycy4gSXQgd2lsbCBhbHNvCisgICAgICAgIG1ha2UgdXMgbW9yZSBj b25zaXN0ZW50IHdoaWxlIGhhbmRsaW5nIFhIVE1MIGVsZW1lbnQuCisKKyAgICAgICAgVGhlIGlz c3VlIGlzIHRoYXQgd2hlbiB3ZSBjcmVhdGUgYW4gWEhUTUwgZWxlbWVudCBpbnNpZGUgYW4gSFRN TCBkb2N1bWVudAorICAgICAgICAoYXMgaXQgaXMgdGhlIGNhc2Ugd2hlbiBjYWxsaW5nIGNyZWF0 ZUVsZW1lbnROUyksIHdlIGRlZmF1bHQgdG8gdGhlIEhUTUwKKyAgICAgICAgYmVoYXZpb3VyIGlu IG5vZGVOYW1lLiBBcyB3ZSBjYW5ub3QgdGVzdCBpZiBhbiBIVE1MRWxlbWVudCBpcyBhbiBYSFRN TAorICAgICAgICBlbGVtZW50LCBvdXIgZml4IGlzIHRvIGNoZWNrIHdoZXRoZXIgaXQgaGFzIGEg cHJlZml4IGFuZCB0aGVuIGRlZmF1bHQKKyAgICAgICAgdG8gWE1MIGJlaGF2aW91ciBmb3Igbm9k ZU5hbWUuCisKKyAgICAgICAgKiBodG1sL0hUTUxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxFbGVtZW50Ojpub2RlTmFtZSk6IEFkZCBhIHByZWZpeCBjaGVjayBiZWZvcmUKKyAg ICAgICAgcmV0dXJuaW5nIHRoZSB1cHBlcmNhc2UgdGFnTmFtZSAoSFRNTCBiZWhhdmlvdXIpLgor CiAyMDA5LTAyLTE4ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBF eHBvcnQgV2ViQ29yZTo6aGFuZEN1cnNvciBhbmQgQ3Vyc29yLmgKSW5kZXg6IFdlYkNvcmUvaHRt bC9IVE1MRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50 LmNwcAkocmV2aXNpb24gNDEwNjkpCisrKyBXZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC02NSw3ICs2NSw4IEBAIFN0cmluZyBIVE1MRWxlbWVudDo6bm9kZU5h bWUoKSBjb25zdAogewogICAgIC8vIEZJWE1FOiBXb3VsZCBiZSBuaWNlIHRvIGhhdmUgYW4gYXRv bWljc3RyaW5nIGxvb2t1cCBiYXNlZCBvZmYgdXBwZXJjYXNlIGNoYXJzIHRoYXQgZG9lcyBub3Qg aGF2ZSB0byBjb3B5CiAgICAgLy8gdGhlIHN0cmluZyBvbiBhIGhpdCBpbiB0aGUgaGFzaC4KLSAg ICBpZiAoZG9jdW1lbnQoKS0+aXNIVE1MRG9jdW1lbnQoKSkKKyAgICAvLyBGSVhNRTogV2Ugc2hv dWxkIGhhdmUgYSB3YXkgdG8gZGV0ZWN0IFhIVE1MIGVsZW1lbnRzIGFuZCByZXBsYWNlIHRoZSBo YXNQcmVmaXgoKSBjaGVjayB3aXRoIGl0LgorICAgIGlmIChkb2N1bWVudCgpLT5pc0hUTUxEb2N1 bWVudCgpICYmICF0YWdRTmFtZSgpLmhhc1ByZWZpeCgpKQogICAgICAgICByZXR1cm4gdGFnUU5h bWUoKS5sb2NhbE5hbWUoKS5zdHJpbmcoKS51cHBlcigpOwogICAgIHJldHVybiBFbGVtZW50Ojpu b2RlTmFtZSgpOwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDEwNjkpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wMi0xOCAgSnVs aWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMTcxNjc6IEZhaWx1cmVzIGluIGZh c3QvZG9tL05vZGUvaW5pdGlhbC12YWx1ZXMuaHRtbAorCisgICAgICAgIEFkZGVkIHNvbWUgbW9y ZSB0ZXN0cyB0byBzaG93IHRoYXQgdGhlIGNvbXBhdGliaWxpdHkgaXNzdWUgaXMgb25seQorICAg ICAgICBwYXJ0bHkgc29sdmVkLgorCisgICAgICAgIEFsc28gdXBkYXRlZCB0aGUgbmV3IHBhc3Np bmcgcmVzdWx0IGFuZCByZW1vdmVkIHRoZSBhc3NvY2lhdGVkIGNvbW1lbnQKKyAgICAgICAgaW5z aWRlIHRoZSBpbml0aWFsLXZhbHVlcy5qcy4KKworICAgICAgICAqIGZhc3QvZG9tL05vZGUvaW5p dGlhbC12YWx1ZXMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZG9tL05vZGUvcmVzb3Vy Y2VzL2luaXRpYWwtdmFsdWVzLmpzOgorCiAyMDA5LTAyLTE4ICBEaW1pdHJpIEdsYXprb3YgIDxk Z2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwu CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL2luaXRpYWwtdmFsdWVzLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL2luaXRpYWwtdmFs dWVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNDEwNjkpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9Ob2RlL2luaXRpYWwtdmFsdWVzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtODAs MTMgKzgwLDM0IEBAIEZBSUwgZWxlbWVudC5uYW1lc3BhY2VVUkkgc2hvdWxkIGJlIG51bGwKIFBB U1MgZWxlbWVudC5wcmVmaXggaXMgbnVsbAogUEFTUyBlbGVtZW50Lm5vZGVWYWx1ZSBpcyBudWxs CiBQQVNTIGVsZW1lbnQuYXR0cmlidXRlcy50b1N0cmluZygpIGlzICdbb2JqZWN0IE5hbWVkTm9k ZU1hcF0nCi1FbGVtZW50IGNyZWF0aW9uIHVzaW5nIGNyZWF0ZUVsZW1lbnROUyBvbiBhbiBIVE1M IGRvYzoKLUZBSUwgZWxlbWVudC5ub2RlTmFtZSBzaG91bGQgYmUgaHRtbDpwcmUuIFdhcyBQUkUu CitQcmVmaXhlZCBlbGVtZW50IGNyZWF0aW9uIHVzaW5nIGNyZWF0ZUVsZW1lbnROUyBvbiBhbiBI VE1MIGRvYzoKK1BBU1MgZWxlbWVudC5ub2RlTmFtZSBpcyAnaHRtbDpwcmUnCiBQQVNTIGVsZW1l bnQubG9jYWxOYW1lIGlzICdwcmUnCiBQQVNTIGVsZW1lbnQubmFtZXNwYWNlVVJJIGlzICdodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hodG1sJwogUEFTUyBlbGVtZW50LnByZWZpeCBpcyAnaHRtbCcK IFBBU1MgZWxlbWVudC5ub2RlVmFsdWUgaXMgbnVsbAogUEFTUyBlbGVtZW50LmF0dHJpYnV0ZXMu dG9TdHJpbmcoKSBpcyAnW29iamVjdCBOYW1lZE5vZGVNYXBdJworU1ZHIEVsZW1lbnQgY3JlYXRp b24gdXNpbmcgY3JlYXRlRWxlbWVudE5TIG9uIGFuIEhUTUwgZG9jOgorUEFTUyBlbGVtZW50Lm5v ZGVOYW1lIGlzICdzdmcnCitQQVNTIGVsZW1lbnQubG9jYWxOYW1lIGlzICdzdmcnCitQQVNTIGVs ZW1lbnQubmFtZXNwYWNlVVJJIGlzICdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZycKK1BBU1Mg ZWxlbWVudC5wcmVmaXggaXMgbnVsbAorUEFTUyBlbGVtZW50Lm5vZGVWYWx1ZSBpcyBudWxsCitQ QVNTIGVsZW1lbnQuYXR0cmlidXRlcy50b1N0cmluZygpIGlzICdbb2JqZWN0IE5hbWVkTm9kZU1h cF0nCitVbmtub3duIEVsZW1lbnQgY3JlYXRpb24gdXNpbmcgY3JlYXRlRWxlbWVudE5TIG9uIGFu IEhUTUwgZG9jOgorUEFTUyBlbGVtZW50Lm5vZGVOYW1lIGlzICdmb286c3ZnJworUEFTUyBlbGVt ZW50LmxvY2FsTmFtZSBpcyAnc3ZnJworUEFTUyBlbGVtZW50Lm5hbWVzcGFjZVVSSSBpcyAnaHR0 cDovL3d3dy53ZWJraXQub3JnJworUEFTUyBlbGVtZW50LnByZWZpeCBpcyAnZm9vJworUEFTUyBl bGVtZW50Lm5vZGVWYWx1ZSBpcyBudWxsCitQQVNTIGVsZW1lbnQuYXR0cmlidXRlcy50b1N0cmlu ZygpIGlzICdbb2JqZWN0IE5hbWVkTm9kZU1hcF0nCitFbGVtZW50IGNyZWF0aW9uIHVzaW5nIGNy ZWF0ZUVsZW1lbnROUyBvbiBhbiBIVE1MIGRvYzoKK0ZBSUwgZWxlbWVudC5ub2RlTmFtZSBzaG91 bGQgYmUgcHJlLiBXYXMgUFJFLgorUEFTUyBlbGVtZW50LmxvY2FsTmFtZSBpcyAncHJlJworUEFT UyBlbGVtZW50Lm5hbWVzcGFjZVVSSSBpcyAnaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCcK K1BBU1MgZWxlbWVudC5wcmVmaXggaXMgbnVsbAorUEFTUyBlbGVtZW50Lm5vZGVWYWx1ZSBpcyBu dWxsCitQQVNTIGVsZW1lbnQuYXR0cmlidXRlcy50b1N0cmluZygpIGlzICdbb2JqZWN0IE5hbWVk Tm9kZU1hcF0nCiBFbGVtZW50IGNyZWF0aW9uIHVzaW5nIGNyZWF0ZUVsZW1lbnQgb24gYW4gWEhU TUwgZG9jOgogUEFTUyBlbGVtZW50Lm5vZGVOYW1lIGlzICdwcmUnCiBGQUlMIGVsZW1lbnQubG9j YWxOYW1lIHNob3VsZCBiZSBudWxsIChvZiB0eXBlIG9iamVjdCkuIFdhcyBwcmUgKG9mIHR5cGUg c3RyaW5nKS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvcmVzb3VyY2VzL2luaXRp YWwtdmFsdWVzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvcmVz b3VyY2VzL2luaXRpYWwtdmFsdWVzLmpzCShyZXZpc2lvbiA0MTA2OSkKKysrIExheW91dFRlc3Rz L2Zhc3QvZG9tL05vZGUvcmVzb3VyY2VzL2luaXRpYWwtdmFsdWVzLmpzCSh3b3JraW5nIGNvcHkp CkBAIC0xMDgsNyArMTA4LDcgQEAgc2hvdWxkQmUoImVsZW1lbnQucHJlZml4IiwgIm51bGwiKTsK IHNob3VsZEJlKCJlbGVtZW50Lm5vZGVWYWx1ZSIsICJudWxsIik7CiBzaG91bGRCZSgiZWxlbWVu dC5hdHRyaWJ1dGVzLnRvU3RyaW5nKCkiLCAiJ1tvYmplY3QgTmFtZWROb2RlTWFwXSciKTsKIAot ZGVidWcoIkVsZW1lbnQgY3JlYXRpb24gdXNpbmcgY3JlYXRlRWxlbWVudE5TIG9uIGFuIEhUTUwg ZG9jOiIpCitkZWJ1ZygiUHJlZml4ZWQgZWxlbWVudCBjcmVhdGlvbiB1c2luZyBjcmVhdGVFbGVt ZW50TlMgb24gYW4gSFRNTCBkb2M6IikKIGVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50 TlMoImh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiLCAiaHRtbDpwcmUiKTsKIHNob3VsZEJl KCJlbGVtZW50Lm5vZGVOYW1lIiwgIidodG1sOnByZSciKTsKIHNob3VsZEJlKCJlbGVtZW50Lmxv Y2FsTmFtZSIsICIncHJlJyIpOwpAQCAtMTE3LDYgKzExNywzNSBAQCBzaG91bGRCZSgiZWxlbWVu dC5wcmVmaXgiLCAiJ2h0bWwnIik7CiBzaG91bGRCZSgiZWxlbWVudC5ub2RlVmFsdWUiLCAibnVs bCIpOwogc2hvdWxkQmUoImVsZW1lbnQuYXR0cmlidXRlcy50b1N0cmluZygpIiwgIidbb2JqZWN0 IE5hbWVkTm9kZU1hcF0nIik7CiAKK2RlYnVnKCJTVkcgRWxlbWVudCBjcmVhdGlvbiB1c2luZyBj cmVhdGVFbGVtZW50TlMgb24gYW4gSFRNTCBkb2M6IikKK2VsZW1lbnQgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50TlMoImh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiwgInN2ZyIpOworc2hvdWxk QmUoImVsZW1lbnQubm9kZU5hbWUiLCAiJ3N2ZyciKTsKK3Nob3VsZEJlKCJlbGVtZW50LmxvY2Fs TmFtZSIsICInc3ZnJyIpOworc2hvdWxkQmUoImVsZW1lbnQubmFtZXNwYWNlVVJJIiwgIidodHRw Oi8vd3d3LnczLm9yZy8yMDAwL3N2ZyciKTsKK3Nob3VsZEJlKCJlbGVtZW50LnByZWZpeCIsICJu dWxsIik7CitzaG91bGRCZSgiZWxlbWVudC5ub2RlVmFsdWUiLCAibnVsbCIpOworc2hvdWxkQmUo ImVsZW1lbnQuYXR0cmlidXRlcy50b1N0cmluZygpIiwgIidbb2JqZWN0IE5hbWVkTm9kZU1hcF0n Iik7CisKK2RlYnVnKCJVbmtub3duIEVsZW1lbnQgY3JlYXRpb24gdXNpbmcgY3JlYXRlRWxlbWVu dE5TIG9uIGFuIEhUTUwgZG9jOiIpCitlbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudE5T KCJodHRwOi8vd3d3LndlYmtpdC5vcmciLCAiZm9vOnN2ZyIpOworc2hvdWxkQmUoImVsZW1lbnQu bm9kZU5hbWUiLCAiJ2ZvbzpzdmcnIik7CitzaG91bGRCZSgiZWxlbWVudC5sb2NhbE5hbWUiLCAi J3N2ZyciKTsKK3Nob3VsZEJlKCJlbGVtZW50Lm5hbWVzcGFjZVVSSSIsICInaHR0cDovL3d3dy53 ZWJraXQub3JnJyIpOworc2hvdWxkQmUoImVsZW1lbnQucHJlZml4IiwgIidmb28nIik7CitzaG91 bGRCZSgiZWxlbWVudC5ub2RlVmFsdWUiLCAibnVsbCIpOworc2hvdWxkQmUoImVsZW1lbnQuYXR0 cmlidXRlcy50b1N0cmluZygpIiwgIidbb2JqZWN0IE5hbWVkTm9kZU1hcF0nIik7CisKK2RlYnVn KCJFbGVtZW50IGNyZWF0aW9uIHVzaW5nIGNyZWF0ZUVsZW1lbnROUyBvbiBhbiBIVE1MIGRvYzoi KQorZWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnROUygiaHR0cDovL3d3dy53My5vcmcv MTk5OS94aHRtbCIsICJwcmUiKTsKKy8vIFNwZWM6IGh0dHA6Ly93d3cudzMub3JnL1RSL0RPTS1M ZXZlbC0zLUNvcmUvY29yZS5odG1sI0lELTEwNDY4MjgxNSAoZWxlbWVudC50YWdOYW1lKQorLy8g RkYgYW5kIE9wZXJhIHJldHVybnMgInByZSIgZm9yIG5vZGVOYW1lIGFzIGl0IGlzIGFuIFhIVE1M IGVsZW1lbnQsIFdlYktpdCByZXR1cm5zICJQUkUiLgorc2hvdWxkQmUoImVsZW1lbnQubm9kZU5h bWUiLCAiJ3ByZSciKTsKK3Nob3VsZEJlKCJlbGVtZW50LmxvY2FsTmFtZSIsICIncHJlJyIpOwor c2hvdWxkQmUoImVsZW1lbnQubmFtZXNwYWNlVVJJIiwgIidodHRwOi8vd3d3LnczLm9yZy8xOTk5 L3hodG1sJyIpOworc2hvdWxkQmUoImVsZW1lbnQucHJlZml4IiwgIm51bGwiKTsKK3Nob3VsZEJl KCJlbGVtZW50Lm5vZGVWYWx1ZSIsICJudWxsIik7CitzaG91bGRCZSgiZWxlbWVudC5hdHRyaWJ1 dGVzLnRvU3RyaW5nKCkiLCAiJ1tvYmplY3QgTmFtZWROb2RlTWFwXSciKTsKKwogZGVidWcoIkVs ZW1lbnQgY3JlYXRpb24gdXNpbmcgY3JlYXRlRWxlbWVudCBvbiBhbiBYSFRNTCBkb2M6IikKIGVs ZW1lbnQgPSB4bWxEb2MuY3JlYXRlRWxlbWVudCgicHJlIik7CiBzaG91bGRCZSgiZWxlbWVudC5u b2RlTmFtZSIsICIncHJlJyIpOwpAQCAtMTI5LDggKzE1OCw2IEBAIHNob3VsZEJlKCJlbGVtZW50 LmF0dHJpYnV0ZXMudG9TdHJpbmcoKSIKIAogZGVidWcoIkVsZW1lbnQgY3JlYXRpb24gdXNpbmcg Y3JlYXRlRWxlbWVudE5TIG9uIGFuIFhIVE1MIGRvYzoiKQogZWxlbWVudCA9IHhtbERvYy5jcmVh dGVFbGVtZW50TlMoImh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiLCAiaHRtbDpwcmUiKTsK LS8vIFNwZWM6IGh0dHA6Ly93d3cudzMub3JnL1RSL0RPTS1MZXZlbC0yLUNvcmUvY29yZS5odG1s I0xldmVsLTItQ29yZS1ET00tY3JlYXRlRWxlbWVudE5TCi0vLyBXZWJLaXQgY3VycmVudGx5IHJl dHVybnMgIlBSRSIgaW5zdGVhZCBvZiAiaHRtbDpwcmUiCiBzaG91bGRCZSgiZWxlbWVudC5ub2Rl TmFtZSIsICInaHRtbDpwcmUnIik7CiBzaG91bGRCZSgiZWxlbWVudC5sb2NhbE5hbWUiLCAiJ3By ZSciKTsKIHNob3VsZEJlKCJlbGVtZW50Lm5hbWVzcGFjZVVSSSIsICInaHR0cDovL3d3dy53My5v cmcvMTk5OS94aHRtbCciKTsK