171603 2017-05-03 09:04:15 -0700 YouTube user agent quirk breaks new YouTube 2021-02-17 07:09:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED https://bugzilla.gnome.org/show_bug.cgi?id=777702 https://bugs.webkit.org/show_bug.cgi?id=176094 https://bugs.webkit.org/show_bug.cgi?id=142074 P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1304035 0 mcatanzaro 2017-05-03 09:04:15 -0700 Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We have to remove this quirk. Note this does not affect Safari as Apple ports don't use our user agent quirks. 1304038 1 308908 mcatanzaro 2017-05-03 09:07:42 -0700 Created attachment 308908 Patch 1304203 2 mcatanzaro 2017-05-03 13:21:18 -0700 """ This preview is closed... for now Thanks for your interest in helping us with the new desktop design! We've got a ton of feedback we're reading through, so we've closed the opt-in. """ So, I was apparently too slow and can't test this patch anymore... also, YouTube is crashing in trunk on bug #171336. But disabling/enabling site-specific quirks in MiniBrowser definitely toggled the problem when I tested it earlier today. So let's go with this. 1304223 3 308908 commit-queue 2017-05-03 13:51:04 -0700 Comment on attachment 308908 Patch Clearing flags on attachment: 308908 Committed r216139: <http://trac.webkit.org/changeset/216139> 1304224 4 commit-queue 2017-05-03 13:51:06 -0700 All reviewed patches have been landed. Closing bug. 308908 2017-05-03 09:07:42 -0700 2017-05-03 13:51:04 -0700 Patch bug-171603-20170503110741.patch text/plain 3183 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI3ZDA1YmU2OWJkNWJh MjVjNTI1ZDI2YjU0NjI4NmExZWUwMTc5ZS4uOGYxMTMzOGYyNTI3NWYwNmE5ZGJhY2MzYThkOWFl YTk1MjUxNzRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA1LTAzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBZb3VUdWJl IHVzZXIgYWdlbnQgcXVpcmsgYnJlYWtzIG5ldyBZb3VUdWJlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE2MDMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdXIgdXNlciBhZ2VudCBxdWlyayB0byBtYWtl IFlvdVR1YmUgMzYwIHdvcmsgYnJlYWtzIHRoZSBuZXcgWW91VHViZSBVSSwgY2F1c2luZyBpdCB0 bworICAgICAgICBhdHRlbXB0IHRvIHVzZSB0aGUgb2Jzb2xldGUgY3VzdG9tIGVsZW1lbnRzIHYw IEFQSS4gV2ViS2l0IG9ubHkgc3VwcG9ydHMgdGhlIHYxIEFQSS4gV2UKKyAgICAgICAgaGF2ZSB0 byByZW1vdmUgdGhpcyBxdWlyay4KKworICAgICAgICBOb3RlIHRoaXMgZG9lcyBub3QgYWZmZWN0 IFNhZmFyaSBhcyBBcHBsZSBwb3J0cyBkb24ndCB1c2Ugb3VyIHVzZXIgYWdlbnQgcXVpcmtzLgor CisgICAgICAgICogcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OnVybFJlcXVpcmVzQ2hyb21lQnJvd3Nlcik6CisKIDIwMTctMDUtMDMgIEFudHRpIEtvaXZp c3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBTdHlsZUludmFsaWRhdGlv bkFuYWx5c2lzIHRvIFN0eWxlOjpJbnZhbGlkYXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1VzZXJBZ2VudFF1aXJrcy5jcHAKaW5kZXggNDI4NGE2ODc4YTVhNmNkNjlkNjZkMDZkZjM3ODVk MzJhNzljNTQzZC4uYmRkODJkYWI0NjE0NDllMmZlM2RhNzU3ZTc4MTNiYmFmN2NjOGUzNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3BwCkBAIC02NiwxMCAr NjYsNiBAQCBzdGF0aWMgYm9vbCB1cmxSZXF1aXJlc0Nocm9tZUJyb3dzZXIoY29uc3QgVVJMJiB1 cmwpCiAgICAgaWYgKGJhc2VEb21haW4gPT0gInR5cGVraXQubmV0IiB8fCBiYXNlRG9tYWluID09 ICJ0eXBla2l0LmNvbSIpCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgLy8gTmVlZGVkIGZv ciBZb3VUdWJlIDM2MCB3aXRoIFdlYktpdEdUSysgYW5kIFdQRSAocmVxdWlyZXMgRU5BQkxFX01F RElBX1NPVVJDRSkuCi0gICAgaWYgKGJhc2VEb21haW4gPT0gInlvdXR1YmUuY29tIikKLSAgICAg ICAgcmV0dXJuIHRydWU7Ci0KICAgICAvLyBTbGFjayBjb21wbGV0ZWx5IGJsb2NrcyB1c2VycyB3 aXRoIFdlYktpdEdUSysncyBzdGFuZGFyZCB1c2VyIGFnZW50LgogICAgIGlmIChiYXNlRG9tYWlu ID09ICJzbGFjay5jb20iKQogICAgICAgICByZXR1cm4gdHJ1ZTsKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0YjE4NDFlYjgyZjhjMjQyN2Y5ZGYy OGE1Y2QwZjE0NTljMTM5N2Q0Li43MzJjMjM4MTZjYWU1MTE0NDgzOWViODM2MTAwOGM0ZjUxMDdk NmFlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTctMDUtMDMgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFy b0BpZ2FsaWEuY29tPgorCisgICAgICAgIFlvdVR1YmUgdXNlciBhZ2VudCBxdWlyayBicmVha3Mg bmV3IFlvdVR1YmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MTYwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZSB0aGUgWW91VHViZSBxdWlyayB0ZXN0LgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHA6CisgICAgICAgIChUZXN0V2Vi S2l0QVBJOjpURVNUKToKKwogMjAxNy0wNS0wMiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBzaG91bGQgYWxzbyBrZWVwIGpz LXRlc3QtcG9zdFstYXN5bmNdLmpzIGluIHN5bmMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAKaW5kZXggOWMyNzVlYzE2ODUz NWVkZDBkZDYyN2VhM2E3YzliNTU2NTk1ZGM5MS4uMmNiNjY2NGRmM2Y3YjU5YTBkMzhkNmU0NDZm MjFlYmMzMTJjN2JjMyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJD b3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAKQEAgLTg5LDcgKzg5LDYgQEAgVEVTVChVc2VyQWdl bnRUZXN0LCBRdWlya3MpCiAKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNDaHJvbWVCcm93 c2VyUXVpcmsoImh0dHA6Ly90eXBla2l0LmNvbS8iKTsKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JV UkxIYXNDaHJvbWVCcm93c2VyUXVpcmsoImh0dHA6Ly90eXBla2l0Lm5ldC8iKTsKLSAgICBhc3Nl cnRVc2VyQWdlbnRGb3JVUkxIYXNDaHJvbWVCcm93c2VyUXVpcmsoImh0dHA6Ly93d3cueW91dHVi ZS5jb20vIik7CiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzQ2hyb21lQnJvd3NlclF1aXJr KCJodHRwOi8vd3d3LnNsYWNrLmNvbS8iKTsKIAogICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhh c0ZpcmVmb3hCcm93c2VyUXVpcmsoImh0dHA6Ly93d3cuZ29vZ2xlLmNvbS8iKTsK