<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171589</bug_id>
          
          <creation_ts>2017-05-02 19:25:14 -0700</creation_ts>
          <short_desc>update FormData to latest spec webidl</short_desc>
          <delta_ts>2020-10-01 23:07:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>171781</dependson>
    
    <dependson>217162</dependson>
          <blocked>161190</blocked>
    
    <blocked>171581</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Ben Kelly">ben</reporter>
          <assigned_to name="Rob Buis">rbuis</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ap</cc>
    
    <cc>cdumez</cc>
    
    <cc>changseok</cc>
    
    <cc>dpaddock</cc>
    
    <cc>dvpdiner2</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>mifenton</cc>
    
    <cc>rbuis</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1303927</commentid>
    <comment_count>0</comment_count>
    <who name="Ben Kelly">ben</who>
    <bug_when>2017-05-02 19:25:14 -0700</bug_when>
    <thetext>This bug is to expose FormData on worker threads.  Currently its only exposed on Window in WebKit, AFAICT.  XHR is exposed in workers, so it would be able to take advantage of this.  Also, I&apos;d like to integrate it with Fetch API in bug 161190 and bug 171581 which also exposed on workers.

https://xhr.spec.whatwg.org/#formdata</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1305653</commentid>
    <comment_count>1</comment_count>
    <who name="Ben Kelly">ben</who>
    <bug_when>2017-05-06 19:24:29 -0700</bug_when>
    <thetext>Actually, the webkit DOMFormData.idl is a bit out of date with the spec.  Looks like the following is missing in addition to the Exposed(Worker):

  void delete(USVString name);
  FormDataEntryValue? get(USVString name);
  sequence&lt;FormDataEntryValue&gt; getAll(USVString name);
  boolean has(USVString name);
  void set(USVString name, USVString value);
  void set(USVString name, Blob blobValue, optional USVString filename);
  iterable&lt;USVString, FormDataEntryValue&gt;;

Let me see if I can just bring the impl update to spec here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1681724</commentid>
    <comment_count>2</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-08-20 10:06:37 -0700</bug_when>
    <thetext>Looks like this was implemented in https://bugs.webkit.org/show_bug.cgi?id=176674 (worker) and https://bugs.webkit.org/show_bug.cgi?id=176659 (the rest).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693389</commentid>
    <comment_count>3</comment_count>
      <attachid>410122</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-09-30 08:21:45 -0700</bug_when>
    <thetext>Created attachment 410122
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693392</commentid>
    <comment_count>4</comment_count>
      <attachid>410125</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-09-30 08:35:53 -0700</bug_when>
    <thetext>Created attachment 410125
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693395</commentid>
    <comment_count>5</comment_count>
      <attachid>410126</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-09-30 08:54:33 -0700</bug_when>
    <thetext>Created attachment 410126
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693410</commentid>
    <comment_count>6</comment_count>
      <attachid>410131</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-09-30 09:42:38 -0700</bug_when>
    <thetext>Created attachment 410131
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693483</commentid>
    <comment_count>7</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2020-09-30 12:23:25 -0700</bug_when>
    <thetext>Is the optional argument not compiling?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693487</commentid>
    <comment_count>8</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-09-30 12:28:22 -0700</bug_when>
    <thetext>(In reply to Sam Weinig from comment #7)
&gt; Is the optional argument not compiling?

Right, I got a &quot;not supported&quot; error from the IDL processing when I tried.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693488</commentid>
    <comment_count>9</comment_count>
      <attachid>410131</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-09-30 12:28:45 -0700</bug_when>
    <thetext>Comment on attachment 410131
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410131&amp;action=review

&gt; Source/WebCore/html/DOMFormData.idl:40
&gt; +    // FIXME: should be optional HTMLFormElement.

I think we should make this work. This change makes our IDL look worse.
I am actually very surprised it does not work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693497</commentid>
    <comment_count>10</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2020-09-30 13:01:52 -0700</bug_when>
    <thetext>(In reply to Rob Buis from comment #8)
&gt; (In reply to Sam Weinig from comment #7)
&gt; &gt; Is the optional argument not compiling?
&gt; 
&gt; Right, I got a &quot;not supported&quot; error from the IDL processing when I tried.

hm, interesting. If you can try again, and give me the full output, I can probably point to what&apos;s wrong.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693500</commentid>
    <comment_count>11</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-09-30 13:06:05 -0700</bug_when>
    <thetext>(In reply to Sam Weinig from comment #10)
&gt; (In reply to Rob Buis from comment #8)
&gt; &gt; (In reply to Sam Weinig from comment #7)
&gt; &gt; &gt; Is the optional argument not compiling?
&gt; &gt; 
&gt; &gt; Right, I got a &quot;not supported&quot; error from the IDL processing when I tried.
&gt; 
&gt; hm, interesting. If you can try again, and give me the full output, I can
&gt; probably point to what&apos;s wrong.

Optional arguments of non-nullable wrapper types are not supported () at /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm line 118.
$VAR1 = &apos; at /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm line 6196.
	CodeGeneratorJS::GenerateParametersCheck(ARRAY(0x7f96c682fa70), IDLOperation=HASH(0x7f96e28a1400), IDLInterface=HASH(0x7f96e289ffa8), &quot;create&quot;, &quot;    &quot;) called at /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm line 7765
	CodeGeneratorJS::GenerateConstructorDefinition(ARRAY(0x7f96c682fa70), &quot;JSDOMFormData&quot;, &quot;JSDOMFormDataPrototype&quot;, &quot;FormData&quot;, IDLInterface=HASH(0x7f96e289ffa8), undef, IDLOperation=HASH(0x7f96e28a1400)) called at /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm line 7696
	CodeGeneratorJS::GenerateConstructorDefinitions(ARRAY(0x7f96c682fa70), &quot;JSDOMFormData&quot;, &quot;JSDOMFormDataPrototype&quot;, &quot;FormData&quot;, IDLInterface=HASH(0x7f96e289ffa8)) called at /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm line 4498
	CodeGeneratorJS::GenerateImplementation(CodeGeneratorJS=HASH(0x7f96e28a1118), IDLInterface=HASH(0x7f96e289ffa8), ARRAY(0x7f96c6850500), ARRAY(0x7f96e28a0ff8)) called at /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm line 177
	CodeGeneratorJS::GenerateInterface(CodeGeneratorJS=HASH(0x7f96e28a1118), IDLInterface=HASH(0x7f96e289ffa8), &quot;ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY ENABLE_ACCESSIBILIT&quot;..., ARRAY(0x7f96c6850500), ARRAY(0x7f96e28a0ff8)) called at /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/CodeGenerator.pm line 256
	CodeGenerator::ProcessInterfaces(CodeGenerator=HASH(0x7f96e28a4cf0), IDLDocument=HASH(0x7f96e28a10a0), &quot;ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY ENABLE_ACCESSIBILIT&quot;..., CodeGeneratorJS=HASH(0x7f96e28a1118)) called at /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/CodeGenerator.pm line 177
	CodeGenerator::ProcessDocument(CodeGenerator=HASH(0x7f96e28a4cf0), IDLDocument=HASH(0x7f96e28a10a0), &quot;ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY ENABLE_ACCESSIBILIT&quot;...) called at WebCore/bindings/scripts/generate-bindings.pl line 132
	main::generateBindings(&quot;WebCore/html/DOMFormData.idl&quot;) called at WebCore/bindings/scripts/generate-bindings.pl line 82
&apos;;
make[1]: *** [JSDOMFormData.h] Error 255
Command /bin/sh failed with exit code 2
** BUILD FAILED **</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693507</commentid>
    <comment_count>12</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2020-09-30 13:37:09 -0700</bug_when>
    <thetext>(In reply to Chris Dumez from comment #11)
&gt; (In reply to Sam Weinig from comment #10)
&gt; &gt; (In reply to Rob Buis from comment #8)
&gt; &gt; &gt; (In reply to Sam Weinig from comment #7)
&gt; &gt; &gt; &gt; Is the optional argument not compiling?
&gt; &gt; &gt; 
&gt; &gt; &gt; Right, I got a &quot;not supported&quot; error from the IDL processing when I tried.
&gt; &gt; 
&gt; &gt; hm, interesting. If you can try again, and give me the full output, I can
&gt; &gt; probably point to what&apos;s wrong.
&gt; 
&gt; Optional arguments of non-nullable wrapper types are not supported () at
&gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; CodeGeneratorJS.pm line 118.
&gt; $VAR1 = &apos; at
&gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; CodeGeneratorJS.pm line 6196.
&gt; 	CodeGeneratorJS::GenerateParametersCheck(ARRAY(0x7f96c682fa70),
&gt; IDLOperation=HASH(0x7f96e28a1400), IDLInterface=HASH(0x7f96e289ffa8),
&gt; &quot;create&quot;, &quot;    &quot;) called at
&gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; CodeGeneratorJS.pm line 7765
&gt; 	CodeGeneratorJS::GenerateConstructorDefinition(ARRAY(0x7f96c682fa70),
&gt; &quot;JSDOMFormData&quot;, &quot;JSDOMFormDataPrototype&quot;, &quot;FormData&quot;,
&gt; IDLInterface=HASH(0x7f96e289ffa8), undef, IDLOperation=HASH(0x7f96e28a1400))
&gt; called at
&gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; CodeGeneratorJS.pm line 7696
&gt; 	CodeGeneratorJS::GenerateConstructorDefinitions(ARRAY(0x7f96c682fa70),
&gt; &quot;JSDOMFormData&quot;, &quot;JSDOMFormDataPrototype&quot;, &quot;FormData&quot;,
&gt; IDLInterface=HASH(0x7f96e289ffa8)) called at
&gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; CodeGeneratorJS.pm line 4498
&gt; 	CodeGeneratorJS::
&gt; GenerateImplementation(CodeGeneratorJS=HASH(0x7f96e28a1118),
&gt; IDLInterface=HASH(0x7f96e289ffa8), ARRAY(0x7f96c6850500),
&gt; ARRAY(0x7f96e28a0ff8)) called at
&gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; CodeGeneratorJS.pm line 177
&gt; 	CodeGeneratorJS::GenerateInterface(CodeGeneratorJS=HASH(0x7f96e28a1118),
&gt; IDLInterface=HASH(0x7f96e289ffa8), &quot;ENABLE_3D_TRANSFORMS
&gt; ENABLE_ACCESSIBILITY ENABLE_ACCESSIBILIT&quot;..., ARRAY(0x7f96c6850500),
&gt; ARRAY(0x7f96e28a0ff8)) called at
&gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; CodeGenerator.pm line 256
&gt; 	CodeGenerator::ProcessInterfaces(CodeGenerator=HASH(0x7f96e28a4cf0),
&gt; IDLDocument=HASH(0x7f96e28a10a0), &quot;ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY
&gt; ENABLE_ACCESSIBILIT&quot;..., CodeGeneratorJS=HASH(0x7f96e28a1118)) called at
&gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; CodeGenerator.pm line 177
&gt; 	CodeGenerator::ProcessDocument(CodeGenerator=HASH(0x7f96e28a4cf0),
&gt; IDLDocument=HASH(0x7f96e28a10a0), &quot;ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY
&gt; ENABLE_ACCESSIBILIT&quot;...) called at
&gt; WebCore/bindings/scripts/generate-bindings.pl line 132
&gt; 	main::generateBindings(&quot;WebCore/html/DOMFormData.idl&quot;) called at
&gt; WebCore/bindings/scripts/generate-bindings.pl line 82
&gt; &apos;;
&gt; make[1]: *** [JSDOMFormData.h] Error 255
&gt; Command /bin/sh failed with exit code 2
&gt; ** BUILD FAILED **

Oh fun. Wonder why I (or perhaps someone else) did that. Probably about disambiguating between null and optional, but I don&apos;t think that should matter here. Will take a look later on this afternoon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693515</commentid>
    <comment_count>13</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-09-30 13:49:11 -0700</bug_when>
    <thetext>(In reply to Sam Weinig from comment #12)
&gt; (In reply to Chris Dumez from comment #11)
&gt; &gt; (In reply to Sam Weinig from comment #10)
&gt; &gt; &gt; (In reply to Rob Buis from comment #8)
&gt; &gt; &gt; &gt; (In reply to Sam Weinig from comment #7)
&gt; &gt; &gt; &gt; &gt; Is the optional argument not compiling?
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; Right, I got a &quot;not supported&quot; error from the IDL processing when I tried.
&gt; &gt; &gt; 
&gt; &gt; &gt; hm, interesting. If you can try again, and give me the full output, I can
&gt; &gt; &gt; probably point to what&apos;s wrong.
&gt; &gt; 
&gt; &gt; Optional arguments of non-nullable wrapper types are not supported () at
&gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; CodeGeneratorJS.pm line 118.
&gt; &gt; $VAR1 = &apos; at
&gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; CodeGeneratorJS.pm line 6196.
&gt; &gt; 	CodeGeneratorJS::GenerateParametersCheck(ARRAY(0x7f96c682fa70),
&gt; &gt; IDLOperation=HASH(0x7f96e28a1400), IDLInterface=HASH(0x7f96e289ffa8),
&gt; &gt; &quot;create&quot;, &quot;    &quot;) called at
&gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; CodeGeneratorJS.pm line 7765
&gt; &gt; 	CodeGeneratorJS::GenerateConstructorDefinition(ARRAY(0x7f96c682fa70),
&gt; &gt; &quot;JSDOMFormData&quot;, &quot;JSDOMFormDataPrototype&quot;, &quot;FormData&quot;,
&gt; &gt; IDLInterface=HASH(0x7f96e289ffa8), undef, IDLOperation=HASH(0x7f96e28a1400))
&gt; &gt; called at
&gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; CodeGeneratorJS.pm line 7696
&gt; &gt; 	CodeGeneratorJS::GenerateConstructorDefinitions(ARRAY(0x7f96c682fa70),
&gt; &gt; &quot;JSDOMFormData&quot;, &quot;JSDOMFormDataPrototype&quot;, &quot;FormData&quot;,
&gt; &gt; IDLInterface=HASH(0x7f96e289ffa8)) called at
&gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; CodeGeneratorJS.pm line 4498
&gt; &gt; 	CodeGeneratorJS::
&gt; &gt; GenerateImplementation(CodeGeneratorJS=HASH(0x7f96e28a1118),
&gt; &gt; IDLInterface=HASH(0x7f96e289ffa8), ARRAY(0x7f96c6850500),
&gt; &gt; ARRAY(0x7f96e28a0ff8)) called at
&gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; CodeGeneratorJS.pm line 177
&gt; &gt; 	CodeGeneratorJS::GenerateInterface(CodeGeneratorJS=HASH(0x7f96e28a1118),
&gt; &gt; IDLInterface=HASH(0x7f96e289ffa8), &quot;ENABLE_3D_TRANSFORMS
&gt; &gt; ENABLE_ACCESSIBILITY ENABLE_ACCESSIBILIT&quot;..., ARRAY(0x7f96c6850500),
&gt; &gt; ARRAY(0x7f96e28a0ff8)) called at
&gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; CodeGenerator.pm line 256
&gt; &gt; 	CodeGenerator::ProcessInterfaces(CodeGenerator=HASH(0x7f96e28a4cf0),
&gt; &gt; IDLDocument=HASH(0x7f96e28a10a0), &quot;ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY
&gt; &gt; ENABLE_ACCESSIBILIT&quot;..., CodeGeneratorJS=HASH(0x7f96e28a1118)) called at
&gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; CodeGenerator.pm line 177
&gt; &gt; 	CodeGenerator::ProcessDocument(CodeGenerator=HASH(0x7f96e28a4cf0),
&gt; &gt; IDLDocument=HASH(0x7f96e28a10a0), &quot;ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY
&gt; &gt; ENABLE_ACCESSIBILIT&quot;...) called at
&gt; &gt; WebCore/bindings/scripts/generate-bindings.pl line 132
&gt; &gt; 	main::generateBindings(&quot;WebCore/html/DOMFormData.idl&quot;) called at
&gt; &gt; WebCore/bindings/scripts/generate-bindings.pl line 82
&gt; &gt; &apos;;
&gt; &gt; make[1]: *** [JSDOMFormData.h] Error 255
&gt; &gt; Command /bin/sh failed with exit code 2
&gt; &gt; ** BUILD FAILED **
&gt; 
&gt; Oh fun. Wonder why I (or perhaps someone else) did that. Probably about
&gt; disambiguating between null and optional, but I don&apos;t think that should
&gt; matter here. Will take a look later on this afternoon.

I think the issue is that our generated bindings always call the implementation function with ALL parameters (even the optional ones that were omitted). As a result, we need a value to pass the implementation. When a parameter is an interface and nullable, we pass null to the implementation. However, when the interface is not nullable, the bindings currently don&apos;t know what to pass.

I guess there could be at least 2 ways to fix it:
1. Pass null to the implementation when the parameter is omitted and it is an interface type (even if not nullable). We&apos;d have to make sure we&apos;re properly throwing when the JS passes null though.
2. Omit the parameters that were omitted in JS when calling the implementation function</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693525</commentid>
    <comment_count>14</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2020-09-30 14:16:49 -0700</bug_when>
    <thetext>(In reply to Chris Dumez from comment #13)
&gt; (In reply to Sam Weinig from comment #12)
&gt; &gt; (In reply to Chris Dumez from comment #11)
&gt; &gt; &gt; (In reply to Sam Weinig from comment #10)
&gt; &gt; &gt; &gt; (In reply to Rob Buis from comment #8)
&gt; &gt; &gt; &gt; &gt; (In reply to Sam Weinig from comment #7)
&gt; &gt; &gt; &gt; &gt; &gt; Is the optional argument not compiling?
&gt; &gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; &gt; Right, I got a &quot;not supported&quot; error from the IDL processing when I tried.
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; hm, interesting. If you can try again, and give me the full output, I can
&gt; &gt; &gt; &gt; probably point to what&apos;s wrong.
&gt; &gt; &gt; 
&gt; &gt; &gt; Optional arguments of non-nullable wrapper types are not supported () at
&gt; &gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; &gt; CodeGeneratorJS.pm line 118.
&gt; &gt; &gt; $VAR1 = &apos; at
&gt; &gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; &gt; CodeGeneratorJS.pm line 6196.
&gt; &gt; &gt; 	CodeGeneratorJS::GenerateParametersCheck(ARRAY(0x7f96c682fa70),
&gt; &gt; &gt; IDLOperation=HASH(0x7f96e28a1400), IDLInterface=HASH(0x7f96e289ffa8),
&gt; &gt; &gt; &quot;create&quot;, &quot;    &quot;) called at
&gt; &gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; &gt; CodeGeneratorJS.pm line 7765
&gt; &gt; &gt; 	CodeGeneratorJS::GenerateConstructorDefinition(ARRAY(0x7f96c682fa70),
&gt; &gt; &gt; &quot;JSDOMFormData&quot;, &quot;JSDOMFormDataPrototype&quot;, &quot;FormData&quot;,
&gt; &gt; &gt; IDLInterface=HASH(0x7f96e289ffa8), undef, IDLOperation=HASH(0x7f96e28a1400))
&gt; &gt; &gt; called at
&gt; &gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; &gt; CodeGeneratorJS.pm line 7696
&gt; &gt; &gt; 	CodeGeneratorJS::GenerateConstructorDefinitions(ARRAY(0x7f96c682fa70),
&gt; &gt; &gt; &quot;JSDOMFormData&quot;, &quot;JSDOMFormDataPrototype&quot;, &quot;FormData&quot;,
&gt; &gt; &gt; IDLInterface=HASH(0x7f96e289ffa8)) called at
&gt; &gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; &gt; CodeGeneratorJS.pm line 4498
&gt; &gt; &gt; 	CodeGeneratorJS::
&gt; &gt; &gt; GenerateImplementation(CodeGeneratorJS=HASH(0x7f96e28a1118),
&gt; &gt; &gt; IDLInterface=HASH(0x7f96e289ffa8), ARRAY(0x7f96c6850500),
&gt; &gt; &gt; ARRAY(0x7f96e28a0ff8)) called at
&gt; &gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; &gt; CodeGeneratorJS.pm line 177
&gt; &gt; &gt; 	CodeGeneratorJS::GenerateInterface(CodeGeneratorJS=HASH(0x7f96e28a1118),
&gt; &gt; &gt; IDLInterface=HASH(0x7f96e289ffa8), &quot;ENABLE_3D_TRANSFORMS
&gt; &gt; &gt; ENABLE_ACCESSIBILITY ENABLE_ACCESSIBILIT&quot;..., ARRAY(0x7f96c6850500),
&gt; &gt; &gt; ARRAY(0x7f96e28a0ff8)) called at
&gt; &gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; &gt; CodeGenerator.pm line 256
&gt; &gt; &gt; 	CodeGenerator::ProcessInterfaces(CodeGenerator=HASH(0x7f96e28a4cf0),
&gt; &gt; &gt; IDLDocument=HASH(0x7f96e28a10a0), &quot;ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY
&gt; &gt; &gt; ENABLE_ACCESSIBILIT&quot;..., CodeGeneratorJS=HASH(0x7f96e28a1118)) called at
&gt; &gt; &gt; /Volumes/Work/WebKit/OpenSource/Source/WebCore/bindings/scripts/
&gt; &gt; &gt; CodeGenerator.pm line 177
&gt; &gt; &gt; 	CodeGenerator::ProcessDocument(CodeGenerator=HASH(0x7f96e28a4cf0),
&gt; &gt; &gt; IDLDocument=HASH(0x7f96e28a10a0), &quot;ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY
&gt; &gt; &gt; ENABLE_ACCESSIBILIT&quot;...) called at
&gt; &gt; &gt; WebCore/bindings/scripts/generate-bindings.pl line 132
&gt; &gt; &gt; 	main::generateBindings(&quot;WebCore/html/DOMFormData.idl&quot;) called at
&gt; &gt; &gt; WebCore/bindings/scripts/generate-bindings.pl line 82
&gt; &gt; &gt; &apos;;
&gt; &gt; &gt; make[1]: *** [JSDOMFormData.h] Error 255
&gt; &gt; &gt; Command /bin/sh failed with exit code 2
&gt; &gt; &gt; ** BUILD FAILED **
&gt; &gt; 
&gt; &gt; Oh fun. Wonder why I (or perhaps someone else) did that. Probably about
&gt; &gt; disambiguating between null and optional, but I don&apos;t think that should
&gt; &gt; matter here. Will take a look later on this afternoon.
&gt; 
&gt; I think the issue is that our generated bindings always call the
&gt; implementation function with ALL parameters (even the optional ones that
&gt; were omitted). As a result, we need a value to pass the implementation. When
&gt; a parameter is an interface and nullable, we pass null to the
&gt; implementation. However, when the interface is not nullable, the bindings
&gt; currently don&apos;t know what to pass.
&gt; 
&gt; I guess there could be at least 2 ways to fix it:
&gt; 1. Pass null to the implementation when the parameter is omitted and it is
&gt; an interface type (even if not nullable). We&apos;d have to make sure we&apos;re
&gt; properly throwing when the JS passes null though.
&gt; 2. Omit the parameters that were omitted in JS when calling the
&gt; implementation function

#1 is what we will likely want to do. For non-wrapper types, what we would do here is have the implementation use Optional&lt;type&gt; as the parameter. This does lead to the potential for a problem if you have a case like:

undefined foo(optional long a);
undefined foo(long? a);

We wouldn&apos;t be able to distinguish between the two overloads in the implementation (I am not sure that is actually valid WebIDL, but you get the idea) as they would both be:

void foo(Optional&lt;int&gt;);


For wrapper types, we don&apos;t use Optional&lt;&gt;, but use nullable pointers for nullable types, and references for non-nullable types. So if you have:

undefined foo(optional Node a);
undefined foo(Node? a);

you would again would have the same situation, where both the implementation functions would have the same signature:

void foo(Node*).


But, given we already live with the ambiguity with the non-wrapper type case, I am not sure why we didn&apos;t implement the wrapper case the same way (but using pointers instead of Optional).

Seems like we should just treat optional Node and Node? the same at the implementation level (but of course keep the bindings throwing for the optional case when you pass null).

One day, we may have to make things more explicit, and have the implementations use specific IDLOptional&lt;&gt; / IDLNullable&lt;&gt; types, but lets wait for that to actually crop up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693964</commentid>
    <comment_count>15</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2020-10-01 18:56:26 -0700</bug_when>
    <thetext>Ok, blocking bug is now in. You should be able to use:

  constructor(optional HTMLFormElement form);</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693966</commentid>
    <comment_count>16</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-10-01 18:59:15 -0700</bug_when>
    <thetext>(In reply to Sam Weinig from comment #15)
&gt; Ok, blocking bug is now in. You should be able to use:
&gt; 
&gt;   constructor(optional HTMLFormElement form);

Yay, thanks Sam.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693978</commentid>
    <comment_count>17</comment_count>
      <attachid>410303</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-10-01 20:53:15 -0700</bug_when>
    <thetext>Created attachment 410303
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693979</commentid>
    <comment_count>18</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-10-01 21:16:23 -0700</bug_when>
    <thetext>(In reply to Chris Dumez from comment #16)
&gt; (In reply to Sam Weinig from comment #15)
&gt; &gt; Ok, blocking bug is now in. You should be able to use:
&gt; &gt; 
&gt; &gt;   constructor(optional HTMLFormElement form);
&gt; 
&gt; Yay, thanks Sam.

Yes, thanks Sam! The patch is now trivial.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693986</commentid>
    <comment_count>19</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-10-01 23:06:32 -0700</bug_when>
    <thetext>Committed r267866: &lt;https://trac.webkit.org/changeset/267866&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410303.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693987</commentid>
    <comment_count>20</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-10-01 23:07:28 -0700</bug_when>
    <thetext>&lt;rdar://problem/69870343&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410122</attachid>
            <date>2020-09-30 08:21:45 -0700</date>
            <delta_ts>2020-09-30 08:40:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-171589-20200930162144.patch</filename>
            <type>text/plain</type>
            <size>4422</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVlNzQxMGNiMmMyZWYz
MTU3M2E1NTRmZTQyN2VmNzE4ZWViM2U3NS4uYzkzZDExMTIzZDNlNWNlNDE4ODVjY2UwMWI1YzQz
MmQ0Mjk0NTQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA5LTMwICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgdXBkYXRlIEZvcm1EYXRhIHRvIGxh
dGVzdCBzcGVjIHdlYmlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTcxNTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgV0lQCisKKyAgICAgICAgKiBodG1sL0RPTUZvcm1EYXRhLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OkRPTUZvcm1EYXRhOjpET01Gb3JtRGF0YSk6CisgICAgICAgICogaHRtbC9ET01G
b3JtRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6RE9NRm9ybURhdGE6OmNyZWF0ZSk6CisgICAg
ICAgICogaHRtbC9ET01Gb3JtRGF0YS5pZGw6CisKIDIwMjAtMDktMzAgIFphbGFuIEJ1anRhcyAg
PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIFJlbmFtZSBMaW5lQnJlYWtl
ciB0byBJbmxpbmVDb250ZW50QnJlYWtlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt
bC9ET01Gb3JtRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmNwcApp
bmRleCA4NGY3OTM5MjFmNDNmNWE2Yzc2NzAyYmViMjJlOWZjZTQ3YmExODM0Li4xM2U1NmU1ZTA0
NGUyZDU5MTBjYWM4OTZhYWE0YmNhZjEzYzE3OGJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9odG1sL0RPTUZvcm1EYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1E
YXRhLmNwcApAQCAtNDIsMTQgKzQyLDExIEBAIERPTUZvcm1EYXRhOjpET01Gb3JtRGF0YShjb25z
dCBUZXh0RW5jb2RpbmcmIGVuY29kaW5nKQogewogfQogCi1ET01Gb3JtRGF0YTo6RE9NRm9ybURh
dGEoSFRNTEZvcm1FbGVtZW50KiBmb3JtKQorRE9NRm9ybURhdGE6OkRPTUZvcm1EYXRhKGNvbnN0
IEhUTUxGb3JtRWxlbWVudCBmb3JtKQogICAgIDogbV9lbmNvZGluZyhVVEY4RW5jb2RpbmcoKSkK
IHsKLSAgICBpZiAoIWZvcm0pCi0gICAgICAgIHJldHVybjsKLQogICAgIEFTU0VSVChpc01haW5U
aHJlYWQoKSk7Ci0gICAgZm9yIChhdXRvJiBlbGVtZW50IDogZm9ybS0+Y29weUFzc29jaWF0ZWRF
bGVtZW50c1ZlY3RvcigpKSB7CisgICAgZm9yIChhdXRvJiBlbGVtZW50IDogZm9ybS5jb3B5QXNz
b2NpYXRlZEVsZW1lbnRzVmVjdG9yKCkpIHsKICAgICAgICAgaWYgKCFlbGVtZW50LT5hc0hUTUxF
bGVtZW50KCkuaXNEaXNhYmxlZEZvcm1Db250cm9sKCkpCiAgICAgICAgICAgICBlbGVtZW50LT5h
cHBlbmRGb3JtRGF0YSgqdGhpcywgdHJ1ZSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvaHRtbC9ET01Gb3JtRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9ET01Gb3JtRGF0
YS5oCmluZGV4IGM4MDQ4OGQ0NDhkMjg5MjFhMmUwZDdlYzFmNjM0NmRmMWQzNDEzNGMuLmI1NDkw
ZWMwZTk0NGNiZGZlMTQxYWE0ZTQ2MDc1ZjUzNzRkZThjMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZv
cm1EYXRhLmgKQEAgLTQ5LDggKzQ5LDkgQEAgcHVibGljOgogICAgICAgICBGb3JtRGF0YUVudHJ5
VmFsdWUgZGF0YTsKICAgICB9OwogCi0gICAgc3RhdGljIFJlZjxET01Gb3JtRGF0YT4gY3JlYXRl
KEhUTUxGb3JtRWxlbWVudCogZm9ybSkgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBET01Gb3JtRGF0
YShmb3JtKSk7IH0KKyAgICBzdGF0aWMgUmVmPERPTUZvcm1EYXRhPiBjcmVhdGUoY29uc3QgSFRN
TEZvcm1FbGVtZW50IGZvcm0pIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgRE9NRm9ybURhdGEoZm9y
bSkpOyB9CiAgICAgc3RhdGljIFJlZjxET01Gb3JtRGF0YT4gY3JlYXRlKGNvbnN0IFRleHRFbmNv
ZGluZyYgZW5jb2RpbmcpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgRE9NRm9ybURhdGEoZW5jb2Rp
bmcpKTsgfQorICAgIHN0YXRpYyBSZWY8RE9NRm9ybURhdGE+IGNyZWF0ZSgpIHsgcmV0dXJuIGFk
b3B0UmVmKCpuZXcgRE9NRm9ybURhdGEoVVRGOEVuY29kaW5nKCkpKTsgfQogCiAgICAgY29uc3Qg
VmVjdG9yPEl0ZW0+JiBpdGVtcygpIGNvbnN0IHsgcmV0dXJuIG1faXRlbXM7IH0KICAgICBjb25z
dCBUZXh0RW5jb2RpbmcmIGVuY29kaW5nKCkgY29uc3QgeyByZXR1cm4gbV9lbmNvZGluZzsgfQpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9ET01Gb3JtRGF0YS5pZGwgYi9Tb3VyY2Uv
V2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmlkbAppbmRleCAyODVjNmQyOTE2MzMxMGYzMmJhMjY2
NTEwYzRiMTQxMmJjZTE3ZDc0Li42NWRlYTFkMTFlZGQ4NGJiNDRmMDRkMWRkODAyYmE3MzdjMGMx
OTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmlkbAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmlkbApAQCAtMzcsNyArMzcsOCBAQCB0
eXBlZGVmIChGaWxlIG9yIFVTVlN0cmluZykgRm9ybURhdGFFbnRyeVZhbHVlOwogICAgIEludGVy
ZmFjZU5hbWU9Rm9ybURhdGEsCiAgICAgSW1wbGVtZW50YXRpb25MYWNrc1ZUYWJsZSwKIF0gaW50
ZXJmYWNlIERPTUZvcm1EYXRhIHsKLSAgICBjb25zdHJ1Y3RvcihvcHRpb25hbCBIVE1MRm9ybUVs
ZW1lbnQ/IGZvcm0pOworICAgIGNvbnN0cnVjdG9yKCk7CisgICAgY29uc3RydWN0b3IoSFRNTEZv
cm1FbGVtZW50IGZvcm0pOwogCiAgICAgdW5kZWZpbmVkIGFwcGVuZChVU1ZTdHJpbmcgbmFtZSwg
VVNWU3RyaW5nIHZhbHVlKTsKICAgICB1bmRlZmluZWQgYXBwZW5kKFVTVlN0cmluZyBuYW1lLCBC
bG9iIGJsb2JWYWx1ZSwgb3B0aW9uYWwgVVNWU3RyaW5nIGZpbGVuYW1lKTsKZGlmZiAtLWdpdCBh
L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRl
ZC93M2MvQ2hhbmdlTG9nCmluZGV4IGVhNTUwMGYwOWUxYWQ5OTVhMjQyNTk3OTg1YTM3NDBlODgz
Yzg2ZWEuLjEzZmEyNDAxNGEwMGQxYmU5NjMyNDcyMjBjMTljY2IwMzRjZjc2ZDkgMTAwNjQ0Ci0t
LSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv
aW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTA5LTMwICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgdXBkYXRlIEZvcm1EYXRhIHRvIGxh
dGVzdCBzcGVjIHdlYmlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTcxNTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMveGhyL2Zvcm1kYXRhLWV4cGVjdGVkLnR4dDoK
KwogMjAyMC0wOS0zMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg
ICAgTWVkaWFSZWNvcmRlciBzaG91bGQgc3VwcG9ydCBpc1R5cGVTdXBwb3J0ZWQKZGlmZiAtLWdp
dCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMveGhyL2Zvcm1k
YXRhLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t
dGVzdHMveGhyL2Zvcm1kYXRhLWV4cGVjdGVkLnR4dAppbmRleCAyYjZlYTgyZDNkNmU5MDBlYTU2
NjQ3NmFhMmNlNTAyMjJkMTFjMGM5Li4zYjNlOTY0ZjIyMzQwNjBlNGM2NmQ4NDY5YzVlYTE1YjVh
ODIzMDc2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt
LXRlc3RzL3hoci9mb3JtZGF0YS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0
ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvZm9ybWRhdGEtZXhwZWN0ZWQudHh0CkBAIC0y
LDcgKzIsNyBAQAogCiAKIAotRkFJTCBDb25zdHJ1Y3RvcnMgc2hvdWxkIHRocm93IGEgdHlwZSBl
cnJvciBhc3NlcnRfdGhyb3dzX2pzOiBmdW5jdGlvbiAiKCkgPT4geyBuZXcgRm9ybURhdGEobnVs
bCk7IH0iIGRpZCBub3QgdGhyb3cKK1BBU1MgQ29uc3RydWN0b3JzIHNob3VsZCB0aHJvdyBhIHR5
cGUgZXJyb3IKIFBBU1MgZW1wdHkgZm9ybWRhdGEKIFBBU1MgZm9ybWRhdGEgd2l0aCBzdHJpbmcK
IFBBU1MgZm9ybWRhdGEgd2l0aCBuYW1lZCBzdHJpbmcK
</data>
<flag name="commit-queue"
          id="425976"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410125</attachid>
            <date>2020-09-30 08:35:53 -0700</date>
            <delta_ts>2020-09-30 08:56:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-171589-20200930163552.patch</filename>
            <type>text/plain</type>
            <size>4424</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVlNzQxMGNiMmMyZWYz
MTU3M2E1NTRmZTQyN2VmNzE4ZWViM2U3NS4uYzkzZDExMTIzZDNlNWNlNDE4ODVjY2UwMWI1YzQz
MmQ0Mjk0NTQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA5LTMwICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgdXBkYXRlIEZvcm1EYXRhIHRvIGxh
dGVzdCBzcGVjIHdlYmlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTcxNTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgV0lQCisKKyAgICAgICAgKiBodG1sL0RPTUZvcm1EYXRhLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OkRPTUZvcm1EYXRhOjpET01Gb3JtRGF0YSk6CisgICAgICAgICogaHRtbC9ET01G
b3JtRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6RE9NRm9ybURhdGE6OmNyZWF0ZSk6CisgICAg
ICAgICogaHRtbC9ET01Gb3JtRGF0YS5pZGw6CisKIDIwMjAtMDktMzAgIFphbGFuIEJ1anRhcyAg
PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIFJlbmFtZSBMaW5lQnJlYWtl
ciB0byBJbmxpbmVDb250ZW50QnJlYWtlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt
bC9ET01Gb3JtRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmNwcApp
bmRleCA4NGY3OTM5MjFmNDNmNWE2Yzc2NzAyYmViMjJlOWZjZTQ3YmExODM0Li4wMDM1NjFhMTg0
NTUxMWYzN2VmM2Q2YWJhMmI3NTY2MTUxNTI2ZTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9odG1sL0RPTUZvcm1EYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1E
YXRhLmNwcApAQCAtNDIsMTQgKzQyLDExIEBAIERPTUZvcm1EYXRhOjpET01Gb3JtRGF0YShjb25z
dCBUZXh0RW5jb2RpbmcmIGVuY29kaW5nKQogewogfQogCi1ET01Gb3JtRGF0YTo6RE9NRm9ybURh
dGEoSFRNTEZvcm1FbGVtZW50KiBmb3JtKQorRE9NRm9ybURhdGE6OkRPTUZvcm1EYXRhKGNvbnN0
IEhUTUxGb3JtRWxlbWVudCYgZm9ybSkKICAgICA6IG1fZW5jb2RpbmcoVVRGOEVuY29kaW5nKCkp
CiB7Ci0gICAgaWYgKCFmb3JtKQotICAgICAgICByZXR1cm47Ci0KICAgICBBU1NFUlQoaXNNYWlu
VGhyZWFkKCkpOwotICAgIGZvciAoYXV0byYgZWxlbWVudCA6IGZvcm0tPmNvcHlBc3NvY2lhdGVk
RWxlbWVudHNWZWN0b3IoKSkgeworICAgIGZvciAoYXV0byYgZWxlbWVudCA6IGZvcm0uY29weUFz
c29jaWF0ZWRFbGVtZW50c1ZlY3RvcigpKSB7CiAgICAgICAgIGlmICghZWxlbWVudC0+YXNIVE1M
RWxlbWVudCgpLmlzRGlzYWJsZWRGb3JtQ29udHJvbCgpKQogICAgICAgICAgICAgZWxlbWVudC0+
YXBwZW5kRm9ybURhdGEoKnRoaXMsIHRydWUpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURh
dGEuaAppbmRleCBjODA0ODhkNDQ4ZDI4OTIxYTJlMGQ3ZWMxZjYzNDZkZjFkMzQxMzRjLi5kOTFj
NTRhMjU2NDk5ZDNhY2I1MTk1MDRjODdkZGRkZWIzZGJlYjY0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9ET01G
b3JtRGF0YS5oCkBAIC00OSw4ICs0OSw5IEBAIHB1YmxpYzoKICAgICAgICAgRm9ybURhdGFFbnRy
eVZhbHVlIGRhdGE7CiAgICAgfTsKIAotICAgIHN0YXRpYyBSZWY8RE9NRm9ybURhdGE+IGNyZWF0
ZShIVE1MRm9ybUVsZW1lbnQqIGZvcm0pIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgRE9NRm9ybURh
dGEoZm9ybSkpOyB9CisgICAgc3RhdGljIFJlZjxET01Gb3JtRGF0YT4gY3JlYXRlKGNvbnN0IEhU
TUxGb3JtRWxlbWVudCYgZm9ybSkgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBET01Gb3JtRGF0YShm
b3JtKSk7IH0KICAgICBzdGF0aWMgUmVmPERPTUZvcm1EYXRhPiBjcmVhdGUoY29uc3QgVGV4dEVu
Y29kaW5nJiBlbmNvZGluZykgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBET01Gb3JtRGF0YShlbmNv
ZGluZykpOyB9CisgICAgc3RhdGljIFJlZjxET01Gb3JtRGF0YT4gY3JlYXRlKCkgeyByZXR1cm4g
YWRvcHRSZWYoKm5ldyBET01Gb3JtRGF0YShVVEY4RW5jb2RpbmcoKSkpOyB9CiAKICAgICBjb25z
dCBWZWN0b3I8SXRlbT4mIGl0ZW1zKCkgY29uc3QgeyByZXR1cm4gbV9pdGVtczsgfQogICAgIGNv
bnN0IFRleHRFbmNvZGluZyYgZW5jb2RpbmcoKSBjb25zdCB7IHJldHVybiBtX2VuY29kaW5nOyB9
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmlkbCBiL1NvdXJj
ZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaWRsCmluZGV4IDI4NWM2ZDI5MTYzMzEwZjMyYmEy
NjY1MTBjNGIxNDEyYmNlMTdkNzQuLjY1ZGVhMWQxMWVkZDg0YmI0NGYwNGQxZGQ4MDJiYTczN2Mw
YzE5MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaWRsCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaWRsCkBAIC0zNyw3ICszNyw4IEBA
IHR5cGVkZWYgKEZpbGUgb3IgVVNWU3RyaW5nKSBGb3JtRGF0YUVudHJ5VmFsdWU7CiAgICAgSW50
ZXJmYWNlTmFtZT1Gb3JtRGF0YSwKICAgICBJbXBsZW1lbnRhdGlvbkxhY2tzVlRhYmxlLAogXSBp
bnRlcmZhY2UgRE9NRm9ybURhdGEgewotICAgIGNvbnN0cnVjdG9yKG9wdGlvbmFsIEhUTUxGb3Jt
RWxlbWVudD8gZm9ybSk7CisgICAgY29uc3RydWN0b3IoKTsKKyAgICBjb25zdHJ1Y3RvcihIVE1M
Rm9ybUVsZW1lbnQgZm9ybSk7CiAKICAgICB1bmRlZmluZWQgYXBwZW5kKFVTVlN0cmluZyBuYW1l
LCBVU1ZTdHJpbmcgdmFsdWUpOwogICAgIHVuZGVmaW5lZCBhcHBlbmQoVVNWU3RyaW5nIG5hbWUs
IEJsb2IgYmxvYlZhbHVlLCBvcHRpb25hbCBVU1ZTdHJpbmcgZmlsZW5hbWUpOwpkaWZmIC0tZ2l0
IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9y
dGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggZWE1NTAwZjA5ZTFhZDk5NWEyNDI1OTc5ODVhMzc0MGU4
ODNjODZlYS4uMTNmYTI0MDE0YTAwZDFiZTk2MzI0NzIyMGMxOWNjYjAzNGNmNzZkOSAxMDA2NDQK
LS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0
cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDktMzAgIFJv
YiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KKworICAgICAgICB1cGRhdGUgRm9ybURhdGEgdG8g
bGF0ZXN0IHNwZWMgd2ViaWRsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0xNzE1ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy94aHIvZm9ybWRhdGEtZXhwZWN0ZWQudHh0
OgorCiAyMDIwLTA5LTMwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg
ICAgICBNZWRpYVJlY29yZGVyIHNob3VsZCBzdXBwb3J0IGlzVHlwZVN1cHBvcnRlZApkaWZmIC0t
Z2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvZm9y
bWRhdGEtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y
bS10ZXN0cy94aHIvZm9ybWRhdGEtZXhwZWN0ZWQudHh0CmluZGV4IDJiNmVhODJkM2Q2ZTkwMGVh
NTY2NDc2YWEyY2U1MDIyMmQxMWMwYzkuLjNiM2U5NjRmMjIzNDA2MGU0YzY2ZDg0NjljNWVhMTVi
NWE4MjMwNzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv
cm0tdGVzdHMveGhyL2Zvcm1kYXRhLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBv
cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9mb3JtZGF0YS1leHBlY3RlZC50eHQKQEAg
LTIsNyArMiw3IEBACiAKIAogCi1GQUlMIENvbnN0cnVjdG9ycyBzaG91bGQgdGhyb3cgYSB0eXBl
IGVycm9yIGFzc2VydF90aHJvd3NfanM6IGZ1bmN0aW9uICIoKSA9PiB7IG5ldyBGb3JtRGF0YShu
dWxsKTsgfSIgZGlkIG5vdCB0aHJvdworUEFTUyBDb25zdHJ1Y3RvcnMgc2hvdWxkIHRocm93IGEg
dHlwZSBlcnJvcgogUEFTUyBlbXB0eSBmb3JtZGF0YQogUEFTUyBmb3JtZGF0YSB3aXRoIHN0cmlu
ZwogUEFTUyBmb3JtZGF0YSB3aXRoIG5hbWVkIHN0cmluZwo=
</data>
<flag name="commit-queue"
          id="425980"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410126</attachid>
            <date>2020-09-30 08:54:33 -0700</date>
            <delta_ts>2020-09-30 09:42:35 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-171589-20200930165431.patch</filename>
            <type>text/plain</type>
            <size>4729</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVlNzQxMGNiMmMyZWYz
MTU3M2E1NTRmZTQyN2VmNzE4ZWViM2U3NS4uYzkzZDExMTIzZDNlNWNlNDE4ODVjY2UwMWI1YzQz
MmQ0Mjk0NTQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA5LTMwICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgdXBkYXRlIEZvcm1EYXRhIHRvIGxh
dGVzdCBzcGVjIHdlYmlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTcxNTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgV0lQCisKKyAgICAgICAgKiBodG1sL0RPTUZvcm1EYXRhLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OkRPTUZvcm1EYXRhOjpET01Gb3JtRGF0YSk6CisgICAgICAgICogaHRtbC9ET01G
b3JtRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6RE9NRm9ybURhdGE6OmNyZWF0ZSk6CisgICAg
ICAgICogaHRtbC9ET01Gb3JtRGF0YS5pZGw6CisKIDIwMjAtMDktMzAgIFphbGFuIEJ1anRhcyAg
PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIFJlbmFtZSBMaW5lQnJlYWtl
ciB0byBJbmxpbmVDb250ZW50QnJlYWtlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt
bC9ET01Gb3JtRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmNwcApp
bmRleCA4NGY3OTM5MjFmNDNmNWE2Yzc2NzAyYmViMjJlOWZjZTQ3YmExODM0Li4wMDM1NjFhMTg0
NTUxMWYzN2VmM2Q2YWJhMmI3NTY2MTUxNTI2ZTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9odG1sL0RPTUZvcm1EYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1E
YXRhLmNwcApAQCAtNDIsMTQgKzQyLDExIEBAIERPTUZvcm1EYXRhOjpET01Gb3JtRGF0YShjb25z
dCBUZXh0RW5jb2RpbmcmIGVuY29kaW5nKQogewogfQogCi1ET01Gb3JtRGF0YTo6RE9NRm9ybURh
dGEoSFRNTEZvcm1FbGVtZW50KiBmb3JtKQorRE9NRm9ybURhdGE6OkRPTUZvcm1EYXRhKGNvbnN0
IEhUTUxGb3JtRWxlbWVudCYgZm9ybSkKICAgICA6IG1fZW5jb2RpbmcoVVRGOEVuY29kaW5nKCkp
CiB7Ci0gICAgaWYgKCFmb3JtKQotICAgICAgICByZXR1cm47Ci0KICAgICBBU1NFUlQoaXNNYWlu
VGhyZWFkKCkpOwotICAgIGZvciAoYXV0byYgZWxlbWVudCA6IGZvcm0tPmNvcHlBc3NvY2lhdGVk
RWxlbWVudHNWZWN0b3IoKSkgeworICAgIGZvciAoYXV0byYgZWxlbWVudCA6IGZvcm0uY29weUFz
c29jaWF0ZWRFbGVtZW50c1ZlY3RvcigpKSB7CiAgICAgICAgIGlmICghZWxlbWVudC0+YXNIVE1M
RWxlbWVudCgpLmlzRGlzYWJsZWRGb3JtQ29udHJvbCgpKQogICAgICAgICAgICAgZWxlbWVudC0+
YXBwZW5kRm9ybURhdGEoKnRoaXMsIHRydWUpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURh
dGEuaAppbmRleCBjODA0ODhkNDQ4ZDI4OTIxYTJlMGQ3ZWMxZjYzNDZkZjFkMzQxMzRjLi40NjUy
YzVkOWE0ZTczMDVjMjZlYjY4MDkxNjllYmE3ODUzMjExZWI2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9ET01G
b3JtRGF0YS5oCkBAIC00OSw4ICs0OSw5IEBAIHB1YmxpYzoKICAgICAgICAgRm9ybURhdGFFbnRy
eVZhbHVlIGRhdGE7CiAgICAgfTsKIAotICAgIHN0YXRpYyBSZWY8RE9NRm9ybURhdGE+IGNyZWF0
ZShIVE1MRm9ybUVsZW1lbnQqIGZvcm0pIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgRE9NRm9ybURh
dGEoZm9ybSkpOyB9CisgICAgc3RhdGljIFJlZjxET01Gb3JtRGF0YT4gY3JlYXRlKGNvbnN0IEhU
TUxGb3JtRWxlbWVudCYgZm9ybSkgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBET01Gb3JtRGF0YShm
b3JtKSk7IH0KICAgICBzdGF0aWMgUmVmPERPTUZvcm1EYXRhPiBjcmVhdGUoY29uc3QgVGV4dEVu
Y29kaW5nJiBlbmNvZGluZykgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBET01Gb3JtRGF0YShlbmNv
ZGluZykpOyB9CisgICAgc3RhdGljIFJlZjxET01Gb3JtRGF0YT4gY3JlYXRlKCkgeyByZXR1cm4g
YWRvcHRSZWYoKm5ldyBET01Gb3JtRGF0YShVVEY4RW5jb2RpbmcoKSkpOyB9CiAKICAgICBjb25z
dCBWZWN0b3I8SXRlbT4mIGl0ZW1zKCkgY29uc3QgeyByZXR1cm4gbV9pdGVtczsgfQogICAgIGNv
bnN0IFRleHRFbmNvZGluZyYgZW5jb2RpbmcoKSBjb25zdCB7IHJldHVybiBtX2VuY29kaW5nOyB9
CkBAIC03Nyw3ICs3OCw3IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBleHBsaWNpdCBET01G
b3JtRGF0YShjb25zdCBUZXh0RW5jb2RpbmcmKTsKLSAgICBleHBsaWNpdCBET01Gb3JtRGF0YShI
VE1MRm9ybUVsZW1lbnQqKTsKKyAgICBleHBsaWNpdCBET01Gb3JtRGF0YShjb25zdCBIVE1MRm9y
bUVsZW1lbnQmKTsKIAogICAgIEl0ZW0gY3JlYXRlRmlsZUVudHJ5KGNvbnN0IFN0cmluZyYgbmFt
ZSwgQmxvYiYsIGNvbnN0IFN0cmluZyYgZmlsZW5hbWUpOwogICAgIHZvaWQgc2V0KGNvbnN0IFN0
cmluZyYgbmFtZSwgSXRlbSYmKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9N
Rm9ybURhdGEuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9ET01Gb3JtRGF0YS5pZGwKaW5kZXgg
Mjg1YzZkMjkxNjMzMTBmMzJiYTI2NjUxMGM0YjE0MTJiY2UxN2Q3NC4uNjVkZWExZDExZWRkODRi
YjQ0ZjA0ZDFkZDgwMmJhNzM3YzBjMTkwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt
bC9ET01Gb3JtRGF0YS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9ET01Gb3JtRGF0YS5p
ZGwKQEAgLTM3LDcgKzM3LDggQEAgdHlwZWRlZiAoRmlsZSBvciBVU1ZTdHJpbmcpIEZvcm1EYXRh
RW50cnlWYWx1ZTsKICAgICBJbnRlcmZhY2VOYW1lPUZvcm1EYXRhLAogICAgIEltcGxlbWVudGF0
aW9uTGFja3NWVGFibGUsCiBdIGludGVyZmFjZSBET01Gb3JtRGF0YSB7Ci0gICAgY29uc3RydWN0
b3Iob3B0aW9uYWwgSFRNTEZvcm1FbGVtZW50PyBmb3JtKTsKKyAgICBjb25zdHJ1Y3RvcigpOwor
ICAgIGNvbnN0cnVjdG9yKEhUTUxGb3JtRWxlbWVudCBmb3JtKTsKIAogICAgIHVuZGVmaW5lZCBh
cHBlbmQoVVNWU3RyaW5nIG5hbWUsIFVTVlN0cmluZyB2YWx1ZSk7CiAgICAgdW5kZWZpbmVkIGFw
cGVuZChVU1ZTdHJpbmcgbmFtZSwgQmxvYiBibG9iVmFsdWUsIG9wdGlvbmFsIFVTVlN0cmluZyBm
aWxlbmFtZSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9n
IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBlYTU1MDBmMDllMWFk
OTk1YTI0MjU5Nzk4NWEzNzQwZTg4M2M4NmVhLi4xM2ZhMjQwMTRhMDBkMWJlOTYzMjQ3MjIwYzE5
Y2NiMDM0Y2Y3NmQ5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl
TG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
MiBAQAorMjAyMC0wOS0zMCAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgorCisgICAgICAg
IHVwZGF0ZSBGb3JtRGF0YSB0byBsYXRlc3Qgc3BlYyB3ZWJpZGwKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTU4OQorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9m
b3JtZGF0YS1leHBlY3RlZC50eHQ6CisKIDIwMjAtMDktMzAgIFlvdWVubiBGYWJsZXQgIDx5b3Vl
bm5AYXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlhUmVjb3JkZXIgc2hvdWxkIHN1cHBvcnQgaXNU
eXBlU3VwcG9ydGVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs
YXRmb3JtLXRlc3RzL3hoci9mb3JtZGF0YS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBv
cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9mb3JtZGF0YS1leHBlY3RlZC50eHQKaW5k
ZXggMmI2ZWE4MmQzZDZlOTAwZWE1NjY0NzZhYTJjZTUwMjIyZDExYzBjOS4uM2IzZTk2NGYyMjM0
MDYwZTRjNjZkODQ2OWM1ZWExNWI1YTgyMzA3NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1w
b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvZm9ybWRhdGEtZXhwZWN0ZWQudHh0Cisr
KyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMveGhyL2Zvcm1k
YXRhLWV4cGVjdGVkLnR4dApAQCAtMiw3ICsyLDcgQEAKIAogCiAKLUZBSUwgQ29uc3RydWN0b3Jz
IHNob3VsZCB0aHJvdyBhIHR5cGUgZXJyb3IgYXNzZXJ0X3Rocm93c19qczogZnVuY3Rpb24gIigp
ID0+IHsgbmV3IEZvcm1EYXRhKG51bGwpOyB9IiBkaWQgbm90IHRocm93CitQQVNTIENvbnN0cnVj
dG9ycyBzaG91bGQgdGhyb3cgYSB0eXBlIGVycm9yCiBQQVNTIGVtcHR5IGZvcm1kYXRhCiBQQVNT
IGZvcm1kYXRhIHdpdGggc3RyaW5nCiBQQVNTIGZvcm1kYXRhIHdpdGggbmFtZWQgc3RyaW5nCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410131</attachid>
            <date>2020-09-30 09:42:38 -0700</date>
            <delta_ts>2020-10-01 20:53:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-171589-20200930174237.patch</filename>
            <type>text/plain</type>
            <size>4961</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVlNzQxMGNiMmMyZWYz
MTU3M2E1NTRmZTQyN2VmNzE4ZWViM2U3NS4uNzg1YzZlYjE0MjI5M2RmYzEzM2IwY2ZlMjYzYjgz
YmJjNGNhNjdlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA5LTMwICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgdXBkYXRlIEZvcm1EYXRhIHRvIGxh
dGVzdCBzcGVjIHdlYmlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTcxNTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgQ2hhbmdlIEZvcm1EYXRhIGNvbnRydWN0b3IgdG8gbm90IHRha2Ugb3B0aW9uYWws
IG51bGxhYmxlCisgICAgICAgIHBhcmFtZXRlci4KKworICAgICAgICBUZXN0OiBpbXBvcnRlZC93
M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9mb3JtZGF0YS5odG1sCisKKyAgICAgICAgKiBodG1s
L0RPTUZvcm1EYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTUZvcm1EYXRhOjpET01Gb3Jt
RGF0YSk6CisgICAgICAgICogaHRtbC9ET01Gb3JtRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6
RE9NRm9ybURhdGE6OmNyZWF0ZSk6CisgICAgICAgICogaHRtbC9ET01Gb3JtRGF0YS5pZGw6CisK
IDIwMjAtMDktMzAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb
TEZDXVtJRkNdIFJlbmFtZSBMaW5lQnJlYWtlciB0byBJbmxpbmVDb250ZW50QnJlYWtlcgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9ET01Gb3JtRGF0YS5jcHAgYi9Tb3VyY2UvV2Vi
Q29yZS9odG1sL0RPTUZvcm1EYXRhLmNwcAppbmRleCA4NGY3OTM5MjFmNDNmNWE2Yzc2NzAyYmVi
MjJlOWZjZTQ3YmExODM0Li4wMDM1NjFhMTg0NTUxMWYzN2VmM2Q2YWJhMmI3NTY2MTUxNTI2ZTRk
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmNwcAorKysgYi9T
b3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmNwcApAQCAtNDIsMTQgKzQyLDExIEBAIERP
TUZvcm1EYXRhOjpET01Gb3JtRGF0YShjb25zdCBUZXh0RW5jb2RpbmcmIGVuY29kaW5nKQogewog
fQogCi1ET01Gb3JtRGF0YTo6RE9NRm9ybURhdGEoSFRNTEZvcm1FbGVtZW50KiBmb3JtKQorRE9N
Rm9ybURhdGE6OkRPTUZvcm1EYXRhKGNvbnN0IEhUTUxGb3JtRWxlbWVudCYgZm9ybSkKICAgICA6
IG1fZW5jb2RpbmcoVVRGOEVuY29kaW5nKCkpCiB7Ci0gICAgaWYgKCFmb3JtKQotICAgICAgICBy
ZXR1cm47Ci0KICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwotICAgIGZvciAoYXV0byYgZWxl
bWVudCA6IGZvcm0tPmNvcHlBc3NvY2lhdGVkRWxlbWVudHNWZWN0b3IoKSkgeworICAgIGZvciAo
YXV0byYgZWxlbWVudCA6IGZvcm0uY29weUFzc29jaWF0ZWRFbGVtZW50c1ZlY3RvcigpKSB7CiAg
ICAgICAgIGlmICghZWxlbWVudC0+YXNIVE1MRWxlbWVudCgpLmlzRGlzYWJsZWRGb3JtQ29udHJv
bCgpKQogICAgICAgICAgICAgZWxlbWVudC0+YXBwZW5kRm9ybURhdGEoKnRoaXMsIHRydWUpOwog
ICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaCBiL1Nv
dXJjZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaAppbmRleCBjODA0ODhkNDQ4ZDI4OTIxYTJl
MGQ3ZWMxZjYzNDZkZjFkMzQxMzRjLi40NjUyYzVkOWE0ZTczMDVjMjZlYjY4MDkxNjllYmE3ODUz
MjExZWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTUZvcm1EYXRhLmgKKysr
IGIvU291cmNlL1dlYkNvcmUvaHRtbC9ET01Gb3JtRGF0YS5oCkBAIC00OSw4ICs0OSw5IEBAIHB1
YmxpYzoKICAgICAgICAgRm9ybURhdGFFbnRyeVZhbHVlIGRhdGE7CiAgICAgfTsKIAotICAgIHN0
YXRpYyBSZWY8RE9NRm9ybURhdGE+IGNyZWF0ZShIVE1MRm9ybUVsZW1lbnQqIGZvcm0pIHsgcmV0
dXJuIGFkb3B0UmVmKCpuZXcgRE9NRm9ybURhdGEoZm9ybSkpOyB9CisgICAgc3RhdGljIFJlZjxE
T01Gb3JtRGF0YT4gY3JlYXRlKGNvbnN0IEhUTUxGb3JtRWxlbWVudCYgZm9ybSkgeyByZXR1cm4g
YWRvcHRSZWYoKm5ldyBET01Gb3JtRGF0YShmb3JtKSk7IH0KICAgICBzdGF0aWMgUmVmPERPTUZv
cm1EYXRhPiBjcmVhdGUoY29uc3QgVGV4dEVuY29kaW5nJiBlbmNvZGluZykgeyByZXR1cm4gYWRv
cHRSZWYoKm5ldyBET01Gb3JtRGF0YShlbmNvZGluZykpOyB9CisgICAgc3RhdGljIFJlZjxET01G
b3JtRGF0YT4gY3JlYXRlKCkgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBET01Gb3JtRGF0YShVVEY4
RW5jb2RpbmcoKSkpOyB9CiAKICAgICBjb25zdCBWZWN0b3I8SXRlbT4mIGl0ZW1zKCkgY29uc3Qg
eyByZXR1cm4gbV9pdGVtczsgfQogICAgIGNvbnN0IFRleHRFbmNvZGluZyYgZW5jb2RpbmcoKSBj
b25zdCB7IHJldHVybiBtX2VuY29kaW5nOyB9CkBAIC03Nyw3ICs3OCw3IEBAIHB1YmxpYzoKIAog
cHJpdmF0ZToKICAgICBleHBsaWNpdCBET01Gb3JtRGF0YShjb25zdCBUZXh0RW5jb2RpbmcmKTsK
LSAgICBleHBsaWNpdCBET01Gb3JtRGF0YShIVE1MRm9ybUVsZW1lbnQqKTsKKyAgICBleHBsaWNp
dCBET01Gb3JtRGF0YShjb25zdCBIVE1MRm9ybUVsZW1lbnQmKTsKIAogICAgIEl0ZW0gY3JlYXRl
RmlsZUVudHJ5KGNvbnN0IFN0cmluZyYgbmFtZSwgQmxvYiYsIGNvbnN0IFN0cmluZyYgZmlsZW5h
bWUpOwogICAgIHZvaWQgc2V0KGNvbnN0IFN0cmluZyYgbmFtZSwgSXRlbSYmKTsKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaWRsIGIvU291cmNlL1dlYkNvcmUv
aHRtbC9ET01Gb3JtRGF0YS5pZGwKaW5kZXggMjg1YzZkMjkxNjMzMTBmMzJiYTI2NjUxMGM0YjE0
MTJiY2UxN2Q3NC4uZjM4MDA4NWExOWU1MDM2NmNhYzA5YWIwODk2YTFiNjhlMTljMzkwZSAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9ET01Gb3JtRGF0YS5pZGwKKysrIGIvU291cmNl
L1dlYkNvcmUvaHRtbC9ET01Gb3JtRGF0YS5pZGwKQEAgLTM3LDcgKzM3LDkgQEAgdHlwZWRlZiAo
RmlsZSBvciBVU1ZTdHJpbmcpIEZvcm1EYXRhRW50cnlWYWx1ZTsKICAgICBJbnRlcmZhY2VOYW1l
PUZvcm1EYXRhLAogICAgIEltcGxlbWVudGF0aW9uTGFja3NWVGFibGUsCiBdIGludGVyZmFjZSBE
T01Gb3JtRGF0YSB7Ci0gICAgY29uc3RydWN0b3Iob3B0aW9uYWwgSFRNTEZvcm1FbGVtZW50PyBm
b3JtKTsKKyAgICAvLyBGSVhNRTogc2hvdWxkIGJlIG9wdGlvbmFsIEhUTUxGb3JtRWxlbWVudC4K
KyAgICBjb25zdHJ1Y3RvcigpOworICAgIGNvbnN0cnVjdG9yKEhUTUxGb3JtRWxlbWVudCBmb3Jt
KTsKIAogICAgIHVuZGVmaW5lZCBhcHBlbmQoVVNWU3RyaW5nIG5hbWUsIFVTVlN0cmluZyB2YWx1
ZSk7CiAgICAgdW5kZWZpbmVkIGFwcGVuZChVU1ZTdHJpbmcgbmFtZSwgQmxvYiBibG9iVmFsdWUs
IG9wdGlvbmFsIFVTVlN0cmluZyBmaWxlbmFtZSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p
bXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxv
ZwppbmRleCBlYTU1MDBmMDllMWFkOTk1YTI0MjU5Nzk4NWEzNzQwZTg4M2M4NmVhLi4yOGVjNTAz
ZTdmMjA5MzYxYmI1YmQ2MzIwNjZiODJhNDcyOWYyMjAwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9D
aGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOS0zMCAgUm9iIEJ1aXMgIDxyYnVpc0Bp
Z2FsaWEuY29tPgorCisgICAgICAgIHVwZGF0ZSBGb3JtRGF0YSB0byBsYXRlc3Qgc3BlYyB3ZWJp
ZGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTU4
OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0
ZSBpbXByb3ZlZCB0ZXN0IHJlc3VsdC4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy94
aHIvZm9ybWRhdGEtZXhwZWN0ZWQudHh0OgorCiAyMDIwLTA5LTMwICBZb3Vlbm4gRmFibGV0ICA8
eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYVJlY29yZGVyIHNob3VsZCBzdXBwb3J0
IGlzVHlwZVN1cHBvcnRlZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl
Yi1wbGF0Zm9ybS10ZXN0cy94aHIvZm9ybWRhdGEtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv
aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvZm9ybWRhdGEtZXhwZWN0ZWQudHh0
CmluZGV4IDJiNmVhODJkM2Q2ZTkwMGVhNTY2NDc2YWEyY2U1MDIyMmQxMWMwYzkuLjNiM2U5NjRm
MjIzNDA2MGU0YzY2ZDg0NjljNWVhMTViNWE4MjMwNzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz
L2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMveGhyL2Zvcm1kYXRhLWV4cGVjdGVkLnR4
dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9m
b3JtZGF0YS1leHBlY3RlZC50eHQKQEAgLTIsNyArMiw3IEBACiAKIAogCi1GQUlMIENvbnN0cnVj
dG9ycyBzaG91bGQgdGhyb3cgYSB0eXBlIGVycm9yIGFzc2VydF90aHJvd3NfanM6IGZ1bmN0aW9u
ICIoKSA9PiB7IG5ldyBGb3JtRGF0YShudWxsKTsgfSIgZGlkIG5vdCB0aHJvdworUEFTUyBDb25z
dHJ1Y3RvcnMgc2hvdWxkIHRocm93IGEgdHlwZSBlcnJvcgogUEFTUyBlbXB0eSBmb3JtZGF0YQog
UEFTUyBmb3JtZGF0YSB3aXRoIHN0cmluZwogUEFTUyBmb3JtZGF0YSB3aXRoIG5hbWVkIHN0cmlu
Zwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410303</attachid>
            <date>2020-10-01 20:53:15 -0700</date>
            <delta_ts>2020-10-01 23:06:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-171589-20201002045314.patch</filename>
            <type>text/plain</type>
            <size>2939</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3ODY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2EyODgxYWNjNmQwZWUy
YTllZjkxYmNjYjM4YjJhMzdhNDhlNTE0Ny4uYzJmMjE5MWFkMTJlNDFiYjYwMTY3Y2UxYTM4MDc5
NGQwN2I5NTgwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTEwLTAxICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgdXBkYXRlIEZvcm1EYXRhIHRvIGxh
dGVzdCBzcGVjIHdlYmlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTcxNTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgQ2hhbmdlIEZvcm1EYXRhIGNvbnRydWN0b3IgdG8gbm90IHRha2Ugb3B0aW9uYWws
IG51bGxhYmxlCisgICAgICAgIHBhcmFtZXRlci4KKworICAgICAgICBUZXN0OiBpbXBvcnRlZC93
M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9mb3JtZGF0YS5odG1sCisKKyAgICAgICAgKiBodG1s
L0RPTUZvcm1EYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTUZvcm1EYXRhOjpET01Gb3Jt
RGF0YSk6CisgICAgICAgICogaHRtbC9ET01Gb3JtRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6
RE9NRm9ybURhdGE6OmNyZWF0ZSk6CisgICAgICAgICogaHRtbC9ET01Gb3JtRGF0YS5pZGw6CisK
IDIwMjAtMTAtMDEgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFtX
ZWJJRExdIEFkZCBzdXBwb3J0IGZvciBub24tbnVsbGFibGUgb3B0aW9uYWwgd3JhcHBlciB0eXBl
IGFyZ3VtZW50cyB0byBvcGVyYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s
L0RPTUZvcm1EYXRhLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURhdGEuaWRsCmlu
ZGV4IDI4NWM2ZDI5MTYzMzEwZjMyYmEyNjY1MTBjNGIxNDEyYmNlMTdkNzQuLjJmNTg3NDQwMTU4
NTk1MTlmZTU1ZmYzODQ0OGJjMWEyNmE2NDFhNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L2h0bWwvRE9NRm9ybURhdGEuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NRm9ybURh
dGEuaWRsCkBAIC0zNyw3ICszNyw3IEBAIHR5cGVkZWYgKEZpbGUgb3IgVVNWU3RyaW5nKSBGb3Jt
RGF0YUVudHJ5VmFsdWU7CiAgICAgSW50ZXJmYWNlTmFtZT1Gb3JtRGF0YSwKICAgICBJbXBsZW1l
bnRhdGlvbkxhY2tzVlRhYmxlLAogXSBpbnRlcmZhY2UgRE9NRm9ybURhdGEgewotICAgIGNvbnN0
cnVjdG9yKG9wdGlvbmFsIEhUTUxGb3JtRWxlbWVudD8gZm9ybSk7CisgICAgY29uc3RydWN0b3Io
b3B0aW9uYWwgSFRNTEZvcm1FbGVtZW50IGZvcm0pOwogCiAgICAgdW5kZWZpbmVkIGFwcGVuZChV
U1ZTdHJpbmcgbmFtZSwgVVNWU3RyaW5nIHZhbHVlKTsKICAgICB1bmRlZmluZWQgYXBwZW5kKFVT
VlN0cmluZyBuYW1lLCBCbG9iIGJsb2JWYWx1ZSwgb3B0aW9uYWwgVVNWU3RyaW5nIGZpbGVuYW1l
KTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlv
dXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGIzYjEwMThkZTdlYzNmZjliYWE1
MWUyNTMxNDlkY2E2NzZiMzJjN2YuLmVmZDcxNjI3Yzk4NTBjMmM0MTE5ZjYwMWEwZGI4ODU2Mzk1
YjUwNzMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysr
IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisy
MDIwLTEwLTAxICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgdXBkYXRl
IEZvcm1EYXRhIHRvIGxhdGVzdCBzcGVjIHdlYmlkbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGltcHJvdmVkIHRlc3QgcmVzdWx0LgorCisg
ICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9mb3JtZGF0YS1leHBlY3RlZC50eHQ6CisK
IDIwMjAtMTAtMDEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K
IAogICAgICAgICBOb24tc3BlY2lhbCBVUkxzIGFyZSBub3QgaWRlbXBvdGVudApkaWZmIC0tZ2l0
IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvZm9ybWRh
dGEtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10
ZXN0cy94aHIvZm9ybWRhdGEtZXhwZWN0ZWQudHh0CmluZGV4IDJiNmVhODJkM2Q2ZTkwMGVhNTY2
NDc2YWEyY2U1MDIyMmQxMWMwYzkuLjNiM2U5NjRmMjIzNDA2MGU0YzY2ZDg0NjljNWVhMTViNWE4
MjMwNzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t
dGVzdHMveGhyL2Zvcm1kYXRhLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRl
ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9mb3JtZGF0YS1leHBlY3RlZC50eHQKQEAgLTIs
NyArMiw3IEBACiAKIAogCi1GQUlMIENvbnN0cnVjdG9ycyBzaG91bGQgdGhyb3cgYSB0eXBlIGVy
cm9yIGFzc2VydF90aHJvd3NfanM6IGZ1bmN0aW9uICIoKSA9PiB7IG5ldyBGb3JtRGF0YShudWxs
KTsgfSIgZGlkIG5vdCB0aHJvdworUEFTUyBDb25zdHJ1Y3RvcnMgc2hvdWxkIHRocm93IGEgdHlw
ZSBlcnJvcgogUEFTUyBlbXB0eSBmb3JtZGF0YQogUEFTUyBmb3JtZGF0YSB3aXRoIHN0cmluZwog
UEFTUyBmb3JtZGF0YSB3aXRoIG5hbWVkIHN0cmluZwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>