171491 2017-05-01 01:27:43 -0700 [GTK] Two test started to fail after due to unhandled promise rejection reported after r215916 2017-05-02 00:54:40 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=150358 Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia joepeck bugs-noreply joepeck saam oldest_to_newest 1303205 0 cgarcia 2017-05-01 01:27:43 -0700 js/promises-tests/promises-tests-2-3-3.html media/video-fullscreen-restriction-removed.html https://build.webkit.org/results/GTK Linux 64-bit Release (Tests)/r216004 (842)/js/promises-tests/promises-tests-2-3-3-pretty-diff.html https://build.webkit.org/results/GTK Linux 64-bit Release (Tests)/r216004 (842)/media/video-fullscreen-restriction-removed-pretty-diff.html Other test expectation were updated to include such message, but I don't know id these test are expected to produce them or not. 1303208 1 cgarcia 2017-05-01 01:40:03 -0700 Expectations updated in r216011 1303388 2 joepeck 2017-05-01 14:12:16 -0700 Took me a while to realize those were links! I can address the js/promise-tests one by disabling unhandled rejection warnings. The media/video-fullscreen-restriction-removed.html case can be rebaselined. I'll address these as soon as my follow-up patch gets reviewed (as it affects the output here). 1303455 3 joepeck 2017-05-01 15:46:50 -0700 Looking into this now. 1303457 4 308778 joepeck 2017-05-01 15:50:56 -0700 Created attachment 308778 [PATCH] Proposed Fix 1303458 5 joepeck 2017-05-01 15:51:09 -0700 Err, I have to unskip now. 1303459 6 308779 joepeck 2017-05-01 15:52:11 -0700 Created attachment 308779 [PATCH] For landing 1303462 7 308779 joepeck 2017-05-01 15:53:17 -0700 Comment on attachment 308779 [PATCH] For landing Going to land this unreviewed as gardening. 1303464 8 joepeck 2017-05-01 15:54:47 -0700 <https://trac.webkit.org/changeset/216039> Unskipped and modified the tests/results. 1303610 9 cgarcia 2017-05-02 00:54:40 -0700 Thanks! 308778 2017-05-01 15:50:56 -0700 2017-05-01 15:52:11 -0700 [PATCH] Proposed Fix rebaseline-1.patch text/plain 2191 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NDYxZjg1MjFjNy4uZThjNDkyMWRhYzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAog MjAxNy0wNS0wMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAg ICAgIFtHVEtdIFR3byB0ZXN0IHN0YXJ0ZWQgdG8gZmFpbCBhZnRlciBkdWUgdG8gdW5oYW5kbGVk IHByb21pc2UgcmVqZWN0aW9uIHJlcG9ydGVkIGFmdGVyIHIyMTU5MTYKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTQ5MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICoganMvcHJvbWlzZXMtdGVzdHMvcHJv bWlzZXMtdGVzdHMtMi0zLTMuaHRtbDoKKyAgICAgICAgU2lsZW5jZSB1bmhhbmRsZWQgZXhwZWN0 YXRpb24gbWVzc2FnZXMgZm9yIHRoaXMgdGVzdC4KKworICAgICAgICAqIG1lZGlhL3ZpZGVvLWZ1 bGxzY3JlZW4tcmVzdHJpY3Rpb24tcmVtb3ZlZC1leHBlY3RlZC50eHQ6CisgICAgICAgIFJlYmFz ZWxpbmUgZXhwZWN0ZWQgcmVzdWx0cyB3aXRoIHVuaGFuZGxlZCBleHBlY3RhdGlvbiBtZXNzYWdl LgorCisyMDE3LTA1LTAxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisK ICAgICAgICAgUmVqZWN0ZWRQcm9taXNlVHJhY2tlciBzaG91bGQgcHJvZHVjZSBiZXR0ZXIgY2Fs bHN0YWNrcyBhbmQgYXZvaWQgY2FwdHVyaW5nIGNhbGxzdGFja3MgdW5sZXNzIHRoZXJlIGlzIGEg ZGVidWdnZXIvaW5zcGVjdG9yCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzE0MTYKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxODk5NDI1PgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvcHJvbWlzZXMtdGVzdHMvcHJvbWlzZXMtdGVzdHMtMi0z LTMuaHRtbCBiL0xheW91dFRlc3RzL2pzL3Byb21pc2VzLXRlc3RzL3Byb21pc2VzLXRlc3RzLTIt My0zLmh0bWwKaW5kZXggZWYxOWViYTI4ZjIuLjI4N2I5Y2RiMDQ5IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9qcy9wcm9taXNlcy10ZXN0cy9wcm9taXNlcy10ZXN0cy0yLTMtMy5odG1sCisrKyBi L0xheW91dFRlc3RzL2pzL3Byb21pc2VzLXRlc3RzL3Byb21pc2VzLXRlc3RzLTItMy0zLmh0bWwK QEAgLTEwLDYgKzEwLDkgQEAKIDxzY3JpcHQ+CiBkZXNjcmlwdGlvbignVGVzdCBQcm9taXNlIHdp dGggUHJvbWlzZSBBKyB0ZXN0cyAyLjMuMy4nKTsKIHdpbmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1 ZTsKKworLy8gU2lsZW5jZSB1bmhhbmRsZWQgcmVqZWN0aW9uIG1lc3NhZ2VzLgord2luZG93Lm9u dW5oYW5kbGVkcmVqZWN0aW9uID0gKCkgPT4gZmFsc2U7CiA8L3NjcmlwdD4KIDxzY3JpcHQgc3Jj PSJyZXNvdXJjZXMvbW9jaGEuanMiPjwvc2NyaXB0PgogPHNjcmlwdD4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL21lZGlhL3ZpZGVvLWZ1bGxzY3JlZW4tcmVzdHJpY3Rpb24tcmVtb3ZlZC1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1mdWxsc2NyZWVuLXJlc3RyaWN0aW9u LXJlbW92ZWQtZXhwZWN0ZWQudHh0CmluZGV4IDA3ODI1MDI2ZDU3Li42Zjg2YWVjYjg1OSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tZnVsbHNjcmVlbi1yZXN0cmljdGlvbi1y ZW1vdmVkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1mdWxsc2Ny ZWVuLXJlc3RyaWN0aW9uLXJlbW92ZWQtZXhwZWN0ZWQudHh0CkBAIC0xLDMgKzEsNCBAQAorQ09O U09MRSBNRVNTQUdFOiBVbmhhbmRsZWQgUHJvbWlzZSBSZWplY3Rpb246IE5vdEFsbG93ZWRFcnJv ciAoRE9NIEV4Y2VwdGlvbiAzNSk6IFRoZSByZXF1ZXN0IGlzIG5vdCBhbGxvd2VkIGJ5IHRoZSB1 c2VyIGFnZW50IG9yIHRoZSBwbGF0Zm9ybSBpbiB0aGUgY3VycmVudCBjb250ZXh0LCBwb3NzaWJs eSBiZWNhdXNlIHRoZSB1c2VyIGRlbmllZCBwZXJtaXNzaW9uLgogVGVzdCB0aGF0ICJmdWxsc2Ny ZWVuIHJlcXVpcmVzIHVzZXIgZ2VzdHVyZSByZXN0cmljdGlvbiIgaXMgcmVtb3ZlZCBieSBhIHVz ZXIgZ2VzdHVyZS4KIAogQ2xpY2sgbWUhCg== 308779 2017-05-01 15:52:11 -0700 2017-05-01 15:53:17 -0700 [PATCH] For landing rebaseline-2.patch text/plain 3084 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NDYxZjg1MjFjNy4uMTY0NjFjMTRiZGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAog MjAxNy0wNS0wMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAg ICAgIFtHVEtdIFR3byB0ZXN0IHN0YXJ0ZWQgdG8gZmFpbCBhZnRlciBkdWUgdG8gdW5oYW5kbGVk IHByb21pc2UgcmVqZWN0aW9uIHJlcG9ydGVkIGFmdGVyIHIyMTU5MTYKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTQ5MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICoganMvcHJvbWlzZXMtdGVzdHMvcHJv bWlzZXMtdGVzdHMtMi0zLTMuaHRtbDoKKyAgICAgICAgU2lsZW5jZSB1bmhhbmRsZWQgZXhwZWN0 YXRpb24gbWVzc2FnZXMgZm9yIHRoaXMgdGVzdC4KKworICAgICAgICAqIG1lZGlhL3ZpZGVvLWZ1 bGxzY3JlZW4tcmVzdHJpY3Rpb24tcmVtb3ZlZC1leHBlY3RlZC50eHQ6CisgICAgICAgIFJlYmFz ZWxpbmUgZXhwZWN0ZWQgcmVzdWx0cyB3aXRoIHVuaGFuZGxlZCBleHBlY3RhdGlvbiBtZXNzYWdl LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKKzIwMTctMDUt MDEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBSZWpl Y3RlZFByb21pc2VUcmFja2VyIHNob3VsZCBwcm9kdWNlIGJldHRlciBjYWxsc3RhY2tzIGFuZCBh dm9pZCBjYXB0dXJpbmcgY2FsbHN0YWNrcyB1bmxlc3MgdGhlcmUgaXMgYSBkZWJ1Z2dlci9pbnNw ZWN0b3IKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 MTQxNgogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzE4OTk0MjU+CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9qcy9wcm9taXNlcy10ZXN0cy9wcm9taXNlcy10ZXN0cy0yLTMtMy5odG1sIGIvTGF5 b3V0VGVzdHMvanMvcHJvbWlzZXMtdGVzdHMvcHJvbWlzZXMtdGVzdHMtMi0zLTMuaHRtbAppbmRl eCBlZjE5ZWJhMjhmMi4uMjg3YjljZGIwNDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL3By b21pc2VzLXRlc3RzL3Byb21pc2VzLXRlc3RzLTItMy0zLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv anMvcHJvbWlzZXMtdGVzdHMvcHJvbWlzZXMtdGVzdHMtMi0zLTMuaHRtbApAQCAtMTAsNiArMTAs OSBAQAogPHNjcmlwdD4KIGRlc2NyaXB0aW9uKCdUZXN0IFByb21pc2Ugd2l0aCBQcm9taXNlIEEr IHRlc3RzIDIuMy4zLicpOwogd2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworCisvLyBTaWxl bmNlIHVuaGFuZGxlZCByZWplY3Rpb24gbWVzc2FnZXMuCit3aW5kb3cub251bmhhbmRsZWRyZWpl Y3Rpb24gPSAoKSA9PiBmYWxzZTsKIDwvc2NyaXB0PgogPHNjcmlwdCBzcmM9InJlc291cmNlcy9t b2NoYS5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvdmlkZW8tZnVsbHNjcmVlbi1yZXN0cmljdGlvbi1yZW1vdmVkLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL21lZGlhL3ZpZGVvLWZ1bGxzY3JlZW4tcmVzdHJpY3Rpb24tcmVtb3ZlZC1leHBl Y3RlZC50eHQKaW5kZXggMDc4MjUwMjZkNTcuLjZmODZhZWNiODU5IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9tZWRpYS92aWRlby1mdWxsc2NyZWVuLXJlc3RyaWN0aW9uLXJlbW92ZWQtZXhwZWN0 ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWZ1bGxzY3JlZW4tcmVzdHJpY3Rp b24tcmVtb3ZlZC1leHBlY3RlZC50eHQKQEAgLTEsMyArMSw0IEBACitDT05TT0xFIE1FU1NBR0U6 IFVuaGFuZGxlZCBQcm9taXNlIFJlamVjdGlvbjogTm90QWxsb3dlZEVycm9yIChET00gRXhjZXB0 aW9uIDM1KTogVGhlIHJlcXVlc3QgaXMgbm90IGFsbG93ZWQgYnkgdGhlIHVzZXIgYWdlbnQgb3Ig dGhlIHBsYXRmb3JtIGluIHRoZSBjdXJyZW50IGNvbnRleHQsIHBvc3NpYmx5IGJlY2F1c2UgdGhl IHVzZXIgZGVuaWVkIHBlcm1pc3Npb24uCiBUZXN0IHRoYXQgImZ1bGxzY3JlZW4gcmVxdWlyZXMg dXNlciBnZXN0dXJlIHJlc3RyaWN0aW9uIiBpcyByZW1vdmVkIGJ5IGEgdXNlciBnZXN0dXJlLgog CiBDbGljayBtZSEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5k ZXggMzJmNGYzMjkyMDkuLjhlYjRkOGZhM2EyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv VGVzdEV4cGVjdGF0aW9ucwpAQCAtMzUyMCw5ICszNTIwLDYgQEAgd2Via2l0Lm9yZy9iLzE3MDA1 MyBtZWRpYS92aWRlby1sb2FkLXJlcXVpcmUtdXNlci1nZXN0dXJlLmh0bWwgWyBGYWlsdXJlIF0K IHdlYmtpdC5vcmcvYi8xNzAzMzUgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXR0ZXJuLmFuaW1h dGVkLmdpZi5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTcwMzM1IHN2Zy9hbmltYXRp b25zL2FuaW1hdGVkLXN2Zy1pbWFnZS1vdXRzaWRlLXZpZXdwb3J0LXBhdXNlZC5odG1sIFsgRmFp bHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xNzE0OTEganMvcHJvbWlzZXMtdGVzdHMvcHJvbWlzZXMt dGVzdHMtMi0zLTMuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE3MTQ5MSBtZWRpYS92 aWRlby1mdWxsc2NyZWVuLXJlc3RyaWN0aW9uLXJlbW92ZWQuaHRtbCBbIEZhaWx1cmUgXQotCiB3 ZWJraXQub3JnL2IvMTcxNDkyIHBsYXRmb3JtL2d0ay9mYXN0L2Zvcm1zL21lbnVsaXN0LXR5cGVh aGVhZC1maW5kLmh0bWwgWyBGYWlsdXJlIF0KIAogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8K