171273 2017-04-25 07:38:37 -0700 [GTK] -Wmissing-field-initializers triggered by RemoteInspectorServer.cpp:128 2017-05-10 07:26:58 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply buildbot cgarcia commit-queue keith_miller mark.lam mcatanzaro msaboff saam oldest_to_newest 1301004 0 mcatanzaro 2017-04-25 07:38:37 -0700 [1240/5820] Building CXX object Source...emote/glib/RemoteInspectorServer.cpp.o ../../Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp:128:1: warning: missing initializer for member ‘_GDBusInterfaceVTable::padding’ [-Wmissing-field-initializers] }; 1301006 1 308099 mcatanzaro 2017-04-25 07:39:27 -0700 Created attachment 308099 Patch 1301007 2 mcatanzaro 2017-04-25 07:41:26 -0700 This will obviously break if those padding values are ever used, but I think that's OK. It's not really possible to do better since it's a constant. 1301016 3 cgarcia 2017-04-25 08:15:26 -0700 (In reply to Michael Catanzaro from comment #2) > This will obviously break if those padding values are ever used, but I think > that's OK. It's not really possible to do better since it's a constant. Do we want to break the build with future glib versions only to fix a harmless warning? There are two more uses of _GDBusInterfaceVTable, btw. 1301025 4 mcatanzaro 2017-04-25 08:27:09 -0700 (In reply to Carlos Garcia Campos from comment #3) > (In reply to Michael Catanzaro from comment #2) > > This will obviously break if those padding values are ever used, but I think > > that's OK. It's not really possible to do better since it's a constant. > > Do we want to break the build with future glib versions only to fix a > harmless warning? There are two more uses of _GDBusInterfaceVTable, btw. This is the only case that's emitting a warning for me, so it's the only one I touched. Are other uses allocated differently? Yes, we definitely want to break future versions of GLib. It's very easy for us to modify the structure initialization in the future if new members are added, which is not even particularly likely. Keeping the build free from warnings is very important; we can't see important warnings if we don't fix smaller ones like this. 1301030 5 cgarcia 2017-04-25 08:37:50 -0700 (In reply to Michael Catanzaro from comment #4) > (In reply to Carlos Garcia Campos from comment #3) > > (In reply to Michael Catanzaro from comment #2) > > > This will obviously break if those padding values are ever used, but I think > > > that's OK. It's not really possible to do better since it's a constant. > > > > Do we want to break the build with future glib versions only to fix a > > harmless warning? There are two more uses of _GDBusInterfaceVTable, btw. > > This is the only case that's emitting a warning for me, so it's the only one > I touched. Are other uses allocated differently? Nope, we use the same pattern in RemoteInspector, RemoteInspectorServer and RemoteinspectorClient 1306382 6 309497 mcatanzaro 2017-05-09 08:22:41 -0700 Created attachment 309497 Patch 1306832 7 309497 commit-queue 2017-05-10 07:26:56 -0700 Comment on attachment 309497 Patch Clearing flags on attachment: 309497 Committed r216582: <http://trac.webkit.org/changeset/216582> 1306833 8 commit-queue 2017-05-10 07:26:58 -0700 All reviewed patches have been landed. Closing bug. 308099 2017-04-25 07:39:27 -0700 2017-05-09 08:22:39 -0700 Patch bug-171273-20170425093926.patch text/plain 1395 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 MjM3OThiMjMyY2RhOWYzODFkZWJmMDhlMGU2NTIxMWRkZDZkMmFjLi40ZGY5MGY2YzEwOGMzODMw MGQxNWZmZWU5NzFiY2ZjMDA2MmQ0YTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNy0wNC0yNSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gLVdtaXNzaW5nLWZpZWxkLWluaXRpYWxpemVycyB0 cmlnZ2VyZWQgYnkgUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcDoxMjgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTI3MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9nbGli L1JlbW90ZUluc3BlY3RvclNlcnZlci5jcHA6CisKIDIwMTctMDQtMjUgIFphbiBEb2JlcnNlayAg PHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFthYXJjaDY0XSBtb3ZlQ29uZGl0aW9u YWxseTMyKCksIG1vdmVDb25kaXRpb25hbGx5VGVzdDMyKCkgc2hvdWxkIG1vdmUgZnJvbS90byA2 NC1iaXQgcmVnaXN0ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL3JlbW90ZS9nbGliL1JlbW90ZUluc3BlY3RvclNlcnZlci5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9nbGliL1JlbW90ZUluc3BlY3RvclNlcnZlci5jcHAK aW5kZXggYjY2OWJmNGJkMTZkNGIzYmNmYzZiOGFjNzgyOTU1ODc0MmYwODIzNS4uZTM0NDAxNzMz MWUxMWEwOTI5NmYyOTBkZDc2Njk2MjViMzBkZDFiZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvZ2xpYi9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2dsaWIvUmVtb3Rl SW5zcGVjdG9yU2VydmVyLmNwcApAQCAtMTI1LDYgKzEyNSw4IEBAIGNvbnN0IEdEQnVzSW50ZXJm YWNlVlRhYmxlIFJlbW90ZUluc3BlY3RvclNlcnZlcjo6c19pbnRlcmZhY2VWVGFibGUgPSB7CiAg ICAgbnVsbHB0ciwKICAgICAvLyBzZXRfcHJvcGVydHkKICAgICBudWxscHRyLAorICAgIC8vIHBh ZGRpbmcKKyAgICBudWxscHRyCiB9OwogCiBSZW1vdGVJbnNwZWN0b3JTZXJ2ZXImIFJlbW90ZUlu c3BlY3RvclNlcnZlcjo6c2luZ2xldG9uKCkK 309497 2017-05-09 08:22:41 -0700 2017-05-10 07:26:56 -0700 Patch bug-171273-20170509102240.patch text/plain 3395 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw YTYyZWFlNDJiMGQ2YjFkMzRjZDRkZGMzODM1YzI3OTk2ZTI5MDFjLi5iOGEwZmJiMDM3ZDQyNGFk ZDcyYTE0YTE5OTkzNjJhZDY1YzI1YWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNy0wNS0wOSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gLVdtaXNzaW5nLWZpZWxkLWluaXRpYWxpemVycyB0 cmlnZ2VyZWQgYnkgUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcDoxMjgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTI3MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9nbGli L1JlbW90ZUluc3BlY3RvckdsaWIuY3BwOgorICAgICAgICAqIGluc3BlY3Rvci9yZW1vdGUvZ2xp Yi9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwOgorCiAyMDE3LTA1LTA5ICBZdXN1a2UgU3V6dWtp ICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIEhhbmRsZSBJRExQcm9taXNlPD4g cHJvcGVybHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwppbmRleCBhZWIzMWQxNjUyZGM0ODFmYjRjMzRiNzc4YjA5MjdjZDY3 NWEyMjRiLi5jYTM2NjhiMDQ2OWY5MGE4Y2FjYjA0ZTljNGYyYjRjMjkwZmM1ZDlhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDUtMDkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNh dGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIC1XbWlzc2luZy1maWVsZC1pbml0 aWFsaXplcnMgdHJpZ2dlcmVkIGJ5IFJlbW90ZUluc3BlY3RvclNlcnZlci5jcHA6MTI4CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzEyNzMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9n bGliL1JlbW90ZUluc3BlY3RvckNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUlu c3BlY3RvckNsaWVudDo6UmVtb3RlSW5zcGVjdG9yQ2xpZW50KToKKwogMjAxNy0wNS0wOSAgWW9z aGlha2kgSml0c3VrYXdhICA8WW9zaGlha2kuSml0c3VrYXdhQHNvbnkuY29tPgogCiAgICAgICAg IFtDb29yZGluYXRlZCBHcmFwaGljc10gRGVidWcgVmlzdWFscyBkb24ndCBoaWRlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9nbGliL1JlbW90ZUlu c3BlY3RvckdsaWIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUv Z2xpYi9SZW1vdGVJbnNwZWN0b3JHbGliLmNwcAppbmRleCBkYzAyOTVlZTFjM2UzZTUyMjMwYWUw YTFkMWEyNjIwZDY1OGUzNWE0Li40ZGMxMTlmYTUwYjk5NGIxZDA4Y2Y1NWM0YjkyYTc5YWU3ZjMy MGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9n bGliL1JlbW90ZUluc3BlY3RvckdsaWIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvcmVtb3RlL2dsaWIvUmVtb3RlSW5zcGVjdG9yR2xpYi5jcHAKQEAgLTE1Miw2ICsx NTIsOCBAQCBjb25zdCBHREJ1c0ludGVyZmFjZVZUYWJsZSBSZW1vdGVJbnNwZWN0b3I6OnNfaW50 ZXJmYWNlVlRhYmxlID0gewogICAgIG51bGxwdHIsCiAgICAgLy8gc2V0X3Byb3BlcnR5CiAgICAg bnVsbHB0ciwKKyAgICAvLyBwYWRkaW5nCisgICAgbnVsbHB0cgogfTsKIAogdm9pZCBSZW1vdGVJ bnNwZWN0b3I6OnNldHVwQ29ubmVjdGlvbihHUmVmUHRyPEdEQnVzQ29ubmVjdGlvbj4mJiBjb25u ZWN0aW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1v dGUvZ2xpYi9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9yZW1vdGUvZ2xpYi9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIuY3BwCmluZGV4IDQ0 N2JhZTlkMzk4ZGNiY2UzY2E2MDI2MWRlY2E0ZjEyMTc4YTBjNWQuLjUyMGI1NTQ3ZGRmZDE1NTg5 MjQ2N2YyZTFjOGRkMjA5YjI3MTVmNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvcmVtb3RlL2dsaWIvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9nbGliL1JlbW90ZUluc3BlY3Rv clNlcnZlci5jcHAKQEAgLTEzMSw2ICsxMzEsOCBAQCBjb25zdCBHREJ1c0ludGVyZmFjZVZUYWJs ZSBSZW1vdGVJbnNwZWN0b3JTZXJ2ZXI6OnNfaW50ZXJmYWNlVlRhYmxlID0gewogICAgIG51bGxw dHIsCiAgICAgLy8gc2V0X3Byb3BlcnR5CiAgICAgbnVsbHB0ciwKKyAgICAvLyBwYWRkaW5nCisg ICAgbnVsbHB0cgogfTsKIAogUmVtb3RlSW5zcGVjdG9yU2VydmVyJiBSZW1vdGVJbnNwZWN0b3JT ZXJ2ZXI6OnNpbmdsZXRvbigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Z2xpYi9SZW1vdGVJbnNwZWN0b3JDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2dsaWIvUmVtb3RlSW5zcGVjdG9yQ2xpZW50LmNwcAppbmRleCBkZjg3YWQ1ZDkwYmY0MzY5YTc0 ZmI3OGM2MDQxZjM4MWZhNjMwMDQ5Li5kZGQ0YmQ3NzI1MDRmNzQ5NjBhMmYxZTk2NGRiY2FmOTFh ZmNiZjdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ2xpYi9SZW1vdGVJ bnNwZWN0b3JDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9nbGliL1Jl bW90ZUluc3BlY3RvckNsaWVudC5jcHAKQEAgLTE1MCw2ICsxNTAsOCBAQCBjb25zdCBHREJ1c0lu dGVyZmFjZVZUYWJsZSBSZW1vdGVJbnNwZWN0b3JDbGllbnQ6OnNfaW50ZXJmYWNlVlRhYmxlID0g ewogICAgIG51bGxwdHIsCiAgICAgLy8gc2V0X3Byb3BlcnR5CiAgICAgbnVsbHB0ciwKKyAgICAv LyBwYWRkaW5nCisgICAgbnVsbHB0cgogfTsKIAogUmVtb3RlSW5zcGVjdG9yQ2xpZW50OjpSZW1v dGVJbnNwZWN0b3JDbGllbnQoY29uc3QgY2hhciogYWRkcmVzcywgdW5zaWduZWQgcG9ydCwgUmVt b3RlSW5zcGVjdG9yT2JzZXJ2ZXImIG9ic2VydmVyKQo=