171059 2017-04-20 09:34:09 -0700 LayoutTests crypto/subtle/ecdsa-generate-key-sign-verify-p384.html and crypto/subtle/ecdsa-generate-key-sign-verify-p256.html are flaky failures 2017-06-12 13:36:11 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad jiewen_tan bfulgham commit-queue jiewen_tan webkit-bug-importer oldest_to_newest 1299136 0 ryanhaddad 2017-04-20 09:34:09 -0700 LayoutTests crypto/subtle/ecdsa-generate-key-sign-verify-p384.html and crypto/subtle/ecdsa-generate-key-sign-verify-p256.html are flaky failures https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=crypto%2Fsubtle%2Fecdsa- --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/crypto/subtle/ecdsa-generate-key-sign-verify-p384-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/crypto/subtle/ecdsa-generate-key-sign-verify-p384-actual.txt @@ -7,7 +7,7 @@ Signing PASS signature.byteLength is 96 Verifying -PASS verified is true +FAIL verified should be true. Was false. PASS successfullyParsed is true TEST COMPLETE --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/crypto/subtle/ecdsa-generate-key-sign-verify-p256-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/crypto/subtle/ecdsa-generate-key-sign-verify-p256-actual.txt @@ -7,7 +7,7 @@ Signing PASS signature.byteLength is 64 Verifying -PASS verified is true +FAIL verified should be true. Was false. PASS successfullyParsed is true TEST COMPLETE 1299137 1 webkit-bug-importer 2017-04-20 09:34:58 -0700 <rdar://problem/31734958> 1299166 2 ryanhaddad 2017-04-20 10:50:28 -0700 Marked tests as flaky in https://trac.webkit.org/changeset/215563/webkit 1300623 3 jiewen_tan 2017-04-24 12:51:51 -0700 *** Bug 170921 has been marked as a duplicate of this bug. *** 1300658 4 308009 jiewen_tan 2017-04-24 14:11:49 -0700 Created attachment 308009 Patch 1300667 5 308011 jiewen_tan 2017-04-24 14:41:14 -0700 Created attachment 308011 Patch 1300749 6 308011 bfulgham 2017-04-24 17:19:17 -0700 Comment on attachment 308011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308011&action=review Looks fine, but I think you might want to clean up the code a little. r=me with cleanups tp signECDSA. > Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:92 > + size_t pos = newSignature.size(); Isn't pos always zero here, since you only reserved capacity above, and did not actually fill the vector with anything? > Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:97 > + // Otherwise skipping the leading 0s of r. // Otherwise skip the leading 0s of r. > Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:98 > + if (signature[offset] > keyLengthInBytes) Should this be "else if"? > Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:113 > + // Otherwise skipping the leading 0s of s. "// Otherwise skip the leading 0s of s." 1300760 7 308011 jiewen_tan 2017-04-24 17:41:55 -0700 Comment on attachment 308011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308011&action=review Thanks Brent for r+ my patch. >> Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:92 >> + size_t pos = newSignature.size(); > > Isn't pos always zero here, since you only reserved capacity above, and did not actually fill the vector with anything? True. I just want to make it more general. I can remove pos under this check completely. >> Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:97 >> + // Otherwise skipping the leading 0s of r. > > // Otherwise skip the leading 0s of r. Fixed. >> Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:98 >> + if (signature[offset] > keyLengthInBytes) > > Should this be "else if"? I remember there is style check on if ... else ... We can only do 'if ... else if ... else ...' not 'if ... else if ...'. Maybe I am wrong. Let me double check. >> Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:113 >> + // Otherwise skipping the leading 0s of s. > > "// Otherwise skip the leading 0s of s." Fixed. 1300802 8 308043 jiewen_tan 2017-04-24 18:58:24 -0700 Created attachment 308043 Patch for landing 1300894 9 308043 commit-queue 2017-04-24 22:10:03 -0700 Comment on attachment 308043 Patch for landing Clearing flags on attachment: 308043 Committed r215721: <http://trac.webkit.org/changeset/215721> 308009 2017-04-24 14:11:49 -0700 2017-04-24 14:41:13 -0700 Patch bug-171059-20170424141148.patch text/plain 3612 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmMxZGE0ZDZjYzNiMGVj NDUzYzBlMThhYWQwZGNiZjE1Nzg2OTI3NC4uYmU1NGIxNzM2ZGY4MDk1ODZhMzhkN2I4OTNlMmQz ODg2YzA1Y2UyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTI0ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdHMgY3J5 cHRvL3N1YnRsZS9lY2RzYS1nZW5lcmF0ZS1rZXktc2lnbi12ZXJpZnktcDM4NC5odG1sIGFuZCBj cnlwdG8vc3VidGxlL2VjZHNhLWdlbmVyYXRlLWtleS1zaWduLXZlcmlmeS1wMjU2Lmh0bWwgYXJl IGZsYWt5IGZhaWx1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzEwNTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxNzM0OTU4PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBjcnlwdG8vbWFjL0NyeXB0b0FsZ29yaXRobUVDRFNB TWFjLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNpZ25FQ0RTQSk6CisgICAgICAgIEVuaGFuY2Ug d2F5cyB0byBjb252ZXJ0IHRoZSBERVIgc2lnbmF0dXJlcyBwcm9kdWNlZCBmcm9tIENvbW1vbkNy eXB0byB0byByfHxzLgorCiAyMDE3LTA0LTE4ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxl LmNvbT4KIAogICAgICAgICBFbmFibGUgb3B0aW1pemVkIGxheWVyIGZsdXNoZXMgb24gaU9TCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vbWFjL0NyeXB0b0FsZ29yaXRobUVDRFNB TWFjLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtRUNEU0FN YWMuY3BwCmluZGV4IGIwNDQwYmI2NTliY2EzNTA1ZGM4NDUzMjg3NjRjOWI1ZGMxYjRmMTYuLjhi YTVhY2FjODYxNGVjNzEzNWQ0OWY4ODk3ZTM0MjRmMzE0ZjlhMzQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2NyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtRUNEU0FNYWMuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2NyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtRUNEU0FNYWMuY3BwCkBAIC04 NCwxNiArODQsMzggQEAgc3RhdGljIEV4Y2VwdGlvbk9yPFZlY3Rvcjx1aW50OF90Pj4gc2lnbkVD RFNBKENyeXB0b0FsZ29yaXRobUlkZW50aWZpZXIgaGFzaCwgY28KICAgICAvLyBjb252ZXJ0IHRo ZSBERVIgYmluYXJ5IGludG8gciArIHMKICAgICBWZWN0b3I8dWludDhfdD4gbmV3U2lnbmF0dXJl OwogICAgIG5ld1NpZ25hdHVyZS5yZXNlcnZlQ2FwYWNpdHkoa2V5TGVuZ3RoSW5CeXRlcyAqIDIp OwotICAgIHNpemVfdCBvZmZzZXQgPSA0OwotICAgIGlmIChzaWduYXR1cmVbb2Zmc2V0XSA9PSBJ bml0aWFsT2N0ZXQpCi0gICAgICAgIG9mZnNldCArPSAxOwotICAgIEFTU0VSVF9XSVRIX1NFQ1VS SVRZX0lNUExJQ0FUSU9OKHNpZ25hdHVyZS5zaXplKCkgPiBvZmZzZXQgKyBrZXlMZW5ndGhJbkJ5 dGVzKTsKLSAgICBuZXdTaWduYXR1cmUuYXBwZW5kKHNpZ25hdHVyZS5kYXRhKCkgKyBvZmZzZXQs IGtleUxlbmd0aEluQnl0ZXMpOwotICAgIG9mZnNldCArPSBrZXlMZW5ndGhJbkJ5dGVzICsgMjsK LSAgICBpZiAoc2lnbmF0dXJlW29mZnNldF0gPT0gSW5pdGlhbE9jdGV0KQotICAgICAgICBvZmZz ZXQgKz0gMTsKLSAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihzaWduYXR1cmUu c2l6ZSgpID49IG9mZnNldCArIGtleUxlbmd0aEluQnl0ZXMpOwotICAgIG5ld1NpZ25hdHVyZS5h cHBlbmQoc2lnbmF0dXJlLmRhdGEoKSArIG9mZnNldCwga2V5TGVuZ3RoSW5CeXRlcyk7CisgICAg c2l6ZV90IG9mZnNldCA9IDM7IC8vIHNraXAgdGFnLCBsZW5ndGgsIHRhZworCisgICAgLy8gSWYg ciA8IGtleUxlbmd0aEluQnl0ZXMsIGZpbGwgdGhlIGhlYWQgb2YgciB3aXRoIDBzLgorICAgIHNp emVfdCBieXRlc1RvQ29weSA9IGtleUxlbmd0aEluQnl0ZXM7CisgICAgaWYgKHNpZ25hdHVyZVtv ZmZzZXRdIDwga2V5TGVuZ3RoSW5CeXRlcykgeworICAgICAgICBzaXplX3QgcG9zID0gbmV3U2ln bmF0dXJlLnNpemUoKTsKKyAgICAgICAgbmV3U2lnbmF0dXJlLnJlc2l6ZShwb3MgKyBrZXlMZW5n dGhJbkJ5dGVzIC0gc2lnbmF0dXJlW29mZnNldF0pOworICAgICAgICBtZW1zZXQobmV3U2lnbmF0 dXJlLmRhdGEoKSArIHBvcywgSW5pdGlhbE9jdGV0LCBrZXlMZW5ndGhJbkJ5dGVzIC0gc2lnbmF0 dXJlW29mZnNldF0pOworICAgICAgICBieXRlc1RvQ29weSA9IHNpZ25hdHVyZVtvZmZzZXRdOwor ICAgIH0KKyAgICAvLyBPdGhlcndpc2Ugc2tpcHBpbmcgdGhlIGxlYWRpbmcgMHMgb2Ygci4KKyAg ICBpZiAoc2lnbmF0dXJlW29mZnNldF0gPiBrZXlMZW5ndGhJbkJ5dGVzKQorICAgICAgICBvZmZz ZXQgKz0gc2lnbmF0dXJlW29mZnNldF0gLSBrZXlMZW5ndGhJbkJ5dGVzOworICAgIG9mZnNldCsr OyAvLyBza2lwIGxlbmd0aAorICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKHNp Z25hdHVyZS5zaXplKCkgPiBvZmZzZXQgKyBieXRlc1RvQ29weSk7CisgICAgbmV3U2lnbmF0dXJl LmFwcGVuZChzaWduYXR1cmUuZGF0YSgpICsgb2Zmc2V0LCBieXRlc1RvQ29weSk7CisgICAgb2Zm c2V0ICs9IGJ5dGVzVG9Db3B5ICsgMTsgLy8gc2tpcCByLCB0YWcKKworICAgIC8vIElmIHMgPCBr ZXlMZW5ndGhJbkJ5dGVzLCBmaWxsIHRoZSBoZWFkIG9mIHMgd2l0aCAwcy4KKyAgICBieXRlc1Rv Q29weSA9IGtleUxlbmd0aEluQnl0ZXM7CisgICAgaWYgKHNpZ25hdHVyZVtvZmZzZXRdIDwga2V5 TGVuZ3RoSW5CeXRlcykgeworICAgICAgICBzaXplX3QgcG9zID0gbmV3U2lnbmF0dXJlLnNpemUo KTsKKyAgICAgICAgbmV3U2lnbmF0dXJlLnJlc2l6ZShwb3MgKyBrZXlMZW5ndGhJbkJ5dGVzIC0g c2lnbmF0dXJlW29mZnNldF0pOworICAgICAgICBtZW1zZXQobmV3U2lnbmF0dXJlLmRhdGEoKSAr IHBvcywgSW5pdGlhbE9jdGV0LCBrZXlMZW5ndGhJbkJ5dGVzIC0gc2lnbmF0dXJlW29mZnNldF0p OworICAgICAgICBieXRlc1RvQ29weSA9IHNpZ25hdHVyZVtvZmZzZXRdOworICAgIH0KKyAgICAv LyBPdGhlcndpc2Ugc2tpcHBpbmcgdGhlIGxlYWRpbmcgMHMgb2Ygcy4KKyAgICBpZiAoc2lnbmF0 dXJlW29mZnNldF0gPiBrZXlMZW5ndGhJbkJ5dGVzKQorICAgICAgICBvZmZzZXQgKz0gc2lnbmF0 dXJlW29mZnNldF0gLSBrZXlMZW5ndGhJbkJ5dGVzOworICAgIG9mZnNldCsrOyAvLyBza2lwIGxl bmd0aAorICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKHNpZ25hdHVyZS5zaXpl KCkgPj0gb2Zmc2V0ICsgYnl0ZXNUb0NvcHkpOworICAgIG5ld1NpZ25hdHVyZS5hcHBlbmQoc2ln bmF0dXJlLmRhdGEoKSArIG9mZnNldCwgYnl0ZXNUb0NvcHkpOwogCiAgICAgcmV0dXJuIFdURk1v dmUobmV3U2lnbmF0dXJlKTsKIH0K 308011 2017-04-24 14:41:14 -0700 2017-04-24 17:19:17 -0700 Patch bug-171059-20170424144113.patch text/plain 5223 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1Njk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTkyODhiMjUwMzkxNWVi ZDA2OTYyMTY4YTEwZTcyYmFhMWIxNGI1YS4uYmI5N2U4YjAyYmM1NmQ4MjYyYzM0NDI0Y2NiOGFi YWFmMDI3YzM2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTI0ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdHMgY3J5 cHRvL3N1YnRsZS9lY2RzYS1nZW5lcmF0ZS1rZXktc2lnbi12ZXJpZnktcDM4NC5odG1sIGFuZCBj cnlwdG8vc3VidGxlL2VjZHNhLWdlbmVyYXRlLWtleS1zaWduLXZlcmlmeS1wMjU2Lmh0bWwgYXJl IGZsYWt5IGZhaWx1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzEwNTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxNzM0OTU4PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBjcnlwdG8vbWFjL0NyeXB0b0FsZ29yaXRobUVDRFNB TWFjLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNpZ25FQ0RTQSk6CisgICAgICAgIEVuaGFuY2Ug d2F5cyB0byBjb252ZXJ0IHRoZSBERVIgc2lnbmF0dXJlcyBwcm9kdWNlZCBmcm9tIENvbW1vbkNy eXB0byB0byByfHxzLgorCiAyMDE3LTA0LTI0ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBbbWFjT1NdIEZpeCB0d28gbWlub3IgaXNzdWVzIHdpdGggTWVkaWFTZWxl Y3Rpb25PcHRpb246OlR5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9tYWMv Q3J5cHRvQWxnb3JpdGhtRUNEU0FNYWMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL21hYy9D cnlwdG9BbGdvcml0aG1FQ0RTQU1hYy5jcHAKaW5kZXggYjA0NDBiYjY1OWJjYTM1MDVkYzg0NTMy ODc2NGM5YjVkYzFiNGYxNi4uOGJhNWFjYWM4NjE0ZWM3MTM1ZDQ5Zjg4OTdlMzQyNGYzMTRmOWEz NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3J5cHRvL21hYy9DcnlwdG9BbGdvcml0aG1F Q0RTQU1hYy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL21hYy9DcnlwdG9BbGdvcml0 aG1FQ0RTQU1hYy5jcHAKQEAgLTg0LDE2ICs4NCwzOCBAQCBzdGF0aWMgRXhjZXB0aW9uT3I8VmVj dG9yPHVpbnQ4X3Q+PiBzaWduRUNEU0EoQ3J5cHRvQWxnb3JpdGhtSWRlbnRpZmllciBoYXNoLCBj bwogICAgIC8vIGNvbnZlcnQgdGhlIERFUiBiaW5hcnkgaW50byByICsgcwogICAgIFZlY3Rvcjx1 aW50OF90PiBuZXdTaWduYXR1cmU7CiAgICAgbmV3U2lnbmF0dXJlLnJlc2VydmVDYXBhY2l0eShr ZXlMZW5ndGhJbkJ5dGVzICogMik7Ci0gICAgc2l6ZV90IG9mZnNldCA9IDQ7Ci0gICAgaWYgKHNp Z25hdHVyZVtvZmZzZXRdID09IEluaXRpYWxPY3RldCkKLSAgICAgICAgb2Zmc2V0ICs9IDE7Ci0g ICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oc2lnbmF0dXJlLnNpemUoKSA+IG9m ZnNldCArIGtleUxlbmd0aEluQnl0ZXMpOwotICAgIG5ld1NpZ25hdHVyZS5hcHBlbmQoc2lnbmF0 dXJlLmRhdGEoKSArIG9mZnNldCwga2V5TGVuZ3RoSW5CeXRlcyk7Ci0gICAgb2Zmc2V0ICs9IGtl eUxlbmd0aEluQnl0ZXMgKyAyOwotICAgIGlmIChzaWduYXR1cmVbb2Zmc2V0XSA9PSBJbml0aWFs T2N0ZXQpCi0gICAgICAgIG9mZnNldCArPSAxOwotICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lN UExJQ0FUSU9OKHNpZ25hdHVyZS5zaXplKCkgPj0gb2Zmc2V0ICsga2V5TGVuZ3RoSW5CeXRlcyk7 Ci0gICAgbmV3U2lnbmF0dXJlLmFwcGVuZChzaWduYXR1cmUuZGF0YSgpICsgb2Zmc2V0LCBrZXlM ZW5ndGhJbkJ5dGVzKTsKKyAgICBzaXplX3Qgb2Zmc2V0ID0gMzsgLy8gc2tpcCB0YWcsIGxlbmd0 aCwgdGFnCisKKyAgICAvLyBJZiByIDwga2V5TGVuZ3RoSW5CeXRlcywgZmlsbCB0aGUgaGVhZCBv ZiByIHdpdGggMHMuCisgICAgc2l6ZV90IGJ5dGVzVG9Db3B5ID0ga2V5TGVuZ3RoSW5CeXRlczsK KyAgICBpZiAoc2lnbmF0dXJlW29mZnNldF0gPCBrZXlMZW5ndGhJbkJ5dGVzKSB7CisgICAgICAg IHNpemVfdCBwb3MgPSBuZXdTaWduYXR1cmUuc2l6ZSgpOworICAgICAgICBuZXdTaWduYXR1cmUu cmVzaXplKHBvcyArIGtleUxlbmd0aEluQnl0ZXMgLSBzaWduYXR1cmVbb2Zmc2V0XSk7CisgICAg ICAgIG1lbXNldChuZXdTaWduYXR1cmUuZGF0YSgpICsgcG9zLCBJbml0aWFsT2N0ZXQsIGtleUxl bmd0aEluQnl0ZXMgLSBzaWduYXR1cmVbb2Zmc2V0XSk7CisgICAgICAgIGJ5dGVzVG9Db3B5ID0g c2lnbmF0dXJlW29mZnNldF07CisgICAgfQorICAgIC8vIE90aGVyd2lzZSBza2lwcGluZyB0aGUg bGVhZGluZyAwcyBvZiByLgorICAgIGlmIChzaWduYXR1cmVbb2Zmc2V0XSA+IGtleUxlbmd0aElu Qnl0ZXMpCisgICAgICAgIG9mZnNldCArPSBzaWduYXR1cmVbb2Zmc2V0XSAtIGtleUxlbmd0aElu Qnl0ZXM7CisgICAgb2Zmc2V0Kys7IC8vIHNraXAgbGVuZ3RoCisgICAgQVNTRVJUX1dJVEhfU0VD VVJJVFlfSU1QTElDQVRJT04oc2lnbmF0dXJlLnNpemUoKSA+IG9mZnNldCArIGJ5dGVzVG9Db3B5 KTsKKyAgICBuZXdTaWduYXR1cmUuYXBwZW5kKHNpZ25hdHVyZS5kYXRhKCkgKyBvZmZzZXQsIGJ5 dGVzVG9Db3B5KTsKKyAgICBvZmZzZXQgKz0gYnl0ZXNUb0NvcHkgKyAxOyAvLyBza2lwIHIsIHRh ZworCisgICAgLy8gSWYgcyA8IGtleUxlbmd0aEluQnl0ZXMsIGZpbGwgdGhlIGhlYWQgb2YgcyB3 aXRoIDBzLgorICAgIGJ5dGVzVG9Db3B5ID0ga2V5TGVuZ3RoSW5CeXRlczsKKyAgICBpZiAoc2ln bmF0dXJlW29mZnNldF0gPCBrZXlMZW5ndGhJbkJ5dGVzKSB7CisgICAgICAgIHNpemVfdCBwb3Mg PSBuZXdTaWduYXR1cmUuc2l6ZSgpOworICAgICAgICBuZXdTaWduYXR1cmUucmVzaXplKHBvcyAr IGtleUxlbmd0aEluQnl0ZXMgLSBzaWduYXR1cmVbb2Zmc2V0XSk7CisgICAgICAgIG1lbXNldChu ZXdTaWduYXR1cmUuZGF0YSgpICsgcG9zLCBJbml0aWFsT2N0ZXQsIGtleUxlbmd0aEluQnl0ZXMg LSBzaWduYXR1cmVbb2Zmc2V0XSk7CisgICAgICAgIGJ5dGVzVG9Db3B5ID0gc2lnbmF0dXJlW29m ZnNldF07CisgICAgfQorICAgIC8vIE90aGVyd2lzZSBza2lwcGluZyB0aGUgbGVhZGluZyAwcyBv ZiBzLgorICAgIGlmIChzaWduYXR1cmVbb2Zmc2V0XSA+IGtleUxlbmd0aEluQnl0ZXMpCisgICAg ICAgIG9mZnNldCArPSBzaWduYXR1cmVbb2Zmc2V0XSAtIGtleUxlbmd0aEluQnl0ZXM7CisgICAg b2Zmc2V0Kys7IC8vIHNraXAgbGVuZ3RoCisgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElD QVRJT04oc2lnbmF0dXJlLnNpemUoKSA+PSBvZmZzZXQgKyBieXRlc1RvQ29weSk7CisgICAgbmV3 U2lnbmF0dXJlLmFwcGVuZChzaWduYXR1cmUuZGF0YSgpICsgb2Zmc2V0LCBieXRlc1RvQ29weSk7 CiAKICAgICByZXR1cm4gV1RGTW92ZShuZXdTaWduYXR1cmUpOwogfQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg4MjhkZTVk MTQ4MjViMDcwYjBiN2IwNDEyYzE2ZDIwMjcwNGFhZDEuLjJkNGRmMDdmZTAyMmRlMDU3MzQwZjBm ZWQ2MzU5OTU3ZGViZmI0ZTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNy0wNC0yNCAgSmll d2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgorCisgICAgICAgIExheW91dFRlc3RzIGNy eXB0by9zdWJ0bGUvZWNkc2EtZ2VuZXJhdGUta2V5LXNpZ24tdmVyaWZ5LXAzODQuaHRtbCBhbmQg Y3J5cHRvL3N1YnRsZS9lY2RzYS1nZW5lcmF0ZS1rZXktc2lnbi12ZXJpZnktcDI1Ni5odG1sIGFy ZSBmbGFreSBmYWlsdXJlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTcxMDU5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMTczNDk1OD4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RFeHBlY3Rh dGlvbnM6CisgICAgICAgIFJlbW92ZSB0ZXN0IGV4cGVjdGF0aW9ucy4KKwogMjAxNy0wNC0yNCAg U2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjIGRlYnVnXSBM YXlvdXRUZXN0IHdvcmtlcnMvd2FzbS1sb25nLWNvbXBpbGUtbWFueS5odG1sIGlzIGEgZmxha3kg dGltZW91dApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91 dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNDFlYmM4NmQ3NzMzZGIzNWQ0OWM1NjBmYjY3 NTM0YWIwMDBiODI3My4uYmM0NWM0ZWVjNzg2OWQ2NTg5M2JkODQ5YmZlOTJlNDNmNzI4NmFhNCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0 cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMjg4LDkgKzEyODgsNCBAQCB3ZWJraXQub3JnL2IvMTcw NzA0IHdlYnJ0Yy92aWRlby1tdXRlLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3ZWJraXQub3Jn L2IvMTcxMDMxIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvWE1MSHR0cFJlcXVlc3Qv Z2V0YWxscmVzcG9uc2VoZWFkZXJzLWNsLmh0bSBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2Iv MTcxMDU5IGNyeXB0by9zdWJ0bGUvZWNkc2EtZ2VuZXJhdGUta2V5LXNpZ24tdmVyaWZ5LXAzODQu aHRtbCBbIFBhc3MgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTcxMDU5IGNyeXB0by9zdWJ0bGUv ZWNkc2EtZ2VuZXJhdGUta2V5LXNpZ24tdmVyaWZ5LXAyNTYuaHRtbCBbIFBhc3MgRmFpbHVyZSBd Ci0KLXdlYmtpdC5vcmcvYi8xNzA5MjEgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9X ZWJDcnlwdG9BUEkvc2lnbl92ZXJpZnkvZWNkc2Eud29ya2VyLmh0bWwgWyBQYXNzIEZhaWx1cmUg XQotCiB3ZWJraXQub3JnL2IvMTcwNzAxIHdlYnJ0Yy9kYXRhY2hhbm5lbC9idWZmZXJlZEFtb3Vu dExvd1RocmVzaG9sZC5odG1sIFsgUGFzcyBGYWlsdXJlIF0K 308043 2017-04-24 18:58:24 -0700 2017-04-24 22:10:03 -0700 Patch for landing bug-171059-20170424185824.patch text/plain 5232 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1NzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjYwYjg2NjA1N2RlMTE0 NTU2YjhlODY5N2IwM2YzNGZhYTJmODgxNy4uODUyNTAzOTVmZjcwMzNlZjFhNTc0M2ExYmQyY2U2 Nzk0ZWEzMTM4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTI0ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdHMgY3J5 cHRvL3N1YnRsZS9lY2RzYS1nZW5lcmF0ZS1rZXktc2lnbi12ZXJpZnktcDM4NC5odG1sIGFuZCBj cnlwdG8vc3VidGxlL2VjZHNhLWdlbmVyYXRlLWtleS1zaWduLXZlcmlmeS1wMjU2Lmh0bWwgYXJl IGZsYWt5IGZhaWx1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzEwNTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxNzM0OTU4PgorCisgICAg ICAgIFJldmlld2VkIGJ5IEJyZW50IEZ1bGdoYW0uCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlz dGluZyB0ZXN0cy4KKworICAgICAgICAqIGNyeXB0by9tYWMvQ3J5cHRvQWxnb3JpdGhtRUNEU0FN YWMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2lnbkVDRFNBKToKKyAgICAgICAgRW5oYW5jZSB3 YXlzIHRvIGNvbnZlcnQgdGhlIERFUiBzaWduYXR1cmVzIHByb2R1Y2VkIGZyb20gQ29tbW9uQ3J5 cHRvIHRvIHJ8fHMuCisKIDIwMTctMDQtMjQgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxs YXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ0ddIFByb3ZpZGUgYSB0eXBlIGlkZW50aWZpZXIg aGludCB0byB0aGUgQ0dJbWFnZVNvdXJjZSBzbyBnZXR0aW5nIHRoZSB0eXBlIGlkZW50aWZpZXIg aXMgbW9yZSBhY2N1cmF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3J5cHRvL21hYy9D cnlwdG9BbGdvcml0aG1FQ0RTQU1hYy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vbWFjL0Ny eXB0b0FsZ29yaXRobUVDRFNBTWFjLmNwcAppbmRleCBiMDQ0MGJiNjU5YmNhMzUwNWRjODQ1MzI4 NzY0YzliNWRjMWI0ZjE2Li4zYWY3ZDAyMzdmZTExNmUzY2FhOTc0ZTBhOTc4MjNmNzU1ZGY3YWFm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vbWFjL0NyeXB0b0FsZ29yaXRobUVD RFNBTWFjLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8vbWFjL0NyeXB0b0FsZ29yaXRo bUVDRFNBTWFjLmNwcApAQCAtODQsMTYgKzg0LDMzIEBAIHN0YXRpYyBFeGNlcHRpb25PcjxWZWN0 b3I8dWludDhfdD4+IHNpZ25FQ0RTQShDcnlwdG9BbGdvcml0aG1JZGVudGlmaWVyIGhhc2gsIGNv CiAgICAgLy8gY29udmVydCB0aGUgREVSIGJpbmFyeSBpbnRvIHIgKyBzCiAgICAgVmVjdG9yPHVp bnQ4X3Q+IG5ld1NpZ25hdHVyZTsKICAgICBuZXdTaWduYXR1cmUucmVzZXJ2ZUNhcGFjaXR5KGtl eUxlbmd0aEluQnl0ZXMgKiAyKTsKLSAgICBzaXplX3Qgb2Zmc2V0ID0gNDsKLSAgICBpZiAoc2ln bmF0dXJlW29mZnNldF0gPT0gSW5pdGlhbE9jdGV0KQotICAgICAgICBvZmZzZXQgKz0gMTsKLSAg ICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihzaWduYXR1cmUuc2l6ZSgpID4gb2Zm c2V0ICsga2V5TGVuZ3RoSW5CeXRlcyk7Ci0gICAgbmV3U2lnbmF0dXJlLmFwcGVuZChzaWduYXR1 cmUuZGF0YSgpICsgb2Zmc2V0LCBrZXlMZW5ndGhJbkJ5dGVzKTsKLSAgICBvZmZzZXQgKz0ga2V5 TGVuZ3RoSW5CeXRlcyArIDI7Ci0gICAgaWYgKHNpZ25hdHVyZVtvZmZzZXRdID09IEluaXRpYWxP Y3RldCkKLSAgICAgICAgb2Zmc2V0ICs9IDE7Ci0gICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1Q TElDQVRJT04oc2lnbmF0dXJlLnNpemUoKSA+PSBvZmZzZXQgKyBrZXlMZW5ndGhJbkJ5dGVzKTsK LSAgICBuZXdTaWduYXR1cmUuYXBwZW5kKHNpZ25hdHVyZS5kYXRhKCkgKyBvZmZzZXQsIGtleUxl bmd0aEluQnl0ZXMpOworICAgIHNpemVfdCBvZmZzZXQgPSAzOyAvLyBza2lwIHRhZywgbGVuZ3Ro LCB0YWcKKworICAgIC8vIElmIHIgPCBrZXlMZW5ndGhJbkJ5dGVzLCBmaWxsIHRoZSBoZWFkIG9m IHIgd2l0aCAwcy4KKyAgICBzaXplX3QgYnl0ZXNUb0NvcHkgPSBrZXlMZW5ndGhJbkJ5dGVzOwor ICAgIGlmIChzaWduYXR1cmVbb2Zmc2V0XSA8IGtleUxlbmd0aEluQnl0ZXMpIHsKKyAgICAgICAg bmV3U2lnbmF0dXJlLnJlc2l6ZShrZXlMZW5ndGhJbkJ5dGVzIC0gc2lnbmF0dXJlW29mZnNldF0p OworICAgICAgICBtZW1zZXQobmV3U2lnbmF0dXJlLmRhdGEoKSwgSW5pdGlhbE9jdGV0LCBrZXlM ZW5ndGhJbkJ5dGVzIC0gc2lnbmF0dXJlW29mZnNldF0pOworICAgICAgICBieXRlc1RvQ29weSA9 IHNpZ25hdHVyZVtvZmZzZXRdOworICAgIH0gZWxzZSBpZiAoc2lnbmF0dXJlW29mZnNldF0gPiBr ZXlMZW5ndGhJbkJ5dGVzKSAvLyBPdGhlcndpc2Ugc2tpcCB0aGUgbGVhZGluZyAwcyBvZiByLgor ICAgICAgICBvZmZzZXQgKz0gc2lnbmF0dXJlW29mZnNldF0gLSBrZXlMZW5ndGhJbkJ5dGVzOwor ICAgIG9mZnNldCsrOyAvLyBza2lwIGxlbmd0aAorICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lN UExJQ0FUSU9OKHNpZ25hdHVyZS5zaXplKCkgPiBvZmZzZXQgKyBieXRlc1RvQ29weSk7CisgICAg bmV3U2lnbmF0dXJlLmFwcGVuZChzaWduYXR1cmUuZGF0YSgpICsgb2Zmc2V0LCBieXRlc1RvQ29w eSk7CisgICAgb2Zmc2V0ICs9IGJ5dGVzVG9Db3B5ICsgMTsgLy8gc2tpcCByLCB0YWcKKworICAg IC8vIElmIHMgPCBrZXlMZW5ndGhJbkJ5dGVzLCBmaWxsIHRoZSBoZWFkIG9mIHMgd2l0aCAwcy4K KyAgICBieXRlc1RvQ29weSA9IGtleUxlbmd0aEluQnl0ZXM7CisgICAgaWYgKHNpZ25hdHVyZVtv ZmZzZXRdIDwga2V5TGVuZ3RoSW5CeXRlcykgeworICAgICAgICBzaXplX3QgcG9zID0gbmV3U2ln bmF0dXJlLnNpemUoKTsKKyAgICAgICAgbmV3U2lnbmF0dXJlLnJlc2l6ZShwb3MgKyBrZXlMZW5n dGhJbkJ5dGVzIC0gc2lnbmF0dXJlW29mZnNldF0pOworICAgICAgICBtZW1zZXQobmV3U2lnbmF0 dXJlLmRhdGEoKSArIHBvcywgSW5pdGlhbE9jdGV0LCBrZXlMZW5ndGhJbkJ5dGVzIC0gc2lnbmF0 dXJlW29mZnNldF0pOworICAgICAgICBieXRlc1RvQ29weSA9IHNpZ25hdHVyZVtvZmZzZXRdOwor ICAgIH0gZWxzZSBpZiAoc2lnbmF0dXJlW29mZnNldF0gPiBrZXlMZW5ndGhJbkJ5dGVzKSAvLyBP dGhlcndpc2Ugc2tpcCB0aGUgbGVhZGluZyAwcyBvZiBzLgorICAgICAgICBvZmZzZXQgKz0gc2ln bmF0dXJlW29mZnNldF0gLSBrZXlMZW5ndGhJbkJ5dGVzOworICAgIG9mZnNldCsrOyAvLyBza2lw IGxlbmd0aAorICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKHNpZ25hdHVyZS5z aXplKCkgPj0gb2Zmc2V0ICsgYnl0ZXNUb0NvcHkpOworICAgIG5ld1NpZ25hdHVyZS5hcHBlbmQo c2lnbmF0dXJlLmRhdGEoKSArIG9mZnNldCwgYnl0ZXNUb0NvcHkpOwogCiAgICAgcmV0dXJuIFdU Rk1vdmUobmV3U2lnbmF0dXJlKTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxY2Q1NzcwMjM0ZDllZmZjNzFiMWUzYzJm N2MwNzhhMDE3NDFjNTcyLi40NWVjOGQ0NWVjY2JkNTk5ZThkZjMzZGY4MGI1NDE4MzZkZDRkYzU1 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDQtMjQgIEppZXdlbiBUYW4gIDxqaWV3ZW5f dGFuQGFwcGxlLmNvbT4KKworICAgICAgICBMYXlvdXRUZXN0cyBjcnlwdG8vc3VidGxlL2VjZHNh LWdlbmVyYXRlLWtleS1zaWduLXZlcmlmeS1wMzg0Lmh0bWwgYW5kIGNyeXB0by9zdWJ0bGUvZWNk c2EtZ2VuZXJhdGUta2V5LXNpZ24tdmVyaWZ5LXAyNTYuaHRtbCBhcmUgZmxha3kgZmFpbHVyZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTA1OQor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzE3MzQ5NTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg QnJlbnQgRnVsZ2hhbS4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgIFJl bW92ZSB0ZXN0IGV4cGVjdGF0aW9ucy4KKwogMjAxNy0wNC0yNCAgTmFuIFdhbmcgIDxuX3dhbmdA YXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBDcmFzaCBhdCBXZWJDb3JlOjpBWE9iamVjdENhY2hl OjpjaGFyYWN0ZXJPZmZzZXRGb3JJbmRleChpbnQsIFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmpl Y3QgY29uc3QqKSArIDcwMwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9u cyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNDFlYmM4NmQ3NzMzZGIzNWQ0 OWM1NjBmYjY3NTM0YWIwMDBiODI3My4uYmM0NWM0ZWVjNzg2OWQ2NTg5M2JkODQ5YmZlOTJlNDNm NzI4NmFhNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9M YXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMjg4LDkgKzEyODgsNCBAQCB3ZWJraXQu b3JnL2IvMTcwNzA0IHdlYnJ0Yy92aWRlby1tdXRlLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3 ZWJraXQub3JnL2IvMTcxMDMxIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvWE1MSHR0 cFJlcXVlc3QvZ2V0YWxscmVzcG9uc2VoZWFkZXJzLWNsLmh0bSBbIEZhaWx1cmUgXQogCi13ZWJr aXQub3JnL2IvMTcxMDU5IGNyeXB0by9zdWJ0bGUvZWNkc2EtZ2VuZXJhdGUta2V5LXNpZ24tdmVy aWZ5LXAzODQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTcxMDU5IGNyeXB0 by9zdWJ0bGUvZWNkc2EtZ2VuZXJhdGUta2V5LXNpZ24tdmVyaWZ5LXAyNTYuaHRtbCBbIFBhc3Mg RmFpbHVyZSBdCi0KLXdlYmtpdC5vcmcvYi8xNzA5MjEgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9XZWJDcnlwdG9BUEkvc2lnbl92ZXJpZnkvZWNkc2Eud29ya2VyLmh0bWwgWyBQYXNz IEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTcwNzAxIHdlYnJ0Yy9kYXRhY2hhbm5lbC9idWZm ZXJlZEFtb3VudExvd1RocmVzaG9sZC5odG1sIFsgUGFzcyBGYWlsdXJlIF0K