17082 2008-01-29 15:07:08 -0800 Acid3 bug: CSS objects in Webkit are not "live" 2008-02-10 14:33:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://acid3.acidtests.org/ HasReduction P2 Normal --- 17064 1 eric hyatt webkit oldest_to_newest 68725 0 eric 2008-01-29 15:07:08 -0800 WebKit fails Acid3's modification of style blocks text node test This will require some reduction. It might be a bug in the test. Test 73: Undefined value function () { // test 73: dynamic modification of <style> blocks' text nodes, from Jonas Sicking and Garret Smith var doc = kungFuDeathGrip.childNodes[3].contentDocument; assert(doc, "missing document for test"); assert(doc.images[0], "prerequisite failed: no image"); assertEquals(doc.images[0].height, 10, "prerequisite failed: style didn't affect image"); assertEquals(doc.styleSheets[0].href, null, "internal stylesheet had a URI"); doc.styleSheets[0].ownerNode.firstChild.data = "img { height: 20px; }"; assertEquals(doc.images[0].height, 20, "change failed to take effect"); doc.styleSheets[0].ownerNode.appendChild(doc.createTextNode("img { height: 30px; }")); assertEquals(doc.images[0].height, 30, "append failed to take effect"); var rules = doc.styleSheets.cssRules; // "All CSS objects in the DOM are "live"" says section 2.1, Overview of the DOM Level 2 CSS Interfaces doc.styleSheets[0].insertRule("img { height: 40px; }", 2); assertEquals(doc.images[0].height, 40, "insertRule failed to take effect"); assertEquals(doc.styleSheets.cssRules.length, rules.length, "cssRules isn't live"); return 5; }, 68783 1 eric 2008-01-30 01:17:57 -0800 We'll need to build this into a nice stand-alone test case. 69342 2 18905 webkit 2008-02-04 05:22:53 -0800 Created attachment 18905 minimal test case 69343 3 webkit 2008-02-04 05:33:53 -0800 The acid3 test 73 was changed a little: function () { // test 73: dynamic modification of <style> blocks' text nodes, from Jonas Sicking and Garret Smith var doc = kungFuDeathGrip.childNodes[3].contentDocument; assert(doc, "missing document for test"); assert(doc.images[0], "prerequisite failed: no image"); assertEquals(doc.images[0].height, 10, "prerequisite failed: style didn't affect image"); doc.styleSheets[0].ownerNode.firstChild.data = "img { height: 20px; }"; assertEquals(doc.images[0].height, 20, "change failed to take effect"); doc.styleSheets[0].ownerNode.appendChild(doc.createTextNode("img { height: 30px; }")); assertEquals(doc.images[0].height, 30, "append failed to take effect"); var rules = doc.styleSheets[0].cssRules; // "All CSS objects in the DOM are "live"" says section 2.1, Overview of the DOM Level 2 CSS Interfaces doc.styleSheets[0].insertRule("img { height: 40px; }", 2); assertEquals(doc.images[0].height, 40, "insertRule failed to take effect"); assertEquals(doc.styleSheets[0].cssRules.length, 3, "count of rules is wrong"); assertEquals(rules.length, 3, "cssRules isn't live"); // while we're at it, check some other things on doc.styleSheets: assert(doc.styleSheets[0].href === null, "internal stylesheet had a URI: " + doc.styleSheets[0].href); assert(document.styleSheets[0].href === null, "internal acid3 stylesheet had a URI: " + document.styleSheets[0].href); return 5; }, 70025 4 hyatt 2008-02-10 02:54:56 -0800 I'm working on this one. Nearly have a fix ready. 70026 5 19034 hyatt 2008-02-10 03:02:11 -0800 Created attachment 19034 Make the rules list live for stylesheets. This code is just a huge mess. This is the minimal surgery that I had to do to get this working (and should perform better). The old code copied all of the rules into a separate list. The new code will not do this if a StyleList is available, unless the IE rules() extension is being used (and charset rules have to be omitted). In the longer term, this class could be fixed to just always reference StyleLists and to never have its own internal list. It would have to operate a bit more like a collection in that case (knowing to skip charset rules if created as an IE rules() extension list). 70128 6 19034 oliver 2008-02-10 13:30:10 -0800 Comment on attachment 19034 Make the rules list live for stylesheets. Testcases amd changelogs are your friend :p 70139 7 hyatt 2008-02-10 14:33:40 -0800 Fixed in r30130. 18905 2008-02-04 05:22:53 -0800 2008-02-04 05:22:53 -0800 minimal test case test-case.html text/html 543 webkit PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIiAiaHR0cDov L3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+CjxodG1sPgo8aGVhZD4KCTx0aXRsZT5U ZXN0IGNhc2UgZm9yIGJ1ZyAxNzA4MjwvdGl0bGU+Cgk8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgoJ PC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPiAK IHZhciBydWxlcyA9IGRvY3VtZW50LnN0eWxlU2hlZXRzWzBdLmNzc1J1bGVzOwogZG9jdW1lbnQu c3R5bGVTaGVldHNbMF0uaW5zZXJ0UnVsZSgiaW1nIHsgaGVpZ2h0OiA0MHB4OyB9IiwgMCk7CiBp ZiAoZG9jdW1lbnQuc3R5bGVTaGVldHNbMF0uY3NzUnVsZXMubGVuZ3RoICYmIHJ1bGVzLmxlbmd0 aCkgZG9jdW1lbnQud3JpdGUoIjxwPlRlc3Q6IFBBU1NFRDwvcD4iKTsgZWxzZSBkb2N1bWVudC53 cml0ZSgiPHAgc3R5bGU9XCJiYWNrZ3JvdW5kLWNvbG9yOnJlZDtcIj5UZXN0OiBGQUlMRUQ8L3A+ Iik7Cjwvc2NyaXB0PgoKPC9ib2R5Pgo8L2h0bWw+ 19034 2008-02-10 03:02:11 -0800 2008-02-10 13:30:10 -0800 Make the rules list live for stylesheets. patch.txt text/plain 2766 hyatt SW5kZXg6IGNzcy9DU1NSdWxlTGlzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY3NzL0NTU1J1bGVMaXN0 LmNwcAkocmV2aXNpb24gMzAxMTEpCisrKyBjc3MvQ1NTUnVsZUxpc3QuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNSwxMSArMzUsMTMgQEAgQ1NTUnVsZUxpc3Q6OkNTU1J1bGVMaXN0KCkKIAogQ1NT UnVsZUxpc3Q6OkNTU1J1bGVMaXN0KFN0eWxlTGlzdCogbGlzdCwgYm9vbCBvbWl0Q2hhcnNldFJ1 bGVzKQogewotICAgIGlmIChsaXN0KSB7CisgICAgbV9saXN0ID0gbGlzdDsKKyAgICBpZiAobGlz dCAmJiBvbWl0Q2hhcnNldFJ1bGVzKSB7CisgICAgICAgIG1fbGlzdCA9IDA7CiAgICAgICAgIHVu c2lnbmVkIGxlbiA9IGxpc3QtPmxlbmd0aCgpOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAw OyBpIDwgbGVuOyArK2kpIHsKICAgICAgICAgICAgIFN0eWxlQmFzZSogc3R5bGUgPSBsaXN0LT5p dGVtKGkpOwotICAgICAgICAgICAgaWYgKHN0eWxlLT5pc1J1bGUoKSAmJiAhKG9taXRDaGFyc2V0 UnVsZXMgJiYgc3R5bGUtPmlzQ2hhcnNldFJ1bGUoKSkpCisgICAgICAgICAgICBpZiAoc3R5bGUt PmlzUnVsZSgpICYmICFzdHlsZS0+aXNDaGFyc2V0UnVsZSgpKQogICAgICAgICAgICAgICAgIGFw cGVuZChzdGF0aWNfY2FzdDxDU1NSdWxlKj4oc3R5bGUpKTsKICAgICAgICAgfQogICAgIH0KQEAg LTUyLDggKzU0LDI0IEBAIENTU1J1bGVMaXN0Ojp+Q1NTUnVsZUxpc3QoKQogICAgICAgICBydWxl LT5kZXJlZigpOwogfQogCit1bnNpZ25lZCBDU1NSdWxlTGlzdDo6bGVuZ3RoKCkgY29uc3QKK3sK KyAgICByZXR1cm4gbV9saXN0ID8gbV9saXN0LT5sZW5ndGgoKSA6IG1fbHN0Q1NTUnVsZXMuY291 bnQoKTsKK30KKworQ1NTUnVsZSogQ1NTUnVsZUxpc3Q6Oml0ZW0odW5zaWduZWQgaW5kZXgpCit7 CisgICAgaWYgKG1fbGlzdCkgeworICAgICAgICBTdHlsZUJhc2UqIHJ1bGUgPSBtX2xpc3QtPml0 ZW0oaW5kZXgpOworICAgICAgICBBU1NFUlQoIXJ1bGUgfHwgcnVsZS0+aXNSdWxlKCkpOworICAg ICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8Q1NTUnVsZSo+KHJ1bGUpOworICAgIH0KKyAgICByZXR1 cm4gbV9sc3RDU1NSdWxlcy5hdChpbmRleCk7Cit9CisKIHZvaWQgQ1NTUnVsZUxpc3Q6OmRlbGV0 ZVJ1bGUodW5zaWduZWQgaW5kZXgpCiB7CisgICAgQVNTRVJUKCFtX2xpc3QpOwogICAgIENTU1J1 bGUqIHJ1bGUgPSBtX2xzdENTU1J1bGVzLnRha2UoaW5kZXgpOwogICAgIGlmIChydWxlKQogICAg ICAgICBydWxlLT5kZXJlZigpOwpAQCAtNjcsNiArODUsNyBAQCB2b2lkIENTU1J1bGVMaXN0Ojph cHBlbmQoQ1NTUnVsZSogcnVsZSkKIAogdW5zaWduZWQgQ1NTUnVsZUxpc3Q6Omluc2VydFJ1bGUo Q1NTUnVsZSogcnVsZSwgdW5zaWduZWQgaW5kZXgpCiB7CisgICAgQVNTRVJUKCFtX2xpc3QpOwog ICAgIGlmIChydWxlICYmIG1fbHN0Q1NTUnVsZXMuaW5zZXJ0KGluZGV4LCBydWxlKSkgewogICAg ICAgICBydWxlLT5yZWYoKTsKICAgICAgICAgcmV0dXJuIGluZGV4OwpJbmRleDogY3NzL0NTU1J1 bGVMaXN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gY3NzL0NTU1J1bGVMaXN0LmgJKHJldmlzaW9uIDMwMTEx KQorKysgY3NzL0NTU1J1bGVMaXN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDcgQEAK IAogI2luY2x1ZGUgIkRlcHJlY2F0ZWRQdHJMaXN0LmgiCiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50 ZWQuaD4KKyNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApA QCAtMzgsMTYgKzM5LDE4IEBAIHB1YmxpYzoKICAgICBDU1NSdWxlTGlzdChTdHlsZUxpc3QqLCBi b29sIG9taXRDaGFyc2V0UnVsZXMgPSBmYWxzZSk7CiAgICAgfkNTU1J1bGVMaXN0KCk7CiAKLSAg ICB1bnNpZ25lZCBsZW5ndGgoKSBjb25zdCB7IHJldHVybiBtX2xzdENTU1J1bGVzLmNvdW50KCk7 IH0KLSAgICBDU1NSdWxlKiBpdGVtKHVuc2lnbmVkIGluZGV4KSB7IHJldHVybiBtX2xzdENTU1J1 bGVzLmF0KGluZGV4KTsgfQorICAgIHVuc2lnbmVkIGxlbmd0aCgpIGNvbnN0OworICAgIENTU1J1 bGUqIGl0ZW0odW5zaWduZWQgaW5kZXgpOwogCi0gICAgLyogbm90IHBhcnQgb2YgdGhlIERPTSAq LworICAgIC8vIEZJWE1FOiBOb3QgcGFydCBvZiB0aGUgRE9NLiAgT25seSB1c2UgYnkgbWVkaWEg cnVsZXMuICBXZSBzaG91bGQgYmUgYWJsZSB0byByZW1vdmUgdGhlbSBpZiB3ZSBjaGFuZ2VkIG1l ZGlhIHJ1bGVzIHRvIHdvcmsKKyAgICAvLyBhcyBTdHlsZUxpc3RzIGluc3RlYWQuCiAgICAgdW5z aWduZWQgaW5zZXJ0UnVsZShDU1NSdWxlKiwgdW5zaWduZWQgaW5kZXgpOwogICAgIHZvaWQgZGVs ZXRlUnVsZSh1bnNpZ25lZCBpbmRleCk7CiAgICAgdm9pZCBhcHBlbmQoQ1NTUnVsZSopOwogCiBw cm90ZWN0ZWQ6Ci0gICAgRGVwcmVjYXRlZFB0ckxpc3Q8Q1NTUnVsZT4gbV9sc3RDU1NSdWxlczsK KyAgICBSZWZQdHI8U3R5bGVMaXN0PiBtX2xpc3Q7CisgICAgRGVwcmVjYXRlZFB0ckxpc3Q8Q1NT UnVsZT4gbV9sc3RDU1NSdWxlczsgLy8gRklYTUU6IFdhbnQgdG8gZWxpbWluYXRlLCBidXQgdXNl ZCBieSBJRSBydWxlcygpIGV4dGVuc2lvbiBhbmQgc3RpbGwgdXNlZCBieSBtZWRpYSBydWxlcy4K IH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK