170609 2017-04-07 11:49:50 -0700 Web Inspector: WebSockets: Transferred size is incorrect 2017-04-14 23:55:52 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 169175 1 nvasilyev nvasilyev buildbot inspector-bugzilla-changes joepeck keith_miller mark.lam mattbaker msaboff saam webkit-bug-importer oldest_to_newest 1295419 0 nvasilyev 2017-04-07 11:49:50 -0700 Transferred size for WebSocket messages is currently incorrect. https://github.com/WebKit/webkit/blob/add8695eff1c434696a6db324fa5daca1bfd4813/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js#L75 this.increaseSize(data.length, elapsedTime); data is a string. data.length does not represent it's size. I think we should send payload size from the backend. We currently don't do this. In WebSocket protocol, payload length must be included with each message: https://developer.mozilla.org/en-US/docs/Web/API/WebSockets_API/Writing_WebSocket_servers#Format 1295471 1 nvasilyev 2017-04-07 13:38:49 -0700 If for some reason the backend change isn't feasible, we should replace data.length with new TextEncoder("utf-8").encode(data).length 1295608 2 306560 nvasilyev 2017-04-07 18:36:39 -0700 Created attachment 306560 Patch 1296202 3 webkit-bug-importer 2017-04-10 16:05:33 -0700 <rdar://problem/31544506> 1296207 4 306560 nvasilyev 2017-04-10 16:17:36 -0700 Comment on attachment 306560 Patch This patch doesn't have any tests. I'll combine it with Bug 169175 - Web Inspector: Add tests for webSocketFrameSent and webSocketFrameReceived. 1296947 5 306560 mattbaker 2017-04-12 22:16:11 -0700 Comment on attachment 306560 Patch Looks good! r- for now, because we should include a test for the protocol change. 1296948 6 mattbaker 2017-04-12 22:17:48 -0700 (In reply to Nikita Vasilyev from comment #4) > Comment on attachment 306560 [details] > Patch > > This patch doesn't have any tests. I'll combine it with Bug 169175 - Web > Inspector: Add tests for webSocketFrameSent and webSocketFrameReceived. Since it's a protocol change I think a test should be included in this patch. 1297652 7 nvasilyev 2017-04-14 23:55:52 -0700 Fixed in https://trac.webkit.org/changeset/215388/webkit. 306560 2017-04-07 18:36:39 -0700 2017-04-13 10:55:19 -0700 Patch patch.txt text/plain 7193 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFhM2QzMzcuLjFiYWRkYmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA0LTA3ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFdlYlNv Y2tldHM6IFRyYW5zZmVycmVkIHNpemUgaXMgaW5jb3JyZWN0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2MDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcGF5bG9hZExlbmd0aCBwcm9wZXJ0eSwg d2hpY2ggaXMgdXNlZCB0byBkaXNwbGF5IHNpemUuIFdoZW4gcGF5bG9hZExlbmd0aCBpcyB1bmF2 YWlsYWJsZSwKKyAgICAgICAgaXQgaXMgY2FsY3VsYXRlZCBmcm9tIHBheWxvYWREYXRhIGJ5IFdl YiBJbnNwZWN0b3IgZnJvbnRlbmQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvcHJvdG9jb2wvTmV0 d29yay5qc29uOgorCiAyMDE3LTA0LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+ CiAKICAgICAgICAgQjMgLU8xIHNob3VsZCBnZW5lcmF0ZSBiZXR0ZXIgY29kZSB0aGFuIC1PMApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9OZXR3 b3JrLmpzb24gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL05ldHdv cmsuanNvbgppbmRleCAxODAyYjJmLi5hNGJlNWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL05ldHdvcmsuanNvbgorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL05ldHdvcmsuanNvbgpAQCAtMTEyLDcgKzEx Miw4IEBACiAgICAgICAgICAgICAicHJvcGVydGllcyI6IFsKICAgICAgICAgICAgICAgICB7ICJu YW1lIjogIm9wY29kZSIsICJ0eXBlIjogIm51bWJlciIsICJkZXNjcmlwdGlvbiI6ICJXZWJTb2Nr ZXQgZnJhbWUgb3Bjb2RlLiIgfSwKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIm1hc2siLCAi dHlwZSI6ICJib29sZWFuIiwgImRlc2NyaXB0aW9uIjogIldlYlNvY2tldCBmcmFtZSBtYXNrLiIg fSwKLSAgICAgICAgICAgICAgICB7ICJuYW1lIjogInBheWxvYWREYXRhIiwgInR5cGUiOiAic3Ry aW5nIiwgImRlc2NyaXB0aW9uIjogIldlYlNvY2tldCBmcmFtZSBwYXlsb2FkIGRhdGEuIiB9Cisg ICAgICAgICAgICAgICAgeyAibmFtZSI6ICJwYXlsb2FkRGF0YSIsICJ0eXBlIjogInN0cmluZyIs ICJkZXNjcmlwdGlvbiI6ICJXZWJTb2NrZXQgZnJhbWUgcGF5bG9hZCBkYXRhLiIgfSwKKyAgICAg ICAgICAgICAgICB7ICJuYW1lIjogInBheWxvYWRMZW5ndGgiLCAidHlwZSI6ICJudW1iZXIiLCAi ZGVzY3JpcHRpb24iOiAiV2ViU29ja2V0IGZyYW1lIHBheWxvYWQgbGVuZ3RoIGluIGJ5dGVzLiIg fQogICAgICAgICAgICAgXQogICAgICAgICB9LAogICAgICAgICB7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRi NzYyNS4uZGVhNjYyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA0LTA3ICBO aWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFdlYlNvY2tldHM6IFRyYW5zZmVycmVkIHNpemUgaXMgaW5jb3JyZWN0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2MDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRl c3RzIHdpbGwgYmUgYWRkZWQgaW4gaHR0cHM6Ly93ZWJraXQub3JnL2IvMTY5MTc1LgorCisgICAg ICAgIEFkZCBwYXlsb2FkTGVuZ3RoIHByb3BlcnR5LCB3aGljaCBpcyB1c2VkIHRvIGRpc3BsYXkg c2l6ZS4gV2hlbiBwYXlsb2FkTGVuZ3RoIGlzIHVuYXZhaWxhYmxlLAorICAgICAgICBpdCBpcyBj YWxjdWxhdGVkIGZyb20gcGF5bG9hZERhdGEgYnkgV2ViIEluc3BlY3RvciBmcm9udGVuZC4KKwor ICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JOZXR3b3JrQWdlbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yTmV0d29ya0FnZW50OjpkaWRSZWNlaXZlV2ViU29ja2V0RnJhbWUp OgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yTmV0d29ya0FnZW50OjpkaWRTZW5kV2ViU29j a2V0RnJhbWUpOgorCiAyMDE3LTA0LTA2ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBw bGUuY29tPgogCiAgICAgICAgIEZvbGxvdyB1cCB0byByMjA5MzA0LCByZW1vdmUgbGluZSBudW1i ZXJzIGZyb20gb25lIG1vcmUgU3R5bGVSdWxlIGNvbnN0cnVjdGlvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck5ldHdvcmtBZ2VudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yTmV0d29ya0FnZW50LmNwcAppbmRleCA0ZjJlMDJi Li4zZjJmM2IxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y TmV0d29ya0FnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y TmV0d29ya0FnZW50LmNwcApAQCAtNjEwLDYgKzYxMCw3IEBAIHZvaWQgSW5zcGVjdG9yTmV0d29y a0FnZW50OjpkaWRSZWNlaXZlV2ViU29ja2V0RnJhbWUodW5zaWduZWQgbG9uZyBpZGVudGlmaWVy LCBjCiAgICAgICAgIC5zZXRPcGNvZGUoZnJhbWUub3BDb2RlKQogICAgICAgICAuc2V0TWFzayhm cmFtZS5tYXNrZWQpCiAgICAgICAgIC5zZXRQYXlsb2FkRGF0YShTdHJpbmcoZnJhbWUucGF5bG9h ZCwgZnJhbWUucGF5bG9hZExlbmd0aCkpCisgICAgICAgIC5zZXRQYXlsb2FkTGVuZ3RoKGZyYW1l LnBheWxvYWRMZW5ndGgpCiAgICAgICAgIC5yZWxlYXNlKCk7CiAgICAgbV9mcm9udGVuZERpc3Bh dGNoZXItPndlYlNvY2tldEZyYW1lUmVjZWl2ZWQoSWRlbnRpZmllcnNGYWN0b3J5OjpyZXF1ZXN0 SWQoaWRlbnRpZmllciksIHRpbWVzdGFtcCgpLCBXVEZNb3ZlKGZyYW1lT2JqZWN0KSk7CiB9CkBA IC02MjAsNiArNjIxLDcgQEAgdm9pZCBJbnNwZWN0b3JOZXR3b3JrQWdlbnQ6OmRpZFNlbmRXZWJT b2NrZXRGcmFtZSh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGNvbnMKICAgICAgICAgLnNldE9w Y29kZShmcmFtZS5vcENvZGUpCiAgICAgICAgIC5zZXRNYXNrKGZyYW1lLm1hc2tlZCkKICAgICAg ICAgLnNldFBheWxvYWREYXRhKFN0cmluZyhmcmFtZS5wYXlsb2FkLCBmcmFtZS5wYXlsb2FkTGVu Z3RoKSkKKyAgICAgICAgLnNldFBheWxvYWRMZW5ndGgoZnJhbWUucGF5bG9hZExlbmd0aCkKICAg ICAgICAgLnJlbGVhc2UoKTsKICAgICBtX2Zyb250ZW5kRGlzcGF0Y2hlci0+d2ViU29ja2V0RnJh bWVTZW50KElkZW50aWZpZXJzRmFjdG9yeTo6cmVxdWVzdElkKGlkZW50aWZpZXIpLCB0aW1lc3Rh bXAoKSwgV1RGTW92ZShmcmFtZU9iamVjdCkpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKaW5k ZXggZTVjM2RhMC4uOWFlOTc3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTggQEAKKzIwMTctMDQtMDcgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV2ViU29ja2V0czogVHJhbnNmZXJyZWQgc2l6ZSBp cyBpbmNvcnJlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MDYwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCBwYXlsb2FkTGVuZ3RoIHByb3BlcnR5LCB3aGljaCBpcyB1c2VkIHRvIGRpc3BsYXkg c2l6ZS4gV2hlbiBwYXlsb2FkTGVuZ3RoIGlzIHVuYXZhaWxhYmxlLAorICAgICAgICBpdCBpcyBj YWxjdWxhdGVkIGZyb20gcGF5bG9hZERhdGEgYnkgV2ViIEluc3BlY3RvciBmcm9udGVuZC4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1hbmFnZXIu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRnJhbWVSZXNvdXJjZU1hbmFnZXIucHJvdG90eXBl Ll93ZWJTb2NrZXRGcmFtZVJlY2VpdmVkT3JTZW50KToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L01vZGVscy9XZWJTb2NrZXRSZXNvdXJjZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5XZWJT b2NrZXRSZXNvdXJjZS5wcm90b3R5cGUuYWRkRnJhbWUpOgorCiAyMDE3LTA0LTA2ICBNYXR0IEJh a2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW9y ZGVyIERlYnVnZ2VyIHRhYiBzaWRlYmFyIHBhbmVsczogU2NvcGUgQ2hhaW4sIFJlc291cmNlLCBQ cm9iZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL0ZyYW1lUmVzb3VyY2VNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1hbmFnZXIuanMKaW5kZXgg NzVhMGIwOS4uODg1N2I5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1hbmFnZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1h bmFnZXIuanMKQEAgLTI5MCwxMiArMjkwLDEwIEBAIFdlYkluc3BlY3Rvci5GcmFtZVJlc291cmNl TWFuYWdlciA9IGNsYXNzIEZyYW1lUmVzb3VyY2VNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjCiAg ICAgICAgIC8vIERhdGEgZ29pbmcgZnJvbSB0aGUgY2xpZW50IHRvIHRoZSBzZXJ2ZXIgaXMgYWx3 YXlzIG1hc2tlZC4KICAgICAgICAgbGV0IGlzT3V0Z29pbmcgPSAhIXJlc3BvbnNlLm1hc2s7CiAK LSAgICAgICAgbGV0IGRhdGEgPSByZXNwb25zZS5wYXlsb2FkRGF0YTsKLSAgICAgICAgbGV0IG9w Y29kZSA9IHJlc3BvbnNlLm9wY29kZTsKLQorICAgICAgICBsZXQge3BheWxvYWREYXRhLCBwYXls b2FkTGVuZ3RoLCBvcGNvZGV9ID0gcmVzcG9uc2U7CiAgICAgICAgIGxldCBlbGFwc2VkVGltZSA9 IFdlYkluc3BlY3Rvci50aW1lbGluZU1hbmFnZXIuY29tcHV0ZUVsYXBzZWRUaW1lKHRpbWVzdGFt cCk7CiAKLSAgICAgICAgcmVzb3VyY2UuYWRkRnJhbWUoZGF0YSwgaXNPdXRnb2luZywgb3Bjb2Rl LCB0aW1lc3RhbXAsIGVsYXBzZWRUaW1lKTsKKyAgICAgICAgcmVzb3VyY2UuYWRkRnJhbWUocGF5 bG9hZERhdGEsIHBheWxvYWRMZW5ndGgsIGlzT3V0Z29pbmcsIG9wY29kZSwgdGltZXN0YW1wLCBl bGFwc2VkVGltZSk7CiAgICAgfQogCiAgICAgbWFya1Jlc291cmNlUmVxdWVzdEFzU2VydmVkRnJv bU1lbW9yeUNhY2hlKHJlcXVlc3RJZGVudGlmaWVyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1dlYlNvY2tldFJlc291cmNlLmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1dlYlNvY2tldFJlc291cmNl LmpzCmluZGV4IDEwYmY3NDQuLjA2ZTVhMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9XZWJTb2NrZXRSZXNvdXJjZS5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvV2ViU29ja2V0UmVzb3VyY2Uu anMKQEAgLTU5LDcgKzU5LDcgQEAgV2ViSW5zcGVjdG9yLldlYlNvY2tldFJlc291cmNlID0gY2xh c3MgV2ViU29ja2V0UmVzb3VyY2UgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuUmUKICAgICAgICAgdGhp cy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLldlYlNvY2tldFJlc291cmNl LkV2ZW50LlJlYWR5U3RhdGVDaGFuZ2VkLCB7cHJldmlvdXNTdGF0ZSwgc3RhdGV9KTsKICAgICB9 CiAKLSAgICBhZGRGcmFtZShkYXRhLCBpc091dGdvaW5nLCBvcGNvZGUsIHRpbWVzdGFtcCwgZWxh cHNlZFRpbWUpCisgICAgYWRkRnJhbWUoZGF0YSwgcGF5bG9hZExlbmd0aCwgaXNPdXRnb2luZywg b3Bjb2RlLCB0aW1lc3RhbXAsIGVsYXBzZWRUaW1lKQogICAgIHsKICAgICAgICAgbGV0IGZyYW1l RGF0YTsKIApAQCAtNzIsNyArNzIsMTEgQEAgV2ViSW5zcGVjdG9yLldlYlNvY2tldFJlc291cmNl ID0gY2xhc3MgV2ViU29ja2V0UmVzb3VyY2UgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuUmUKICAgICAg ICAgbGV0IGZyYW1lID0ge2RhdGE6IGZyYW1lRGF0YSwgaXNPdXRnb2luZywgb3Bjb2RlLCB3YWxs dGltZTogdGhpcy5fd2FsbHRpbWVGb3JXZWJTb2NrZXRUaW1lc3RhbXAodGltZXN0YW1wKX07CiAg ICAgICAgIHRoaXMuX2ZyYW1lcy5wdXNoKGZyYW1lKTsKIAotICAgICAgICB0aGlzLmluY3JlYXNl U2l6ZShkYXRhLmxlbmd0aCwgZWxhcHNlZFRpbWUpOworICAgICAgICAvLyBDT01QQVRJQklMSVRZ IChpT1MgMTAuMyk6IGBwYXlsb2FkTGVuZ3RoYCBkaWQgbm90IGV4aXN0IGluIDEwLjMgYW5kIGVh cmxpZXIuCisgICAgICAgIGlmICh0eXBlb2YgcGF5bG9hZExlbmd0aCA9PT0gInVuZGVmaW5lZCIp CisgICAgICAgICAgICBwYXlsb2FkTGVuZ3RoID0gbmV3IFRleHRFbmNvZGVyKCJ1dGYtOCIpLmVu Y29kZShkYXRhKS5sZW5ndGg7CisKKyAgICAgICAgdGhpcy5pbmNyZWFzZVNpemUocGF5bG9hZExl bmd0aCwgZWxhcHNlZFRpbWUpOwogCiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVu ZXJzKFdlYkluc3BlY3Rvci5XZWJTb2NrZXRSZXNvdXJjZS5FdmVudC5GcmFtZUFkZGVkLCBmcmFt ZSk7CiAgICAgfQo=