170540 2017-04-06 00:52:07 -0700 [GTK] Remove unneeded modules from the jhbuild 2017-06-23 18:23:42 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugzilla.gnome.org/show_bug.cgi?id=760367 Gtk P2 Normal --- 170500 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1294822 0 cgarcia 2017-04-06 00:52:07 -0700 We are building several modules we don't really need to build from sources. libxml, libxslt and libffi. 1294823 1 306369 cgarcia 2017-04-06 00:54:32 -0700 Created attachment 306369 Patch Let's start by removing what we don't ned to build. This shouldn't affect the tests. 1294826 2 cgarcia 2017-04-06 01:20:15 -0700 It turns out it does affect tests, there are only a few failures. The libxml version in the bot is exactly the same, so it must be libxslt. However, I can reproduce some of the failures in my laptop with even newer versions. 1294852 3 cgarcia 2017-04-06 04:07:25 -0700 Ok, the problem is not libxslt but libxml. It's weird because we used 2.9.1 which is what the bot has installed ii libxml2:amd64 2.9.1+dfsg1-5+deb8u4 I can also reproduce the differences with my libxml from debian testing ii libxml2:amd64 2.9.4+dfsg1-2.2 1294873 4 mcatanzaro 2017-04-06 07:40:42 -0700 I'd rather introduce new failures and update test expectations accordingly than continue using the older version. 1295947 5 cgarcia 2017-04-10 03:13:30 -0700 So, this regressed in libxml2 and we never noticed it because our tests ran fine with the old version of libxml2. However, it has been broken for our users all this time, since most of the distros are shipping a libxml2 version with the regression. This is a good example of why it's not a good idea to use old versions of our deps to run the tests. 1321027 6 cgarcia 2017-06-20 00:10:13 -0700 Committed r218550: <http://trac.webkit.org/changeset/218550> 1322528 7 mcatanzaro 2017-06-23 18:23:42 -0700 You need to add libffi to install-dependencies: libffi-dev (Debian) libffi-devel (Fedora) libffi (Arch) 306369 2017-04-06 00:54:32 -0700 2017-04-06 07:40:17 -0700 Patch wk-remove-deps.diff text/plain 3556 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxOTY0 YWQzZmJiZC4uYjBlYjg3YTJkOGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNy0wNC0wNiAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gUmVtb3ZlIHVu bmVlZGVkIG1vZHVsZXMgZnJvbSB0aGUgamhidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgYXJlIGJ1aWxkaW5nIHNldmVyYWwgbW9kdWxlcyB3 ZSBkb24ndCByZWFsbHkgbmVlZCB0byBidWlsZCBmcm9tIHNvdXJjZXMuIGxpYnhtbCwgbGlieHNs dCBhbmQgbGliZmZpLgorCisgICAgICAgICogZ3RrL2poYnVpbGQubW9kdWxlczoKKwogMjAxNy0w NC0wNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIHRl c3QyNjI6IG1vZHVsZSB0ZXN0IHByb2dyZXNzaW9ucyBuZWVkIHVwZGF0ZWQgZXhwZWN0YXRpb25z IChAQGl0ZXJhdG9yIGNoYW5nZXMpCmRpZmYgLS1naXQgYS9Ub29scy9ndGsvamhidWlsZC5tb2R1 bGVzIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwppbmRleCBlZjJiNWRjZTM0MC4uOGQxZDFi YzIyMDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMv Z3RrL2poYnVpbGQubW9kdWxlcwpAQCAtMTEsOCArMTEsNiBAQAogICAgICAgPGRlcCBwYWNrYWdl PSJmb250Y29uZmlnIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImZyZWV0eXBlNiIvPgogICAgICAg PGRlcCBwYWNrYWdlPSJoYXJmYnV6eiIvPgotICAgICAgPGRlcCBwYWNrYWdlPSJsaWJ4bWwyIi8+ Ci0gICAgICA8ZGVwIHBhY2thZ2U9ImxpYnhzbHQiLz4KICAgICAgIDxkZXAgcGFja2FnZT0iZ2Rr LXBpeGJ1ZiIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJndGsrIi8+CiAgICAgICA8ZGVwIHBhY2th Z2U9ImdsaWIiLz4KQEAgLTE0OCwxMyArMTQ2LDYgQEAKICAgICA8L2JyYW5jaD4KICAgPC9hdXRv dG9vbHM+CiAKLSAgPGF1dG90b29scyBpZD0ibGliZmZpIiBhdXRvZ2VuLXNoPSJjb25maWd1cmUi PgotICAgIDxicmFuY2ggbW9kdWxlPSJsaWJmZmkvbGliZmZpLTMuMS50YXIuZ3oiIHZlcnNpb249 IjMuMSIKLSAgICAgICAgICAgICByZXBvPSJzb3VyY2V3YXJlLm9yZy1taXJyb3IiCi0gICAgICAg ICAgICAgaGFzaD0ic2hhMjU2Ojk3ZmVlZWFkY2E1ZTIxODcwZmE0NDMzYmM5NTNkMWIzYWYzZjY5 OGQ1ZGY4YTQyOGY2OGI3M2NkNjBhZWY2ZWIiCi0gICAgICAgICAgICAgbWQ1c3VtPSJmNTg5OGIy OWJiZmQ3MDUwMjgzMWEyMTJkOTI0OWQxMCIvPgotICA8L2F1dG90b29scz4KLQogICA8YXV0b3Rv b2xzIGlkPSJnZGstcGl4YnVmIiBhdXRvZ2VuLXNoPSJjb25maWd1cmUiCiAgICAgICAgICAgICAg YXV0b2dlbmFyZ3M9Ii0tZGlzYWJsZS1pbnRyb3NwZWN0aW9uIj4KICAgICA8ZGVwZW5kZW5jaWVz PgpAQCAtMjEwLDkgKzIwMSw2IEBACiAgIDxhdXRvdG9vbHMgaWQ9ImdsaWIiCiAgICAgICAgICAg ICAgYXV0b2dlbi1zaD0iY29uZmlndXJlIgogICAgICAgICAgICAgIGF1dG9nZW5hcmdzPSItLWRp c2FibGUtZHRyYWNlIj4KLSAgICA8ZGVwZW5kZW5jaWVzPgotICAgICAgPGRlcCBwYWNrYWdlPSJs aWJmZmkiLz4KLSAgICA8L2RlcGVuZGVuY2llcz4KICAgICA8YnJhbmNoIG1vZHVsZT0iL3B1Yi9H Tk9NRS9zb3VyY2VzL2dsaWIvMi40NC9nbGliLTIuNDQuMS50YXIueHoiIHZlcnNpb249IjIuNDQu MSIKICAgICAgICAgICAgIHJlcG89ImZ0cC5nbm9tZS5vcmciCiAgICAgICAgICAgICBoYXNoPSJz aGEyNTY6ODgxMWRlYWNhZjhhNTAzZDBhOWI3MDE3NzdlYTA3OWNhNmE0Mjc3YmUxMGUzZDczMGQy MTEyNzM1ZDVlY2EwNyI+CkBAIC0yNTksNyArMjQ3LDYgQEAKICAgICA8L2lmPgogICAgIDxkZXBl bmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImZyZWV0eXBlNiIvPgotICAgICAgPGRlcCBw YWNrYWdlPSJsaWJ4bWwyIi8+CiAgICAgPC9kZXBlbmRlbmNpZXM+CiAgICAgPGJyYW5jaCBtb2R1 bGU9InNvZnR3YXJlL2ZvbnRjb25maWcvcmVsZWFzZS9mb250Y29uZmlnLTIuMTEuMS50YXIuZ3oi IHZlcnNpb249IjIuMTEuMSIKICAgICAgICAgICAgIHJlcG89ImZyZWVkZXNrdG9wLm9yZyIKQEAg LTMzMywyMyArMzIwLDYgQEAKICAgICA8L2RlcGVuZGVuY2llcz4KICAgPC9hdXRvdG9vbHM+CiAK LSAgPGF1dG90b29scyBpZD0ibGlieG1sMiIgc3VwcG9ydHMtbm9uLXNyY2Rpci1idWlsZHM9Im5v IgotICAgICAgICAgICAgIGF1dG9nZW4tc2g9Ii4vYXV0b2dlbi5zaDsgLi9jb25maWd1cmUgLS13 aXRoLXB5dGhvbj1ubyI+Ci0gICAgPGJyYW5jaCBtb2R1bGU9Ii9zb3VyY2VzL2xpYnhtbDItMi45 LjEudGFyLmd6IiB2ZXJzaW9uPSIyLjkuMSIKLSAgICAgICAgICAgIHJlcG89InhtbHNvZnQub3Jn IgotICAgICAgICAgICAgaGFzaD0ic2hhMjU2OmZkM2M2NGNiNjZmMmM0ZWEyN2U5MzRkMjc1OTA0 ZDkyY2VjNDk0YThlODQwNTYxMzc4MGNiYzhhNzE2ODBmZGIiCi0gICAgICAgICAgICBtZDVzdW09 IjljMGNmZWYyODVkNWM0YTVjODBkMDA5MDRkZGFiMzgwIi8+Ci0gIDwvYXV0b3Rvb2xzPgotCi0g IDxhdXRvdG9vbHMgaWQ9ImxpYnhzbHQiPgotICAgIDxicmFuY2ggbW9kdWxlPSIvc291cmNlcy9s aWJ4c2x0LSR7dmVyc2lvbn0udGFyLmd6IiB2ZXJzaW9uPSIxLjEuMjkiCi0gICAgICAgICAgICBy ZXBvPSJ4bWxzb2Z0Lm9yZyIKLSAgICAgICAgICAgIGhhc2g9InNoYTI1NjpiNTk3NmUzODU3ODM3 ZTc2MTdiMjlmMjI0OWViYjVlZWFjMzRlMjQ5MjA4ZDMxZjFmYmY3YTZiYTdhNDA5MGNlIi8+Ci0g ICAgPGRlcGVuZGVuY2llcz4KLSAgICAgIDxkZXAgcGFja2FnZT0ibGlieG1sMiIvPgotICAgIDwv ZGVwZW5kZW5jaWVzPgotICA8L2F1dG90b29scz4KLQogICA8YXV0b3Rvb2xzIGlkPSJvcmMiIGF1 dG9nZW5hcmdzPSItLWRpc2FibGUtZ3RrLWRvYyIgYXV0b2dlbi1zaD0iY29uZmlndXJlIj4KICAg ICA8YnJhbmNoIG1vZHVsZT0ib3JjL29yYy0wLjQuMTcudGFyLmd6IiB2ZXJzaW9uPSIwLjQuMTci CiAgICAgICAgICAgICByZXBvPSJnc3RyZWFtZXIiCkBAIC00NTEsOSArNDIxLDYgQEAKIAogICA8 YXV0b3Rvb2xzIGlkPSJ3YXlsYW5kIiBhdXRvZ2VuYXJncz0iLS1kaXNhYmxlLWRvY3VtZW50YXRp b24iPgogICAgIDxwa2ctY29uZmlnPndheWxhbmQtc2VydmVyLnBjPC9wa2ctY29uZmlnPgotICAg IDxkZXBlbmRlbmNpZXM+Ci0gICAgICA8ZGVwIHBhY2thZ2U9ImxpYmZmaSIvPgotICAgIDwvZGVw ZW5kZW5jaWVzPgogICAgIDxicmFuY2ggbW9kdWxlPSJyZWxlYXNlcy93YXlsYW5kLTEuOC4xLnRh ci54eiIKICAgICAgICAgICAgIHZlcnNpb249IjEuOC4xIgogICAgICAgICAgICAgcmVwbz0id2F5 bGFuZC5mcmVlZGVza3RvcC5vcmciCg==