170106 2017-03-26 05:59:48 -0700 generate-bindings-all.pl shouldn't use Perl threads 2017-04-09 14:48:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build PC Other RESOLVED FIXED P2 Blocker --- 161433 1 ajacoutot fujii buildbot cdumez commit-queue fujii lforschler mcatanzaro sam ysuzuki oldest_to_newest 1291317 0 ajacoutot 2017-03-26 05:59:48 -0700 Hi. Could the generate-bindings-all.pl script be modified to not require a threaded perl? "The use of interpreter-based threads in perl is officially discouraged" by upstream and not all Linux distributions compile perl with threads support; that's also the case of the BSDs. Trying to build on OpenBSD fails with: This Perl not built to support threads Compilation failed in require at ./webkitgtk4-2.16.0/webkitgtk-2.16.0/Source/WebCore/bindings/scripts/generate-bindings-all.pl line 35. BEGIN failed--compilation aborted at ./webkitgtk4-2.16.0/webkitgtk-2.16.0/Source/WebCore/bindings/scripts/generate-bindings-all.pl line 35. ninja: build stopped: subcommand failed. Thanks. 1291407 1 fujii 2017-03-26 22:24:39 -0700 http://search.cpan.org/~rybskej/forks/lib/forks.pm This seems useful. I'll try it. 1291419 2 ajacoutot 2017-03-27 00:25:15 -0700 Thanks for looking into it. If you need me to test anything, feel free to ask :-) 1291440 3 fujii 2017-03-27 03:20:28 -0700 (In reply to Fujii Hironori from comment #1) > http://search.cpan.org/~rybskej/forks/lib/forks.pm > This seems useful. I'll try it. This doesn't work for me. I need to give up using threads in Perl. 1291441 4 305459 fujii 2017-03-27 03:22:43 -0700 Created attachment 305459 WIP Patch I created a WIP patch of using fork&exec&wait. I feel slower in case of using Windows Perl. 1291492 5 ajacoutot 2017-03-27 09:37:07 -0700 Ah that seems to work fine so far :-) Still building but I am way passed the original failure. I'll keep you posted once the build is done. Thanks. 1291755 6 fujii 2017-03-27 19:50:54 -0700 (In reply to Fujii Hironori from comment #4) > I feel slower in case of using Windows Perl. This my feeling was wrong. I did benchmark: with threads: 00:04:01.83 without threads: 00:04:01.32 1291797 7 305559 fujii 2017-03-27 21:43:40 -0700 Created attachment 305559 Patch 1291809 8 ajacoutot 2017-03-27 23:06:42 -0700 I can confirm that with this patch I am able to build WebKit fine :-) Thank you! 1295706 9 fujii 2017-04-08 15:53:44 -0700 Could anyone review this? Gentoo Linux also gets the trouble. https://paste.pound-python.org/show/cC5FbmhCBLSg1qrwoLuv/ 1295832 10 305559 ysuzuki 2017-04-09 14:20:22 -0700 Comment on attachment 305559 Patch r=me 1295838 11 305559 commit-queue 2017-04-09 14:48:09 -0700 Comment on attachment 305559 Patch Clearing flags on attachment: 305559 Committed r215166: <http://trac.webkit.org/changeset/215166> 1295839 12 commit-queue 2017-04-09 14:48:11 -0700 All reviewed patches have been landed. Closing bug. 305459 2017-03-27 03:22:43 -0700 2017-03-27 21:43:36 -0700 WIP Patch a.patch text/plain 2655 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmlu ZGluZ3MtYWxsLnBsIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1i aW5kaW5ncy1hbGwucGwKaW5kZXggMzdiMjdjYy4uZjBlNWEyOCAxMDA3NTUKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy1hbGwucGwKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy1hbGwucGwK QEAgLTMyLDkgKzMyLDYgQEAgdXNlIEZpbGU6OkJhc2VuYW1lOwogdXNlIEZpbGU6OlNwZWM7CiB1 c2UgRmlsZTo6RmluZDsKIHVzZSBHZXRvcHQ6Okxvbmc7Ci11c2UgdGhyZWFkczsKLXVzZSB0aHJl YWRzOjpzaGFyZWQ7Ci11c2UgVGhyZWFkOjpRdWV1ZTsKIAogbXkgJHBlcmwgPSAkXlg7CiBteSAk c2NyaXB0RGlyID0gJEZpbmRCaW46OkJpbjsKQEAgLTEyMSwxMyArMTE4LDE4IEBAIG15IEBpZGxG aWxlc1RvVXBkYXRlID0gZ3JlcCAme3N1YiB7CiAgICAgICAgICAgICAgICAgaW1wbGljaXREZXBl bmRlbmNpZXMoJGRlcEZpbGUpKTsKICAgICBuZWVkc1VwZGF0ZShcQG91dHB1dCwgXEBkZXBzKTsK IH19LCBAaWRsRmlsZXM7Ci1teSAkcXVldWUgPSBUaHJlYWQ6OlF1ZXVlLT5uZXcoQGlkbEZpbGVz VG9VcGRhdGUpOwotbXkgJGFib3J0IDpzaGFyZWQgPSAwOworCitteSAkYWJvcnQgPSAwOwogbXkg JHRvdGFsQ291bnQgPSBAaWRsRmlsZXNUb1VwZGF0ZTsKLW15ICRjdXJyZW50Q291bnQgOnNoYXJl ZCA9IDA7CitteSAkY3VycmVudENvdW50ID0gMDsKIAotbXkgQHRocmVhZFBvb2wgPSBtYXAgeyB0 aHJlYWRzLT5jcmVhdGUoXCZ3b3JrZXIpIH0gKDEgLi4gJG51bU9mSm9icyk7Ci0kXy0+am9pbiBm b3IgQHRocmVhZFBvb2w7CitzcGF3bkdlbmVyYXRlQmluZGluZ3NDb21tYW5kKCkgZm9yICgxIC4u ICRudW1PZkpvYnMpOword2hpbGUgKHdhaXRwaWQoLTEsIDApICE9IC0xKSB7CisgICAgaWYgKCQ/ KSB7CisgICAgICAgICRhYm9ydCA9IDE7CisgICAgfQorICAgIHNwYXduR2VuZXJhdGVCaW5kaW5n c0NvbW1hbmQoKTsKK30KIGV4aXQgJGFib3J0OwogCiBzdWIgbmVlZHNVcGRhdGUKQEAgLTE1Nywy MCArMTU5LDE2IEBAIHN1YiBtdGltZQogICAgIHJldHVybiAoc3RhdCAkZmlsZSlbOV07CiB9CiAK LXN1YiB3b3JrZXIgewotICAgIHdoaWxlIChteSAkZmlsZSA9ICRxdWV1ZS0+ZGVxdWV1ZV9uYigp KSB7Ci0gICAgICAgIGxhc3QgaWYgJGFib3J0OwotICAgICAgICBldmFsIHsKLSAgICAgICAgICAg ICRjdXJyZW50Q291bnQrKzsKLSAgICAgICAgICAgIG15ICRiYXNlbmFtZSA9IGJhc2VuYW1lKCRm aWxlKTsKLSAgICAgICAgICAgIHByaW50UHJvZ3Jlc3MoIlskY3VycmVudENvdW50LyR0b3RhbENv dW50XSAkYmFzZW5hbWUiKTsKLSAgICAgICAgICAgIGV4ZWN1dGVDb21tYW5kKCRwZXJsLCBAYXJn cywgJGZpbGUpID09IDAgb3IgZGllOwotICAgICAgICB9OwotICAgICAgICBpZiAoJEApIHsKLSAg ICAgICAgICAgICRhYm9ydCA9IDE7Ci0gICAgICAgICAgICBkaWU7Ci0gICAgICAgIH0KLSAgICB9 CitzdWIgc3Bhd25HZW5lcmF0ZUJpbmRpbmdzQ29tbWFuZAoreworICAgIHJldHVybiBpZiAkYWJv cnQ7CisgICAgcmV0dXJuIHVubGVzcyBAaWRsRmlsZXNUb1VwZGF0ZTsKKyAgICBteSAkZmlsZSA9 IHNoaWZ0IEBpZGxGaWxlc1RvVXBkYXRlOworICAgICRjdXJyZW50Q291bnQrKzsKKyAgICBteSAk YmFzZW5hbWUgPSBiYXNlbmFtZSgkZmlsZSk7CisgICAgcHJpbnRQcm9ncmVzcygiWyRjdXJyZW50 Q291bnQvJHRvdGFsQ291bnRdICRiYXNlbmFtZSIpOworICAgIG15ICRwaWQgPSBzcGF3bkNvbW1h bmQoJHBlcmwsIEBhcmdzLCAkZmlsZSk7CisgICAgJGFib3J0ID0gMSB1bmxlc3MgZGVmaW5lZCAk cGlkOwogfQogCiBzdWIgYnVpbGREaXJlY3RvcnlDYWNoZQpAQCAtMTk2LDIyICsxOTQsMjMgQEAg c3ViIGltcGxpY2l0RGVwZW5kZW5jaWVzCiAKIHN1YiBleGVjdXRlQ29tbWFuZAogewotICAgIGlm ICgkXk8gZXEgJ2N5Z3dpbicpIHsKLSAgICAgICAgIyAnc3lzdGVtJyBvZiBDeWd3aW4gUGVybCBk b2Vzbid0IHNlZW0gdGhyZWFkLXNhZmUKLSAgICAgICAgbXkgJHBpZCA9IGZvcmsoKTsKLSAgICAg ICAgZGVmaW5lZCgkcGlkKSBvciBkaWU7Ci0gICAgICAgIGlmICgkcGlkID09IDApIHsKLSAgICAg ICAgICAgIGV4ZWMoQF8pIG9yIGRpZTsKLSAgICAgICAgfQotICAgICAgICB3YWl0cGlkKCRwaWQs IDApOwotICAgICAgICByZXR1cm4gJD87Ci0gICAgfQogICAgIGlmICgkXk8gZXEgJ01TV2luMzIn KSB7CiAgICAgICAgIHJldHVybiBzeXN0ZW0ocXVvdGVDb21tYW5kKEBfKSk7CiAgICAgfQogICAg IHJldHVybiBzeXN0ZW0oQF8pOwogfQogCitzdWIgc3Bhd25Db21tYW5kCit7CisgICAgbXkgJHBp ZCA9IGZvcmsoKTsKKyAgICBpZiAoJHBpZCA9PSAwKSB7CisgICAgICAgIEBfID0gcXVvdGVDb21t YW5kKEBfKSBpZiAoJF5PIGVxICdNU1dpbjMyJyk7CisgICAgICAgIGV4ZWMoQF8pOworICAgICAg ICBkaWUgIkNhbm5vdCBleGVjIjsKKyAgICB9CisgICAgcmV0dXJuICRwaWQ7Cit9CisKIHN1YiBx dW90ZUNvbW1hbmQKIHsKICAgICByZXR1cm4gbWFwIHsK 305559 2017-03-27 21:43:40 -0700 2017-04-09 14:48:09 -0700 Patch bug-170106-20170328134339.patch text/plain 3821 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTgyYTg3NzE4ZDcwOGQz ZjM3OTliOGIxZjRiNDU2MTYwNmQ0OTY5MC4uZDliOGQ0Y2MwMGFjZjg4YjFkZDI4YWQ0NTE0YThk NDAyNDk1NTM2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTAzLTI3ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIGdlbmVyYXRl LWJpbmRpbmdzLWFsbC5wbCBzaG91bGRuJ3QgdXNlIFBlcmwgdGhyZWFkcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMTA2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHVzZSBvZiBpbnRlcnByZXRl ci1iYXNlZCB0aHJlYWRzIGluIFBlcmwgaXMgb2ZmaWNpYWxseQorICAgICAgICBkaXNjb3VyYWdl ZCBhbmQgbm90IGFsbCBMaW51eCBkaXN0cmlidXRpb25zIGFuZCBCU0QgY29tcGlsZSBQZXJsCisg ICAgICAgIHdpdGggdGhyZWFkcyBzdXBwb3J0LiBVc2UgZm9yayBpbnN0ZWFkIG9mIHRocmVhZHMg dG8gcnVuCisgICAgICAgIGdlbmVyYXRlLWJpbmRpbmdzLnBsIGluIHBhcmFsbGVsLgorCisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy1hbGwucGw6CisgICAgICAg IChzcGF3bkdlbmVyYXRlQmluZGluZ3NJZk5lZWRlZCk6IEFkZGVkLgorICAgICAgICAoZXhlY3V0 ZUNvbW1hbmQpOiBSZW1vdmVkIHRoZSB3b3JrYXJvdW5kIGZvciBDeWd3aW4gUGVybCB0aHJlYWRz LgorICAgICAgICAoc3Bhd25Db21tYW5kKTogQWRkZWQuCisgICAgICAgICh3b3JrZXIpOiBEZWxl dGVkLgorCiAyMDE3LTAzLTI3ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAog ICAgICAgICBBbGxvdyB0aGUgcGFnZSB0byByZW5kZXIgYmVmb3JlIDxsaW5rPiBzdHlsZXNoZWV0 IHRhZ3MgaW4gYm9keQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9nZW5lcmF0ZS1iaW5kaW5ncy1hbGwucGwgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL2dlbmVyYXRlLWJpbmRpbmdzLWFsbC5wbAppbmRleCAzN2IyN2NjNzQ5YzYxMzE4OGUwYTll MTBmMTAyNTkzNGY1MmJlNzc1Li45NjhlYTExM2ViNGEyNTRhNGQyODgzMGUyMjY3NzBjYTM4YjNm YThlIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL2dlbmVyYXRl LWJpbmRpbmdzLWFsbC5wbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL2dl bmVyYXRlLWJpbmRpbmdzLWFsbC5wbApAQCAtMzIsOSArMzIsNiBAQCB1c2UgRmlsZTo6QmFzZW5h bWU7CiB1c2UgRmlsZTo6U3BlYzsKIHVzZSBGaWxlOjpGaW5kOwogdXNlIEdldG9wdDo6TG9uZzsK LXVzZSB0aHJlYWRzOwotdXNlIHRocmVhZHM6OnNoYXJlZDsKLXVzZSBUaHJlYWQ6OlF1ZXVlOwog CiBteSAkcGVybCA9ICReWDsKIG15ICRzY3JpcHREaXIgPSAkRmluZEJpbjo6QmluOwpAQCAtMTIx LDEzICsxMTgsMTggQEAgbXkgQGlkbEZpbGVzVG9VcGRhdGUgPSBncmVwICZ7c3ViIHsKICAgICAg ICAgICAgICAgICBpbXBsaWNpdERlcGVuZGVuY2llcygkZGVwRmlsZSkpOwogICAgIG5lZWRzVXBk YXRlKFxAb3V0cHV0LCBcQGRlcHMpOwogfX0sIEBpZGxGaWxlczsKLW15ICRxdWV1ZSA9IFRocmVh ZDo6UXVldWUtPm5ldyhAaWRsRmlsZXNUb1VwZGF0ZSk7Ci1teSAkYWJvcnQgOnNoYXJlZCA9IDA7 CisKK215ICRhYm9ydCA9IDA7CiBteSAkdG90YWxDb3VudCA9IEBpZGxGaWxlc1RvVXBkYXRlOwot bXkgJGN1cnJlbnRDb3VudCA6c2hhcmVkID0gMDsKK215ICRjdXJyZW50Q291bnQgPSAwOwogCi1t eSBAdGhyZWFkUG9vbCA9IG1hcCB7IHRocmVhZHMtPmNyZWF0ZShcJndvcmtlcikgfSAoMSAuLiAk bnVtT2ZKb2JzKTsKLSRfLT5qb2luIGZvciBAdGhyZWFkUG9vbDsKK3NwYXduR2VuZXJhdGVCaW5k aW5nc0lmTmVlZGVkKCkgZm9yICgxIC4uICRudW1PZkpvYnMpOword2hpbGUgKHdhaXRwaWQoLTEs IDApICE9IC0xKSB7CisgICAgaWYgKCQ/KSB7CisgICAgICAgICRhYm9ydCA9IDE7CisgICAgfQor ICAgIHNwYXduR2VuZXJhdGVCaW5kaW5nc0lmTmVlZGVkKCk7Cit9CiBleGl0ICRhYm9ydDsKIAog c3ViIG5lZWRzVXBkYXRlCkBAIC0xNTcsMjAgKzE1OSwxNiBAQCBzdWIgbXRpbWUKICAgICByZXR1 cm4gKHN0YXQgJGZpbGUpWzldOwogfQogCi1zdWIgd29ya2VyIHsKLSAgICB3aGlsZSAobXkgJGZp bGUgPSAkcXVldWUtPmRlcXVldWVfbmIoKSkgewotICAgICAgICBsYXN0IGlmICRhYm9ydDsKLSAg ICAgICAgZXZhbCB7Ci0gICAgICAgICAgICAkY3VycmVudENvdW50Kys7Ci0gICAgICAgICAgICBt eSAkYmFzZW5hbWUgPSBiYXNlbmFtZSgkZmlsZSk7Ci0gICAgICAgICAgICBwcmludFByb2dyZXNz KCJbJGN1cnJlbnRDb3VudC8kdG90YWxDb3VudF0gJGJhc2VuYW1lIik7Ci0gICAgICAgICAgICBl eGVjdXRlQ29tbWFuZCgkcGVybCwgQGFyZ3MsICRmaWxlKSA9PSAwIG9yIGRpZTsKLSAgICAgICAg fTsKLSAgICAgICAgaWYgKCRAKSB7Ci0gICAgICAgICAgICAkYWJvcnQgPSAxOwotICAgICAgICAg ICAgZGllOwotICAgICAgICB9Ci0gICAgfQorc3ViIHNwYXduR2VuZXJhdGVCaW5kaW5nc0lmTmVl ZGVkCit7CisgICAgcmV0dXJuIGlmICRhYm9ydDsKKyAgICByZXR1cm4gdW5sZXNzIEBpZGxGaWxl c1RvVXBkYXRlOworICAgIG15ICRmaWxlID0gc2hpZnQgQGlkbEZpbGVzVG9VcGRhdGU7CisgICAg JGN1cnJlbnRDb3VudCsrOworICAgIG15ICRiYXNlbmFtZSA9IGJhc2VuYW1lKCRmaWxlKTsKKyAg ICBwcmludFByb2dyZXNzKCJbJGN1cnJlbnRDb3VudC8kdG90YWxDb3VudF0gJGJhc2VuYW1lIik7 CisgICAgbXkgJHBpZCA9IHNwYXduQ29tbWFuZCgkcGVybCwgQGFyZ3MsICRmaWxlKTsKKyAgICAk YWJvcnQgPSAxIHVubGVzcyBkZWZpbmVkICRwaWQ7CiB9CiAKIHN1YiBidWlsZERpcmVjdG9yeUNh Y2hlCkBAIC0xOTYsMjIgKzE5NCwyMyBAQCBzdWIgaW1wbGljaXREZXBlbmRlbmNpZXMKIAogc3Vi IGV4ZWN1dGVDb21tYW5kCiB7Ci0gICAgaWYgKCReTyBlcSAnY3lnd2luJykgewotICAgICAgICAj ICdzeXN0ZW0nIG9mIEN5Z3dpbiBQZXJsIGRvZXNuJ3Qgc2VlbSB0aHJlYWQtc2FmZQotICAgICAg ICBteSAkcGlkID0gZm9yaygpOwotICAgICAgICBkZWZpbmVkKCRwaWQpIG9yIGRpZTsKLSAgICAg ICAgaWYgKCRwaWQgPT0gMCkgewotICAgICAgICAgICAgZXhlYyhAXykgb3IgZGllOwotICAgICAg ICB9Ci0gICAgICAgIHdhaXRwaWQoJHBpZCwgMCk7Ci0gICAgICAgIHJldHVybiAkPzsKLSAgICB9 CiAgICAgaWYgKCReTyBlcSAnTVNXaW4zMicpIHsKICAgICAgICAgcmV0dXJuIHN5c3RlbShxdW90 ZUNvbW1hbmQoQF8pKTsKICAgICB9CiAgICAgcmV0dXJuIHN5c3RlbShAXyk7CiB9CiAKK3N1YiBz cGF3bkNvbW1hbmQKK3sKKyAgICBteSAkcGlkID0gZm9yaygpOworICAgIGlmICgkcGlkID09IDAp IHsKKyAgICAgICAgQF8gPSBxdW90ZUNvbW1hbmQoQF8pIGlmICgkXk8gZXEgJ01TV2luMzInKTsK KyAgICAgICAgZXhlYyhAXyk7CisgICAgICAgIGRpZSAiQ2Fubm90IGV4ZWMiOworICAgIH0KKyAg ICByZXR1cm4gJHBpZDsKK30KKwogc3ViIHF1b3RlQ29tbWFuZAogewogICAgIHJldHVybiBtYXAg ewo=