170086 2017-03-24 16:54:45 -0700 Add some instrumentation in Heap::resumeThePeriphery() to help debug an issue. 2017-03-24 22:35:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo jfbastien keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1291080 0 mark.lam 2017-03-24 16:54:45 -0700 Adding some instrumentation in Heap::resumeThePeriphery() to dump some Heap state just before we RELEASE_ASSERT_NOT_REACHED. 1291081 1 webkit-bug-importer 2017-03-24 16:55:40 -0700 <rdar://problem/31253673> 1291104 2 305347 mark.lam 2017-03-24 17:56:12 -0700 Created attachment 305347 proposed patch. 1291142 3 305347 saam 2017-03-24 20:48:55 -0700 Comment on attachment 305347 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=305347&action=review > Source/JavaScriptCore/heap/Heap.cpp:1502 > +#if OS(DARWIN) Can you also put a FIXME here with a bug number so we can consider removing this once we find the bug? 1291153 4 mark.lam 2017-03-24 22:35:26 -0700 (In reply to Saam Barati from comment #3) > Can you also put a FIXME here with a bug number so we can consider removing > this once we find the bug? Thanks for the review. I've added the FIXME with bug https://bugs.webkit.org/show_bug.cgi?id=170094. Landed in r214393: <http://trac.webkit.org/r214393>. 305347 2017-03-24 17:56:12 -0700 2017-03-24 20:48:55 -0700 proposed patch. bug-170086.patch text/plain 2089 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE0Mzg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE3LTAzLTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgc29tZSBpbnN0cnVtZW50YXRpb24gaW4gSGVhcDo6cmVzdW1lVGhlUGVyaXBoZXJ5KCkgdG8g aGVscCBkZWJ1ZyBhbiBpc3N1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3MDA4NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzEyNTM2NzM+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIHNv bWUgaW5zdHJ1bWVudGF0aW9uIGluIEhlYXA6OnJlc3VtZVRoZVBlcmlwaGVyeSgpIHRvIGR1bXAg c29tZSBIZWFwIHN0YXRlCisgICAgICAgIGp1c3QgYmVmb3JlIHdlIFJFTEVBU0VfQVNTRVJUX05P VF9SRUFDSEVELgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVh cDo6cmVzdW1lVGhlUGVyaXBoZXJ5KToKKwogMjAxNy0wMy0yNCAgSkYgQmFzdGllbiAgPGpmYmFz dGllbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViQXNzZW1ibHk6IHN0b3JlIHN0YXRlIGluIFRM UyBpbnN0ZWFkIG9mIG9uIFZNCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFw LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAko cmV2aXNpb24gMjE0MzczKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE0OTksNiArMTQ5OSwyOCBAQCBORVZFUl9JTkxJTkUgdm9pZCBI ZWFwOjpyZXN1bWVUaGVQZXJpcGhlCiAgICAgCiAgICAgaWYgKCFtX2NvbGxlY3RvckJlbGlldmVz VGhhdFRoZVdvcmxkSXNTdG9wcGVkKSB7CiAgICAgICAgIGRhdGFMb2coIkZhdGFsOiBjb2xsZWN0 b3IgZG9lcyBub3QgYmVsaWV2ZSB0aGF0IHRoZSB3b3JsZCBpcyBzdG9wcGVkLlxuIik7CisjaWYg T1MoREFSV0lOKQorI2lmIENQVShYODZfNjQpCisgICAgICAgIHVuc2lnbmVkIHdvcmxkU3RhdGUg PSBtX3dvcmxkU3RhdGUubG9hZCgpOworICAgICAgICBhc20gdm9sYXRpbGUoCisgICAgICAgICAg ICAiaW50MyIKKyAgICAgICAgICAgIDoKKyAgICAgICAgICAgIDogImEiKG1fY3VycmVudFBoYXNl KSwgImIiKG1fbmV4dFBoYXNlKSwgImMiKHdvcmxkU3RhdGUpLCAiUyIobV9sYXN0U2VydmVkVGlj a2V0KSwgIkQiKG1fbGFzdEdyYW50ZWRUaWNrZXQpCisgICAgICAgICAgICA6ICJtZW1vcnkiKTsK KyNlbGlmIENQVShBUk02NCkKKyAgICAgICAgdW5zaWduZWQgd29ybGRTdGF0ZSA9IG1fd29ybGRT dGF0ZS5sb2FkKCk7CisgICAgICAgIGFzbSB2b2xhdGlsZSgKKyAgICAgICAgICAgICJsZHJiIHcw LCAlMFxuIgorICAgICAgICAgICAgImxkcmIgdzEsICUxXG4iCisgICAgICAgICAgICAibGRyIHcy LCAlMlxuIgorICAgICAgICAgICAgImxkciB4MywgJTNcbiIKKyAgICAgICAgICAgICJsZHIgeDQs ICU0XG4iCisgICAgICAgICAgICAiYnJrICMwIgorICAgICAgICAgICAgOgorICAgICAgICAgICAg OiAibSIobV9jdXJyZW50UGhhc2UpLCAibSIobV9uZXh0UGhhc2UpLCAibSIod29ybGRTdGF0ZSks ICJtIihtX2xhc3RTZXJ2ZWRUaWNrZXQpLCAibSIobV9sYXN0R3JhbnRlZFRpY2tldCkKKyAgICAg ICAgICAgIDogIm1lbW9yeSIpOworI2VuZGlmCisjZW5kaWYgLy8gT1MoREFSV0lOKQogICAgICAg ICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KICAgICBtX2NvbGxlY3RvckJl bGlldmVzVGhhdFRoZVdvcmxkSXNTdG9wcGVkID0gZmFsc2U7Cg==