170028 2017-03-23 15:40:06 -0700 webkitpy should be able to run API tests 2020-06-19 18:24:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=106596 https://bugs.webkit.org/show_bug.cgi?id=213421 P2 Normal --- 170021 1 webkit webkit-unassigned aakash_jain ap buildbot commit-queue glenn rniwa sam oldest_to_newest 1290620 0 webkit 2017-03-23 15:40:06 -0700 webkitpy should be able to run API tests 1290625 1 305233 webkit 2017-03-23 15:43:49 -0700 Created attachment 305233 Patch 1290780 2 sam 2017-03-24 05:37:15 -0700 I don't understand why this is necessary? The api tests script is perl script, why involve another language? 1290809 3 ap 2017-03-24 09:00:32 -0700 It's to run API tests in EWS, which is all written in Python. 1290901 4 305233 ap 2017-03-24 11:50:17 -0700 Comment on attachment 305233 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305233&action=review > Tools/Scripts/webkitpy/tool/steps/runtests.py:65 > + if self._options.group == "api": I'm not sure if this is quite right. As API tests run together with regular ones, marking the EWS queue as "api" doesn't seem to make sense. 1290923 5 webkit 2017-03-24 12:17:49 -0700 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 305233 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305233&action=review > > > Tools/Scripts/webkitpy/tool/steps/runtests.py:65 > > + if self._options.group == "api": > > I'm not sure if this is quite right. As API tests run together with regular > ones, marking the EWS queue as "api" doesn't seem to make sense. This code runs when webkit-patch calls itself using a command such as "webkit-patch build-and-test --test --non-interactive --group=x". What's being checked here is the value of x that was passed, not any property of the queue itself. The arguments above are generated in PatchAnalysisTask, which will be changed to allow group=api for running the API tests. 1290925 6 webkit 2017-03-24 12:22:54 -0700 They won't always run together with the layout tests, for example if only one of them needs to be re-tested. So, we need a way to run them independently. The code in EarlyWarningSystem, EarlyWarningSystemTask etc would then decide whether to run both (default), or just one. 1290998 7 305233 commit-queue 2017-03-24 14:24:02 -0700 Comment on attachment 305233 Patch Clearing flags on attachment: 305233 Committed r214377: <http://trac.webkit.org/changeset/214377> 1290999 8 commit-queue 2017-03-24 14:24:06 -0700 All reviewed patches have been landed. Closing bug. 1524823 9 dbates 2019-04-05 14:28:03 -0700 *** Bug 106596 has been marked as a duplicate of this bug. *** 305233 2017-03-23 15:43:49 -0700 2017-03-24 14:24:02 -0700 Patch bug-170028-20170323154348.patch text/plain 5736 webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MzEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDU1NWNkMzRlYWJjY2ZmYjQ5MmNlNDYzODgzODNhMGY1 MDhkYWNmNS4uZGExYTA0OTcyNjYzMDI2NmNhNTBhM2NjMWVkZWU5ZGU0NzJmMTQ3MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE3LTAzLTIzICBTcmluaXZhc2FuIFZpamF5YXJhZ2hhdmFuICA8c3ZpamF5YXJhZ2hh dmFuQGFwcGxlLmNvbT4KKworICAgICAgICB3ZWJraXRweSBzaG91bGQgYmUgYWJsZSB0byBydW4g QVBJIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzAwMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weToKKyAgICAgICAgKERl cHJlY2F0ZWRQb3J0LnJ1bl9hcGlfdGVzdHNfY29tbWFuZCk6IEFkZGVkLgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5OgorICAgICAgICAoUG9ydC5hcGlfcmVzdWx0c19k aXJlY3RvcnkpOiBBZGRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMv cnVudGVzdHMucHk6CisgICAgICAgIChSdW5UZXN0cy5ydW4pOiBDaGVjayBpZiB3ZSBzaG91bGQg YmUgcnVubmluZyBBUEkgdGVzdHMuCisgICAgICAgIChSdW5UZXN0cy5fcnVuX2FwaV90ZXN0cyk6 IEdlbmVyYXRlIHNjcmlwdCB0byBydW4gQVBJIHRlc3RzIHdpdGgganNvbiBvdXRwdXQuCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3N0ZXBzX3VuaXR0ZXN0LnB5OiBVbml0 IHRlc3RzLgorCiAyMDE3LTAzLTIyICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAog ICAgICAgICBbQ29jb2FdIEFkZCBhbiBvcHRpb24gdG8gZXhjbHVkZSBvdmVyZmxvdyB3aGVuIHNu YXBzaG90dGluZyBhIFdLV2ViUHJvY2Vzc1BsdWdJbk5vZGVIYW5kbGUKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weQppbmRleCA5OWE3Zjc1ZmUzMWM1N2M1 ZGViMjk2ZGI4YWM5MjhiMTQxYzNmYzlmLi4xZWUwZGEwZmRlMzg1MmM4ZTdjNDYxMjAzY2RjYTkz YWQ1Mzk5ZTdjIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25m aWcvcG9ydHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3Bv cnRzLnB5CkBAIC0xMzAsNiArMTMwLDEwIEBAIGNsYXNzIERlcHJlY2F0ZWRQb3J0KG9iamVjdCk6 CiAgICAgZGVmIHJ1bl9iaW5kaW5nc190ZXN0c19jb21tYW5kKHNlbGYpOgogICAgICAgICByZXR1 cm4gc2VsZi5zY3JpcHRfc2hlbGxfY29tbWFuZCgicnVuLWJpbmRpbmdzLXRlc3RzIikKIAorICAg IGRlZiBydW5fYXBpX3Rlc3RzX2NvbW1hbmQoc2VsZiwgYnVpbGRfc3R5bGU9Tm9uZSk6CisgICAg ICAgIGNvbW1hbmQgPSBzZWxmLnNjcmlwdF9zaGVsbF9jb21tYW5kKCJydW4tYXBpLXRlc3RzIikK KyAgICAgICAgcmV0dXJuIHNlbGYuX2FwcGVuZF9idWlsZF9zdHlsZV9mbGFnKGNvbW1hbmQsIGJ1 aWxkX3N0eWxlKQorCiAKIGNsYXNzIElPU1BvcnQoRGVwcmVjYXRlZFBvcnQpOgogICAgIHBvcnRf ZmxhZ19uYW1lID0gImlvcy1kZXZpY2UiCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvYmFzZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5Cmlu ZGV4IGVhNGVhNTc3OWE1ZDM2NmRkZTlkNDA0ZWZhNzYyMTQwNTUxNmI5MGYuLmJkNmM5ZjZhNWFj OGQ5MTg4YzcwYTc2ODVlYzE3MDNhNDQ3ZWM5NjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC9iYXNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9i YXNlLnB5CkBAIC04MTQsNiArODE0LDkgQEAgY2xhc3MgUG9ydChvYmplY3QpOgogICAgIGRlZiBi aW5kaW5nc19yZXN1bHRzX2RpcmVjdG9yeShzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYuX2J1 aWxkX3BhdGgoKQogCisgICAgZGVmIGFwaV9yZXN1bHRzX2RpcmVjdG9yeShzZWxmKToKKyAgICAg ICAgcmV0dXJuIHNlbGYuX2J1aWxkX3BhdGgoKQorCiAgICAgZGVmIHJlc3VsdHNfZGlyZWN0b3J5 KHNlbGYpOgogICAgICAgICAiIiJBYnNvbHV0ZSBwYXRoIHRvIHRoZSBwbGFjZSB0byBzdG9yZSB0 aGUgdGVzdCByZXN1bHRzICh1c2VzIC0tcmVzdWx0cy1kaXJlY3RvcnkpLiIiIgogICAgICAgICBp ZiBub3Qgc2VsZi5fcmVzdWx0c19kaXJlY3Rvcnk6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvc3RlcHMvcnVudGVzdHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvc3RlcHMvcnVudGVzdHMucHkKaW5kZXggYjQ1Y2E0ZTQ0NTBmODlhZjhlZTYxNWRjZjUy ZTdiMGJmMGFiMDc4Yy4uMWFlZTcxMmM2ZTA0MWJkNDliZjAwMGI4MWFmY2FlNWFjMTM0YjZlMCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3J1bnRlc3RzLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9ydW50ZXN0cy5weQpAQCAt NjIsNiArNjIsMTAgQEAgY2xhc3MgUnVuVGVzdHMoQWJzdHJhY3RTdGVwKToKICAgICAgICAgICAg IHNlbGYuX3J1bl9qYXZhc2NyaXB0Y29yZV90ZXN0cygpCiAgICAgICAgICAgICByZXR1cm4KIAor ICAgICAgICBpZiBzZWxmLl9vcHRpb25zLmdyb3VwID09ICJhcGkiOgorICAgICAgICAgICAgc2Vs Zi5fcnVuX2FwaV90ZXN0cygpCisgICAgICAgICAgICByZXR1cm4KKwogICAgICAgICBpZiBzZWxm Ll9vcHRpb25zLmdyb3VwID09ICJiaW5kaW5ncyI6CiAgICAgICAgICAgICBzZWxmLl9ydW5fYmlu ZGluZ3NfdGVzdHMoKQogICAgICAgICAgICAgcmV0dXJuCkBAIC0xNjksMyArMTczLDEwIEBAIGNs YXNzIFJ1blRlc3RzKEFic3RyYWN0U3RlcCk6CiAgICAgICAgIHJlc3VsdHNfZmlsZV9wYXRoID0g c2VsZi5fdG9vbC5maWxlc3lzdGVtLmpvaW4ocmVzdWx0c19kaXJlY3RvcnksICJiaW5kaW5nc190 ZXN0X3Jlc3VsdHMuanNvbiIpCiAgICAgICAgIGFyZ3MuYXBwZW5kKCItLWpzb24tb3V0cHV0PSVz IiAlIHJlc3VsdHNfZmlsZV9wYXRoKQogICAgICAgICBzZWxmLl90b29sLmV4ZWN1dGl2ZS5ydW5f YW5kX3Rocm93X2lmX2ZhaWwoYXJncywgY3dkPXNlbGYuX3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9v dCkKKworICAgIGRlZiBfcnVuX2FwaV90ZXN0cyhzZWxmKToKKyAgICAgICAgYXJncyA9IHNlbGYu X3Rvb2wuZGVwcmVjYXRlZF9wb3J0KCkucnVuX2FwaV90ZXN0c19jb21tYW5kKHNlbGYuX29wdGlv bnMuYnVpbGRfc3R5bGUpCisgICAgICAgIHJlc3VsdHNfZGlyZWN0b3J5ID0gc2VsZi5fdG9vbC5w b3J0X2ZhY3RvcnkuZ2V0KG9wdGlvbnM9c2VsZi5fb3B0aW9ucykuYXBpX3Jlc3VsdHNfZGlyZWN0 b3J5KCkKKyAgICAgICAgcmVzdWx0c19maWxlX3BhdGggPSBzZWxmLl90b29sLmZpbGVzeXN0ZW0u am9pbihyZXN1bHRzX2RpcmVjdG9yeSwgImFwaV90ZXN0X3Jlc3VsdHMuanNvbiIpCisgICAgICAg IGFyZ3MuYXBwZW5kKCItLWpzb24tb3V0cHV0PSVzIiAlIHJlc3VsdHNfZmlsZV9wYXRoKQorICAg ICAgICBzZWxmLl90b29sLmV4ZWN1dGl2ZS5ydW5fYW5kX3Rocm93X2lmX2ZhaWwoYXJncywgY3dk PXNlbGYuX3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9zdGVwcy9zdGVwc191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9zdGVwcy9zdGVwc191bml0dGVzdC5weQppbmRleCA2YzA2NjY4NzVlZDE1 ZjcyMTdiYzkyMWEzY2FjMDkzMGMwZTg2ZGI5Li45YWU4MWFhZWQ5MjQ0N2U0ODM5NzdjYmE3Y2U3 ZWY4NjgyMzVmZGE3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3Rl cHMvc3RlcHNfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0 ZXBzL3N0ZXBzX3VuaXR0ZXN0LnB5CkBAIC0yODIsMyArMjgyLDI5IEBAIFRoaXMgcGF0Y2ggZG9l cyBub3QgaGF2ZSByZWxldmFudCBjaGFuZ2VzLgogICAgICAgICBleHBlY3RlZF9sb2dzID0gIiIi Q2hlY2tpbmcgcmVsZXZhbmNlIG9mIHBhdGNoCiBUaGlzIHBhdGNoIGRvZXMgbm90IGhhdmUgcmVs ZXZhbnQgY2hhbmdlcy4KICIiIgorCisgICAgZGVmIHRlc3RfcnVudGVzdHNfYXBpKHNlbGYpOgor ICAgICAgICBtb2NrX29wdGlvbnMgPSBzZWxmLl9zdGVwX29wdGlvbnMoKQorICAgICAgICBtb2Nr X29wdGlvbnMubm9uX2ludGVyYWN0aXZlID0gRmFsc2UKKyAgICAgICAgbW9ja19vcHRpb25zLmJ1 aWxkX3N0eWxlID0gInJlbGVhc2UiCisgICAgICAgIG1vY2tfb3B0aW9ucy5ncm91cCA9ICJhcGki CisgICAgICAgIHN0ZXAgPSBzdGVwcy5SdW5UZXN0cyhNb2NrVG9vbChsb2dfZXhlY3V0aXZlPVRy dWUpLCBtb2NrX29wdGlvbnMpCisgICAgICAgIHRvb2wgPSBNb2NrVG9vbChsb2dfZXhlY3V0aXZl PVRydWUpCisgICAgICAgIHRvb2wuX2RlcHJlY2F0ZWRfcG9ydCA9IERlcHJlY2F0ZWRQb3J0KCkK KyAgICAgICAgc3RlcCA9IHN0ZXBzLlJ1blRlc3RzKHRvb2wsIG1vY2tfb3B0aW9ucykKKyAgICAg ICAgZXhwZWN0ZWRfbG9ncyA9ICIiIk1PQ0sgcnVuX2FuZF90aHJvd19pZl9mYWlsOiBbJ1Rvb2xz L1NjcmlwdHMvcnVuLWFwaS10ZXN0cycsICctLXJlbGVhc2UnLCAnLS1qc29uLW91dHB1dD0vdG1w L2FwaV90ZXN0X3Jlc3VsdHMuanNvbiddLCBjd2Q9L21vY2stY2hlY2tvdXQKKyIiIgorICAgICAg ICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgc3RlcC5ydW4sIFt7fV0sIGV4 cGVjdGVkX2xvZ3M9ZXhwZWN0ZWRfbG9ncykKKworICAgIGRlZiB0ZXN0X3J1bnRlc3RzX2FwaV9k ZWJ1ZyhzZWxmKToKKyAgICAgICAgbW9ja19vcHRpb25zID0gc2VsZi5fc3RlcF9vcHRpb25zKCkK KyAgICAgICAgbW9ja19vcHRpb25zLm5vbl9pbnRlcmFjdGl2ZSA9IEZhbHNlCisgICAgICAgIG1v Y2tfb3B0aW9ucy5idWlsZF9zdHlsZSA9ICJkZWJ1ZyIKKyAgICAgICAgbW9ja19vcHRpb25zLmdy b3VwID0gImFwaSIKKyAgICAgICAgc3RlcCA9IHN0ZXBzLlJ1blRlc3RzKE1vY2tUb29sKGxvZ19l eGVjdXRpdmU9VHJ1ZSksIG1vY2tfb3B0aW9ucykKKyAgICAgICAgdG9vbCA9IE1vY2tUb29sKGxv Z19leGVjdXRpdmU9VHJ1ZSkKKyAgICAgICAgdG9vbC5fZGVwcmVjYXRlZF9wb3J0ID0gRGVwcmVj YXRlZFBvcnQoKQorICAgICAgICBzdGVwID0gc3RlcHMuUnVuVGVzdHModG9vbCwgbW9ja19vcHRp b25zKQorICAgICAgICBleHBlY3RlZF9sb2dzID0gIiIiTU9DSyBydW5fYW5kX3Rocm93X2lmX2Zh aWw6IFsnVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzJywgJy0tZGVidWcnLCAnLS1qc29uLW91 dHB1dD0vdG1wL2FwaV90ZXN0X3Jlc3VsdHMuanNvbiddLCBjd2Q9L21vY2stY2hlY2tvdXQKKyIi IgorICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgc3RlcC5ydW4s IFt7fV0sIGV4cGVjdGVkX2xvZ3M9ZXhwZWN0ZWRfbG9ncykK