169987 2017-03-22 18:52:24 -0700 NeverDestroyed<MediaQueryEvaluator> must explicitly construct with a String 2017-03-23 11:26:00 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 169245 1 dino webkit-unassigned sam oldest_to_newest 1290313 0 dino 2017-03-22 18:52:24 -0700 CSSDefaultStyleSheets creates a static MediaQueryEvaluator, but thanks to the template magic of NeverDestroyed, it was converting the char* argument into a bool, and calling the wrong constructor. 1290314 1 dino 2017-03-22 18:53:04 -0700 <rdar://problem/31211087> 1290315 2 305152 dino 2017-03-22 18:57:04 -0700 Created attachment 305152 Patch 1290505 3 dino 2017-03-23 11:19:12 -0700 Committed r214305: <http://trac.webkit.org/changeset/214305> 305152 2017-03-22 18:57:04 -0700 2017-03-23 00:42:28 -0700 Patch media.patch text/plain 2249 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZmVjMzc5ZDc1OC4uZGI1YjJjY2NlMWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNy0wMy0yMiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisK KyAgICAgICAgTmV2ZXJEZXN0cm95ZWQ8TWVkaWFRdWVyeUV2YWx1YXRvcj4gbXVzdCBleHBsaWNp dGx5IGNvbnN0cnVjdCB3aXRoIGEgU3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk5ODcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxMjEx MDg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENT U0RlZmF1bHRTdHlsZVNoZWV0cyBjcmVhdGVzIGEgc3RhdGljIE1lZGlhUXVlcnlFdmFsdWF0b3Is IGJ1dCB0aGFua3MKKyAgICAgICAgdG8gdGhlIHRlbXBsYXRlIG1hZ2ljIG9mIE5ldmVyRGVzdHJv eWVkLCBpdCB3YXMgY29udmVydGluZyB0aGUgY2hhcioKKyAgICAgICAgYXJndW1lbnQgaW50byBh IGJvb2wsIGFuZCBjYWxsaW5nIHRoZSB3cm9uZyBjb25zdHJ1Y3Rvci4KKworICAgICAgICBVbmZv cnR1bmF0ZWx5IHRoaXMgaXMgZGlmZmljdWx0IHRvIHRlc3QgYmVjYXVzZSBpdCBvbmx5IGFmZmVj dHMKKyAgICAgICAgdGhlIGRlZmF1bHQgVUEgc3R5bGUgc2hlZXRzLCBhbmQgdGhleSBjdXJyZW50 bHkgZG9uJ3QgaGF2ZQorICAgICAgICBhbmQgQG1lZGlhIHJ1bGVzICh3aGljaCB3b3VsZCBhbHdh eXMgZXZhbHVhdGUgdG8gdHJ1ZSBnaXZlbgorICAgICAgICB0aGUgYnVnKS4gSSBkb24ndCB3YW50 IHRvIHB1dCBpbiBhIHVzZWxlc3MgcnVsZSBqdXN0IHRvIGNoZWNrCisgICAgICAgIGlmIHRoZSBi dWcgaXMgZml4ZWQuIFdoZW4gb25lIGlzIGFkZGVkIGZvciBidWcgMTY4NDQ3LCB0aGlzIGNoYW5n ZQorICAgICAgICB3aWxsIGJlIGV4ZXJjaXNlZC4KKworICAgICAgICAqIGNzcy9DU1NEZWZhdWx0 U3R5bGVTaGVldHMuY3BwOiBFeHBsaWNpdGx5IGNvbnN0cnVjdCB3aXRoIGEgU3RyaW5nCisgICAg ICAgIHJhdGhlciB0aGFuIGEgY2hhciouCisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5FdmFsKToK KyAgICAgICAgKFdlYkNvcmU6OnByaW50RXZhbCk6CisKIDIwMTctMDMtMjIgIEFudHRpIEtvaXZp c3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIER5bmFtaWNhbGx5IGFwcGxpZWQgOmVt cHR5IHBzZXVkbyBjbGFzcyB3aXRoIGRpc3BsYXk6bm9uZSBkb2VzIG5vdCBnZXQgdW5hcHBsaWVk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRGVmYXVsdFN0eWxlU2hlZXRzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NEZWZhdWx0U3R5bGVTaGVldHMuY3BwCmluZGV4IDU1 MzM1YzA4OGQxLi5iOWI0MGRkOGFjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U0RlZmF1bHRTdHlsZVNoZWV0cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0RlZmF1 bHRTdHlsZVNoZWV0cy5jcHAKQEAgLTg0LDEzICs4NCwxMyBAQCBzdGF0aWMgaW5saW5lIGJvb2wg ZWxlbWVudENhblVzZVNpbXBsZURlZmF1bHRTdHlsZShjb25zdCBFbGVtZW50JiBlbGVtZW50KQog CiBzdGF0aWMgY29uc3QgTWVkaWFRdWVyeUV2YWx1YXRvciYgc2NyZWVuRXZhbCgpCiB7Ci0gICAg c3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IE1lZGlhUXVlcnlFdmFsdWF0b3I+IHN0YXRpY1Nj cmVlbkV2YWwoInNjcmVlbiIpOworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxjb25zdCBNZWRp YVF1ZXJ5RXZhbHVhdG9yPiBzdGF0aWNTY3JlZW5FdmFsKFN0cmluZyhBU0NJSUxpdGVyYWwoInNj cmVlbiIpKSk7CiAgICAgcmV0dXJuIHN0YXRpY1NjcmVlbkV2YWw7CiB9CiAKIHN0YXRpYyBjb25z dCBNZWRpYVF1ZXJ5RXZhbHVhdG9yJiBwcmludEV2YWwoKQogewotICAgIHN0YXRpYyBOZXZlckRl c3Ryb3llZDxjb25zdCBNZWRpYVF1ZXJ5RXZhbHVhdG9yPiBzdGF0aWNQcmludEV2YWwoInByaW50 Iik7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IE1lZGlhUXVlcnlFdmFsdWF0b3I+ IHN0YXRpY1ByaW50RXZhbChTdHJpbmcoQVNDSUlMaXRlcmFsKCJwcmludCIpKSk7CiAgICAgcmV0 dXJuIHN0YXRpY1ByaW50RXZhbDsKIH0KIAo=