169856 2017-03-18 16:41:35 -0700 Web Inspector: Clicking DOM breakpoint marker should enable/disable breakpoints 2017-03-22 10:41:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1289328 0 mattbaker 2017-03-18 16:41:35 -0700 Summary: Clicking DOM breakpoint marker should enable/disable breakpoints. Behavior should match the breakpoint marker context menu: 1) If one or more breakpoints is disabled, clicking enables all. 2) If all breakpoints are enabled, clicked disables all. 1289329 1 webkit-bug-importer 2017-03-18 16:42:02 -0700 <rdar://problem/31133090> 1289331 2 304886 mattbaker 2017-03-18 16:44:56 -0700 Created attachment 304886 Patch 1289634 3 304886 joepeck 2017-03-20 16:51:00 -0700 Comment on attachment 304886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304886&action=review Nice! r=me > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1696 > + _statusImageClicked(event) > + { The element handles contextmenu but what if a 3 button mouse user does a middle-click? We should match what regular breakpoints do, but a lot of our code does this dance: if (event.button !== 0 || event.ctrlKey) return; 1289643 4 mattbaker 2017-03-20 17:14:10 -0700 (In reply to comment #3) > Comment on attachment 304886 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304886&action=review > > Nice! r=me > > > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1696 > > + _statusImageClicked(event) > > + { > > The element handles contextmenu but what if a 3 button mouse user does a > middle-click? We should match what regular breakpoints do, but a lot of our > code does this dance: > > if (event.button !== 0 || event.ctrlKey) > return; It looks like line widgets for breakpoints handle mouse up, and don't do any button checks (other than to make sure a drag wasn't taking place). 1289648 5 joepeck 2017-03-20 17:17:11 -0700 > It looks like line widgets for breakpoints handle mouse up, and don't do any > button checks (other than to make sure a drag wasn't taking place). Maybe we should improve that then too! 1289797 6 mattbaker 2017-03-21 12:35:51 -0700 (In reply to Joseph Pecoraro from comment #5) > > It looks like line widgets for breakpoints handle mouse up, and don't do any > > button checks (other than to make sure a drag wasn't taking place). > > Maybe we should improve that then too! It turns out we do make the check, in TextEditor.prototype._gutterMouseDown before we add the mouse up event listener. 1289799 7 305012 mattbaker 2017-03-21 12:37:24 -0700 Created attachment 305012 Patch for landing 1290099 8 commit-queue 2017-03-22 10:40:46 -0700 The commit-queue encountered the following flaky tests while processing attachment 305012: media/track/track-in-band-style.html bug 153143 (authors: dgorbik@apple.com, eric.carlson@apple.com, and jer.noble@apple.com) The commit-queue is continuing to process your patch. 1290100 9 305012 commit-queue 2017-03-22 10:41:15 -0700 Comment on attachment 305012 Patch for landing Clearing flags on attachment: 305012 Committed r214256: <http://trac.webkit.org/changeset/214256> 1290101 10 commit-queue 2017-03-22 10:41:19 -0700 All reviewed patches have been landed. Closing bug. 304886 2017-03-18 16:44:56 -0700 2017-03-21 12:37:20 -0700 Patch bug-169856-20170318164456.patch text/plain 2845 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 YmM0OTgyM2M0YjJjMzViZmFmZmJhOTgwNzdhNDUxZjM3ZmE1MGViLi43MTg0ZjRmMDA2YWY1ZTEx YmZlODRhMjJkNjAzZDIwYzRjMjM1ZGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNy0wMy0xOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xpY2tpbmcgRE9NIGJyZWFrcG9pbnQgbWFya2Vy IHNob3VsZCBlbmFibGUvZGlzYWJsZSBicmVha3BvaW50cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5ODU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8zMTEzMzA5MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDbGlja2luZyBET00gYnJlYWtwb2ludCBtYXJrZXIgc2hvdWxkIGVuYWJsZS9kaXNhYmxl IGJyZWFrcG9pbnRzLAorICAgICAgICBtYXRjaGluZyB0aGUgYmVoYXZpb3Igb2YgdGhlIG1hcmtl cidzIGNvbnRleHQgbWVudToKKworICAgICAgICAtIElmIG9uZSBvciBtb3JlIGJyZWFrcG9pbnRz IGFyZSBkaXNhYmxlZCwgY2xpY2sgZW5hYmxlcyBhbGwKKyAgICAgICAgLSBJZiBhbGwgYnJlYWtw b2ludHMgYXJlIGVuYWJsZWQsIGNsaWNrIGRpc2FibGVzIGFsbAorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5E T01UcmVlRWxlbWVudC5wcm90b3R5cGUuX3VwZGF0ZUJyZWFrcG9pbnRTdGF0dXMpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5fc3RhdHVzSW1hZ2VDbGlj a2VkKToKKwogMjAxNy0wMy0xNyAgRGV2aW4gUm91c3NvICA8d2Via2l0QGRldmlucm91c3NvLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiB3cm9uZyBmaWxlbmFtZSB3aGVuIHNhdmluZyBy ZXNvdXJjZSBmcm9tIFJlc291cmNlSW1hZ2VDb250ZW50VmlldwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5q cwppbmRleCAxYmI5ZjYyNjUyNWFhOWE4N2E2ZDU3NDI4N2QyMjU3MTA4YWMyZWI2Li4zODQ0ZTIw YzZiZjIxMjcyNDgxM2QwYmUyZTQwODgzODE2NzVlZjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5q cwpAQCAtMTY4MSw2ICsxNjgxLDcgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50ID0gY2xh c3MgRE9NVHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVHJlZUVsZW0KICAgICAgICAg aWYgKCF0aGlzLl9zdGF0dXNJbWFnZUVsZW1lbnQpIHsKICAgICAgICAgICAgIHRoaXMuX3N0YXR1 c0ltYWdlRWxlbWVudCA9IHVzZVNWR1N5bWJvbCgiSW1hZ2VzL0RPTUJyZWFrcG9pbnQuc3ZnIiwg InN0YXR1cy1pbWFnZSIpOwogICAgICAgICAgICAgdGhpcy5fc3RhdHVzSW1hZ2VFbGVtZW50LmNs YXNzTGlzdC5hZGQoImJyZWFrcG9pbnQiKTsKKyAgICAgICAgICAgIHRoaXMuX3N0YXR1c0ltYWdl RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX3N0YXR1c0ltYWdlQ2xpY2tl ZC5iaW5kKHRoaXMpKTsKICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0ltYWdlRWxlbWVudC5hZGRF dmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIsIHRoaXMuX3N0YXR1c0ltYWdlQ29udGV4dG1lbnUu YmluZCh0aGlzKSk7CiAgICAgICAgICAgICB0aGlzLl9zdGF0dXNJbWFnZUVsZW1lbnQuYWRkRXZl bnRMaXN0ZW5lcigibW91c2Vkb3duIiwgKGV2ZW50KSA9PiB7IGV2ZW50LnN0b3BQcm9wYWdhdGlv bigpOyB9KTsKICAgICAgICAgfQpAQCAtMTY5MSw2ICsxNjkyLDE2IEBAIFdlYkluc3BlY3Rvci5E T01UcmVlRWxlbWVudCA9IGNsYXNzIERPTVRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG9y LlRyZWVFbGVtCiAgICAgICAgIHRoaXMuX3N0YXR1c0ltYWdlRWxlbWVudC5jbGFzc0xpc3QudG9n Z2xlKCJkaXNhYmxlZCIsIGRpc2FibGVkKTsKICAgICB9CiAKKyAgICBfc3RhdHVzSW1hZ2VDbGlj a2VkKGV2ZW50KQorICAgIHsKKyAgICAgICAgbGV0IGJyZWFrcG9pbnRzID0gV2ViSW5zcGVjdG9y LmRvbURlYnVnZ2VyTWFuYWdlci5kb21CcmVha3BvaW50c0Zvck5vZGUodGhpcy5yZXByZXNlbnRl ZE9iamVjdCk7CisgICAgICAgIGlmICghYnJlYWtwb2ludHMgfHwgIWJyZWFrcG9pbnRzLmxlbmd0 aCkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBsZXQgc2hvdWxkRW5hYmxlID0gYnJl YWtwb2ludHMuc29tZSgoYnJlYWtwb2ludCkgPT4gYnJlYWtwb2ludC5kaXNhYmxlZCk7CisgICAg ICAgIGJyZWFrcG9pbnRzLmZvckVhY2goKGJyZWFrcG9pbnQpID0+IGJyZWFrcG9pbnQuZGlzYWJs ZWQgPSAhc2hvdWxkRW5hYmxlKTsKKyAgICB9CisKICAgICBfc3RhdHVzSW1hZ2VDb250ZXh0bWVu dShldmVudCkKICAgICB7CiAgICAgICAgIGNvbnN0IGFsbG93RWRpdGluZyA9IHRydWU7Cg== 305012 2017-03-21 12:37:24 -0700 2017-03-22 10:41:15 -0700 Patch for landing bug-169856-20170321123724.patch text/plain 2907 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 N2NmY2E3Mjg0OGY0NjJmMDQyNDkzNzZhNjVlYmY1ZjcxMjI3OTE2Li5hYzZhOTNhZmU1YTJlZTE3 NmE4ZTA5NTAyOWZmNzI5NDlmZTA0ZmZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNy0wMy0yMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xpY2tpbmcgRE9NIGJyZWFrcG9pbnQgbWFya2Vy IHNob3VsZCBlbmFibGUvZGlzYWJsZSBicmVha3BvaW50cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5ODU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8zMTEzMzA5MD4KKworICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8uCisKKyAg ICAgICAgQ2xpY2tpbmcgRE9NIGJyZWFrcG9pbnQgbWFya2VyIHNob3VsZCBlbmFibGUvZGlzYWJs ZSBicmVha3BvaW50cywKKyAgICAgICAgbWF0Y2hpbmcgdGhlIGJlaGF2aW9yIG9mIHRoZSBtYXJr ZXIncyBjb250ZXh0IG1lbnU6CisKKyAgICAgICAgLSBJZiBvbmUgb3IgbW9yZSBicmVha3BvaW50 cyBhcmUgZGlzYWJsZWQsIGNsaWNrIGVuYWJsZXMgYWxsCisgICAgICAgIC0gSWYgYWxsIGJyZWFr cG9pbnRzIGFyZSBlbmFibGVkLCBjbGljayBkaXNhYmxlcyBhbGwKKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu RE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLl91cGRhdGVCcmVha3BvaW50U3RhdHVzKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudC5wcm90b3R5cGUuX3N0YXR1c0ltYWdlQ2xp Y2tlZCk6CisKIDIwMTctMDMtMjAgIERldmluIFJvdXNzbyAgPHdlYmtpdEBkZXZpbnJvdXNzby5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUlRMOiBtaW5vciBsYXlvdXQgaXNzdWVzIGlu IEJyZWFrcG9pbnQgRWRpdG9yIHBvcG92ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKaW5kZXggZWEy ZmE3MDc0NDdlYTA4MWM2N2UxYTkzOWQ0MDI2NDgzYzNjNDAxOS4uNTljNDFhM2NhYTAzOGZhODNj ODUzMTRhNWYwYzMzNmM0OTZkZGM1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKQEAgLTE2ODQs NiArMTY4NCw3IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudCA9IGNsYXNzIERPTVRyZWVF bGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRyZWVFbGVtCiAgICAgICAgIGlmICghdGhpcy5f c3RhdHVzSW1hZ2VFbGVtZW50KSB7CiAgICAgICAgICAgICB0aGlzLl9zdGF0dXNJbWFnZUVsZW1l bnQgPSB1c2VTVkdTeW1ib2woIkltYWdlcy9ET01CcmVha3BvaW50LnN2ZyIsICJzdGF0dXMtaW1h Z2UiKTsKICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0ltYWdlRWxlbWVudC5jbGFzc0xpc3QuYWRk KCJicmVha3BvaW50Iik7CisgICAgICAgICAgICB0aGlzLl9zdGF0dXNJbWFnZUVsZW1lbnQuYWRk RXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9zdGF0dXNJbWFnZUNsaWNrZWQuYmluZCh0aGlz KSk7CiAgICAgICAgICAgICB0aGlzLl9zdGF0dXNJbWFnZUVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5l cigiY29udGV4dG1lbnUiLCB0aGlzLl9zdGF0dXNJbWFnZUNvbnRleHRtZW51LmJpbmQodGhpcykp OwogICAgICAgICAgICAgdGhpcy5fc3RhdHVzSW1hZ2VFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo Im1vdXNlZG93biIsIChldmVudCkgPT4geyBldmVudC5zdG9wUHJvcGFnYXRpb24oKTsgfSk7CiAg ICAgICAgIH0KQEAgLTE2OTQsNiArMTY5NSwxOSBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1l bnQgPSBjbGFzcyBET01UcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rvci5UcmVlRWxlbQog ICAgICAgICB0aGlzLl9zdGF0dXNJbWFnZUVsZW1lbnQuY2xhc3NMaXN0LnRvZ2dsZSgiZGlzYWJs ZWQiLCBkaXNhYmxlZCk7CiAgICAgfQogCisgICAgX3N0YXR1c0ltYWdlQ2xpY2tlZChldmVudCkK KyAgICB7CisgICAgICAgIGlmIChldmVudC5idXR0b24gIT09IDAgfHwgZXZlbnQuY3RybEtleSkK KyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBsZXQgYnJlYWtwb2ludHMgPSBXZWJJbnNw ZWN0b3IuZG9tRGVidWdnZXJNYW5hZ2VyLmRvbUJyZWFrcG9pbnRzRm9yTm9kZSh0aGlzLnJlcHJl c2VudGVkT2JqZWN0KTsKKyAgICAgICAgaWYgKCFicmVha3BvaW50cyB8fCAhYnJlYWtwb2ludHMu bGVuZ3RoKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGxldCBzaG91bGRFbmFibGUg PSBicmVha3BvaW50cy5zb21lKChicmVha3BvaW50KSA9PiBicmVha3BvaW50LmRpc2FibGVkKTsK KyAgICAgICAgYnJlYWtwb2ludHMuZm9yRWFjaCgoYnJlYWtwb2ludCkgPT4gYnJlYWtwb2ludC5k aXNhYmxlZCA9ICFzaG91bGRFbmFibGUpOworICAgIH0KKwogICAgIF9zdGF0dXNJbWFnZUNvbnRl eHRtZW51KGV2ZW50KQogICAgIHsKICAgICAgICAgY29uc3QgYWxsb3dFZGl0aW5nID0gdHJ1ZTsK