169336 2017-03-07 20:17:50 -0800 Web Inspector: DOM Tree broken if an element has a "debounce" attribute 2017-03-07 21:18:43 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes jcraig joepeck webkit-bug-importer oldest_to_newest 1284721 0 joepeck 2017-03-07 20:17:50 -0800 Summary: DOM Tree broken if an element has a "debounce" attribute Test: <body><div debounce="debounceUpdate"></div></body> Steps to Reproduce: 1. Inspect reduction 2. Show Elements tree => <body> doesn't have expected <div> child. Notes: * Error in Inspector: [Error] TypeError: Attempted to assign to readonly property. _addAttribute — Main.js:9238 _setAttributesPayload — Main.js:9180 DOMNode — Main.js:8681 _setChildrenPayload — Main.js:9212 Evaluating: this._attributesMap[name] = attr; Where name is "debounce". This is hitting Object.prototype.debounce which is not writable. We should avoid these issues by making attributesMap an actually `Map` and not an Object. 1284722 1 joepeck 2017-03-07 20:18:47 -0800 <rdar://problem/30899430> 1284723 2 303766 joepeck 2017-03-07 20:20:12 -0800 Created attachment 303766 [PATCH] Proposed Fix 1284726 3 303766 bburg 2017-03-07 20:26:25 -0800 Comment on attachment 303766 [PATCH] Proposed Fix r=me 1284746 4 commit-queue 2017-03-07 21:18:10 -0800 The commit-queue encountered the following flaky tests while processing attachment 303766: media/track/track-in-band-style.html bug 153143 (authors: dgorbik@apple.com, eric.carlson@apple.com, and jer.noble@apple.com) media/track/media-element-enqueue-event-crash.html bug 117756 (authors: eric.carlson@apple.com, ggaren@apple.com, and simon.pena@samsung.com) The commit-queue is continuing to process your patch. 1284747 5 303766 commit-queue 2017-03-07 21:18:38 -0800 Comment on attachment 303766 [PATCH] Proposed Fix Clearing flags on attachment: 303766 Committed r213565: <http://trac.webkit.org/changeset/213565> 1284748 6 commit-queue 2017-03-07 21:18:43 -0800 All reviewed patches have been landed. Closing bug. 303766 2017-03-07 20:20:12 -0800 2017-03-07 21:18:38 -0800 [PATCH] Proposed Fix attributes-1.patch text/plain 3662 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNhNDNkNGNjZTVkLi4xN2E4YjNlNTllNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTctMDMtMDcgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBET00gVHJlZSBicm9rZW4gaWYgYW4gZWxlbWVudCBoYXMgYSAiZGVib3VuY2UiIGF0dHJpYnV0 ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5MzM2 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDg5OTQzMD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5v ZGUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NTm9kZSk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRE9NTm9kZS5wcm90b3R5cGUuZ2V0QXR0cmlidXRlKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5ET01Ob2RlLnByb3RvdHlwZS5yZW1vdmVBdHRyaWJ1dGUubXljYWxsYmFjayk6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuRE9NTm9kZS5wcm90b3R5cGUucmVtb3ZlQXR0cmlidXRlKToKKyAg ICAgICAgQ29udmVydCB0aGUgYXR0cmlidXRlcyBtYXAgdG8gYW4gYWN0dWFsIE1hcCB0byBhdm9p ZCBuYW1lIGNvbGxpc2lvbnMKKyAgICAgICAgd2l0aCBPYmplY3QucHJvdG90eXBlIHByb3BlcnRp ZXMuCisKIDIwMTctMDMtMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaG91bGQgYmUgYWJsZSB0byBzZWUgd2hlcmUgUmVz b3VyY2VzIGNhbWUgZnJvbSAoTWVtb3J5IENhY2hlLCBEaXNrIENhY2hlKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcwppbmRl eCA2MzZhNzU4NmYwYi4uMGZiZWRjMDEwYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzCkBAIC01Nyw3ICs1Nyw3IEBA IFdlYkluc3BlY3Rvci5ET01Ob2RlID0gY2xhc3MgRE9NTm9kZSBleHRlbmRzIFdlYkluc3BlY3Rv ci5PYmplY3QKICAgICAgICAgICAgIHRoaXMub3duZXJEb2N1bWVudCA9IGRvYzsKIAogICAgICAg ICB0aGlzLl9hdHRyaWJ1dGVzID0gW107Ci0gICAgICAgIHRoaXMuX2F0dHJpYnV0ZXNNYXAgPSB7 fTsKKyAgICAgICAgdGhpcy5fYXR0cmlidXRlc01hcCA9IG5ldyBNYXA7CiAgICAgICAgIGlmIChw YXlsb2FkLmF0dHJpYnV0ZXMpCiAgICAgICAgICAgICB0aGlzLl9zZXRBdHRyaWJ1dGVzUGF5bG9h ZChwYXlsb2FkLmF0dHJpYnV0ZXMpOwogCkBAIC0zODcsNyArMzg3LDcgQEAgV2ViSW5zcGVjdG9y LkRPTU5vZGUgPSBjbGFzcyBET01Ob2RlIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAg ICAgZ2V0QXR0cmlidXRlKG5hbWUpCiAgICAgewotICAgICAgICB2YXIgYXR0ciA9IHRoaXMuX2F0 dHJpYnV0ZXNNYXBbbmFtZV07CisgICAgICAgIGxldCBhdHRyID0gdGhpcy5fYXR0cmlidXRlc01h cC5nZXQobmFtZSk7CiAgICAgICAgIHJldHVybiBhdHRyID8gYXR0ci52YWx1ZSA6IHVuZGVmaW5l ZDsKICAgICB9CiAKQEAgLTQxMSw3ICs0MTEsNyBAQCBXZWJJbnNwZWN0b3IuRE9NTm9kZSA9IGNs YXNzIERPTU5vZGUgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAgICAgIGZ1bmN0aW9u IG15Y2FsbGJhY2soZXJyb3IsIHN1Y2Nlc3MpCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmICgh ZXJyb3IpIHsKLSAgICAgICAgICAgICAgICBkZWxldGUgdGhpcy5fYXR0cmlidXRlc01hcFtuYW1l XTsKKyAgICAgICAgICAgICAgICB0aGlzLl9hdHRyaWJ1dGVzTWFwLmRlbGV0ZShuYW1lKTsKICAg ICAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX2F0dHJpYnV0ZXMubGVuZ3Ro OyArK2kpIHsKICAgICAgICAgICAgICAgICAgICAgaWYgKHRoaXMuX2F0dHJpYnV0ZXNbaV0ubmFt ZSA9PT0gbmFtZSkgewogICAgICAgICAgICAgICAgICAgICAgICAgdGhpcy5fYXR0cmlidXRlcy5z cGxpY2UoaSwgMSk7CkBAIC02NjksNyArNjY5LDcgQEAgV2ViSW5zcGVjdG9yLkRPTU5vZGUgPSBj bGFzcyBET01Ob2RlIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgIF9zZXRBdHRyaWJ1 dGVzUGF5bG9hZChhdHRycykKICAgICB7CiAgICAgICAgIHRoaXMuX2F0dHJpYnV0ZXMgPSBbXTsK LSAgICAgICAgdGhpcy5fYXR0cmlidXRlc01hcCA9IHt9OworICAgICAgICB0aGlzLl9hdHRyaWJ1 dGVzTWFwID0gbmV3IE1hcDsKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBhdHRycy5sZW5n dGg7IGkgKz0gMikKICAgICAgICAgICAgIHRoaXMuX2FkZEF0dHJpYnV0ZShhdHRyc1tpXSwgYXR0 cnNbaSArIDFdKTsKICAgICB9CkBAIC03MzUsMTQgKzczNSwxNCBAQCBXZWJJbnNwZWN0b3IuRE9N Tm9kZSA9IGNsYXNzIERPTU5vZGUgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAKICAgICBf YWRkQXR0cmlidXRlKG5hbWUsIHZhbHVlKQogICAgIHsKLSAgICAgICAgdmFyIGF0dHIgPSB7bmFt ZSwgdmFsdWUsIF9ub2RlOiB0aGlzfTsKLSAgICAgICAgdGhpcy5fYXR0cmlidXRlc01hcFtuYW1l XSA9IGF0dHI7CisgICAgICAgIGxldCBhdHRyID0ge25hbWUsIHZhbHVlLCBfbm9kZTogdGhpc307 CisgICAgICAgIHRoaXMuX2F0dHJpYnV0ZXNNYXAuc2V0KG5hbWUsIGF0dHIpOwogICAgICAgICB0 aGlzLl9hdHRyaWJ1dGVzLnB1c2goYXR0cik7CiAgICAgfQogCiAgICAgX3NldEF0dHJpYnV0ZShu YW1lLCB2YWx1ZSkKICAgICB7Ci0gICAgICAgIHZhciBhdHRyID0gdGhpcy5fYXR0cmlidXRlc01h cFtuYW1lXTsKKyAgICAgICAgbGV0IGF0dHIgPSB0aGlzLl9hdHRyaWJ1dGVzTWFwLmdldChuYW1l KTsKICAgICAgICAgaWYgKGF0dHIpCiAgICAgICAgICAgICBhdHRyLnZhbHVlID0gdmFsdWU7CiAg ICAgICAgIGVsc2UKQEAgLTc1MSwxMCArNzUxLDEwIEBAIFdlYkluc3BlY3Rvci5ET01Ob2RlID0g Y2xhc3MgRE9NTm9kZSBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKIAogICAgIF9yZW1vdmVB dHRyaWJ1dGUobmFtZSkKICAgICB7Ci0gICAgICAgIHZhciBhdHRyID0gdGhpcy5fYXR0cmlidXRl c01hcFtuYW1lXTsKKyAgICAgICAgbGV0IGF0dHIgPSB0aGlzLl9hdHRyaWJ1dGVzTWFwLmdldChu YW1lKTsKICAgICAgICAgaWYgKGF0dHIpIHsKICAgICAgICAgICAgIHRoaXMuX2F0dHJpYnV0ZXMu cmVtb3ZlKGF0dHIpOwotICAgICAgICAgICAgZGVsZXRlIHRoaXMuX2F0dHJpYnV0ZXNNYXBbbmFt ZV07CisgICAgICAgICAgICB0aGlzLl9hdHRyaWJ1dGVzTWFwLmRlbGV0ZShuYW1lKTsKICAgICAg ICAgfQogICAgIH0KIAo=