169130 2017-03-03 05:52:57 -0800 [GTK] Ensure WebKitWebView always have a user content manager 2017-03-03 09:23:12 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 166680 1 cgarcia webkit-unassigned berto bugs-noreply commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1283139 0 cgarcia 2017-03-03 05:52:57 -0800 User content manager is a construct only property, so if not set by the user the web view doesn't have any. We can create a default one, like we do for settings, when user didn't provide one. 1283140 1 303315 cgarcia 2017-03-03 05:55:39 -0800 Created attachment 303315 Patch I need this for the new remote inspector, that uses a custom protocol page with user script messages. 1283141 2 commit-queue 2017-03-03 05:57:20 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1283152 3 303315 mcatanzaro 2017-03-03 08:02:05 -0800 Comment on attachment 303315 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303315&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2267 > * Returns: (transfer none): the #WebKitUserContentManager associated with the view So it's no longer (transfer none), then. Technically an introspection API break, but breakage should be minimal.... 1283167 4 cgarcia 2017-03-03 08:49:24 -0800 (In reply to comment #3) > Comment on attachment 303315 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=303315&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2267 > > * Returns: (transfer none): the #WebKitUserContentManager associated with the view > > So it's no longer (transfer none), then. Technically an introspection API > break, but breakage should be minimal.... Why not? the default user content manager is also owned by the web view, so this is still transfer none. 1283173 5 mcatanzaro 2017-03-03 08:57:53 -0800 (In reply to comment #4) > Why not? the default user content manager is also owned by the web view, so > this is still transfer none. Ah, dumb, sorry. I confused (transfer none) with (allow none). 1283181 6 303315 commit-queue 2017-03-03 09:23:08 -0800 Comment on attachment 303315 Patch Clearing flags on attachment: 303315 Committed r213366: <http://trac.webkit.org/changeset/213366> 1283182 7 commit-queue 2017-03-03 09:23:12 -0800 All reviewed patches have been landed. Closing bug. 303315 2017-03-03 05:55:39 -0800 2017-03-03 09:23:08 -0800 Patch wk2-default-user-content-manager.diff text/plain 2115 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhZmM0MzQwYWNhMS4uN2IyYmExZjY5YzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wMy0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRW5zdXJlIFdlYktpdFdlYlZpZXcgYWx3YXlzIGhh dmUgYSB1c2VyIGNvbnRlbnQgbWFuYWdlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY5MTMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXNlciBjb250ZW50IG1hbmFnZXIgaXMgYSBjb25zdHJ1Y3Qgb25s eSBwcm9wZXJ0eSwgc28gaWYgbm90IHNldCBieSB0aGUgdXNlciB0aGUgd2ViIHZpZXcgZG9lc24n dCBoYXZlIGFueS4gV2UKKyAgICAgICAgY2FuIGNyZWF0ZSBhIGRlZmF1bHQgb25lLCBsaWtlIHdl IGRvIGZvciBzZXR0aW5ncywgd2hlbiB1c2VyIGRpZG4ndCBwcm92aWRlIG9uZS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwOgorICAgICAgICAod2Via2l0 V2ViVmlld0NvbnN0cnVjdGVkKToKKwogMjAxNy0wMy0wMiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJlbmFtZSBodG1sZWRpdGluZy5oL2NwcCB0byBFZGl0aW5nLmgv Y3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXcuY3BwCmluZGV4IGU0ZmIyMzQxMjMzLi4wNmQwZjllYjAzNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKQEAgLTY1Niw2ICs2 NTYsOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3Q29uc3RydWN0ZWQoR09iamVjdCogb2Jq ZWN0KQogICAgIGlmICghcHJpdi0+c2V0dGluZ3MpCiAgICAgICAgIHByaXYtPnNldHRpbmdzID0g YWRvcHRHUmVmKHdlYmtpdF9zZXR0aW5nc19uZXcoKSk7CiAKKyAgICBpZiAoIXByaXYtPnVzZXJD b250ZW50TWFuYWdlcikKKyAgICAgICAgcHJpdi0+dXNlckNvbnRlbnRNYW5hZ2VyID0gYWRvcHRH UmVmKHdlYmtpdF91c2VyX2NvbnRlbnRfbWFuYWdlcl9uZXcoKSk7CisKICAgICBpZiAocHJpdi0+ aXNFcGhlbWVyYWwgJiYgIXdlYmtpdF93ZWJfY29udGV4dF9pc19lcGhlbWVyYWwocHJpdi0+Y29u dGV4dC5nZXQoKSkpIHsKICAgICAgICAgcHJpdi0+d2Vic2l0ZURhdGFNYW5hZ2VyID0gYWRvcHRH UmVmKHdlYmtpdF93ZWJzaXRlX2RhdGFfbWFuYWdlcl9uZXdfZXBoZW1lcmFsKCkpOwogICAgICAg ICB3ZWJraXRXZWJzaXRlRGF0YU1hbmFnZXJBZGRQcm9jZXNzUG9vbChwcml2LT53ZWJzaXRlRGF0 YU1hbmFnZXIuZ2V0KCksIHdlYmtpdFdlYkNvbnRleHRHZXRQcm9jZXNzUG9vbChwcml2LT5jb250 ZXh0LmdldCgpKSk7CkBAIC0yMjU5LDggKzIyNjIsNyBAQCBXZWJLaXRXZWJDb250ZXh0KiB3ZWJr aXRfd2ViX3ZpZXdfZ2V0X2NvbnRleHQoV2ViS2l0V2ViVmlldyAqd2ViVmlldykKICAqIHdlYmtp dF93ZWJfdmlld19nZXRfdXNlcl9jb250ZW50X21hbmFnZXI6CiAgKiBAd2ViX3ZpZXc6IGEgI1dl YktpdFdlYlZpZXcKICAqCi0gKiBHZXRzIHRoZSB1c2VyIGNvbnRlbnQgbWFuYWdlciBhc3NvY2lh dGVkIHRvIEB3ZWJfdmlldywgb3IgJU5VTEwgaWYgdGhlCi0gKiB2aWV3IGRvZXMgbm90IGhhdmUg YW4gdXNlciBjb250ZW50IG1hbmFnZXIuCisgKiBHZXRzIHRoZSB1c2VyIGNvbnRlbnQgbWFuYWdl ciBhc3NvY2lhdGVkIHRvIEB3ZWJfdmlldy4KICAqCiAgKiBSZXR1cm5zOiAodHJhbnNmZXIgbm9u ZSk6IHRoZSAjV2ViS2l0VXNlckNvbnRlbnRNYW5hZ2VyIGFzc29jaWF0ZWQgd2l0aCB0aGUgdmll dwogICoK