168637 2017-02-20 22:30:42 -0800 NetworkProcess: Stop disabling buffering when NETWORK_CACHE is disabled in build 2017-02-22 00:35:36 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=137692 P2 Normal --- 1 cgarcia webkit-unassigned darin koivisto ossy zan oldest_to_newest 1279224 0 cgarcia 2017-02-20 22:30:42 -0800 It was added in r193752 as part of bug #137692 to fix an infinite loop in network process that happened in EFL because they didn't enable the network cache at that time. I think that was actually a workaround, and it was added without any comment so it has stayed there even when EFL enabled disk cache, and now that is gone. Looking at current code I see no reason why buffering can't work with the disk cache disabled, so I think it's time to remove that workaround. 1279225 1 302231 cgarcia 2017-02-20 22:32:34 -0800 Created attachment 302231 Patch 1279234 2 ossy 2017-02-20 22:53:14 -0800 (In reply to comment #0) > It was added in r193752 as part of bug #137692 to fix an infinite loop in > network process that happened in EFL because they didn't enable the network > cache at that time. I think that was actually a workaround, and it was added > without any comment so it has stayed there even when EFL enabled disk cache, > and now that is gone. Looking at current code I see no reason why buffering > can't work with the disk cache disabled, so I think it's time to remove that > workaround. Have you tried it out with disabled network cache or do you just think that it will work? 1279237 3 cgarcia 2017-02-20 22:59:54 -0800 (In reply to comment #2) > (In reply to comment #0) > > It was added in r193752 as part of bug #137692 to fix an infinite loop in > > network process that happened in EFL because they didn't enable the network > > cache at that time. I think that was actually a workaround, and it was added > > without any comment so it has stayed there even when EFL enabled disk cache, > > and now that is gone. Looking at current code I see no reason why buffering > > can't work with the disk cache disabled, so I think it's time to remove that > > workaround. > > Have you tried it out with disabled network cache or do you just think that > it will work? Nope, I've just read the buffering code in the network process. 1279816 4 cgarcia 2017-02-22 00:35:36 -0800 Committed r212816: <http://trac.webkit.org/changeset/212816> 302231 2017-02-20 22:32:34 -0800 2017-02-21 11:04:41 -0800 Patch wk2-network-buffering.diff text/plain 1784 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlNmJkZjQ3ZWM2MS4uNWE3ZGY0NzBmZDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMSBAQAogMjAxNy0wMi0yMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgTmV0d29ya1Byb2Nlc3M6IFN0b3AgZGlzYWJsaW5nIGJ1ZmZl cmluZyB3aGVuIE5FVFdPUktfQ0FDSEUgaXMgZGlzYWJsZWQgaW4gYnVpbGQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODYzNworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IHdhcyBhZGRlZCBpbiByMTkz NzUyIGFzIHBhcnQgb2YgYnVnICMxMzc2OTIgdG8gZml4IGFuIGluZmluaXRlIGxvb3AgaW4gbmV0 d29yayBwcm9jZXNzIHRoYXQgaGFwcGVuZWQgaW4gRUZMCisgICAgICAgIGJlY2F1c2UgdGhleSBk aWRuJ3QgZW5hYmxlIHRoZSBuZXR3b3JrIGNhY2hlIGF0IHRoYXQgdGltZS4gSSB0aGluayB0aGF0 IHdhcyBhY3R1YWxseSBhIHdvcmthcm91bmQsIGFuZCBpdCB3YXMKKyAgICAgICAgYWRkZWQgd2l0 aG91dCBhbnkgY29tbWVudCBzbyBpdCBoYXMgc3RheWVkIHRoZXJlIGV2ZW4gd2hlbiBFRkwgZW5h YmxlZCBkaXNrIGNhY2hlLCBhbmQgbm93IHRoYXQgaXMgZ29uZS4gTG9va2luZworICAgICAgICBh dCBjdXJyZW50IGNvZGUgSSBzZWUgbm8gcmVhc29uIHdoeSBidWZmZXJpbmcgY2FuJ3Qgd29yayB3 aXRoIHRoZSBkaXNrIGNhY2hlIGRpc2FibGVkLCBzbyBJIHRoaW5rIGl0J3MgdGltZSB0bworICAg ICAgICByZW1vdmUgdGhhdCB3b3JrYXJvdW5kLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3 b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6bWF4aW11bUJ1ZmZl cmluZ1RpbWUpOgorCisyMDE3LTAyLTIwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKwogICAgICAgICBSZW1vdmUgRU5BQkxFX1RIUkVBREVEX0NPTVBPU0lUT1Ig YnVpbGQgb3B0aW9uCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjg2MDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3 b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0 d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAKaW5kZXggNGJkZGEyZTJkZmEuLjZiODc0ZTAxZWE3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVy U3RyYXRlZ3kuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJM b2FkZXJTdHJhdGVneS5jcHAKQEAgLTk4LDEwICs5OCw2IEBAIFJlZlB0cjxOZXRzY2FwZVBsdWdJ blN0cmVhbUxvYWRlcj4gV2ViTG9hZGVyU3RyYXRlZ3k6OnNjaGVkdWxlUGx1Z2luU3RyZWFtTG9h ZChGCiAKIHN0YXRpYyBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzIG1heGltdW1CdWZmZXJpbmdU aW1lKENhY2hlZFJlc291cmNlKiByZXNvdXJjZSkKIHsKLSNpZiAhRU5BQkxFKE5FVFdPUktfQ0FD SEUpCi0gICAgcmV0dXJuIDBtczsKLSNlbmRpZgotCiAgICAgaWYgKCFyZXNvdXJjZSkKICAgICAg ICAgcmV0dXJuIDBtczsKIAo=