168634 2017-02-20 22:03:00 -0800 [Xcode] libwebrtc installhdrs doesn’t install any of the headers 2017-02-21 15:26:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167293 P2 Normal --- 1 mitz youennf achristensen youennf oldest_to_newest 1279212 0 mitz 2017-02-20 22:03:00 -0800 libwebrtc’s installhdrs action doesn’t install any of its headers. It looks like the install action installs headers via a script build phase in the “Copy webrtc headers” target, but that target doesn’t have INSTALLHDRS_SCRIPT_PHASE set to YES. 1279318 1 302258 youennf 2017-02-21 07:33:10 -0800 Created attachment 302258 Patch 1279325 2 302258 mitz 2017-02-21 08:04:38 -0800 Comment on attachment 302258 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302258&action=review > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:13 > +INSTALLHDRS_COPY_PHASE = YES; Can you explain what this is for? 1279328 3 302258 mitz 2017-02-21 08:10:56 -0800 Comment on attachment 302258 Patch Can you explain how libwebrtc.xcconfig affects the “Copy webrtc headers” target? My reading of the project file is that that configuration settings file is not used for that target. Does this patch actually fix the bug? 1279332 4 youennf 2017-02-21 08:14:55 -0800 Let me check further. 1279364 5 302271 youennf 2017-02-21 09:24:35 -0800 Created attachment 302271 Patch 1279578 6 302271 achristensen 2017-02-21 15:25:40 -0800 Comment on attachment 302271 Patch http://trac.webkit.org/r212772 1279579 7 302271 achristensen 2017-02-21 15:26:14 -0800 Comment on attachment 302271 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302271&action=review > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:13 > +INSTALLHDRS_COPY_PHASE = YES; What I committed has INSTALLHDRS_SCRIPT_PHASE = YES instead of this. 302258 2017-02-21 07:33:10 -0800 2017-02-21 09:24:29 -0800 Patch bug-168634-20170221073025.patch text/plain 2111 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBmMzU4M2IzZDgwZGJmNGVkY2EwMGRkMDBiM2Q0MmIzODVjNjU4YTM0Li4yYTc1 NWNlZTFiMWZjYmQ1ZGQ1OGIyYzc1MjQwNjY5ZTM4NGFkOGNhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0wMi0yMSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgW1hjb2RlXSBsaWJ3ZWJydGMgaW5z dGFsbGhkcnMgZG9lc27igJl0IGluc3RhbGwgYW55IG9mIHRoZSBoZWFkZXJzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg2MzQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL2xp YndlYnJ0Yy54Y2NvbmZpZzoKKwogMjAxNy0wMi0xOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgW1dlYlJUQ11bTWFjXSBBY3RpdmF0ZSBsaWJ3ZWJydGMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9saWJ3 ZWJydGMueGNjb25maWcgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlv bnMvbGlid2VicnRjLnhjY29uZmlnCmluZGV4IDE0ZWE4ZjJkMTlmMmM4NDkxMDMzYmZjNjhiMzIw NmZkYWJiY2M0NjcuLjgxNWVkMDkxMDkyNjU2MjBlNDQ1YmM2NDNlOGZiY2JjYzAzZTlkYjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9saWJ3 ZWJydGMueGNjb25maWcKKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NvbmZpZ3Vy YXRpb25zL2xpYndlYnJ0Yy54Y2NvbmZpZwpAQCAtMTAsNiArMTAsOCBAQCBIRUFERVJfU0VBUkNI X1BBVEhTID0gU291cmNlIFNvdXJjZS90aGlyZF9wYXJ0eS9qc29uY3BwL3NvdXJjZS9pbmNsdWRl IFNvdXJjZS90aAogCiBQVUJMSUNfSEVBREVSU19GT0xERVJfUEFUSCA9IC91c3IvbG9jYWwvaW5j bHVkZS9saWJ3ZWJydGM7CiBVU0VfSEVBREVSTUFQID0gTk87CitJTlNUQUxMSERSU19DT1BZX1BI QVNFID0gWUVTOworSU5TVEFMTEhEUlNfU0NSSVBUX1BIQVNFID0gWUVTOwogV0FSTklOR19DRkxB R1MgPSAtV25vLWV4aXQtdGltZS1kZXN0cnVjdG9ycyAtV25vLW9iamMtcHJvcGVydHktbm8tYXR0 cmlidXRlIC1Xbm8tb2JqYy1taXNzaW5nLXN1cGVyLWNhbGxzIC1Xbm8tZGVwcmVjYXRlZC1kZWNs YXJhdGlvbnM7CiAKIEdDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlMgPSBXRUJSVENfUE9TSVgg V0VCUlRDX01BQyBTU0xfVVNFX09QRU5TU0wgRkVBVFVSRV9FTkFCTEVfU1NMIEhBVkVfU1JUUCBI QVZFX09QRU5TU0xfU1NMX0ggU0NUUF9QUk9DRVNTX0xFVkVMX0xPQ0tTIFNDVFBfU0lNUExFX0FM TE9DQVRPUiBTQ1RQX1VTRV9PUEVOU1NMX1NIQTEgX19Vc2Vyc3BhY2VfXyBIQVZFX1NBX0xFTiBI QVZFX1NDT05OX0xFTiBfX0FQUExFX1VTRV9SRkNfMjI5MiBfX1VzZXJzcGFjZV9vc19EYXJ3aW4g Tk9OX1dJTkRPV1NfREVGSU5FIEhBVkVfV0VCUlRDX1ZJREVPIEhBVkVfV0VCUlRDX1ZPSUNFIFdF QlJUQ19JTlRFTExJR0lCSUxJVFlfRU5IQU5DRVI9MCBXRUJSVENfQVBNX0RFQlVHX0RVTVA9MCBX RUJSVENfTlNfRkxPQVQgV0VCUlRDX0NPREVDX0lMQkMgV0VCUlRDX0NPREVDX09QVVMgV0VCUlRD X0NPREVDX0lTQUMgV0VCUlRDX0NPREVDX1JFRCBSVENfRElTQUJMRV9WUDkgUlRDX0RJU0FCTEVf VlA4IEhBVkVfU1RESU5UX0ggSEFWRV9TVERMSUJfSCBIQVZFX1VJTlQ2NF9UIE9QRU5TU0wgSEFW RV9DT05GSUdfSCBXRUJSVENfV0VCS0lUX0JVSUxEIEhBVkVfUFRIUkVBRF9DT05EX1RJTUVEV0FJ VF9SRUxBVElWRSAgSEFWRV9TQ1RQIFdFQlJUQ19DT0RFQ19HNzExIFdFQlJUQ19DT0RFQ19HNzIy Owo= 302271 2017-02-21 09:24:35 -0800 2017-02-21 15:25:40 -0800 Patch bug-168634-20170221092150.patch text/plain 3283 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBmMzU4M2IzZDgwZGJmNGVkY2EwMGRkMDBiM2Q0MmIzODVjNjU4YTM0Li44NzQ3 ZGQ0Nzk0NTMxMGY5YmE1NmM2ZTNlNTNiMTE3ODc4NGYwZThiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wMi0yMSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgW1hjb2RlXSBsaWJ3ZWJydGMgaW5z dGFsbGhkcnMgZG9lc27igJl0IGluc3RhbGwgYW55IG9mIHRoZSBoZWFkZXJzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg2MzQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL2xp YndlYnJ0Yy54Y2NvbmZpZzoKKyAgICAgICAgKiBsaWJ3ZWJydGMueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvajoKKwogMjAxNy0wMi0xOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CiAKICAgICAgICAgW1dlYlJUQ11bTWFjXSBBY3RpdmF0ZSBsaWJ3ZWJydGMKZGlmZiAtLWdpdCBh L1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9saWJ3ZWJydGMueGNj b25maWcgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvbGlid2Vi cnRjLnhjY29uZmlnCmluZGV4IDE0ZWE4ZjJkMTlmMmM4NDkxMDMzYmZjNjhiMzIwNmZkYWJiY2M0 NjcuLjk3NmI4YmQ5M2U4MDgxMWRhYzgwZjc5OWNmZjZjZThhODQ5M2ViOGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9saWJ3ZWJydGMueGNj b25maWcKKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NvbmZpZ3VyYXRpb25zL2xp YndlYnJ0Yy54Y2NvbmZpZwpAQCAtMTAsNiArMTAsNyBAQCBIRUFERVJfU0VBUkNIX1BBVEhTID0g U291cmNlIFNvdXJjZS90aGlyZF9wYXJ0eS9qc29uY3BwL3NvdXJjZS9pbmNsdWRlIFNvdXJjZS90 aAogCiBQVUJMSUNfSEVBREVSU19GT0xERVJfUEFUSCA9IC91c3IvbG9jYWwvaW5jbHVkZS9saWJ3 ZWJydGM7CiBVU0VfSEVBREVSTUFQID0gTk87CitJTlNUQUxMSERSU19DT1BZX1BIQVNFID0gWUVT OwogV0FSTklOR19DRkxBR1MgPSAtV25vLWV4aXQtdGltZS1kZXN0cnVjdG9ycyAtV25vLW9iamMt cHJvcGVydHktbm8tYXR0cmlidXRlIC1Xbm8tb2JqYy1taXNzaW5nLXN1cGVyLWNhbGxzIC1Xbm8t ZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnM7CiAKIEdDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlMg PSBXRUJSVENfUE9TSVggV0VCUlRDX01BQyBTU0xfVVNFX09QRU5TU0wgRkVBVFVSRV9FTkFCTEVf U1NMIEhBVkVfU1JUUCBIQVZFX09QRU5TU0xfU1NMX0ggU0NUUF9QUk9DRVNTX0xFVkVMX0xPQ0tT IFNDVFBfU0lNUExFX0FMTE9DQVRPUiBTQ1RQX1VTRV9PUEVOU1NMX1NIQTEgX19Vc2Vyc3BhY2Vf XyBIQVZFX1NBX0xFTiBIQVZFX1NDT05OX0xFTiBfX0FQUExFX1VTRV9SRkNfMjI5MiBfX1VzZXJz cGFjZV9vc19EYXJ3aW4gTk9OX1dJTkRPV1NfREVGSU5FIEhBVkVfV0VCUlRDX1ZJREVPIEhBVkVf V0VCUlRDX1ZPSUNFIFdFQlJUQ19JTlRFTExJR0lCSUxJVFlfRU5IQU5DRVI9MCBXRUJSVENfQVBN X0RFQlVHX0RVTVA9MCBXRUJSVENfTlNfRkxPQVQgV0VCUlRDX0NPREVDX0lMQkMgV0VCUlRDX0NP REVDX09QVVMgV0VCUlRDX0NPREVDX0lTQUMgV0VCUlRDX0NPREVDX1JFRCBSVENfRElTQUJMRV9W UDkgUlRDX0RJU0FCTEVfVlA4IEhBVkVfU1RESU5UX0ggSEFWRV9TVERMSUJfSCBIQVZFX1VJTlQ2 NF9UIE9QRU5TU0wgSEFWRV9DT05GSUdfSCBXRUJSVENfV0VCS0lUX0JVSUxEIEhBVkVfUFRIUkVB RF9DT05EX1RJTUVEV0FJVF9SRUxBVElWRSAgSEFWRV9TQ1RQIFdFQlJUQ19DT0RFQ19HNzExIFdF QlJUQ19DT0RFQ19HNzIyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L2xpYndlYnJ0Yy54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1RoaXJkUGFydHkv bGlid2VicnRjL2xpYndlYnJ0Yy54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGQyMzJl YzYxZWFhM2E5YmY5MGVlYTFmZDhlZjk3NDY4NTgwMTU0YTcuLmMxYmU0NTljODM5YjEzNWYzZjcx ZDU1ZmJhZWE1ZmNmYjI5M2EyODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndl YnJ0Yy9saWJ3ZWJydGMueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvVGhp cmRQYXJ0eS9saWJ3ZWJydGMvbGlid2VicnRjLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAg LTExOTQ5LDYgKzExOTQ5LDcgQEAKIAkJfTsKIAkJNUM2M0Y2NjMxRTQxNEFCNjAwMkNBNTMxIC8q IERlYnVnICovID0gewogCQkJaXNhID0gWENCdWlsZENvbmZpZ3VyYXRpb247CisJCQliYXNlQ29u ZmlndXJhdGlvblJlZmVyZW5jZSA9IDVEN0M1OUM1MTIwOEM2OEIwMDFDODczRSAvKiBsaWJ3ZWJy dGMueGNjb25maWcgKi87CiAJCQlidWlsZFNldHRpbmdzID0gewogCQkJCVBST0RVQ1RfTkFNRSA9 ICIkKFRBUkdFVF9OQU1FKSI7CiAJCQl9OwpAQCAtMTE5NTYsNiArMTE5NTcsNyBAQAogCQl9Owog CQk1QzYzRjY2NDFFNDE0QUI2MDAyQ0E1MzEgLyogUmVsZWFzZSAqLyA9IHsKIAkJCWlzYSA9IFhD QnVpbGRDb25maWd1cmF0aW9uOworCQkJYmFzZUNvbmZpZ3VyYXRpb25SZWZlcmVuY2UgPSA1RDdD NTlDNTEyMDhDNjhCMDAxQzg3M0UgLyogbGlid2VicnRjLnhjY29uZmlnICovOwogCQkJYnVpbGRT ZXR0aW5ncyA9IHsKIAkJCQlQUk9EVUNUX05BTUUgPSAiJChUQVJHRVRfTkFNRSkiOwogCQkJfTsK QEAgLTExOTYzLDYgKzExOTY1LDcgQEAKIAkJfTsKIAkJNUM2M0Y2NjUxRTQxNEFCNjAwMkNBNTMx IC8qIFByb2R1Y3Rpb24gKi8gPSB7CiAJCQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKKwkJ CWJhc2VDb25maWd1cmF0aW9uUmVmZXJlbmNlID0gNUQ3QzU5QzUxMjA4QzY4QjAwMUM4NzNFIC8q IGxpYndlYnJ0Yy54Y2NvbmZpZyAqLzsKIAkJCWJ1aWxkU2V0dGluZ3MgPSB7CiAJCQkJUFJPRFVD VF9OQU1FID0gIiQoVEFSR0VUX05BTUUpIjsKIAkJCX07Cg==