168304 2017-02-14 04:49:19 -0800 Use a set instead of a list for tests when parsing expectations 2017-02-14 13:03:38 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 50635 1 webkit.org webkit-unassigned annulen commit-queue glenn lforschler rniwa oldest_to_newest 1276681 0 webkit.org 2017-02-14 04:49:19 -0800 In _collect_matching_tests, a lot of membership tests are done on a giant list of strings. By making it a set instead, we can make those much faster, and there's no reason for it to be a list. With ~45k tests and some 1000 expectations, this reduces the parse time from 34s to 3s on my machine. 1276684 1 301487 webkit.org 2017-02-14 04:55:27 -0800 Created attachment 301487 Patch 1276879 2 301487 commit-queue 2017-02-14 13:03:34 -0800 Comment on attachment 301487 Patch Clearing flags on attachment: 301487 Committed r212319: <http://trac.webkit.org/changeset/212319> 1276880 3 commit-queue 2017-02-14 13:03:38 -0800 All reviewed patches have been landed. Closing bug. 301487 2017-02-14 04:55:27 -0800 2017-02-14 13:03:34 -0800 Patch bug-168304-20170214135205.patch text/plain 2767 webkit.org U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMjg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGE0MWU4MDU4MTYzYTM1MTZhYjM1NzJmN2NhYzZhYjIy MzNjYzNlZi4uMWFiNjBhMDZlOTAyYzAzOWVkOTIwMmVjZjY5ZDIzYzI4Y2U4ZmRmYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE3LTAyLTE0ICBGbG9yaWFuIEJydWhpbiAgPGdpdEB0aGUtY29tcGlsZXIub3JnPgor CisgICAgICAgIFVzZSBhIHNldCBpbnN0ZWFkIG9mIGEgbGlzdCBmb3IgdGVzdHMgd2hlbiBwYXJz aW5nIGV4cGVjdGF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY4MzA0CisKKyAgICAgICAgSW4gX2NvbGxlY3RfbWF0Y2hpbmdfdGVzdHMsIGEg bG90IG9mIG1lbWJlcnNoaXAgdGVzdHMgYXJlIGRvbmUgb24gYSBnaWFudCBsaXN0CisgICAgICAg IG9mIHN0cmluZ3MuIEJ5IG1ha2luZyBpdCBhIHNldCBpbnN0ZWFkLCB3ZSBjYW4gbWFrZSB0aG9z ZSBtdWNoIGZhc3RlciwgYW5kCisgICAgICAgIHRoZXJlJ3Mgbm8gcmVhc29uIGZvciBpdCB0byBi ZSBhIGxpc3QuCisKKyAgICAgICAgV2l0aCB+NDVrIHRlc3RzIGFuZCBzb21lIDEwMDAgZXhwZWN0 YXRpb25zLCB0aGlzIHJlZHVjZXMgdGhlIHBhcnNlIHRpbWUgZnJvbSAzNHMKKyAgICAgICAgdG8g M3Mgb24gbXkgbWFjaGluZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4 cGVjdGF0aW9ucy5weToKKyAgICAgICAgKFRlc3RFeHBlY3RhdGlvblBhcnNlci5fX2luaXRfXyk6 CisgICAgICAgIChUZXN0RXhwZWN0YXRpb25QYXJzZXIuX2NvbGxlY3RfbWF0Y2hpbmdfdGVzdHMp OgorCiAyMDE3LTAyLTE0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjEyMjM3LgpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRp b25zLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3Rf ZXhwZWN0YXRpb25zLnB5CmluZGV4IDk1ZTljNjkwMDNiNjA4NzZhY2I3MmVlODk2NmQxZWE5OGI3 NDRjODAuLjZkNWUyOTA0MzlhNjJmZmQ0OTllZTI0M2UyNmNjNTY3NzIxZjdjMTcgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVj dGF0aW9ucy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2Rl bHMvdGVzdF9leHBlY3RhdGlvbnMucHkKQEAgLTgxLDcgKzgxLDEwIEBAIGNsYXNzIFRlc3RFeHBl Y3RhdGlvblBhcnNlcihvYmplY3QpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwb3J0LCBmdWxs X3Rlc3RfbGlzdCwgYWxsb3dfcmViYXNlbGluZV9tb2RpZmllcik6CiAgICAgICAgIHNlbGYuX3Bv cnQgPSBwb3J0CiAgICAgICAgIHNlbGYuX3Rlc3RfY29uZmlndXJhdGlvbl9jb252ZXJ0ZXIgPSBU ZXN0Q29uZmlndXJhdGlvbkNvbnZlcnRlcihzZXQocG9ydC5hbGxfdGVzdF9jb25maWd1cmF0aW9u cygpKSwgcG9ydC5jb25maWd1cmF0aW9uX3NwZWNpZmllcl9tYWNyb3MoKSkKLSAgICAgICAgc2Vs Zi5fZnVsbF90ZXN0X2xpc3QgPSBmdWxsX3Rlc3RfbGlzdAorICAgICAgICBpZiBmdWxsX3Rlc3Rf bGlzdCBpcyBOb25lOgorICAgICAgICAgICAgc2VsZi5fZnVsbF90ZXN0X2xpc3QgPSBOb25lCisg ICAgICAgIGVsc2U6CisgICAgICAgICAgICBzZWxmLl9mdWxsX3Rlc3RfbGlzdCA9IHNldChmdWxs X3Rlc3RfbGlzdCkKICAgICAgICAgc2VsZi5fYWxsb3dfcmViYXNlbGluZV9tb2RpZmllciA9IGFs bG93X3JlYmFzZWxpbmVfbW9kaWZpZXIKIAogICAgIGRlZiBwYXJzZShzZWxmLCBmaWxlbmFtZSwg ZXhwZWN0YXRpb25zX3N0cmluZyk6CkBAIC0xODksMTEgKzE5Miw2IEBAIGNsYXNzIFRlc3RFeHBl Y3RhdGlvblBhcnNlcihvYmplY3QpOgogICAgIGRlZiBfY29sbGVjdF9tYXRjaGluZ190ZXN0cyhz ZWxmLCBleHBlY3RhdGlvbl9saW5lKToKICAgICAgICAgIiIiQ29udmVydCB0aGUgdGVzdCBzcGVj aWZpY2F0aW9uIHRvIGFuIGFic29sdXRlLCBub3JtYWxpemVkCiAgICAgICAgIHBhdGggYW5kIG1h a2Ugc3VyZSBkaXJlY3RvcmllcyBlbmQgd2l0aCB0aGUgT1MgcGF0aCBzZXBhcmF0b3IuIiIiCi0g ICAgICAgICMgRklYTUU6IGZ1bGxfdGVzdF9saXN0IGNhbiBxdWlja2x5IGNvbnRhaW4gYSBiaWcg YW1vdW50IG9mCi0gICAgICAgICMgZWxlbWVudHMuIFdlIHNob3VsZCBjb25zaWRlciBhdCBzb21l IHBvaW50IHRvIHVzZSBhIG1vcmUKLSAgICAgICAgIyBlZmZpY2llbnQgc3RydWN0dXJlIGluc3Rl YWQgb2YgYSBsaXN0LiBNYXliZSBhIGRpY3Rpb25hcnkgb2YKLSAgICAgICAgIyBsaXN0cyB0byBy ZXByZXNlbnQgdGhlIHRyZWUgb2YgdGVzdHMsIGxlYXZlcyBiZWluZyB0ZXN0Ci0gICAgICAgICMg ZmlsZXMgYW5kIG5vZGVzIGJlaW5nIGNhdGVnb3JpZXMuCiAKICAgICAgICAgaWYgbm90IHNlbGYu X2Z1bGxfdGVzdF9saXN0OgogICAgICAgICAgICAgZXhwZWN0YXRpb25fbGluZS5tYXRjaGluZ190 ZXN0cyA9IFtleHBlY3RhdGlvbl9saW5lLnBhdGhdCg==