16799 2008-01-09 00:21:18 -0800 Acid3 expects HTMLObjectElement.data to canonicalize urls 2008-02-06 11:29:57 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED http://www.hixie.ch/tests/evil/acid/003/ HasReduction P2 Normal --- 17064 1 eric hyatt fishd webkit oldest_to_newest 66642 0 eric 2008-01-09 00:21:18 -0800 Test 64: FAIL (expected ./test.html, got: test.html - object elements didn't resolve URIs correctly) function () { // test 64: attributes of the <object> element var obj1 = document.createElement('object'); obj1.setAttribute('data', 'test.html'); var obj2 = document.createElement('object'); obj2.setAttribute('data', './test.html'); assertEquals(obj1.data, obj2.data, "object elements didn't resolve URIs correctly"); assert(obj1.data.match(/^http:/), "object.data isn't absolute"); obj1.appendChild(document.createElement('param')); assertEquals(obj1.getElementsByTagName('param').length, 1, "object is missing its only child"); return 4; }, 68427 1 18735 webkit 2008-01-28 03:58:20 -0800 Created attachment 18735 Minimal test case 69406 2 18921 hyatt 2008-02-04 15:22:02 -0800 Created attachment 18921 Make data absolute Will land test case in bug. 69408 3 18921 mrowe 2008-02-04 15:24:16 -0800 Comment on attachment 18921 Make data absolute r=me 69409 4 18921 darin 2008-02-04 15:25:56 -0800 Comment on attachment 18921 Make data absolute + if (dataVal.isNull()) + return dataVal; You don't need this. Document::completeURL already does this. It can just be a one-liner. return document()->completeURL(getAttribute(dataAttr)); 69478 5 fishd 2008-02-05 08:53:04 -0800 *** Bug 14448 has been marked as a duplicate of this bug. *** 69479 6 fishd 2008-02-05 08:57:22 -0800 you might want to review my patch in bug 14448, which includes a test case, but more importantly it had to be backed out after it was found to regress some existing layout tests! 69590 7 hyatt 2008-02-06 11:26:43 -0800 I will just remove those layout tests, as they make a bogus assumption. 69593 8 hyatt 2008-02-06 11:29:57 -0800 Fixed in r30044. 18735 2008-01-28 03:58:20 -0800 2008-01-28 03:58:20 -0800 Minimal test case test-case.html text/html 481 webkit PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIiAiaHR0cDov L3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+CjxodG1sPgo8aGVhZD4KPHRpdGxlPlRl c3QgY2FzZSBmb3IgVVJJIHJlc29sdmluZyBpbiBvYmplY3QgZWxlbWVudHM8L3RpdGxlPgo8L2hl YWQ+Cjxib2R5Pgo8cD5UaGVyZSBzaG91bGQgYmUgbm8gUkVEIG9uIHRoZSBwYWdlPC9wPgo8cD48 b2JqZWN0IGlkPSJvYmoiIGRhdGE9InRlc3QuaHRtbCI+PC9vYmplY3Q+PC9wPgo8c2NyaXB0IHR5 cGU9InRleHQvamF2YXNjcmlwdCI+CglpZiAoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm9iaiIp LmRhdGE9PSJ0ZXN0Lmh0bWwiKQoJCWRvY3VtZW50LndyaXRlKCI8cCBzdHlsZT1cImJhY2tncm91 bmQtY29sb3I6cmVkO1wiPlRFU1QgRkFJTEVEIC0gcmVzdWx0OiAndGVzdC5odG1sJzwvcD4iKTsK PC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPg== 18921 2008-02-04 15:22:02 -0800 2008-02-04 15:24:16 -0800 Make data absolute patch.txt text/plain 542 hyatt SW5kZXg6IGh0bWwvSFRNTE9iamVjdEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGh0bWwvSFRN TE9iamVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiAyOTk0MykKKysrIGh0bWwvSFRNTE9iamVjdEVs ZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTEsNyArMzkxLDEwIEBAIHZvaWQgSFRNTE9i amVjdEVsZW1lbnQ6OnNldENvZGVUeXBlKGNvbnMKIAogU3RyaW5nIEhUTUxPYmplY3RFbGVtZW50 OjpkYXRhKCkgY29uc3QKIHsKLSAgICByZXR1cm4gZ2V0QXR0cmlidXRlKGRhdGFBdHRyKTsKKyAg ICBTdHJpbmcgZGF0YVZhbCA9IGdldEF0dHJpYnV0ZShkYXRhQXR0cik7CisgICAgaWYgKGRhdGFW YWwuaXNOdWxsKCkpCisgICAgICAgIHJldHVybiBkYXRhVmFsOworICAgIHJldHVybiBkb2N1bWVu dCgpLT5jb21wbGV0ZVVSTChkYXRhVmFsKTsKIH0KIAogdm9pZCBIVE1MT2JqZWN0RWxlbWVudDo6 c2V0RGF0YShjb25zdCBTdHJpbmcmIHZhbHVlKQo=