167906 2017-02-06 14:48:25 -0800 svn-create-patch duplicating deletes 2018-09-03 11:10:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 14590 https://bugs.webkit.org/show_bug.cgi?id=167863 P2 Normal --- 1 jbedard webkit-unassigned ap dbates ddkilzer lforschler sam oldest_to_newest 1273723 0 jbedard 2017-02-06 14:48:25 -0800 svn-create-patch will duplicate deletes, https://bugs.webkit.org/attachment.cgi?id=300680 is a good example of this. Among other files, PerformanceTests/ES6SampleBench/Basic/util.js is deleted 3 times. 1273765 1 jbedard 2017-02-06 16:29:10 -0800 I was able to reproduce this. This is a bug in svn-create-patch. If you delete a file and then move the directory the file that was deleted is in, the resulting patch will have duplicated the delete. The commands to reproduce this are: rm SomeDir/file.txt svn rm SomeDir/file.txt svn mv SomeDir SomeNewDir I would guess that this was caused by https://bugs.webkit.org/show_bug.cgi?id=167169. 1273779 2 ap 2017-02-06 17:07:21 -0800 Is this a duplicate of bug 167903? 1273995 3 jbedard 2017-02-07 08:07:36 -0800 *** Bug 167903 has been marked as a duplicate of this bug. *** 1273996 4 jbedard 2017-02-07 08:08:36 -0800 (In reply to comment #2) > Is this a duplicate of bug 167903? Yes, it is the same issue. Marked the other as a duplicate since this one has more than just a report. 1274016 5 ap 2017-02-07 09:05:01 -0800 *** This bug has been marked as a duplicate of bug 167903 *** 1274031 6 ap 2017-02-07 09:36:59 -0800 Jonathan and I look into this briefly, and this may end up being a separate bug - there are no deletes in bug 167903. 1274046 7 jbedard 2017-02-07 10:14:26 -0800 This is not a duplicate of bug 167903, they are different issues. 1456191 8 ddkilzer 2018-09-03 11:10:19 -0700 This is a duplicate of: Bug 14590: svn-create-patch fails when svn mv is used on directory trees The patch I have to fix that (not v1) also fixes this issue. *** This bug has been marked as a duplicate of bug 14590 ***