167571 2017-01-29 21:32:55 -0800 [WebRTC] RTCPeerConnection should reject getStats promise in closed state 2017-08-29 15:43:59 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 143211 1 youennf youennf adam.bergkvist agouaillard jonlee webkit-bug-importer youennf oldest_to_newest 1271181 0 youennf 2017-01-29 21:32:55 -0800 RTCPeerConnection should reject getStats promise in closed mode 1271182 1 300085 youennf 2017-01-29 21:34:37 -0800 Created attachment 300085 Patch 1271443 2 300085 achristensen 2017-01-30 15:37:34 -0800 Comment on attachment 300085 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300085&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:388 > + promise.reject(Exception { INVALID_STATE_ERR, "Cannot get stats on closed state" }); Do we need a message here? "Cannot get stats on closed state" doesn't make much sense. 1274807 3 adam.bergkvist 2017-02-09 04:47:13 -0800 The getStats() method [1] doesn't specify that it should reject on closed state. I believe it's a feature that you should be able to extract the "last" stats gathered by a closed RTCPeerConnection. [1] https://w3c.github.io/webrtc-pc/archives/20161219/webrtc.html#rtcpeerconnection-interface-extensions-2 1343125 4 webkit-bug-importer 2017-08-29 09:51:51 -0700 <rdar://problem/34134439> 1343270 5 jonlee 2017-08-29 15:43:59 -0700 The spec has changed since. 300085 2017-01-29 21:34:37 -0800 2017-01-30 15:37:34 -0800 Patch bug-167571-20170129213228.patch text/plain 4048 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFmZGNkODdiZThhNzc5 MTRhOTlmNGZlNjQ1YTJiYTA2ZWI5ODJkNS4uMGI3ZGJhMTY4ZjIxMTg1ZTI5ZWY5YWY2ZWZmZGJj OTFiNWU0MzE5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTI5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViUlRDXSBSVENQZWVy Q29ubmVjdGlvbiBzaG91bGQgcmVqZWN0IGdldFN0YXRzIHByb21pc2UgaW4gY2xvc2VkIG1vZGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzU3MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQg YnkgdXBkYXRlZCB0ZXN0LgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVy Q29ubmVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSVENQZWVyQ29ubmVjdGlvbjo6cHJp dmF0ZUdldFN0YXRzKTogcmVqZWN0aW5nIGluIGNsb3NlZCBtb2RlLgorCiAyMDE3LTAxLTI3ICBZ dXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIEltcGxlbWVu dCBkeW5hbWljLWltcG9ydCBmb3IgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAppbmRleCBkZjExMGZl MTJhNDUyY2FiZGJjZDliOThjZjIwZjJhYWYwZWYxNzA1Li43MDA5ZTQxZTk1ODRiOTU2NjU4ZDUw YTRkNzhjOTdjMjg2MjUyM2U2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcApAQCAtMzg0LDYgKzM4NCwxMCBA QCBFeGNlcHRpb25Pcjx2b2lkPiBSVENQZWVyQ29ubmVjdGlvbjo6c2V0Q29uZmlndXJhdGlvbihS VENDb25maWd1cmF0aW9uJiYgY29uZmlndQogCiB2b2lkIFJUQ1BlZXJDb25uZWN0aW9uOjpwcml2 YXRlR2V0U3RhdHMoTWVkaWFTdHJlYW1UcmFjayogc2VsZWN0b3IsIFBlZXJDb25uZWN0aW9uOjpT dGF0c1Byb21pc2UmJiBwcm9taXNlKQogeworICAgIGlmIChtX3NpZ25hbGluZ1N0YXRlID09IFNp Z25hbGluZ1N0YXRlOjpDbG9zZWQpIHsKKyAgICAgICAgcHJvbWlzZS5yZWplY3QoRXhjZXB0aW9u IHsgSU5WQUxJRF9TVEFURV9FUlIsICJDYW5ub3QgZ2V0IHN0YXRzIG9uIGNsb3NlZCBzdGF0ZSIg fSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAgICAgbV9iYWNrZW5kLT5nZXRTdGF0cyhzZWxl Y3RvciwgV1RGTW92ZShwcm9taXNlKSk7CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxZTFkZjBiNDVkZDY1OWNmZmE2 MzQyOTBiZmE2ZjA2NDdmNGFmMWMzLi5kODQwMzU1MWU2MmYwMjA5YWNhNTg1NGEwYmNhMGRlYzdi NDJkNGQwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDEtMjkgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFtXZWJSVENdIFJUQ1BlZXJDb25uZWN0aW9u IHNob3VsZCByZWplY3QgZ2V0U3RhdHMgcHJvbWlzZSBpbiBjbG9zZWQgbW9kZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NTcxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFt L1JUQ1BlZXJDb25uZWN0aW9uLWNsb3NlZC1zdGF0ZS1leHBlY3RlZC50eHQ6CisgICAgICAgICog ZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1jbG9zZWQtc3RhdGUuaHRtbDoKKwog MjAxNy0wMS0yNyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAg ICAgICBJbXBsZW1lbnQgZHluYW1pYy1pbXBvcnQgZm9yIFdlYkNvcmUKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24tY2xvc2VkLXN0YXRl LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5l Y3Rpb24tY2xvc2VkLXN0YXRlLWV4cGVjdGVkLnR4dAppbmRleCA1ODkzMzY0NGE4OTZiNzBhZWEz YzVlNDI2MzJjOGJiYmQ4ZDdjMDE3Li4wYTcwOTE4MjQ5ZmQ2ZjI3NWUyNjgxYTM4MDY4OTFhN2I2 MWEzZmIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJD b25uZWN0aW9uLWNsb3NlZC1zdGF0ZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1jbG9zZWQtc3RhdGUtZXhwZWN0ZWQudHh0 CkBAIC0xNCw3ICsxNCw3IEBAIFBBU1MgY3JlYXRlQW5zd2VyIHJlamVjdGVkIG9uIGNsb3NlZCBz dGF0ZQogUEFTUyBzZXRMb2NhbERlc2NyaXB0aW9uIHJlamVjdGVkIG9uIGNsb3NlZCBzdGF0ZQog UEFTUyBzZXRSZW1vdGVEZXNjcmlwdGlvbiByZWplY3RlZCBvbiBjbG9zZWQgc3RhdGUKIFBBU1Mg YWRkSWNlQ2FuZGlkYXRlIHJlamVjdGVkIG9uIGNsb3NlZCBzdGF0ZQotUEFTUyBnZXRTdGF0cyBy ZWplY3RlZCBvbiBjbG9zZWQgc3RhdGUKK1BBU1MgZ2V0U3RhdHMgcmVqZWN0ZWQgb24gY2xvc2Vk IHN0YXRlOiBJbnZhbGlkU3RhdGVFcnJvciAoRE9NIEV4Y2VwdGlvbiAxMSk6IENhbm5vdCBnZXQg c3RhdHMgb24gY2xvc2VkIHN0YXRlCiAKIFRlc3Qgbm9uLXByb21pc2UgZnVuY3Rpb25zCiBQQVNT IHBjLmFkZFRyYWNrKHN0cmVhbS5nZXRUcmFja3MoKVswXSwgc3RyZWFtKSB0aHJldyBleGNlcHRp b24gSW52YWxpZFN0YXRlRXJyb3IgKERPTSBFeGNlcHRpb24gMTEpOiBUaGUgb2JqZWN0IGlzIGlu IGFuIGludmFsaWQgc3RhdGUuLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0 cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1jbG9zZWQtc3RhdGUuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24tY2xvc2VkLXN0YXRlLmh0bWwKaW5kZXgg OGE1OTZlYWJkN2ZiZWViNGRjZWFlOGEzOGFiN2UxYjEwNDFkYThjMC4uN2ZkODM5MzMwOGM1Mzlm NWU3NTc1NGYwYzAwZGE1Mjg5YjAwMjJjNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9t ZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1jbG9zZWQtc3RhdGUuaHRtbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWNsb3NlZC1zdGF0ZS5o dG1sCkBAIC01NCw4ICs1NCw4IEBACiAgICAgICAgICAgICAgICAgdGVzdFBhc3NlZCgiYWRkSWNl Q2FuZGlkYXRlIHJlamVjdGVkIG9uIGNsb3NlZCBzdGF0ZSIpOwogICAgICAgICAgICAgICAgIHJl dHVybiBwYy5nZXRTdGF0cygpOwogICAgICAgICAgICAgfSkKLSAgICAgICAgICAgIC50aGVuKGZh aWxlZCwgZnVuY3Rpb24gKCkgewotICAgICAgICAgICAgICAgIHRlc3RQYXNzZWQoImdldFN0YXRz IHJlamVjdGVkIG9uIGNsb3NlZCBzdGF0ZSIpOworICAgICAgICAgICAgLnRoZW4oZmFpbGVkLCBm dW5jdGlvbiAoZXJyb3IpIHsKKyAgICAgICAgICAgICAgICB0ZXN0UGFzc2VkKCJnZXRTdGF0cyBy ZWplY3RlZCBvbiBjbG9zZWQgc3RhdGU6ICIgKyBlcnJvcik7CiAgICAgICAgICAgICAgICAgZGVi dWcoIiIpOwogICAgICAgICAgICAgICAgIHRlc3ROb25Qcm9taXNlKCkKICAgICAgICAgICAgIH0p Cg==