166663 2017-01-03 14:22:40 -0800 Use prctl to name thread on Linux 2017-01-04 01:44:32 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 166676 1 ysuzuki ysuzuki benjamin cdumez cgarcia cmarcelo commit-queue dbates mcatanzaro oldest_to_newest 1263547 0 ysuzuki 2017-01-03 14:22:40 -0800 Use prctl to name thread on Linux 1263548 1 297953 ysuzuki 2017-01-03 14:24:00 -0800 Created attachment 297953 Patch 1263580 2 297953 mcatanzaro 2017-01-03 15:26:16 -0800 Comment on attachment 297953 Patch OK, I don't see why not. Did you do this to help Carlos keep track of which thread is the main thread? :D What do our thread names look like? I see from prctl(2) that they are truncated to 16 characters; I wonder if our names are often longer than that? 1263701 3 ysuzuki 2017-01-03 23:37:58 -0800 (In reply to comment #2) > Comment on attachment 297953 [details] > Patch > > OK, I don't see why not. Did you do this to help Carlos keep track of which > thread is the main thread? :D > > What do our thread names look like? I see from prctl(2) that they are > truncated to 16 characters; I wonder if our names are often longer than that? Yeah, characters are truncated. The typical form is like, jsc.watchdog.queue org.webkit.ThreadedCompositorWorkQueue So I think we should retrieve trailing 16 characters. 1263712 4 ysuzuki 2017-01-04 00:27:04 -0800 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 297953 [details] > > Patch > > > > OK, I don't see why not. Did you do this to help Carlos keep track of which > > thread is the main thread? :D > > > > What do our thread names look like? I see from prctl(2) that they are > > truncated to 16 characters; I wonder if our names are often longer than that? > > Yeah, characters are truncated. The typical form is like, > > jsc.watchdog.queue > org.webkit.ThreadedCompositorWorkQueue > > So I think we should retrieve trailing 16 characters. I'll just port WorkQueue::platformInitialize's threadName handling. 1263713 5 ysuzuki 2017-01-04 00:27:57 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Comment on attachment 297953 [details] > > > Patch > > > > > > OK, I don't see why not. Did you do this to help Carlos keep track of which > > > thread is the main thread? :D > > > > > > What do our thread names look like? I see from prctl(2) that they are > > > truncated to 16 characters; I wonder if our names are often longer than that? > > > > Yeah, characters are truncated. The typical form is like, > > > > jsc.watchdog.queue > > org.webkit.ThreadedCompositorWorkQueue > > > > So I think we should retrieve trailing 16 characters. > > I'll just port WorkQueue::platformInitialize's threadName handling. I'll do that in different patch :) 1263716 6 ysuzuki 2017-01-04 00:30:52 -0800 Committed r210272: <http://trac.webkit.org/changeset/210272> 1263731 7 ysuzuki 2017-01-04 01:44:32 -0800 (In reply to comment #2) > Comment on attachment 297953 [details] > Patch > > OK, I don't see why not. Did you do this to help Carlos keep track of which > thread is the main thread? :D > > What do our thread names look like? I see from prctl(2) that they are > truncated to 16 characters; I wonder if our names are often longer than that? I found it when debugging WorkQueue thing. I'm super happy if it would help Carlos :) 297953 2017-01-03 14:24:00 -0800 2017-01-03 15:26:16 -0800 Patch bug-166663-20170104072235.patch text/plain 1466 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBkMjMyZjllNGQ5NjU0Njg2Y2M3NjNh YTg5MGRjMzFiY2UzY2IyM2YuLmNlZTY4NDMzYzQxMzIyNDc3YThjNjVlMTYzOTQzMTVjYmRlNzVk N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDEtMDMgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgVXNlIHByY3RsIHRvIG5hbWUgdGhyZWFkIG9u IExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjY2NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ dCBpcyBxdWl0ZSB1c2VmdWwgaWYgd2UgY2FuIG5hbWUgdGhyZWFkcy4gVGhpcyBuYW1lIHdpbGwg YmUgc2hvd24gaW4gR0RCLgorICAgICAgICBXaGlsZSBtYWNPUyB1c2VzIHB0aHJlYWRfc2V0bmFt ZV9ucCwgd2UgY2FuIHVzZSBwcmN0bCBvbiBMaW51eC4KKworICAgICAgICAqIHd0Zi9UaHJlYWRp bmdQdGhyZWFkcy5jcHA6CisgICAgICAgIChXVEY6OmluaXRpYWxpemVDdXJyZW50VGhyZWFkSW50 ZXJuYWwpOgorCiAyMDE3LTAxLTAyICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28u Y29tPgogCiAgICAgICAgIFJlbW92ZSBzaDQgc3BlY2lmaWMgY29kZSBmcm9tIEphdmFTY3JpcHRD b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAgYi9T b3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKaW5kZXggNzA1ZjM2ZGVmNjdjMTc5 MzM0MzIwMzg5OGMyZGMxNWVhMTBmZmJjMi4uYmUxZDgyNjYxMzlhZDI0MjgwZWVhYTc5NWFjZTVl ZDI0OGJmYzVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVGhyZWFkaW5nUHRocmVhZHMu Y3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcApAQCAtNTUsNiAr NTUsMTAgQEAKICNpbmNsdWRlIDxzeXMvdGltZS5oPgogI2VuZGlmCiAKKyNpZiBPUyhMSU5VWCkK KyNpbmNsdWRlIDxzeXMvcHJjdGwuaD4KKyNlbmRpZgorCiBuYW1lc3BhY2UgV1RGIHsKIAogY2xh c3MgUHRocmVhZFN0YXRlIHsKQEAgLTE5Miw2ICsxOTYsOCBAQCB2b2lkIGluaXRpYWxpemVDdXJy ZW50VGhyZWFkSW50ZXJuYWwoY29uc3QgY2hhciogdGhyZWFkTmFtZSkKIHsKICNpZiBIQVZFKFBU SFJFQURfU0VUTkFNRV9OUCkKICAgICBwdGhyZWFkX3NldG5hbWVfbnAodGhyZWFkTmFtZSk7Cisj ZWxpZiBPUyhMSU5VWCkKKyAgICBwcmN0bChQUl9TRVRfTkFNRSwgdGhyZWFkTmFtZSk7CiAjZWxz ZQogICAgIFVOVVNFRF9QQVJBTSh0aHJlYWROYW1lKTsKICNlbmRpZgo=