166455 2016-12-22 18:40:51 -0800 [GTK] GLES build broken since r208997 2016-12-23 06:37:36 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro achristensen bugs-noreply commit-queue dino graouts kondapallykalyan magomez mcatanzaro noam oldest_to_newest 1262510 0 mcatanzaro 2016-12-22 18:40:51 -0800 GLES build is broken since r208997 (bug #164049). I don't normally ask for reviews for simple build failures, but I'm not sure about the right preprocessor guards to use here. Extensions3DOpenGLCommon::initializeAvailableExtensions currently guards its use of API not available in GLES2 with #if PLATFORM(MAC) || PLATFORM(GTK), which isn't good enough. At first I thought to change it to #if PLATFORM(MAC) || (PLATFORM(GTK) && !USE(OPENGL_ES_2)), but actually this code does not appear to be platform-specific, so maybe we can just use #if !USE(OPENGL_ES_2) here? Let's try that. 1262511 1 297699 mcatanzaro 2016-12-22 18:43:05 -0800 Created attachment 297699 Patch 1262532 2 magomez 2016-12-23 00:31:37 -0800 I would use #if PLATFORM(MAC) || (PLATFORM(GTK) && !USE(OPENGL_ES_2)), which is what is intended to do: use this branch only if GLES2 is not enabled in WKGtk. There are also EFL and Win using this and they are probably going to break if the platform guards are removed. 1262547 3 297699 mcatanzaro 2016-12-23 06:34:34 -0800 Comment on attachment 297699 Patch OK then 1262548 4 mcatanzaro 2016-12-23 06:37:36 -0800 Committed r210133: <http://trac.webkit.org/changeset/210133> 297699 2016-12-22 18:43:05 -0800 2016-12-23 06:34:34 -0800 Patch bug-166455-20161222204200.patch text/plain 1699 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ1MTRlMzI5N2MyODQw MWI3OTg2ZmM2NjQ4Y2Q4ZTIyNjBjZDU4NS4uN2Y4MDczYmJkMTU0OWJjMmU4YmNlZmIwYTFmZWYx OTBiMTMzMDJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTEyLTIyICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBH TEVTIGJ1aWxkIGJyb2tlbiBzaW5jZSByMjA4OTk3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjY0NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdGhlIHByZXByb2Nlc3NvciBndWFyZHMgaGVyZTsg dGhpcyBjb2RlIGlzIGluY29tcGF0aWJsZSB3aXRoIEdMRVMyLgorCisgICAgICAgIExvb2tzIGxp a2UgaXQncyBiZWVuIGJyb2tlbiBmb3IgYSBtb250aC4gVHlwaWNhbCEKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uOjppbml0aWFsaXplQXZhaWxh YmxlRXh0ZW5zaW9ucyk6CisKKzIwMTYtMTItMjIgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu emFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCB1bnVzZWQgcGFyYW1l dGVyIHdhcm5pbmcgaW4gR0xFUyBidWlsZAogCiAgICAgICAgIExvb2tzIGxpa2UgaXQncyBiZWVu IGhlcmUgc2luY2UgMjAxMi4gSW1wcmVzc2l2ZSEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5H TENvbW1vbi5jcHAKaW5kZXggNDkyYjU5MzU0MGE0MzBhZGFmMjIxNWE3MzBiZTZkYTNmZmI2NGU4 ZC4uODMwNWJjMmFhMzNiODljYzdmOWVkMjc0YjRiMmQ3YTIwNmE0MTAwZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5H TENvbW1vbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3Blbmds L0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHAKQEAgLTIwOSw3ICsyMDksNyBAQCBTdHJpbmcg RXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uOjpnZXRUcmFuc2xhdGVkU2hhZGVyU291cmNlQU5HTEUo UGxhdGZvcm0zRE9iamVjdAogCiB2b2lkIEV4dGVuc2lvbnMzRE9wZW5HTENvbW1vbjo6aW5pdGlh bGl6ZUF2YWlsYWJsZUV4dGVuc2lvbnMoKQogewotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZP Uk0oR1RLKQorI2lmICFVU0UoT1BFTkdMX0VTXzIpCiAgICAgaWYgKG1fdXNlSW5kZXhlZEdldFN0 cmluZykgewogICAgICAgICBHTGludCBudW1FeHRlbnNpb25zID0gMDsKICAgICAgICAgOjpnbEdl dEludGVnZXJ2KEdMX05VTV9FWFRFTlNJT05TLCAmbnVtRXh0ZW5zaW9ucyk7Cg==