166444 2016-12-22 16:17:51 -0800 WebAssembly: Make spec-tests/linking.wast.js pass 2017-05-03 09:58:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 165282 1 saam saam benjamin fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff oliver ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1262447 0 saam 2016-12-22 16:17:51 -0800 ... 1262454 1 saam 2016-12-22 16:38:28 -0800 *** Bug 166445 has been marked as a duplicate of this bug. *** 1262456 2 297688 saam 2016-12-22 16:43:26 -0800 Created attachment 297688 WIP This is probably all that's needed, but it's hard to tell until https://bugs.webkit.org/show_bug.cgi?id=165282 lands so I can test it. 1304082 3 webkit-bug-importer 2017-05-03 09:58:03 -0700 <rdar://problem/31965384> 297688 2016-12-22 16:43:26 -0800 2016-12-22 16:43:26 -0800 WIP patch.diff text/plain 5706 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL0pTV2ViQXNzZW1ibHlJbnN0YW5j ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL0pTV2ViQXNz ZW1ibHlJbnN0YW5jZS5oCShyZXZpc2lvbiAyMTAxMTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvd2FzbS9qcy9KU1dlYkFzc2VtYmx5SW5zdGFuY2UuaAkod29ya2luZyBjb3B5KQpAQCAtNTMs MTggKzUzLDE4IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1fbW9kdWxlLmdldCgpOwogICAg IH0KIAotICAgIFdyaXRlQmFycmllcjxKU0NlbGw+KiBpbXBvcnRGdW5jdGlvbih1bnNpZ25lZCBp ZHgpCisgICAgV3JpdGVCYXJyaWVyPEpTT2JqZWN0PiogaW1wb3J0RnVuY3Rpb24odW5zaWduZWQg aWR4KQogICAgIHsKICAgICAgICAgUkVMRUFTRV9BU1NFUlQoaWR4IDwgbV9udW1JbXBvcnRGdW5j dGlvbnMpOwogICAgICAgICByZXR1cm4gJmltcG9ydEZ1bmN0aW9ucygpW2lkeF07CiAgICAgfQog Ci0gICAgV3JpdGVCYXJyaWVyPEpTQ2VsbD4qIGltcG9ydEZ1bmN0aW9ucygpCisgICAgV3JpdGVC YXJyaWVyPEpTT2JqZWN0PiogaW1wb3J0RnVuY3Rpb25zKCkKICAgICB7Ci0gICAgICAgIHJldHVy biBiaXR3aXNlX2Nhc3Q8V3JpdGVCYXJyaWVyPEpTQ2VsbD4qPihiaXR3aXNlX2Nhc3Q8Y2hhcio+ KHRoaXMpICsgb2Zmc2V0T2ZJbXBvcnRGdW5jdGlvbnMoKSk7CisgICAgICAgIHJldHVybiBiaXR3 aXNlX2Nhc3Q8V3JpdGVCYXJyaWVyPEpTT2JqZWN0Pio+KGJpdHdpc2VfY2FzdDxjaGFyKj4odGhp cykgKyBvZmZzZXRPZkltcG9ydEZ1bmN0aW9ucygpKTsKICAgICB9CiAKLSAgICB2b2lkIHNldElt cG9ydEZ1bmN0aW9uKFZNJiB2bSwgSlNDZWxsKiB2YWx1ZSwgdW5zaWduZWQgaWR4KQorICAgIHZv aWQgc2V0SW1wb3J0RnVuY3Rpb24oVk0mIHZtLCBKU09iamVjdCogdmFsdWUsIHVuc2lnbmVkIGlk eCkKICAgICB7CiAgICAgICAgIGltcG9ydEZ1bmN0aW9uKGlkeCktPnNldCh2bSwgdGhpcywgdmFs dWUpOwogICAgIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL1dlYkFzc2Vt Ymx5SW5zdGFuY2VDb25zdHJ1Y3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3dhc20vanMvV2ViQXNzZW1ibHlJbnN0YW5jZUNvbnN0cnVjdG9yLmNwcAkocmV2aXNp b24gMjEwMTE0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vanMvV2ViQXNzZW1ibHlJ bnN0YW5jZUNvbnN0cnVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDkgKzExMiw5IEBA IHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnMKICAgICAgICAgICAgIC8v IGkuIElmIElzQ2FsbGFibGUodikgaXMgZmFsc2UsIHRocm93IGEgV2ViQXNzZW1ibHkuTGlua0Vy cm9yLgogICAgICAgICAgICAgaWYgKCF2YWx1ZS5pc0Z1bmN0aW9uKCkpCiAgICAgICAgICAgICAg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZSh0aHJvd0V4Y2VwdGlvbihleGVjLCB0aHJvd1Njb3Bl LCBjcmVhdGVKU1dlYkFzc2VtYmx5TGlua0Vycm9yKGV4ZWMsIHZtLCBBU0NJSUxpdGVyYWwoImlt cG9ydCBmdW5jdGlvbiBtdXN0IGJlIGNhbGxhYmxlIikpKSk7Ci0gICAgICAgICAgICBKU0NlbGwq IGNlbGwgPSB2YWx1ZS5hc0NlbGwoKTsKKyAgICAgICAgICAgIEpTT2JqZWN0KiBmdW5jdGlvbiA9 IGpzQ2FzdDxKU09iamVjdCo+KHZhbHVlLmFzQ2VsbCgpKTsKICAgICAgICAgICAgIC8vIGlpLiBJ ZiB2IGlzIGFuIEV4cG9ydGVkIEZ1bmN0aW9uIEV4b3RpYyBPYmplY3Q6Ci0gICAgICAgICAgICBp ZiAoV2ViQXNzZW1ibHlGdW5jdGlvbiogaW1wb3J0ZWRFeHBvcnRzID0ganNEeW5hbWljQ2FzdDxX ZWJBc3NlbWJseUZ1bmN0aW9uKj4ob2JqZWN0KSkgeworICAgICAgICAgICAgaWYgKFdlYkFzc2Vt Ymx5RnVuY3Rpb24qIGltcG9ydGVkRXhwb3J0cyA9IGpzRHluYW1pY0Nhc3Q8V2ViQXNzZW1ibHlG dW5jdGlvbio+KGZ1bmN0aW9uKSkgewogICAgICAgICAgICAgICAgIC8vIEZJWE1FIGhhbmRsZSBG dW5jdGlvbiBFeG90aWMgT2JqZWN0IHByb3Blcmx5LiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY1MjgyCiAgICAgICAgICAgICAgICAgLy8gYS4gSWYgdGhlIHNpZ25h dHVyZSBvZiB2IGRvZXMgbm90IG1hdGNoIHRoZSBzaWduYXR1cmUgb2YgaSwgdGhyb3cgYSBUeXBl RXJyb3IuCiAgICAgICAgICAgICAgICAgLy8gYi4gTGV0IGNsb3N1cmUgYmUgdi5bW0Nsb3N1cmVd XS4KQEAgLTEyNiw3ICsxMjYsNyBAQCBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBjb25zCiAgICAgICAgICAgICAvLyBhLiBMZXQgY2xvc3VyZSBiZSBhIG5ldyBob3N0IGZ1bmN0 aW9uIG9mIHRoZSBnaXZlbiBzaWduYXR1cmUgd2hpY2ggY2FsbHMgdiBieSBjb2VyY2luZyBXZWJB c3NlbWJseSBhcmd1bWVudHMgdG8gSmF2YVNjcmlwdCBhcmd1bWVudHMgdmlhIFRvSlNWYWx1ZSBh bmQgcmV0dXJucyB0aGUgcmVzdWx0LCBpZiBhbnksIGJ5IGNvZXJjaW5nIHZpYSBUb1dlYkFzc2Vt Ymx5VmFsdWUuCiAgICAgICAgICAgICAvLyBOb3RlOiBkb25lIGFzIHBhcnQgb2YgUGxhbiBjb21w aWxhdGlvbi4KICAgICAgICAgICAgIC8vIGl2LiBBcHBlbmQgdiB0byBmdW5jcy4KLSAgICAgICAg ICAgIGluc3RhbmNlLT5zZXRJbXBvcnRGdW5jdGlvbih2bSwgY2VsbCwgbnVtSW1wb3J0RnVuY3Rp b25zKyspOworICAgICAgICAgICAgaW5zdGFuY2UtPnNldEltcG9ydEZ1bmN0aW9uKHZtLCBmdW5j dGlvbiwgbnVtSW1wb3J0RnVuY3Rpb25zKyspOwogICAgICAgICAgICAgLy8gdi4gQXBwZW5kIGNs b3N1cmUgdG8gaW1wb3J0cy4KICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9qcy9XZWJBc3NlbWJseU1vZHVsZVJlY29yZC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vanMvV2ViQXNzZW1ibHlN b2R1bGVSZWNvcmQuY3BwCShyZXZpc2lvbiAyMTAxMTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvd2FzbS9qcy9XZWJBc3NlbWJseU1vZHVsZVJlY29yZC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEwOCw5ICsxMDgsMTggQEAgdm9pZCBXZWJBc3NlbWJseU1vZHVsZVJlY29yZDo6bGluayhFeGVj UwogICAgICAgICAgICAgLy8gMS4gSWYgZSBpcyBhIGNsb3N1cmUgYzoKICAgICAgICAgICAgIC8v ICAgaS4gSWYgdGhlcmUgaXMgYW4gRXhwb3J0ZWQgRnVuY3Rpb24gRXhvdGljIE9iamVjdCBmdW5j IGluIGZ1bmNzIHdob3NlIGZ1bmMuW1tDbG9zdXJlXV0gZXF1YWxzIGMsIHRoZW4gcmV0dXJuIGZ1 bmMuCiAgICAgICAgICAgICAvLyAgIGlpLiAoTm90ZTogQXQgbW9zdCBvbmUgd3JhcHBlciBpcyBj cmVhdGVkIGZvciBhbnkgY2xvc3VyZSwgc28gZnVuYyBpcyB1bmlxdWUsIGV2ZW4gaWYgdGhlcmUg YXJlIG11bHRpcGxlIG9jY3VycmFuY2VzIGluIHRoZSBsaXN0LiBNb3Jlb3ZlciwgaWYgdGhlIGl0 ZW0gd2FzIGFuIGltcG9ydCB0aGF0IGlzIGFscmVhZHkgYW4gRXhwb3J0ZWQgRnVuY3Rpb24gRXhv dGljIE9iamVjdCwgdGhlbiB0aGUgb3JpZ2luYWwgZnVuY3Rpb24gb2JqZWN0IHdpbGwgYmUgZm91 bmQuIEZvciBpbXBvcnRzIHRoYXQgYXJlIHJlZ3VsYXIgSlMgZnVuY3Rpb25zLCBhIG5ldyB3cmFw cGVyIHdpbGwgYmUgY3JlYXRlZC4pCisgICAgICAgICAgICBXYXNtOjpTaWduYXR1cmVJbmRleCBz aWduYXR1cmVJbmRleCA9IG1vZHVsZS0+c2lnbmF0dXJlRm9yRnVuY3Rpb25JbmRleFNwYWNlKGV4 cC5raW5kSW5kZXgpOwogICAgICAgICAgICAgaWYgKGV4cC5raW5kSW5kZXggPCBpbXBvcnRDb3Vu dCkgewotICAgICAgICAgICAgICAgIC8vIEZJWE1FIEltcGxlbWVudCByZS1leHBvcnRpbmcgYW4g aW1wb3J0LiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NTEwCi0g ICAgICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAg ICAgICBKU09iamVjdCogZnVuY3Rpb25FeHBvcnQgPSBpbnN0YW5jZS0+aW1wb3J0RnVuY3Rpb24o ZXhwLmtpbmRJbmRleCktPmdldCgpOworICAgICAgICAgICAgICAgIGlmIChXZWJBc3NlbWJseUZ1 bmN0aW9uKiB3YXNtRXhwb3J0ID0ganNEeW5hbWljQ2FzdDxXZWJBc3NlbWJseUZ1bmN0aW9uKj4o ZnVuY3Rpb25FeHBvcnQpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmICh3YXNtRXhwb3J0LT5z aWduYXR1cmVJbmRleCgpICE9IHNpZ25hdHVyZUluZGV4KSB7CisgICAgICAgICAgICAgICAgICAg ICAgICB0aHJvd0V4Y2VwdGlvbihzdGF0ZSwgc2NvcGUsIGNyZWF0ZUpTV2ViQXNzZW1ibHlMaW5r RXJyb3Ioc3RhdGUsIHZtLCAiRXhwb3J0aW5nIHdhc20gaW1wb3J0IHdpdGggd3Jvbmcgc2lnbmF0 dXJlIikpOworICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgICAg ICAgICB9CisgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgZXhwb3J0ZWRWYWx1 ZSA9IGZ1bmN0aW9uRXhwb3J0OworICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAg fQogICAgICAgICAgICAgLy8gICBpaWkuIE90aGVyd2lzZToKICAgICAgICAgICAgIC8vICAgICBh LiBMZXQgZnVuYyBiZSBhbiBFeHBvcnRlZCBGdW5jdGlvbiBFeG90aWMgT2JqZWN0IGNyZWF0ZWQg ZnJvbSBjLgpAQCAtMTE4LDcgKzEyNyw2IEBAIHZvaWQgV2ViQXNzZW1ibHlNb2R1bGVSZWNvcmQ6 OmxpbmsoRXhlY1MKICAgICAgICAgICAgIC8vICAgICBjLiBSZXR1cm4gZnVuYy4KICAgICAgICAg ICAgIEpTV2ViQXNzZW1ibHlDYWxsZWUqIGpzRW50cnlwb2ludENhbGxlZSA9IG1vZHVsZS0+anNF bnRyeXBvaW50Q2FsbGVlRnJvbUZ1bmN0aW9uSW5kZXhTcGFjZShleHAua2luZEluZGV4KTsKICAg ICAgICAgICAgIEpTV2ViQXNzZW1ibHlDYWxsZWUqIHdhc21FbnRyeXBvaW50Q2FsbGVlID0gbW9k dWxlLT53YXNtRW50cnlwb2ludENhbGxlZUZyb21GdW5jdGlvbkluZGV4U3BhY2UoZXhwLmtpbmRJ bmRleCk7Ci0gICAgICAgICAgICBXYXNtOjpTaWduYXR1cmVJbmRleCBzaWduYXR1cmVJbmRleCA9 IG1vZHVsZS0+c2lnbmF0dXJlRm9yRnVuY3Rpb25JbmRleFNwYWNlKGV4cC5raW5kSW5kZXgpOwog ICAgICAgICAgICAgY29uc3QgV2FzbTo6U2lnbmF0dXJlKiBzaWduYXR1cmUgPSBXYXNtOjpTaWdu YXR1cmVJbmZvcm1hdGlvbjo6Z2V0KCZ2bSwgc2lnbmF0dXJlSW5kZXgpOwogICAgICAgICAgICAg V2ViQXNzZW1ibHlGdW5jdGlvbiogZnVuY3Rpb24gPSBXZWJBc3NlbWJseUZ1bmN0aW9uOjpjcmVh dGUodm0sIGdsb2JhbE9iamVjdCwgc2lnbmF0dXJlLT5hcmd1bWVudENvdW50KCksIGV4cC5maWVs ZC5zdHJpbmcoKSwgaW5zdGFuY2UsIGpzRW50cnlwb2ludENhbGxlZSwgd2FzbUVudHJ5cG9pbnRD YWxsZWUsIHNpZ25hdHVyZUluZGV4KTsKICAgICAgICAgICAgIGV4cG9ydGVkVmFsdWUgPSBmdW5j dGlvbjsK