165593 2016-12-07 21:43:33 -0800 DumpRenderTree EventSendingController must implement keyDown for "escape". 2016-12-12 09:30:24 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Mac Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=165585 InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk ap enrica jer.noble lforschler webkit-bug-importer wenson_hsieh oldest_to_newest 1257603 0 jeremyj-wk 2016-12-07 21:43:33 -0800 DumpRenderTree EventSendingController must implement keyDown for "escape". 1257604 1 jeremyj-wk 2016-12-07 21:44:32 -0800 rdar://problem/29568847 1257605 2 296483 jeremyj-wk 2016-12-07 21:47:36 -0800 Created attachment 296483 Patch 1257634 3 296483 ap 2016-12-07 23:08:05 -0800 Comment on attachment 296483 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296483&action=review > Tools/DumpRenderTree/mac/EventSendingController.mm:925 > + const unichar ch = 0x1B; This doesn't feel right to me. I believe that AppKit handles the Esc key internally, and its behavior is a lot more complicated than just sending a keyDown/keyUp to firstResponder. IIRC, the processing also includes sending a -performKeyEquivalent: and a -doCommandBySelector with both cancelOperation and cancel selectors. Curiously, this may not be concern for WebKitTestRunner, because WK2 takes care of sending an even back to AppKit ifself. I don't have any good suggestion for what to do here. > LayoutTests/platform/mac-wk1/TestExpectations:-296 > -webkit.org/b/165589 pointer-lock/lock-lost-on-esc-in-fullscreen.html [ Skip ] As fa as I can tell, you could just use this bug for the fix. 1258799 4 296483 darin 2016-12-10 17:57:16 -0800 Comment on attachment 296483 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296483&action=review >> Tools/DumpRenderTree/mac/EventSendingController.mm:925 >> + const unichar ch = 0x1B; > > This doesn't feel right to me. I believe that AppKit handles the Esc key internally, and its behavior is a lot more complicated than just sending a keyDown/keyUp to firstResponder. IIRC, the processing also includes sending a -performKeyEquivalent: and a -doCommandBySelector with both cancelOperation and cancel selectors. > > Curiously, this may not be concern for WebKitTestRunner, because WK2 takes care of sending an even back to AppKit ifself. > > I don't have any good suggestion for what to do here. I don’t think that’s quite right. I studied the relevant AppKit source code, and I am almost certain that the escape key event first passes through the responder chain as an argument to keyDown: and then the additional processing you are referring above done inside the -[NSWindow keyDown:] method. So I believe there is a good chance the change in this patch will work for testing escape key behavior. 1259067 5 ap 2016-12-12 09:30:24 -0800 My understanding is that with this patch, the event won't go through the responder chain, and will never reach -[NSWindow keyDown:]. So, the behavior of Esc is not accurately emulated. If my understanding is correct, the behavior of eventSender.keyDown("escape") is very imprecise. For example, it will fail if the implementation ever changes to use -performKeyEquivalent:. Then again, we already have a lot of special keys there, such as "leftArrow". I guess my concern is that Escape is the trickiest of them all. 296483 2016-12-07 21:47:36 -0800 2016-12-10 17:57:16 -0800 Patch bug-165593-20161207214654.patch text/plain 3029 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NTIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTc2MWI5ZjU3NGU5NjhlMGYzNTZlMTRmY2U3OTQ1YTQx MmQ1ZTA2Ny4uMTY1OGU3OTBmM2FlYzMyNTA5MTY4YjU2NGY2YzI2YTJhNzRjNGY2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE2LTEyLTA3ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAg ICAgICBEdW1wUmVuZGVyVHJlZSBFdmVudFNlbmRpbmdDb250cm9sbGVyIG11c3QgaW1wbGVtZW50 IGtleURvd24gZm9yICJlc2NhcGUiLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY1NTkzCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI5NTY4ODQ3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVu ZGVyVHJlZS9tYWMvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5tbToKKyAgICAgICAgKC1bRXZlbnRT ZW5kaW5nQ29udHJvbGxlciBrZXlEb3duOndpdGhNb2RpZmllcnM6d2l0aExvY2F0aW9uOl0pOgor CiAyMDE2LTEyLTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBE dW1wUmVuZGVyVHJlZSBzaG91bGQgc3RvcCB1c2luZyBDaGVja2VkTWFsbG9jLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIubW0gYi9U b29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5tbQppbmRleCA2 NWUyYzFmNWI1NmNiM2RkZTM0NTk3ZjU0MTFhNTE0NjVhNzA3OTIyLi42ZThjZjVhYzRkMTlhMWZh NGRkMTAzM2NjN2FiNTM4YWNjYmZkMmE5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9tYWMvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5tbQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9tYWMvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5tbQpAQCAtOTIxLDYgKzkyMSwxMCBAQCBzdGF0 aWMgaW50IGJ1aWxkTW9kaWZpZXJGbGFncyhjb25zdCBXZWJTY3JpcHRPYmplY3QqIG1vZGlmaWVy cykKICAgICAgICAgY29uc3QgdW5pY2hhciBjaCA9IDB4RkZFODsKICAgICAgICAgZXZlbnRDaGFy YWN0ZXIgPSBbTlNTdHJpbmcgc3RyaW5nV2l0aENoYXJhY3RlcnM6JmNoIGxlbmd0aDoxXTsKICAg ICAgICAga2V5Q29kZSA9IDB4M0Q7CisgICAgfSBlbHNlIGlmIChbY2hhcmFjdGVyIGlzRXF1YWxU b1N0cmluZzpAImVzY2FwZSJdKSB7CisgICAgICAgIGNvbnN0IHVuaWNoYXIgY2ggPSAweDFCOwor ICAgICAgICBldmVudENoYXJhY3RlciA9IFtOU1N0cmluZyBzdHJpbmdXaXRoQ2hhcmFjdGVyczom Y2ggbGVuZ3RoOjFdOworICAgICAgICBrZXlDb2RlID0gMHgzNTsKICAgICB9CiAKICAgICAvLyBD b21wYXJlIHRoZSBpbnB1dCBzdHJpbmcgd2l0aCB0aGUgZnVuY3Rpb24ta2V5IG5hbWVzIGRlZmlu ZWQgYnkgdGhlIERPTSBzcGVjIChpLmUuICJGMSIsLi4uLCJGMjQiKS4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhZGVmZWNj NzFkMzQyNWQyMjc5ZjRlN2JhNjViZGIxM2VjNTNmYTA5Li5lZTA4N2ZmMzRhNzIyNjY2YzlmOTJl NTY1YjM3ZjlhMWQ4Mjk3YjA2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTYtMTItMDcgIEpl cmVteSBKb25lcyAgPGplcmVteWpAYXBwbGUuY29tPgogCisgICAgICAgIER1bXBSZW5kZXJUcmVl IEV2ZW50U2VuZGluZ0NvbnRyb2xsZXIgbXVzdCBpbXBsZW1lbnQga2V5RG93biBmb3IgImVzY2Fw ZSIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU1 OTMKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjk1Njg4NDcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy13azEvVGVzdEV4cGVj dGF0aW9uczoKKyAgICAgICAgRW5hYmxlIHBvaW50ZXItbG9jay9sb2NrLWxvc3Qtb24tZXNjLWlu LWZ1bGxzY3JlZW4uaHRtbAorCisyMDE2LTEyLTA3ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFw cGxlLmNvbT4KKwogICAgICAgICBwb2ludGVyLWxvY2svbG9jay1sb3N0LW9uLWVzYy1pbi1mdWxs c2NyZWVuLmh0bWwgdGltZW91dCBvbiBtYWMtd2sxCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU1ODkKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDM4OWQwOTU0YzliYzVmNWY2NTg5YzkzOTM5 MzI0MzRiYjk2NWJmNzEuLmEyMWQ2MDAyOWYzMjBiMmZmZmJkNjkzNWRhNmZlNzExOGVkMDcxZmIg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKQEAg LTI5Miw1ICsyOTIsMyBAQCB3ZWJraXQub3JnL2IvMTY0NDkxIFsgWW9zZW1pdGUgRWxDYXBpdGFu IF0gZmFzdC92aXN1YWwtdmlld3BvcnQvcnRsLXpvb21lZC1yZWN0cwogd2Via2l0Lm9yZy9iLzE2 NDkzMyBodHRwL3Rlc3RzL21pc2MvbGluay1yZWwtaWNvbi1iZWZvcmVsb2FkLmh0bWwgWyBGYWls dXJlIF0KIAogd2Via2l0Lm9yZy9iLzE2NTU0MSBjb21wb3NpdGluZy9sYXllci1jcmVhdGlvbi9m aXhlZC1vdmVybGFwLWV4dGVudC1ydGwuaHRtbCBbIEZhaWx1cmUgXQotCi13ZWJraXQub3JnL2Iv MTY1NTg5IHBvaW50ZXItbG9jay9sb2NrLWxvc3Qtb24tZXNjLWluLWZ1bGxzY3JlZW4uaHRtbCBb IFNraXAgXQo=