165221 2016-11-30 14:15:43 -0800 IndexedDB 2.0: Send operations off to the server in batches instead of one at a time 2016-11-30 14:59:52 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 160306 1 beidson beidson achristensen alecflett commit-queue jsbell oldest_to_newest 1254971 0 beidson 2016-11-30 14:15:43 -0800 IndexedDB 2.0: Send operations off to the server in batches instead of one at a time Turns out timer scheduling and/or dispatching to the runloop is expensive. On a profile of "100,000 writes to an IDB", timer scheduling/firing presented as 10+% of the time. This patch negates much of that. 1254972 1 295767 beidson 2016-11-30 14:17:33 -0800 Created attachment 295767 Patch v1 1254993 2 beidson 2016-11-30 14:43:49 -0800 GTK build breakage is not because of this patch. 1254998 3 295767 mmaxfield 2016-11-30 14:55:09 -0800 Comment on attachment 295767 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=295767&action=review > Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:412 > + static const size_t operationBatchLimit = 128; IIRC Ben had an argument against const variables being static. I can't remember it but I think it was about how static variables have to live in their own memory region and therefore have to be a load rather than an immediate. > Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:-417 > - schedulePendingOperationTimer(); I assume you are scheduling the operation for the next chunk somewhere else? 1255000 4 beidson 2016-11-30 14:56:52 -0800 (In reply to comment #3) > Comment on attachment 295767 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295767&action=review > > > Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:412 > > + static const size_t operationBatchLimit = 128; > > IIRC Ben had an argument against const variables being static. I can't > remember it but I think it was about how static variables have to live in > their own memory region and therefore have to be a load rather than an > immediate. "An expert" needs to figure this out for sure, because as is there are 5958 results in 1264 files searching for "static const" > > Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:-417 > > - schedulePendingOperationTimer(); > > I assume you are scheduling the operation for the next chunk somewhere else? Correct! Thanks. 1255002 5 295767 commit-queue 2016-11-30 14:59:49 -0800 Comment on attachment 295767 Patch v1 Clearing flags on attachment: 295767 Committed r209157: <http://trac.webkit.org/changeset/209157> 1255003 6 commit-queue 2016-11-30 14:59:52 -0800 All reviewed patches have been landed. Closing bug. 295767 2016-11-30 14:17:33 -0800 2016-11-30 14:59:49 -0800 Patch v1 patch text/plain 2667 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiN2Y0ZDA0Li5mYjE2MWM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTYtMTEtMzAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAg ICAgIEluZGV4ZWREQiAyLjA6IFNlbmQgb3BlcmF0aW9ucyBvZmYgdG8gdGhlIHNlcnZlciBpbiBi YXRjaGVzIGluc3RlYWQgb2Ygb25lIGF0IGEgdGltZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTIyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoTm8gb2JzZXJ2YWJsZSBiZWhh dmlvciBjaGFuZ2UpLgorCisgICAgICAgIE9uIGEgcHJvZmlsZSBvZiAiTG90cyBvZiB3cml0ZXMg dG8gYW4gSW5kZXhlZERCIiwgdGltZXIgc2NoZWR1bGluZy9maXJpbmcgcHJlc2VudGVkIGFzIG92 ZXIgMTAlIG9mIHRoZSB0aW1lLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbmVnYXRlcyBtdWNoIG9m IHRoYXQuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFuc2FjdGlvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJREJUcmFuc2FjdGlvbjo6cGVuZGluZ09wZXJhdGlvblRpbWVy RmlyZWQpOiBTZW5kIDEwMCBvcGVyYXRpb25zIG9mZiB0byB0aGUgc2VydmVyCisgICAgICAgICAg YmVmb3JlIHNwaW5uaW5nIHRoZSBydW5sb29wLCBpbnN0ZWFkIG9mIG9ubHkgMS4KKworMjAxNi0x MS0zMCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisKICAgICAgICAgSW5kZXhl ZERCOiBXaGVuIGRvaW5nIHB1dHMsIGRvbid0ICJ1cGRhdGVBbGxJbmRleGVzRm9yQWRkUmVjb3Jk IiBpZiB0aGVyZSBhcmUgbm8gaW5kZXhlcy4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2NTIxNQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9JREJUcmFuc2FjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2luZGV4ZWRkYi9JREJUcmFuc2FjdGlvbi5jcHAKaW5kZXggZWIwZDg3Yi4uNDQ5NzM0NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCVHJhbnNhY3Rp b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0 aW9uLmNwcApAQCAtNDA2LDE3ICs0MDYsMTkgQEAgdm9pZCBJREJUcmFuc2FjdGlvbjo6cGVuZGlu Z09wZXJhdGlvblRpbWVyRmlyZWQoKQogICAgIGlmICghbV90cmFuc2FjdGlvbk9wZXJhdGlvbnNJ blByb2dyZXNzUXVldWUuaXNFbXB0eSgpICYmICFtX3RyYW5zYWN0aW9uT3BlcmF0aW9uc0luUHJv Z3Jlc3NRdWV1ZS5sYXN0KCktPm5leHRSZXF1ZXN0Q2FuR29Ub1NlcnZlcigpKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBpZiAoIW1fcGVuZGluZ1RyYW5zYWN0aW9uT3BlcmF0aW9uUXVldWUuaXNF bXB0eSgpKSB7CisgICAgLy8gV2Ugd2FudCB0byBiYXRjaCBvcGVyYXRpb25zIHRvZ2V0aGVyIHdp dGhvdXQgc3Bpbm5pbmcgdGhlIHJ1bmxvb3AgZm9yIHBlcmZvcm1hbmNlLAorICAgIC8vIGJ1dCBk b24ndCB3YW50IHRvIGFmZmVjdCByZXNwb25zaXZlbmVzcyBvZiB0aGUgbWFpbiB0aHJlYWQuCisg ICAgLy8gVGhpcyBudW1iZXIgaXMgYSBnb29kIGNvbXByb21pc2UgaW4gYWQtaG9jIHRlc3Rpbmcu CisgICAgc3RhdGljIGNvbnN0IHNpemVfdCBvcGVyYXRpb25CYXRjaExpbWl0ID0gMTI4OworCisg ICAgZm9yIChzaXplX3QgaXRlcmF0aW9ucyA9IDA7ICFtX3BlbmRpbmdUcmFuc2FjdGlvbk9wZXJh dGlvblF1ZXVlLmlzRW1wdHkoKSAmJiBpdGVyYXRpb25zIDwgb3BlcmF0aW9uQmF0Y2hMaW1pdDsg KytpdGVyYXRpb25zKSB7CiAgICAgICAgIGF1dG8gb3BlcmF0aW9uID0gbV9wZW5kaW5nVHJhbnNh Y3Rpb25PcGVyYXRpb25RdWV1ZS50YWtlRmlyc3QoKTsKICAgICAgICAgbV90cmFuc2FjdGlvbk9w ZXJhdGlvbnNJblByb2dyZXNzUXVldWUuYXBwZW5kKG9wZXJhdGlvbi5nZXQoKSk7CiAgICAgICAg IG9wZXJhdGlvbi0+cGVyZm9ybSgpOwogCi0gICAgICAgIC8vIElmIHRoaXMgb3BlcmF0aW9uIHdl IGp1c3Qgc3RhcnRlZCBoYXMgYW4gYXNzb2NpYXRlZCBJREJSZXF1ZXN0LCB3ZSBtaWdodCBiZSBh YmxlIHRvIHNlbmQKLSAgICAgICAgLy8gYW5vdGhlciBvcGVyYXRpb24gdG8gdGhlIHNlcnZlciBi ZWZvcmUgaXQgY29tcGxldGVzLgotICAgICAgICBpZiAob3BlcmF0aW9uLT5pZGJSZXF1ZXN0KCkg JiYgIW1fcGVuZGluZ1RyYW5zYWN0aW9uT3BlcmF0aW9uUXVldWUuaXNFbXB0eSgpKQotICAgICAg ICAgICAgc2NoZWR1bGVQZW5kaW5nT3BlcmF0aW9uVGltZXIoKTsKKyAgICAgICAgaWYgKCFvcGVy YXRpb24tPm5leHRSZXF1ZXN0Q2FuR29Ub1NlcnZlcigpKQorICAgICAgICAgICAgYnJlYWs7CiAK LSAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIGlmICghbV90cmFuc2FjdGlvbk9wZXJhdGlv bk1hcC5pc0VtcHR5KCkgfHwgIW1fb3BlblJlcXVlc3RzLmlzRW1wdHkoKSkK