165024 2016-11-21 22:18:05 -0800 Hasher::addCharacters() should be able to handle zero length strings. 2016-11-21 22:31:18 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo commit-queue darin dbates ysuzuki oldest_to_newest 1253340 0 mark.lam 2016-11-21 22:18:05 -0800 Currently, it will fail to handle zero length strings if it has a pending character. 1253342 1 295327 mark.lam 2016-11-21 22:23:38 -0800 Created attachment 295327 proposed patch. 1253343 2 295327 ysuzuki 2016-11-21 22:26:46 -0800 Comment on attachment 295327 proposed patch. r=me 1253345 3 mark.lam 2016-11-21 22:31:18 -0800 Thanks for the review. Landed in r208958: <http://trac.webkit.org/r208958>. 295327 2016-11-21 22:23:38 -0800 2016-11-21 22:26:46 -0800 proposed patch. bug-165024.patch text/plain 4317 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDg5NTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTExLTIxICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBIYXNoZXI6OmFkZENoYXJhY3RlcnMoKSBzaG91bGQgYmUg YWJsZSB0byBoYW5kbGUgemVybyBsZW5ndGggc3RyaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTAyNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgaXQgd2lsbCBmYWlsIHRvIGhh bmRsZSB6ZXJvIGxlbmd0aCBzdHJpbmdzIGlmIGl0IGhhcyBhIHBlbmRpbmcKKyAgICAgICAgY2hh cmFjdGVyLiAgVGhlIGZpeCBpcyBzaW1wbHkgdG8gcmV0dXJuIGVhcmx5IGlmIGxlbmd0aCBpcyAw LiAKKworICAgICAgICAqIHd0Zi9IYXNoZXIuaDoKKyAgICAgICAgKFdURjo6U3RyaW5nSGFzaGVy OjphZGRDaGFyYWN0ZXJzKToKKwogMjAxNi0xMS0xOCAgSmVyZW15IEpvbmVzICA8amVyZW15akBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIHJ1bnRpbWUgZmxhZyB0byBlbmFibGUgcG9pbnRlciBs b2NrLiBFbmFibGUgcG9pbnRlciBsb2NrIGZlYXR1cmUgZm9yIG1hYy4KSW5kZXg6IFNvdXJjZS9X VEYvd3RmL0hhc2hlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0hhc2hlci5oCShy ZXZpc2lvbiAyMDg5NTcpCisrKyBTb3VyY2UvV1RGL3d0Zi9IYXNoZXIuaAkod29ya2luZyBjb3B5 KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDUsIDIwMDYsIDIwMDgs IDIwMTAsIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0 IChDKSAyMDA1LTIwMDYsIDIwMDgsIDIwMTAsIDIwMTMsIDIwMTYgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgogICogQ29weXJpZ2h0IChDKSAyMDEwIFBhdHJpY2sgR2Fuc3RlcmVyIDxw YXJvZ2FAcGFyb2dhLmNvbT4KICAqCiAgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsg eW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCkBAIC0xMzEsNyArMTMxLDkgQEAgcHVibGlj OgogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgVUNoYXIgQ29udmVydGVyKFQpPiB2b2lkIGFk ZENoYXJhY3RlcnMoY29uc3QgVCogZGF0YSwgdW5zaWduZWQgbGVuZ3RoKQogICAgIHsKLSAgICAg ICAgaWYgKG1faGFzUGVuZGluZ0NoYXJhY3RlciAmJiBsZW5ndGgpIHsKKyAgICAgICAgaWYgKCFs ZW5ndGgpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIGlmIChtX2hhc1BlbmRpbmdDaGFy YWN0ZXIpIHsKICAgICAgICAgICAgIG1faGFzUGVuZGluZ0NoYXJhY3RlciA9IGZhbHNlOwogICAg ICAgICAgICAgYWRkQ2hhcmFjdGVyc0Fzc3VtaW5nQWxpZ25lZChtX3BlbmRpbmdDaGFyYWN0ZXIs IENvbnZlcnRlcigqZGF0YSsrKSk7CiAgICAgICAgICAgICAtLWxlbmd0aDsKSW5kZXg6IFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODk1 NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisy MDE2LTExLTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBIYXNo ZXI6OmFkZENoYXJhY3RlcnMoKSBzaG91bGQgYmUgYWJsZSB0byBoYW5kbGUgemVybyBsZW5ndGgg c3RyaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2NTAyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5nSGFzaGVyLmNwcDoKKyAgICAgICAgKFRl c3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE2LTExLTIxICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQ ZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDTWFrZV0gYnVpbGQgZmFpbHMg YWZ0ZXIgdXBkYXRlIHRvIGNtYWtlIDMuNwpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XVEYvU3RyaW5nSGFzaGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dURi9TdHJpbmdIYXNoZXIuY3BwCShyZXZpc2lvbiAyMDg5NTcpCisrKyBUb29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdIYXNoZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNjQsNiArMjY0LDQzIEBAIFRFU1QoV1RGLCBTdHJpbmdIYXNoZXJfYWRkQ2hhcmFjdGVycykK ICAgICBoYXNoZXIuYWRkQ2hhcmFjdGVycyh0ZXN0QlVDaGFycyArIDMpOwogICAgIEFTU0VSVF9F USh0ZXN0Qkhhc2g1LCBoYXNoZXIuaGFzaCgpKTsKICAgICBBU1NFUlRfRVEodGVzdEJIYXNoNSAm IDB4RkZGRkZGLCBoYXNoZXIuaGFzaFdpdGhUb3A4Qml0c01hc2tlZCgpKTsKKworICAgIC8vIEhh c2hpbmcgemVybyBjaGFyYWN0ZXJzIGFmdGVyIGhhc2hpbmcgb3RoZXIgY2hhcmFjdGVycy4KKyAg ICBoYXNoZXIgPSBTdHJpbmdIYXNoZXIoKTsKKyAgICBoYXNoZXIuYWRkQ2hhcmFjdGVycyhudWxs TENoYXJzLCAwKTsKKyAgICBoYXNoZXIuYWRkQ2hhcmFjdGVycyhudWxsTENoYXJzLCAwKTsKKyAg ICBBU1NFUlRfRVEoZW1wdHlTdHJpbmdIYXNoLCBoYXNoZXIuaGFzaCgpKTsKKyAgICBBU1NFUlRf RVEoZW1wdHlTdHJpbmdIYXNoICYgMHhGRkZGRkYsIGhhc2hlci5oYXNoV2l0aFRvcDhCaXRzTWFz a2VkKCkpOworICAgIAorICAgIGhhc2hlciA9IFN0cmluZ0hhc2hlcigpOworICAgIGhhc2hlci5h ZGRDaGFyYWN0ZXJzKHRlc3RBTENoYXJzLCAxKTsKKyAgICBoYXNoZXIuYWRkQ2hhcmFjdGVycyhu dWxsTENoYXJzLCAwKTsKKyAgICBBU1NFUlRfRVEodGVzdEFIYXNoMSwgaGFzaGVyLmhhc2goKSk7 CisgICAgQVNTRVJUX0VRKHRlc3RBSGFzaDEgJiAweEZGRkZGRiwgaGFzaGVyLmhhc2hXaXRoVG9w OEJpdHNNYXNrZWQoKSk7CisgICAgCisgICAgaGFzaGVyID0gU3RyaW5nSGFzaGVyKCk7CisgICAg aGFzaGVyLmFkZENoYXJhY3RlcnModGVzdEFMQ2hhcnMsIDIpOworICAgIGhhc2hlci5hZGRDaGFy YWN0ZXJzKG51bGxMQ2hhcnMsIDApOworICAgIEFTU0VSVF9FUSh0ZXN0QUhhc2gyLCBoYXNoZXIu aGFzaCgpKTsKKyAgICBBU1NFUlRfRVEodGVzdEFIYXNoMiAmIDB4RkZGRkZGLCBoYXNoZXIuaGFz aFdpdGhUb3A4Qml0c01hc2tlZCgpKTsKKworICAgIGhhc2hlciA9IFN0cmluZ0hhc2hlcigpOwor ICAgIGhhc2hlci5hZGRDaGFyYWN0ZXJzKHRlc3RBVUNoYXJzLCAzKTsKKyAgICBoYXNoZXIuYWRk Q2hhcmFjdGVycyhudWxsTENoYXJzLCAwKTsKKyAgICBBU1NFUlRfRVEodGVzdEFIYXNoMywgaGFz aGVyLmhhc2goKSk7CisgICAgQVNTRVJUX0VRKHRlc3RBSGFzaDMgJiAweEZGRkZGRiwgaGFzaGVy Lmhhc2hXaXRoVG9wOEJpdHNNYXNrZWQoKSk7CisKKyAgICBoYXNoZXIgPSBTdHJpbmdIYXNoZXIo KTsKKyAgICBoYXNoZXIuYWRkQ2hhcmFjdGVycyh0ZXN0QUxDaGFycywgNCk7CisgICAgaGFzaGVy LmFkZENoYXJhY3RlcnMobnVsbExDaGFycywgMCk7CisgICAgQVNTRVJUX0VRKHRlc3RBSGFzaDQs IGhhc2hlci5oYXNoKCkpOworICAgIEFTU0VSVF9FUSh0ZXN0QUhhc2g0ICYgMHhGRkZGRkYsIGhh c2hlci5oYXNoV2l0aFRvcDhCaXRzTWFza2VkKCkpOworICAgIAorICAgIGhhc2hlciA9IFN0cmlu Z0hhc2hlcigpOworICAgIGhhc2hlci5hZGRDaGFyYWN0ZXJzKHRlc3RBTENoYXJzLCA1KTsKKyAg ICBoYXNoZXIuYWRkQ2hhcmFjdGVycyhudWxsTENoYXJzLCAwKTsKKyAgICBBU1NFUlRfRVEodGVz dEFIYXNoNSwgaGFzaGVyLmhhc2goKSk7CisgICAgQVNTRVJUX0VRKHRlc3RBSGFzaDUgJiAweEZG RkZGRiwgaGFzaGVyLmhhc2hXaXRoVG9wOEJpdHNNYXNrZWQoKSk7CiB9CiAKIFRFU1QoV1RGLCBT dHJpbmdIYXNoZXJfYWRkQ2hhcmFjdGVyc0Fzc3VtaW5nQWxpZ25lZCkK