164951 2016-11-18 13:29:15 -0800 Flaky 32-bit JSC test timeouts: stress/op_div-* and ress/op_mod-* 2016-11-23 07:32:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=155289 P2 Normal --- 164994 1 ryanhaddad mark.lam ap fpizlo ggaren jfbastien keith_miller mark.lam msaboff saam ysuzuki oldest_to_newest 1252812 0 ryanhaddad 2016-11-18 13:29:15 -0800 https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/4252 ** The following JSC stress test failures have been introduced: stress/op_div-ConstVar.js.misc-ftl-no-cjit stress/op_div-VarConst.js.misc-ftl-no-cjit stress/op_div-VarVar.js.misc-ftl-no-cjit stress/op_mod-ConstVar.js.misc-ftl-no-cjit stress/op_mod-VarConst.js.misc-ftl-no-cjit stress/op_mod-VarVar.js.misc-ftl-no-cjit 1252814 1 ryanhaddad 2016-11-18 13:30:21 -0800 Another instance seen here: https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/4226 ** The following JSC stress test failures have been introduced: stress/op_div-VarConst.js.misc-ftl-no-cjit stress/op_mod-ConstVar.js.misc-ftl-no-cjit stress/op_mod-VarConst.js.misc-ftl-no-cjit stress/op_mod-VarVar.js.misc-ftl-no-cjit 1252822 2 mark.lam 2016-11-18 13:36:47 -0800 These are all due to time outs. When did these failures started happening? Either we started running on slower bots or potentially, someone introduced a perf regression. 1252823 3 ryanhaddad 2016-11-18 13:38:10 -0800 (In reply to comment #2) > These are all due to time outs. When did these failures started happening? > Either we started running on slower bots or potentially, someone introduced > a perf regression. I'm going through logs now to try to find out. 1252826 4 ryanhaddad 2016-11-18 13:41:32 -0800 Earliest instance I can find on this bot is r208607 / Fri Nov 11 13:56:25 2016 https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/4192 1252828 5 ryanhaddad 2016-11-18 13:42:09 -0800 The bot config has not changed. 1253055 6 295255 mark.lam 2016-11-19 00:13:49 -0800 Created attachment 295255 proposed patch. I'm fixing this by simply recognizing that not all tests are equal, and that some just needs more time to run. I've added a --timeoutMultipler=<multiplier> option that can be used on these slower tests to increase their timeout duration. This should fix this issue for good. 1253057 7 295255 ysuzuki 2016-11-19 00:20:49 -0800 Comment on attachment 295255 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295255&action=review r=me > Source/JavaScriptCore/jsc.cpp:2606 > + auto timeout = std::chrono::microseconds(static_cast<std::chrono::microseconds::rep>(timeoutDuration * 1000000)); Let's use WTF::Seconds. 1253084 8 mark.lam 2016-11-19 09:41:32 -0800 Thanks for the review. I've changed the timeout thread to use WTF::Seconds. Landed in r208925: <http://trac.webkit.org/r208925>. 1253127 9 mark.lam 2016-11-19 17:58:10 -0800 I forgot to also lengthen the timeout for op_mod-* tests. Will do that in https://bugs.webkit.org/show_bug.cgi?id=164994. 1253489 10 mark.lam 2016-11-23 07:32:09 -0800 *** Bug 155289 has been marked as a duplicate of this bug. *** 295255 2016-11-19 00:13:49 -0800 2016-11-19 09:40:10 -0800 proposed patch. bug-164951.patch text/plain 6419 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDg5MjIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDE2LTExLTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgLS10aW1lb3V0TXVsdGlwbGllciBvcHRpb24gdG8gYWxsb3cgc29t ZSB0ZXN0cyBtb3JlIHRpbWUgdG8gcnVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY0OTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRXh0ZW5kZWQgdGhlIHRpbWVvdXQgZm9yIHRoZXNlIHRlc3RzIGJ5 IDUwJSBtb3JlIGJlY2F1c2UgdGhleSBydW4gcXVpdGUgc2xvdyBvbgorICAgICAgICBsb3ctZW5k IG1hY2hpbmVzLgorCisgICAgICAgICogc3RyZXNzL29wX2Rpdi1Db25zdFZhci5qczoKKyAgICAg ICAgKiBzdHJlc3Mvb3BfZGl2LVZhckNvbnN0LmpzOgorICAgICAgICAqIHN0cmVzcy9vcF9kaXYt VmFyVmFyLmpzOgorCiAyMDE2LTExLTE4ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21h aWwuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIwODg2Nyk6IEpTQyB0ZXN0IGZhaWx1cmU6 IENoYWtyYUNvcmUueWFtbC9DaGFrcmFDb3JlL3Rlc3Qvc3RyaWN0LzA1LmFyZ3VtZW50c19zbS5q cy5kZWZhdWx0CkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9vcF9kaXYtQ29uc3RWYXIuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSlNUZXN0cy9zdHJlc3Mvb3BfZGl2LUNvbnN0VmFyLmpzCShyZXZpc2lvbiAyMDg5 MjEpCisrKyBKU1Rlc3RzL3N0cmVzcy9vcF9kaXYtQ29uc3RWYXIuanMJKHdvcmtpbmcgY29weSkK QEAgLTEsNCArMSw0IEBACi0vL0AgcnVuRlRMTm9DSklUCisvL0AgcnVuRlRMTm9DSklUKCItLXRp bWVvdXRNdWx0aXBsaWVyPTEuNSIpCiAKIC8vIElmIGFsbCBnb2VzIHdlbGwsIHRoaXMgdGVzdCBt b2R1bGUgd2lsbCB0ZXJtaW5hdGUgc2lsZW50bHkuIElmIG5vdCwgaXQgd2lsbCBwcmludAogLy8g ZXJyb3JzLiBTZWUgYmluYXJ5LW9wLXRlc3QuanMgZm9yIGRlYnVnZ2luZyBvcHRpb25zIGlmIG5l ZWRlZC4KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL29wX2Rpdi1WYXJDb25zdC5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKU1Rlc3RzL3N0cmVzcy9vcF9kaXYtVmFyQ29uc3QuanMJKHJldmlzaW9uIDIwODkyMSkK KysrIEpTVGVzdHMvc3RyZXNzL29wX2Rpdi1WYXJDb25zdC5qcwkod29ya2luZyBjb3B5KQpAQCAt MSw0ICsxLDQgQEAKLS8vQCBydW5GVExOb0NKSVQKKy8vQCBydW5GVExOb0NKSVQoIi0tdGltZW91 dE11bHRpcGxpZXI9MS41IikKIAogLy8gSWYgYWxsIGdvZXMgd2VsbCwgdGhpcyB0ZXN0IG1vZHVs ZSB3aWxsIHRlcm1pbmF0ZSBzaWxlbnRseS4gSWYgbm90LCBpdCB3aWxsIHByaW50CiAvLyBlcnJv cnMuIFNlZSBiaW5hcnktb3AtdGVzdC5qcyBmb3IgZGVidWdnaW5nIG9wdGlvbnMgaWYgbmVlZGVk LgpJbmRleDogSlNUZXN0cy9zdHJlc3Mvb3BfZGl2LVZhclZhci5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK U1Rlc3RzL3N0cmVzcy9vcF9kaXYtVmFyVmFyLmpzCShyZXZpc2lvbiAyMDg5MjEpCisrKyBKU1Rl c3RzL3N0cmVzcy9vcF9kaXYtVmFyVmFyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBA QAotLy9AIHJ1bkZUTE5vQ0pJVAorLy9AIHJ1bkZUTE5vQ0pJVCgiLS10aW1lb3V0TXVsdGlwbGll cj0xLjUiKQogCiAvLyBJZiBhbGwgZ29lcyB3ZWxsLCB0aGlzIHRlc3QgbW9kdWxlIHdpbGwgdGVy bWluYXRlIHNpbGVudGx5LiBJZiBub3QsIGl0IHdpbGwgcHJpbnQKIC8vIGVycm9ycy4gU2VlIGJp bmFyeS1vcC10ZXN0LmpzIGZvciBkZWJ1Z2dpbmcgb3B0aW9ucyBpZiBuZWVkZWQuCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODkyMSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMyBAQAorMjAxNi0x MS0xOSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIC0tdGlt ZW91dE11bHRpcGxpZXIgb3B0aW9uIHRvIGFsbG93IHNvbWUgdGVzdHMgbW9yZSB0aW1lIHRvIHJ1 bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDk1 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICoganNj LmNwcDoKKyAgICAgICAgKHRpbWVvdXRUaHJlYWRNYWluKToKKyAgICAgICAgLSBNb2RpZmllZCB0 byBmYWN0b3IgaW4gYSB0aW1lb3V0IG11bHRpcGxpZXIgdGhhdCBjYW4gYWRqdXN0IHRoZSB0aW1l b3V0IGR1cmF0aW9uLgorICAgICAgICAoc3RhcnRUaW1lb3V0VGhyZWFkSWZOZWVkZWQpOgorICAg ICAgICAtIE1vdmVkIHRoZSBjb2RlIHRoYXQgc3RhcnRzIHRoZSB0aW1lb3V0IHRocmVhZCBoZXJl IGZyb20gbWFpbigpIHNvIHRoYXQgd2UgY2FuCisgICAgICAgIGNhbGwgaXQgYWZ0ZXIgY29tbWFu ZCBsaW5lIGFyZ3MgaGF2ZSBiZWVuIHBhcnNlZCBpbnN0ZWFkLgorICAgICAgICAobWFpbik6Cisg ICAgICAgIC0gRGVsZXRlZCBvbGQgdGltZW91dCB0aHJlYWQgc3RhcnRpbmcgY29kZS4KKyAgICAg ICAgKENvbW1hbmRMaW5lOjpwYXJzZUFyZ3VtZW50cyk6CisgICAgICAgIC0gQWRkZWQgcGFyc2lu ZyBvZiB0aGUgLS10aW1lb3V0TXVsdGlwbGllciBvcHRpb24uCisgICAgICAgIChqc2NtYWluKToK KyAgICAgICAgLSBTdGFydCB0aGUgdGltZW91dCB0aHJlYWQgaWYgbmVlZGVkIGFmdGVyIHdlJ3Zl IHBhcnNlZCB0aGUgY29tbWFuZCBsaW5lIGFyZ3MuCisKIDIwMTYtMTEtMTggIE1hcmsgTGFtICA8 bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBtaXNzaW5nIGV4Y2VwdGlvbiBjaGVj a3MgaW4gREZHT3BlcmF0aW9ucy5jcHAuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNj LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNp b24gMjA4OTIxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI1OTgsMTYgKzI1OTgsMjkgQEAgc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NU X0NBTEwgZnVuYwogaW50IGpzY21haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KTsKIAogc3RhdGlj IGRvdWJsZSBzX2Rlc2lyZWRUaW1lb3V0Oworc3RhdGljIGRvdWJsZSBzX3RpbWVvdXRNdWx0aXBs aWVyID0gMS4wOwogCiBzdGF0aWMgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIHRpbWVvdXRU aHJlYWRNYWluKHZvaWQqKQogewotICAgIGF1dG8gdGltZW91dCA9IHN0ZDo6Y2hyb25vOjptaWNy b3NlY29uZHMoc3RhdGljX2Nhc3Q8c3RkOjpjaHJvbm86Om1pY3Jvc2Vjb25kczo6cmVwPihzX2Rl c2lyZWRUaW1lb3V0ICogMTAwMDAwMCkpOworICAgIGRvdWJsZSB0aW1lb3V0RHVyYXRpb24gPSBz X2Rlc2lyZWRUaW1lb3V0ICogc190aW1lb3V0TXVsdGlwbGllcjsKKyAgICBhdXRvIHRpbWVvdXQg PSBzdGQ6OmNocm9ubzo6bWljcm9zZWNvbmRzKHN0YXRpY19jYXN0PHN0ZDo6Y2hyb25vOjptaWNy b3NlY29uZHM6OnJlcD4odGltZW91dER1cmF0aW9uICogMTAwMDAwMCkpOwogICAgIHN0ZDo6dGhp c190aHJlYWQ6OnNsZWVwX2Zvcih0aW1lb3V0KTsKICAgICAKLSAgICBkYXRhTG9nKCJUaW1lZCBv dXQgYWZ0ZXIgIiwgc19kZXNpcmVkVGltZW91dCwgIiBzZWNvbmRzIVxuIik7CisgICAgZGF0YUxv ZygiVGltZWQgb3V0IGFmdGVyICIsIHRpbWVvdXREdXJhdGlvbiwgIiBzZWNvbmRzIVxuIik7CiAg ICAgQ1JBU0goKTsKIH0KIAorc3RhdGljIHZvaWQgc3RhcnRUaW1lb3V0VGhyZWFkSWZOZWVkZWQo KQoreworICAgIGlmIChjaGFyKiB0aW1lb3V0U3RyaW5nID0gZ2V0ZW52KCJKU0NURVNUX3RpbWVv dXQiKSkgeworICAgICAgICBpZiAoc3NjYW5mKHRpbWVvdXRTdHJpbmcsICIlbGYiLCAmc19kZXNp cmVkVGltZW91dCkgIT0gMSkgeworICAgICAgICAgICAgZGF0YUxvZygiV0FSTklORzogdGltZW91 dCBzdHJpbmcgaXMgbWFsZm9ybWVkLCBnb3QgIiwgdGltZW91dFN0cmluZywKKyAgICAgICAgICAg ICAgICAiIGJ1dCBleHBlY3RlZCBhIG51bWJlci4gTm90IHVzaW5nIGEgdGltZW91dC5cbiIpOwor ICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIGNyZWF0ZVRocmVhZCh0aW1lb3V0VGhyZWFkTWFp biwgMCwgImpzYyBUaW1lb3V0IFRocmVhZCIpOworICAgIH0KK30KKwogaW50IG1haW4oaW50IGFy Z2MsIGNoYXIqKiBhcmd2KQogewogI2lmIFBMQVRGT1JNKElPUykgJiYgQ1BVKEFSTV9USFVNQjIp CkBAIC0yNjUwLDE1ICsyNjYzLDYgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQog ICAgIC8vIGhhdmUgYSBjaGFuY2UgdG8gcGFyc2Ugb3B0aW9ucy4KICAgICBXVEY6OmluaXRpYWxp emVUaHJlYWRpbmcoKTsKIAotICAgIGlmIChjaGFyKiB0aW1lb3V0U3RyaW5nID0gZ2V0ZW52KCJK U0NURVNUX3RpbWVvdXQiKSkgewotICAgICAgICBpZiAoc3NjYW5mKHRpbWVvdXRTdHJpbmcsICIl bGYiLCAmc19kZXNpcmVkVGltZW91dCkgIT0gMSkgewotICAgICAgICAgICAgZGF0YUxvZygKLSAg ICAgICAgICAgICAgICAiV0FSTklORzogdGltZW91dCBzdHJpbmcgaXMgbWFsZm9ybWVkLCBnb3Qg IiwgdGltZW91dFN0cmluZywKLSAgICAgICAgICAgICAgICAiIGJ1dCBleHBlY3RlZCBhIG51bWJl ci4gTm90IHVzaW5nIGEgdGltZW91dC5cbiIpOwotICAgICAgICB9IGVsc2UKLSAgICAgICAgICAg IGNyZWF0ZVRocmVhZCh0aW1lb3V0VGhyZWFkTWFpbiwgMCwgImpzYyBUaW1lb3V0IFRocmVhZCIp OwotICAgIH0KLQogI2lmIFBMQVRGT1JNKElPUykKICAgICBPcHRpb25zOjpjcmFzaElmQ2FudEFs bG9jYXRlSklUTWVtb3J5KCkgPSB0cnVlOwogI2VuZGlmCkBAIC0zMDEwLDYgKzMwMTQsMTUgQEAg dm9pZCBDb21tYW5kTGluZTo6cGFyc2VBcmd1bWVudHMoaW50IGFyZwogICAgICAgICAgICAgY29u dGludWU7CiAgICAgICAgIH0KIAorICAgICAgICBzdGF0aWMgY29uc3QgY2hhciogdGltZW91dE11 bHRpcGxpZXJPcHRTdHIgPSAiLS10aW1lb3V0TXVsdGlwbGllcj0iOworICAgICAgICBzdGF0aWMg Y29uc3QgdW5zaWduZWQgdGltZW91dE11bHRpcGxpZXJPcHRTdHJMZW5ndGggPSBzdHJsZW4odGlt ZW91dE11bHRpcGxpZXJPcHRTdHIpOworICAgICAgICBpZiAoIXN0cm5jbXAoYXJnLCB0aW1lb3V0 TXVsdGlwbGllck9wdFN0ciwgdGltZW91dE11bHRpcGxpZXJPcHRTdHJMZW5ndGgpKSB7CisgICAg ICAgICAgICBjb25zdCBjaGFyKiB2YWx1ZVN0ciA9ICZhcmdbdGltZW91dE11bHRpcGxpZXJPcHRT dHJMZW5ndGhdOworICAgICAgICAgICAgaWYgKHNzY2FuZih2YWx1ZVN0ciwgIiVsZiIsICZzX3Rp bWVvdXRNdWx0aXBsaWVyKSAhPSAxKQorICAgICAgICAgICAgICAgIGRhdGFMb2coIldBUk5JTkc6 IC0tdGltZW91dE11bHRpcGxpZXI9IiwgdmFsdWVTdHIsICIgaXMgaW52YWxpZC4gRXhwZWN0cyBh IG51bWVyaWMgcmF0aW8uXG4iKTsKKyAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICB9CisK ICAgICAgICAgaWYgKCFzdHJjbXAoYXJnLCAiLS10ZXN0MjYyLWFzeW5jIikpIHsKICAgICAgICAg ICAgIHRlc3QyNjJBc3luY1Rlc3QgPSB0cnVlOwogICAgICAgICAgICAgY29udGludWU7CkBAIC0z MTM2LDYgKzMxNDksNyBAQCBpbnQganNjbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAg Ly8gSW5pdGlhbGl6ZSBKU0MgYmVmb3JlIGdldHRpbmcgVk0uCiAgICAgV1RGOjppbml0aWFsaXpl TWFpblRocmVhZCgpOwogICAgIEpTQzo6aW5pdGlhbGl6ZVRocmVhZGluZygpOworICAgIHN0YXJ0 VGltZW91dFRocmVhZElmTmVlZGVkKCk7CiAKICAgICBWTSogdm0gPSAmVk06OmNyZWF0ZShMYXJn ZUhlYXApLmxlYWtSZWYoKTsKICAgICBpbnQgcmVzdWx0Owo=