164390 2016-11-03 17:10:16 -0700 REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail 2016-11-04 11:05:35 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 beidson beidson commit-queue darin ggaren ryanhaddad oldest_to_newest 1247942 0 beidson 2016-11-03 17:10:16 -0700 REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail Link to the change: https://trac.webkit.org/changeset/208349 The difference is that memory hashing used to mask the top 8 bits of the hash, just like string hashing needed. Now it no longer does. We can either restore the masking behavior, or accept the change in behavior (as an improvement, I think) and update the test. Note: There was a FIXME in hashMemory that called out how odd it was that we masked the top 8 bits for memory hashing when it wasn't needed like for string hashing. 1247944 1 293830 beidson 2016-11-03 17:12:52 -0700 Created attachment 293830 Patch 1248160 2 293830 ggaren 2016-11-04 10:41:03 -0700 Comment on attachment 293830 Patch Specifically, we don't see any reason that memory hashing needs to mask off the high bits of the hash code, even though string hashing does so in order to support an implementation of StringImpl that stores flags in the high bits of the hash code. 1248170 3 293830 commit-queue 2016-11-04 11:05:31 -0700 Comment on attachment 293830 Patch Clearing flags on attachment: 293830 Committed r208387: <http://trac.webkit.org/changeset/208387> 1248171 4 commit-queue 2016-11-04 11:05:35 -0700 All reviewed patches have been landed. Closing bug. 293830 2016-11-03 17:12:52 -0700 2016-11-04 11:05:31 -0700 Patch bug-164390-20161103170851.patch text/plain 2843 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MzQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjA2NGZmMWJhZTk0OTU3NjhkYjhjYzkxZGY1MzMwZDk1 ZjQ4Mjk4My4uMTQxMDE3YTdlYTVkMTg5NDkwMTYyM2QzZjY0OWQ2Y2M3MjljMmYyMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE2LTExLTAzICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OIChyMjA4MzQ5KSBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnkgYmVoYXZp b3IgY2hhbmdlZCwgY2F1c2luZyBBUEkgdGVzdHMgdG8gZmFpbAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MzkwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3BlcmF0aW5nIHVuZGVyIHRoZSBhc3N1bXB0 aW9uIHRoYXQgdGhlIGJlaGF2aW9yIGNoYW5nZSBpcyBva2F5L2Rlc2lyYWJsZSwgdGhpcyB1cGRh dGVzIHRoZSB0ZXN0LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5n SGFzaGVyLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE2LTExLTAz ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgV0tXZWJWaWV34oCZ cyBfb2JzZXJ2ZWRSZW5kZXJpbmdQcm9ncmVzc0V2ZW50cyBub3QgcmVzdG9yZWQgYWZ0ZXIgd2Vi IHByb2Nlc3MgY3Jhc2gKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RG L1N0cmluZ0hhc2hlci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdI YXNoZXIuY3BwCmluZGV4IDczOWE4MTkwZTFmODVjMzY2NjhmNzZhMjRmNDNmZWRjY2YyMzc1OTAu LmRhODRiYjE1M2I1M2IzZjQ0MTY5NGIwYzgzNjVkZDA3MTU5YTRlNDEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1N0cmluZ0hhc2hlci5jcHAKKysrIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5nSGFzaGVyLmNwcApAQCAtNDI3LDE4ICs0Mjcs MTggQEAgVEVTVChXVEYsIFN0cmluZ0hhc2hlcl9jb21wdXRlSGFzaEFuZE1hc2tUb3A4Qml0cykK IAogVEVTVChXVEYsIFN0cmluZ0hhc2hlcl9oYXNoTWVtb3J5KQogewotICAgIEFTU0VSVF9FUShl bXB0eVN0cmluZ0hhc2ggJiAweEZGRkZGRiwgU3RyaW5nSGFzaGVyOjpoYXNoTWVtb3J5KDAsIDAp KTsKLSAgICBBU1NFUlRfRVEoZW1wdHlTdHJpbmdIYXNoICYgMHhGRkZGRkYsIFN0cmluZ0hhc2hl cjo6aGFzaE1lbW9yeShudWxsVUNoYXJzLCAwKSk7Ci0gICAgQVNTRVJUX0VRKGVtcHR5U3RyaW5n SGFzaCAmIDB4RkZGRkZGLCBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnk8MD4oMCkpOwotICAgIEFT U0VSVF9FUShlbXB0eVN0cmluZ0hhc2ggJiAweEZGRkZGRiwgU3RyaW5nSGFzaGVyOjpoYXNoTWVt b3J5PDA+KG51bGxVQ2hhcnMpKTsKLQotICAgIEFTU0VSVF9FUShzaW5nbGVOdWxsQ2hhcmFjdGVy SGFzaCAmIDB4RkZGRkZGLCBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnkobnVsbFVDaGFycywgMikp OwotICAgIEFTU0VSVF9FUShzaW5nbGVOdWxsQ2hhcmFjdGVySGFzaCAmIDB4RkZGRkZGLCBTdHJp bmdIYXNoZXI6Omhhc2hNZW1vcnk8Mj4obnVsbFVDaGFycykpOwotCi0gICAgQVNTRVJUX0VRKHRl c3RBSGFzaDUgJiAweEZGRkZGRiwgU3RyaW5nSGFzaGVyOjpoYXNoTWVtb3J5KHRlc3RBVUNoYXJz LCAxMCkpOwotICAgIEFTU0VSVF9FUSh0ZXN0QUhhc2g1ICYgMHhGRkZGRkYsIFN0cmluZ0hhc2hl cjo6aGFzaE1lbW9yeTwxMD4odGVzdEFVQ2hhcnMpKTsKLSAgICBBU1NFUlRfRVEodGVzdEJIYXNo NSAmIDB4RkZGRkZGLCBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnkodGVzdEJVQ2hhcnMsIDEwKSk7 Ci0gICAgQVNTRVJUX0VRKHRlc3RCSGFzaDUgJiAweEZGRkZGRiwgU3RyaW5nSGFzaGVyOjpoYXNo TWVtb3J5PDEwPih0ZXN0QlVDaGFycykpOworICAgIEFTU0VSVF9FUShlbXB0eVN0cmluZ0hhc2gs IFN0cmluZ0hhc2hlcjo6aGFzaE1lbW9yeSgwLCAwKSk7CisgICAgQVNTRVJUX0VRKGVtcHR5U3Ry aW5nSGFzaCwgU3RyaW5nSGFzaGVyOjpoYXNoTWVtb3J5KG51bGxVQ2hhcnMsIDApKTsKKyAgICBB U1NFUlRfRVEoZW1wdHlTdHJpbmdIYXNoLCBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnk8MD4oMCkp OworICAgIEFTU0VSVF9FUShlbXB0eVN0cmluZ0hhc2gsIFN0cmluZ0hhc2hlcjo6aGFzaE1lbW9y eTwwPihudWxsVUNoYXJzKSk7CisKKyAgICBBU1NFUlRfRVEoc2luZ2xlTnVsbENoYXJhY3Rlckhh c2gsIFN0cmluZ0hhc2hlcjo6aGFzaE1lbW9yeShudWxsVUNoYXJzLCAyKSk7CisgICAgQVNTRVJU X0VRKHNpbmdsZU51bGxDaGFyYWN0ZXJIYXNoLCBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnk8Mj4o bnVsbFVDaGFycykpOworCisgICAgQVNTRVJUX0VRKHRlc3RBSGFzaDUsIFN0cmluZ0hhc2hlcjo6 aGFzaE1lbW9yeSh0ZXN0QVVDaGFycywgMTApKTsKKyAgICBBU1NFUlRfRVEodGVzdEFIYXNoNSwg U3RyaW5nSGFzaGVyOjpoYXNoTWVtb3J5PDEwPih0ZXN0QVVDaGFycykpOworICAgIEFTU0VSVF9F USh0ZXN0Qkhhc2g1LCBTdHJpbmdIYXNoZXI6Omhhc2hNZW1vcnkodGVzdEJVQ2hhcnMsIDEwKSk7 CisgICAgQVNTRVJUX0VRKHRlc3RCSGFzaDUsIFN0cmluZ0hhc2hlcjo6aGFzaE1lbW9yeTwxMD4o dGVzdEJVQ2hhcnMpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQo=