164298 2016-11-01 15:50:06 -0700 LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html is flaky 2017-01-24 19:01:20 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 164784 1 ryanhaddad graouts commit-queue graouts oldest_to_newest 1247090 0 ryanhaddad 2016-11-01 15:50:06 -0700 LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html timing out https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fplacard-support%2Fplacard-support-airplay.html 1247091 1 ryanhaddad 2016-11-01 15:50:52 -0700 Test was landed again with http://trac.webkit.org/changeset/208242, seems to be timing out on release builds. 1268547 2 ryanhaddad 2017-01-20 13:43:52 -0800 The test fails or times out on every run: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r210975%20(2974)/results.html --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-actual.txt @@ -1,13 +1,8 @@ +FAIL: Timed out waiting for notifyDone to be called Testing the PlacardSupport behavior when playing media through AirPlay. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -got event false -got event true -PASS mediaController.controls.showsPlacard is true -PASS mediaController.controls.children.includes(mediaController.controls.airplayPlacard) is true -PASS successfullyParsed is true -TEST COMPLETE - +00:0600:00 1268548 3 ryanhaddad 2017-01-20 13:44:25 -0800 Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/210979 1269506 4 299621 graouts 2017-01-24 13:06:34 -0800 Created attachment 299621 Patch 1269517 5 299621 jonlee 2017-01-24 13:15:18 -0800 Comment on attachment 299621 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299621&action=review > LayoutTests/media/modern-media-controls/placard-support/placard-support-airplay.html:41 > + window.internals.setMockMediaPlaybackTargetPickerState('Sleepy TV', 'DeviceAvailable'); If there are more of these. I think we should refactor all of this setup out to a helper script. 1269667 6 299621 commit-queue 2017-01-24 19:01:16 -0800 Comment on attachment 299621 Patch Clearing flags on attachment: 299621 Committed r211132: <http://trac.webkit.org/changeset/211132> 1269668 7 commit-queue 2017-01-24 19:01:20 -0800 All reviewed patches have been landed. Closing bug. 299621 2017-01-24 13:06:34 -0800 2017-01-24 19:01:16 -0800 Patch bug-164298-20170124220434.patch text/plain 6267 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMDg3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGI5MjIwY2QxNzYzMzg0NjFmOTgy OGZkOWQyOTcyMTljZTQ5ZWM3Ny4uZTVjOGExOWNjOTgwNmQxMzgwNTFlZTU0NTI2Y2U5OTFmYjUy MzFhYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAxLTI0ICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdCBtZWRpYS9tb2Rlcm4tbWVk aWEtY29udHJvbHMvcGxhY2FyZC1zdXBwb3J0L3BsYWNhcmQtc3VwcG9ydC1haXJwbGF5Lmh0bWwg aXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2NDI5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2UgbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3BsYWNhcmQtc3VwcG9ydC9wbGFjYXJk LXN1cHBvcnQtYWlycGxheS5odG1sIG1vcmUgcm9idXN0IGJ5CisgICAgICAgIGZvbGxvd2luZyB0 aGUgc2FtZSBwYXR0ZXJuIHVzZWQgaW4gbWVkaWEvYWlycGxheS10YXJnZXQtYXZhaWxhYmlsaXR5 Lmh0bWwgd2hpY2ggcHJvdmVkIHRvIGJlIHJvYnVzdC4KKworICAgICAgICAqIG1lZGlhL21vZGVy bi1tZWRpYS1jb250cm9scy9wbGFjYXJkLXN1cHBvcnQvcGxhY2FyZC1zdXBwb3J0LWFpcnBsYXkt ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9wbGFj YXJkLXN1cHBvcnQvcGxhY2FyZC1zdXBwb3J0LWFpcnBsYXkuaHRtbDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNy0wMS0yNCAgSm9zZXBoIFBlY29yYXJv ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBhbHdheXMgdHJ1ZSBzeW5j WEhSSW5Eb2N1bWVudHNFbmFibGVkIHNldHRpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21l ZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9wbGFjYXJkLXN1cHBvcnQvcGxhY2FyZC1zdXBwb3J0 LWFpcnBsYXktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNv bnRyb2xzL3BsYWNhcmQtc3VwcG9ydC9wbGFjYXJkLXN1cHBvcnQtYWlycGxheS1leHBlY3RlZC50 eHQKaW5kZXggOWY2ZDg2ZDc0OTU3MTBiMWEwZjhhZjYxNzZhMTBiMTg1MDMzMDUxOC4uMzQwMDIy NGZiODY1NDlkYjBlM2JjYTVmZDhhNjBlNmI2ZmExYzI4NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3BsYWNhcmQtc3VwcG9ydC9wbGFjYXJkLXN1 cHBvcnQtYWlycGxheS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJu LW1lZGlhLWNvbnRyb2xzL3BsYWNhcmQtc3VwcG9ydC9wbGFjYXJkLXN1cHBvcnQtYWlycGxheS1l eHBlY3RlZC50eHQKQEAgLTMsMTAgKzMsOSBAQCBUZXN0aW5nIHRoZSBQbGFjYXJkU3VwcG9ydCBi ZWhhdmlvciB3aGVuIHBsYXlpbmcgbWVkaWEgdGhyb3VnaCBBaXJQbGF5LgogT24gc3VjY2Vzcywg eW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRF U1QgQ09NUExFVEUiLgogCiAKLWdvdCBldmVudCBmYWxzZQotZ290IGV2ZW50IHRydWUKIFBBU1Mg bWVkaWFDb250cm9sbGVyLmNvbnRyb2xzLnNob3dzUGxhY2FyZCBpcyB0cnVlCiBQQVNTIG1lZGlh Q29udHJvbGxlci5jb250cm9scy5jaGlsZHJlbi5pbmNsdWRlcyhtZWRpYUNvbnRyb2xsZXIuY29u dHJvbHMuYWlycGxheVBsYWNhcmQpIGlzIHRydWUKKwogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9t b2Rlcm4tbWVkaWEtY29udHJvbHMvcGxhY2FyZC1zdXBwb3J0L3BsYWNhcmQtc3VwcG9ydC1haXJw bGF5Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGxhY2Fy ZC1zdXBwb3J0L3BsYWNhcmQtc3VwcG9ydC1haXJwbGF5Lmh0bWwKaW5kZXggMjc0MTQ0ODFmYTQw MGJiNDgxZTk4ODQzMTBkOWU0ZDI0Y2M5ZDE3Mi4uYTYzZmExNTM5ZDJlYWZkZTIyODRiMzZmZTMz NjQ1ODhkM2YwZjhmMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlh LWNvbnRyb2xzL3BsYWNhcmQtc3VwcG9ydC9wbGFjYXJkLXN1cHBvcnQtYWlycGxheS5odG1sCisr KyBiL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9wbGFjYXJkLXN1cHBv cnQvcGxhY2FyZC1zdXBwb3J0LWFpcnBsYXkuaHRtbApAQCAtMjMsMzMgKzIzLDU2IEBAIHdpbmRv dy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKIAogZGVzY3JpcHRpb24oIlRlc3RpbmcgdGhlIDxjb2Rl PlBsYWNhcmRTdXBwb3J0PC9jb2RlPiBiZWhhdmlvciB3aGVuIHBsYXlpbmcgbWVkaWEgdGhyb3Vn aCBBaXJQbGF5LiIpOwogCi1pY29uU2VydmljZS5kaXJlY3RvcnlQYXRoID0gIi4uLy4uLy4uLy4u L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2ltYWdlcyI7Ci0K IGNvbnN0IGNvbnRhaW5lciA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoImRpdiNob3N0Iik7CiBj b25zdCBtZWRpYSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoInZpZGVvIik7CiBjb25zdCBtZWRp YUNvbnRyb2xsZXIgPSBjcmVhdGVDb250cm9scyhjb250YWluZXIsIG1lZGlhLCBudWxsKTsKIAot aWYgKHdpbmRvdy5pbnRlcm5hbHMpIHsKLSAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRpbmdzLnNl dEFsbG93c0FpclBsYXlGb3JNZWRpYVBsYXliYWNrKHRydWUpOwotICAgIHdpbmRvdy5pbnRlcm5h bHMuc2V0TWVkaWFFbGVtZW50UmVzdHJpY3Rpb25zKG1lZGlhLCAibm9yZXN0cmljdGlvbnMiKTsK KyhmdW5jdGlvbiBtYWtlQWlyUGxheUF2YWlsYWJsZSgpCit7CisgICAgbWVkaWEuYWRkRXZlbnRM aXN0ZW5lcigid2Via2l0cGxheWJhY2t0YXJnZXRhdmFpbGFiaWxpdHljaGFuZ2VkIiwgcGxheWJh Y2tUYXJnZXRBdmFpbGFiaWxpdHlDaGFuZ2VkT25jZSwgdHJ1ZSk7CisgICAgd2luZG93LmludGVy bmFscy5zZXRNb2NrTWVkaWFQbGF5YmFja1RhcmdldFBpY2tlckVuYWJsZWQodHJ1ZSk7Cit9KSgp OworCitmdW5jdGlvbiBwbGF5YmFja1RhcmdldEF2YWlsYWJpbGl0eUNoYW5nZWRPbmNlKGV2ZW50 KQoreworICAgIG1lZGlhLnJlbW92ZUV2ZW50TGlzdGVuZXIoJ3dlYmtpdHBsYXliYWNrdGFyZ2V0 YXZhaWxhYmlsaXR5Y2hhbmdlZCcsIHBsYXliYWNrVGFyZ2V0QXZhaWxhYmlsaXR5Q2hhbmdlZE9u Y2UsIHRydWUpOworICAgIG1lZGlhLmFkZEV2ZW50TGlzdGVuZXIoJ3dlYmtpdHBsYXliYWNrdGFy Z2V0YXZhaWxhYmlsaXR5Y2hhbmdlZCcsIHBsYXliYWNrVGFyZ2V0QXZhaWxhYmlsaXR5Q2hhbmdl ZEFnYWluLCB0cnVlKTsKKworICAgIHdpbmRvdy5pbnRlcm5hbHMuc2V0TW9ja01lZGlhUGxheWJh Y2tUYXJnZXRQaWNrZXJTdGF0ZSgnU2xlZXB5IFRWJywgJ0RldmljZUF2YWlsYWJsZScpOwogfQor ICAgIAorZnVuY3Rpb24gcGxheWJhY2tUYXJnZXRBdmFpbGFiaWxpdHlDaGFuZ2VkQWdhaW4oZXZl bnQpCit7CisgICAgLy8gc2V0TW9ja01lZGlhUGxheWJhY2tUYXJnZXRQaWNrZXJTdGF0ZSBoYXBw ZW5zIGFzeW5jaHJvbm91c2x5IGluIFdLMiBhbmQgYQorICAgIC8vICJ3ZWJraXRwbGF5YmFja3Rh cmdldGF2YWlsYWJpbGl0eWNoYW5nZWQiIGlzIGFsd2F5cyBzZW50IHdoZW4gYW4gZXZlbnQgbGlz dGVuZXIKKyAgICAvLyBpcyBhZGRlZCwgc28gd2UgbWF5IGdldCBhICJub3QgYXZhaWxhYmxlIiBl dmVudCBmaXJzdC4KKyAgICBpZiAoZXZlbnQuYXZhaWxhYmlsaXR5ID09ICdub3QtYXZhaWxhYmxl JykKKyAgICAgICAgcmV0dXJuOwogCi1tZWRpYS5hZGRFdmVudExpc3RlbmVyKCJ3ZWJraXRjdXJy ZW50cGxheWJhY2t0YXJnZXRpc3dpcmVsZXNzY2hhbmdlZCIsICgpID0+IHsKLSAgICBpZiAoIW1l ZGlhLnBhdXNlZCAmJiBtZWRpYS53ZWJraXRDdXJyZW50UGxheWJhY2tUYXJnZXRJc1dpcmVsZXNz KSB7Ci0gICAgICAgIHNob3VsZEJlVHJ1ZSgibWVkaWFDb250cm9sbGVyLmNvbnRyb2xzLnNob3dz UGxhY2FyZCIpOwotICAgICAgICBzaG91bGRCZVRydWUoIm1lZGlhQ29udHJvbGxlci5jb250cm9s cy5jaGlsZHJlbi5pbmNsdWRlcyhtZWRpYUNvbnRyb2xsZXIuY29udHJvbHMuYWlycGxheVBsYWNh cmQpIik7CisgICAgbWVkaWEucmVtb3ZlRXZlbnRMaXN0ZW5lcignd2Via2l0cGxheWJhY2t0YXJn ZXRhdmFpbGFiaWxpdHljaGFuZ2VkJywgcGxheWJhY2tUYXJnZXRBdmFpbGFiaWxpdHlDaGFuZ2Vk QWdhaW4sIHRydWUpOwogCi0gICAgICAgIGNvbnRhaW5lci5yZW1vdmUoKTsKLSAgICAgICAgbWVk aWEucmVtb3ZlKCk7Ci0gICAgICAgIGZpbmlzaEpTVGVzdCgpOwotICAgIH0KLX0pOworICAgIHdp bmRvdy5zZXRUaW1lb3V0KGVudGVyQWlyUGxheSwgMTAwKTsKK30KIAotbWVkaWEuYWRkRXZlbnRM aXN0ZW5lcigicGxheSIsICgpID0+IHsKK2Z1bmN0aW9uIGVudGVyQWlyUGxheSgpCit7CisgICAg bWVkaWEuYWRkRXZlbnRMaXN0ZW5lcigid2Via2l0Y3VycmVudHBsYXliYWNrdGFyZ2V0aXN3aXJl bGVzc2NoYW5nZWQiLCBjdXJyZW50UGxheWJhY2tUYXJnZXRJc1dpcmVsZXNzQ2hhbmdlZCk7CiAg ICAgbWVkaWEud2Via2l0U2hvd1BsYXliYWNrVGFyZ2V0UGlja2VyKCk7Ci0gICAgaWYgKHdpbmRv dy5pbnRlcm5hbHMpCi0gICAgICAgIHdpbmRvdy5pbnRlcm5hbHMuc2V0TW9ja01lZGlhUGxheWJh Y2tUYXJnZXRQaWNrZXJTdGF0ZSgiU2xlZXB5IFRWIiwgIkRldmljZUF2YWlsYWJsZSIpOwotfSk7 Cit9CisKK2Z1bmN0aW9uIGN1cnJlbnRQbGF5YmFja1RhcmdldElzV2lyZWxlc3NDaGFuZ2VkKGV2 ZW50KQoreworICAgIGlmICghbWVkaWEud2Via2l0Q3VycmVudFBsYXliYWNrVGFyZ2V0SXNXaXJl bGVzcykKKyAgICAgICAgcmV0dXJuOworCisgICAgc2hvdWxkQmVUcnVlKCJtZWRpYUNvbnRyb2xs ZXIuY29udHJvbHMuc2hvd3NQbGFjYXJkIik7CisgICAgc2hvdWxkQmVUcnVlKCJtZWRpYUNvbnRy b2xsZXIuY29udHJvbHMuY2hpbGRyZW4uaW5jbHVkZXMobWVkaWFDb250cm9sbGVyLmNvbnRyb2xz LmFpcnBsYXlQbGFjYXJkKSIpOworCisgICAgZGVidWcoIiIpOworICAgIGNvbnRhaW5lci5yZW1v dmUoKTsKKyAgICBtZWRpYS5yZW1vdmUoKTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsKK30KIAogPC9z Y3JpcHQ+CiA8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4 IGZhMjAxNjIxZjdhZjFmYWIwZDc0MzBjZTYyZmVkNjYxNzljNmUyMGIuLjEyOGZkNDk1NTY0YzY4 NDZiMzNiODczMTBhNjJjYWY2ZGNjNTUzNWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCkBAIC0xNDgwLDcgKzE0ODAsNiBAQCBtZWRpYS9tb2Rlcm4tbWVkaWEt Y29udHJvbHMvc2NydWJiZXItc3VwcG9ydC9pcGFkL3NjcnViYmVyLXN1cHBvcnQtZHJhZy5odG1s IFsgUwogCiAjIFRoZXNlIHNvbWV0aW1lcyB3b3JrIGJ1dCBtb3JlIG9mdGVuIHRoYW4gbm90IGRv bid0CiB3ZWJraXQub3JnL2IvMTY0MzIzIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9haXJw bGF5LXN1cHBvcnQvYWlycGxheS1zdXBwb3J0Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotd2Via2l0 Lm9yZy9iLzE2NDI5OCBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGxhY2FyZC1zdXBwb3J0 L3BsYWNhcmQtc3VwcG9ydC1haXJwbGF5Lmh0bWwgWyBQYXNzIEZhaWx1cmUgVGltZW91dCBdCiAK ICMgVGhpcyBvbmUgYWx3YXlzIHRpbWVzIG91dCBvbiB0aGUgYm90cywgY2Fubm90IHJlcHJvZHVj ZSBsb2NhbGx5Lgogd2Via2l0Lm9yZy9iLzE2NTIzNCBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJv bHMvYXVkaW8vYXVkaW8tY29udHJvbHMtYnV0dG9ucy5odG1sIFsgUGFzcyBUaW1lb3V0IF0K