163701 2016-10-19 16:00:10 -0700 create_hash_table: allow empty tables 2025-02-09 17:29:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=287377 P2 Normal --- 163571 1 jfbastien jfbastien commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1242167 0 jfbastien 2016-10-19 16:00:10 -0700 The Windows build was broken by because I added empty tables and Windows insists that empty tables are horrible. Put in dummy entries in that case. 1242171 1 292124 jfbastien 2016-10-19 16:11:45 -0700 Created attachment 292124 patch 1242172 2 292124 keith_miller 2016-10-19 16:14:47 -0700 Comment on attachment 292124 patch r=me 1242183 3 292124 commit-queue 2016-10-19 16:37:29 -0700 Comment on attachment 292124 patch Clearing flags on attachment: 292124 Committed r207576: <http://trac.webkit.org/changeset/207576> 1242184 4 commit-queue 2016-10-19 16:37:32 -0700 All reviewed patches have been landed. Closing bug. 292124 2016-10-19 16:11:45 -0700 2016-10-19 16:37:29 -0700 patch 0001-create_hash_table-allow-empty-tables.patch text/plain 3138 jfbastien RnJvbSA4NGY0YWExNWNmMWZkY2MyNDMxNTQyMWM4NzRjYWI0MmUwZWNkMWYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBXZWQsIDE5IE9jdCAyMDE2IDE2OjA2OjM1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gY3JlYXRl X2hhc2hfdGFibGU6IGFsbG93IGVtcHR5IHRhYmxlcwoKVGhlIFdpbmRvd3MgYnVpbGQgd2FzIGJy b2tlbiBieSBiZWNhdXNlIEkgYWRkZWQgZW1wdHkgdGFibGVzIGFuZCBXaW5kb3dzIGluc2lzdHMg dGhhdCBlbXB0eSB0YWJsZXMgYXJlIGhvcnJpYmxlLiBQdXQgaW4gZHVtbXkgZW50cmllcyBpbiB0 aGF0IGNhc2UuCi0tLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgICAgIHwg MTMgKysrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9oYXNoX3RhYmxl IHwgMjggKysrKysrKysrKysrKysrKysrKystLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAzMyBp bnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4 IDQ1NDIxMmQuLmVkMDU1NGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDE2LTEwLTE5ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KIAorICAg ICAgICBjcmVhdGVfaGFzaF90YWJsZTogYWxsb3cgZW1wdHkgdGFibGVzCisKKyAgICAgICAgVGhl IFdpbmRvd3MgYnVpbGQgd2FzIGJyb2tlbiBieSBiZWNhdXNlIEkgYWRkZWQgZW1wdHkgdGFibGVz IGFuZCBXaW5kb3dzIGluc2lzdHMgdGhhdCBlbXB0eSB0YWJsZXMgYXJlIGhvcnJpYmxlLiBQdXQg aW4gZHVtbXkgZW50cmllcyBpbiB0aGF0IGNhc2UuCisKKyAgICAgICAgY3JlYXRlX2hhc2hfdGFi bGU6IGFsbG93IGVtcHR5IHRhYmxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYzNzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBjcmVhdGVfaGFzaF90YWJsZToKKworMjAxNi0xMC0xOSAgSkYgQmFz dGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CisKICAgICAgICAgSmF2YVNjcmlwdCBXZWJBc3Nl bWJseSBBUEk6IGJhYnkgc3RlcHMKIAogICAgICAgICAgLSBFeHBhbmQgV2ViQXNzZW1ibHkgY29u c3RydWN0b3JzIGludG8gdGhlaXIgb3duIGZpbGVzLiBUaGlzIHJlcXVpcmVzIGEgbG90IG9mCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvY3JlYXRlX2hhc2hfdGFibGUgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvY3JlYXRlX2hhc2hfdGFibGUKaW5kZXggMWNiMmU0OS4uMjhkZjZl NyAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9oYXNoX3RhYmxlCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9jcmVhdGVfaGFzaF90YWJsZQpAQCAtMjcwLDE5ICsy NzAsMzEgQEAgc3ViIG91dHB1dCgpIHsKICAgICBwcmludCAiXG4iOwogICAgIHByaW50ICJuYW1l c3BhY2UgSlNDIHtcbiI7CiAgICAgcHJpbnQgIlxuIjsKLSAgICBwcmludCAic3RhdGljIGNvbnN0 IHN0cnVjdCBDb21wYWN0SGFzaEluZGV4ICR7bmFtZUluZGV4fVxbJGNvbXBhY3RTaXplXF0gPSB7 XG4iOwotICAgIGZvciAobXkgJGkgPSAwOyAkaSA8ICRjb21wYWN0U2l6ZTsgJGkrKykgewotICAg ICAgICBteSAkVCA9IC0xOwotICAgICAgICBpZiAoZGVmaW5lZCgkdGFibGVbJGldKSkgeyAkVCA9 ICR0YWJsZVskaV07IH0KLSAgICAgICAgbXkgJEwgPSAtMTsKLSAgICAgICAgaWYgKGRlZmluZWQo JGxpbmtzWyRpXSkpIHsgJEwgPSAkbGlua3NbJGldOyB9Ci0gICAgICAgIHByaW50ICIgICAgeyAk VCwgJEwgfSxcbiI7CisgICAgaWYgKCRjb21wYWN0U2l6ZSAhPSAwKSB7CisgICAgICAgIHByaW50 ICJzdGF0aWMgY29uc3Qgc3RydWN0IENvbXBhY3RIYXNoSW5kZXggJHtuYW1lSW5kZXh9XFskY29t cGFjdFNpemVcXSA9IHtcbiI7CisgICAgICAgIGZvciAobXkgJGkgPSAwOyAkaSA8ICRjb21wYWN0 U2l6ZTsgJGkrKykgeworICAgICAgICAgICAgbXkgJFQgPSAtMTsKKyAgICAgICAgICAgIGlmIChk ZWZpbmVkKCR0YWJsZVskaV0pKSB7ICRUID0gJHRhYmxlWyRpXTsgfQorICAgICAgICAgICAgbXkg JEwgPSAtMTsKKyAgICAgICAgICAgIGlmIChkZWZpbmVkKCRsaW5rc1skaV0pKSB7ICRMID0gJGxp bmtzWyRpXTsgfQorICAgICAgICAgICAgcHJpbnQgIiAgICB7ICRULCAkTCB9LFxuIjsKKyAgICAg ICAgfQorICAgIH0gZWxzZSB7CisgICAgICAgICMgTVNWQyBkaXNsaWtlcyBlbXB0eSBhcnJheXMu CisgICAgICAgIHByaW50ICJzdGF0aWMgY29uc3Qgc3RydWN0IENvbXBhY3RIYXNoSW5kZXggJHtu YW1lSW5kZXh9XFsxXF0gPSB7XG4iOworICAgICAgICBwcmludCAiICAgIHsgMCwgMCB9XG4iOwog ICAgIH0KICAgICBwcmludCAifTtcbiI7CiAgICAgcHJpbnQgIlxuIjsKIAogICAgIG15ICRwYWNr ZWRTaXplID0gc2NhbGFyIEBrZXlzOwotICAgIHByaW50ICJzdGF0aWMgY29uc3Qgc3RydWN0IEhh c2hUYWJsZVZhbHVlICR7bmFtZUVudHJpZXN9XFskcGFja2VkU2l6ZVxdID0ge1xuIjsKKyAgICBp ZiAoJHBhY2tlZFNpemUgIT0gMCkgeworICAgICAgICBwcmludCAic3RhdGljIGNvbnN0IHN0cnVj dCBIYXNoVGFibGVWYWx1ZSAke25hbWVFbnRyaWVzfVxbJHBhY2tlZFNpemVcXSA9IHtcbiI7Cisg ICAgfSBlbHNlIHsKKyAgICAgICAgIyBNU1ZDIGRpc2xpa2VzIGVtcHR5IGFycmF5cy4KKyAgICAg ICAgcHJpbnQgInN0YXRpYyBjb25zdCBzdHJ1Y3QgSGFzaFRhYmxlVmFsdWUgJHtuYW1lRW50cmll c31cWzFcXSA9IHtcbiI7CisgICAgICAgIHByaW50ICIgICAgeyBudWxscHRyLCAwLCBOb0ludHJp bnNpYywgeyAwLCAwIH0gfVxuIjsKKyAgICB9CiAgICAgbXkgJGkgPSAwOwogICAgIGZvcmVhY2gg bXkgJGtleSAoQGtleXMpIHsKICAgICAgICAgbXkgJGZpcnN0VmFsdWUgPSAiIjsKLS0gCjIuMTAu MQoK