163673 2016-10-19 11:09:15 -0700 Move HTML Interactive Form Validation behind an experimental flag 2016-11-07 09:46:18 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 164382 1 cdumez cdumez barraclough cdumez darin dbates dino jonlee sam oldest_to_newest 1241995 0 cdumez 2016-10-19 11:09:15 -0700 Move Interactive Form Validation behind an experimental flag and disable by default until by have a better UI. 1242018 1 292089 cdumez 2016-10-19 11:50:45 -0700 Created attachment 292089 Patch 1242079 2 292089 dbates 2016-10-19 13:29:29 -0700 Comment on attachment 292089 Patch Notice that interactive form validation is enabled in DumpRenderTree and WebKitTestRunner. Did you intend to keep them enabled by default in these test tools? 1242082 3 cdumez 2016-10-19 13:31:04 -0700 (In reply to comment #2) > Comment on attachment 292089 [details] > Patch > > Notice that interactive form validation is enabled in DumpRenderTree and > WebKitTestRunner. Did you intend to keep them enabled by default in these > test tools? Sure, we need them for testing. They were always enabled there. I only turned on the feature on for Safari recently so I am basically rolling back my recent change. 1242083 4 292089 cdumez 2016-10-19 13:31:46 -0700 Comment on attachment 292089 Patch Clearing flags on attachment: 292089 Committed r207562: <http://trac.webkit.org/changeset/207562> 1242084 5 cdumez 2016-10-19 13:31:51 -0700 All reviewed patches have been landed. Closing bug. 292089 2016-10-19 11:50:45 -0700 2016-10-19 13:31:46 -0700 Patch bug-163673-20161019114709.patch text/plain 5242 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjBhNTgxY2Qy NTk3MjQ5NzEyMTAzOTg0OWE1MGRhYWZlMDMyZTJhMS4uMGMwMWUxYTY1NGRkNDY4NmQ3NzA2ZjIx Yzc1ZDNkMWZmNDA4ZThhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2 LTEwLTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSBI VE1MIEludGVyYWN0aXZlIEZvcm0gVmFsaWRhdGlvbiBiZWhpbmQgYW4gZXhwZXJpbWVudGFsIGZs YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzY3 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlLWRp c2FibGUgSFRNTCBJbnRlcmFjdGl2ZSBGb3JtIFZhbGlkYXRpb24gYnkgZGVmYXVsdCBvbiBNYWMg V0sxLgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3RGF0YS5tbToKKyAgICAgICAgKC1bV2Vi Vmlld1ByaXZhdGUgaW5pdF0pOgorCiAyMDE2LTEwLTE5ICBEYXJpbiBBZGxlciAgPGRhcmluQGFw cGxlLmNvbT4KIAogICAgICAgICBNb3ZlIFhQYXRoIGZyb20gRXhjZXB0aW9uQ29kZSB0byBFeGNl cHRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwppbmRleCBmOTZjOTQ2ZjczNTY5M2ExZWYzMDY1OTIzZGU2NTI4MDEzNmY0 ZDBmLi5iZDE4ZDgzMjQ0OGY2MWU5ZWM2ODFkOTdkMGQyZDM1NmM4YTM2ODljIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTcgQEAKKzIwMTYtMTAtMTkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KKworICAgICAgICBNb3ZlIEhUTUwgSW50ZXJhY3RpdmUgRm9ybSBWYWxpZGF0aW9uIGJl aGluZCBhbiBleHBlcmltZW50YWwgZmxhZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNjczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTW92ZSBIVE1MIEludGVyYWN0aXZlIEZvcm0gVmFsaWRhdGlvbiBi ZWhpbmQgYW4gZXhwZXJpbWVudGFsIGZlYXR1cmUgZmxhZworICAgICAgICBhbmQgZGlzYWJsZSBi eSBkZWZhdWx0IHVudGlsIGJ5IGhhdmUgYSBiZXR0ZXIgVUkuCisKKyAgICAgICAgKiBTaGFyZWQv V2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpJbmplY3RlZEJ1 bmRsZTo6b3ZlcnJpZGVCb29sUHJlZmVyZW5jZUZvclRlc3RSdW5uZXIpOgorCiAyMDE2LTEwLTE5 ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIFhQYXRoIGZy b20gRXhjZXB0aW9uQ29kZSB0byBFeGNlcHRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv bWFjL1dlYlZpZXcvV2ViVmlld0RhdGEubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dl YlZpZXdEYXRhLm1tCmluZGV4IDZlN2I5NzNkOWQ0MjQzNTkyZGQ2NjNlMWIwNGJmNjU2OGI0YTcw YTEuLjVlN2M4ZDdiN2ZkZTMyNGRmYTBjNmZlODk3ZDJjZDAyYzQwOTc1OGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0RhdGEubW0KKysrIGIvU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJWaWV3RGF0YS5tbQpAQCAtMTQzLDcgKzE0Myw3IEBAIC0gKGlk KWluaXQKICAgICB6b29tTXVsdGlwbGllciA9IDE7CiAgICAgem9vbXNUZXh0T25seSA9IE5POwog Ci0gICAgaW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQgPSBZRVM7CisgICAgaW50ZXJh Y3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQgPSBOTzsKICAgICAvLyBUaGUgZGVmYXVsdCB2YWx1 ZSBzaG91bGQgYmUgc3luY2hyb25pemVkIHdpdGggV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNwcC4K ICAgICB2YWxpZGF0aW9uTWVzc2FnZVRpbWVyTWFnbmlmaWNhdGlvbiA9IDUwOwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oIGIv U291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaAppbmRleCA4 ZDA3ZDI5M2I3YmVhYzNlNjM5MzM1ZDYzNjg0ZGY3ZTQ1NjQyNTU2Li4wNTM5NGI2NWI5MmUyY2Vl NmI2MzEyYTQwOTA0ZDVhOGY3NWRiYzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKQEAgLTE3OSw3ICsxNzksNiBAQAogICAgIG1h Y3JvKEFzeW5jaHJvbm91c1BsdWdpbkluaXRpYWxpemF0aW9uRW5hYmxlZEZvckFsbFBsdWdpbnMs IGFzeW5jaHJvbm91c1BsdWdpbkluaXRpYWxpemF0aW9uRW5hYmxlZEZvckFsbFBsdWdpbnMsIEJv b2wsIGJvb2wsIGZhbHNlLCAiIiwgIiIpIFwKICAgICBtYWNybyhBcnRpZmljaWFsUGx1Z2luSW5p dGlhbGl6YXRpb25EZWxheUVuYWJsZWQsIGFydGlmaWNpYWxQbHVnaW5Jbml0aWFsaXphdGlvbkRl bGF5RW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICIiLCAiIikgXAogICAgIG1hY3JvKFRhYlRv TGlua3NFbmFibGVkLCB0YWJUb0xpbmtzRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICIiLCAi IikgXAotICAgIG1hY3JvKEludGVyYWN0aXZlRm9ybVZhbGlkYXRpb25FbmFibGVkLCBpbnRlcmFj dGl2ZUZvcm1WYWxpZGF0aW9uRW5hYmxlZCwgQm9vbCwgYm9vbCwgdHJ1ZSwgIiIsICIiKSBcCiAg ICAgbWFjcm8oU2Nyb2xsaW5nUGVyZm9ybWFuY2VMb2dnaW5nRW5hYmxlZCwgc2Nyb2xsaW5nUGVy Zm9ybWFuY2VMb2dnaW5nRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICIiLCAiIikgXAogICAg IG1hY3JvKFNjcm9sbEFuaW1hdG9yRW5hYmxlZCwgc2Nyb2xsQW5pbWF0b3JFbmFibGVkLCBCb29s LCBib29sLCBERUZBVUxUX1dFQktJVF9TQ1JPTExfQU5JTUFUT1JfRU5BQkxFRCwgIiIsICIiKSBc CiAgICAgbWFjcm8oRm9yY2VVcGRhdGVTY3JvbGxiYXJzT25NYWluVGhyZWFkRm9yUGVyZm9ybWFu Y2VUZXN0aW5nLCBmb3JjZVVwZGF0ZVNjcm9sbGJhcnNPbk1haW5UaHJlYWRGb3JQZXJmb3JtYW5j ZVRlc3RpbmcsIEJvb2wsIGJvb2wsIGZhbHNlLCAiIiwgIiIpIFwKQEAgLTI5MCw2ICsyODksNyBA QAogICAgIG1hY3JvKENTU0dyaWRMYXlvdXRFbmFibGVkLCBjc3NHcmlkTGF5b3V0RW5hYmxlZCwg Qm9vbCwgYm9vbCwgZmFsc2UsICJDU1MgR3JpZCIsICJDU1MgR3JpZCBMYXlvdXQgTW9kdWxlIHN1 cHBvcnQiKSBcCiAgICAgbWFjcm8oU3ByaW5nVGltaW5nRnVuY3Rpb25FbmFibGVkLCBzcHJpbmdU aW1pbmdGdW5jdGlvbkVuYWJsZWQsIEJvb2wsIGJvb2wsIHRydWUsICJDU1MgU3ByaW5nIEFuaW1h dGlvbnMiLCAiQ1NTIFNwcmluZyBBbmltYXRpb24gcHJvdG90eXBlIikgXAogICAgIG1hY3JvKEN1 c3RvbUVsZW1lbnRzRW5hYmxlZCwgY3VzdG9tRWxlbWVudHNFbmFibGVkLCBCb29sLCBib29sLCB0 cnVlLCAiQ3VzdG9tIEVsZW1lbnRzIiwgIkhUTUwgQ3VzdG9tIEVsZW1lbnRzIHByb3RvdHlwZSIp IFwKKyAgICBtYWNybyhJbnRlcmFjdGl2ZUZvcm1WYWxpZGF0aW9uRW5hYmxlZCwgaW50ZXJhY3Rp dmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQsIEJvb2wsIGJvb2wsIGZhbHNlLCAiSFRNTCBJbnRlcmFj dGl2ZSBGb3JtIFZhbGlkYXRpb24iLCAiSFRNTCBpbnRlcmFjdGl2ZSBmb3JtIHZhbGlkYXRpb24g cHJvdG90eXBlIikgXAogICAgIG1hY3JvKEdhbWVwYWRzRW5hYmxlZCwgZ2FtZXBhZHNFbmFibGVk LCBCb29sLCBib29sLCB0cnVlLCAiR2FtZXBhZHMiLCAiV2ViIEdhbWVwYWQgQVBJIHN1cHBvcnQi KSBcCiAgICAgbWFjcm8oTW9kZXJuTWVkaWFDb250cm9sc0VuYWJsZWQsIG1vZGVybk1lZGlhQ29u dHJvbHNFbmFibGVkLCBCb29sLCBib29sLCBmYWxzZSwgIk1vZGVybiBNZWRpYSBDb250cm9scyIs ICJVc2UgbW9kZXJuIG1lZGlhIGNvbnRyb2xzIGxvb2siKSBcCiAgICAgbWFjcm8oVmFyaWF0aW9u Rm9udHNFbmFibGVkLCB2YXJpYXRpb25Gb250c0VuYWJsZWQsIEJvb2wsIGJvb2wsIHRydWUsICJW YXJpYXRpb24gRm9udHMiLCAiRW5hYmxlIHZhcmlhdGlvbiBmb250cyIpIFwKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUu Y3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1 bmRsZS5jcHAKaW5kZXggYjEwYTg3MTIyMGJhMjFhNzg5ZGMyYjQ3NmIzYTMxYjQ3ZjMzNjAyYi4u ODE1NGNjNTcwMzAyMTM4ZTdmZjNjMTBjZTUzNWVmNTI4ZmM5MjgzZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1 bmRsZS5jcHAKQEAgLTIwNyw2ICsyMDcsOSBAQCB2b2lkIEluamVjdGVkQnVuZGxlOjpvdmVycmlk ZUJvb2xQcmVmZXJlbmNlRm9yVGVzdFJ1bm5lcihXZWJQYWdlR3JvdXBQcm94eSogcGFnZQogICAg ICAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLnNldEN1c3RvbUVs ZW1lbnRzRW5hYmxlZChlbmFibGVkKTsKICNlbmRpZgogCisgICAgaWYgKHByZWZlcmVuY2UgPT0g IldlYktpdEludGVyYWN0aXZlRm9ybVZhbGlkYXRpb25FbmFibGVkIikKKyAgICAgICAgUnVudGlt ZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5zZXRJbnRlcmFjdGl2ZUZvcm1WYWxp ZGF0aW9uRW5hYmxlZChlbmFibGVkKTsKKwogI2lmIEVOQUJMRShXRUJHTDIpCiAgICAgaWYgKHBy ZWZlcmVuY2UgPT0gIldlYktpdFdlYkdMMkVuYWJsZWQiKQogICAgICAgICBSdW50aW1lRW5hYmxl ZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLnNldFdlYkdMMkVuYWJsZWQoZW5hYmxlZCk7Cg==